16865 2008-01-13 14:36:39 -0800 fast/layers/resize-layer-deletion-crash.html crashes under GuardMalloc 2008-01-13 20:41:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 67154 0 mitz 2008-01-13 14:36:39 -0800 fast/layers/resize-layer-deletion-crash.html crashes in ~RenderLayer under GuardMalloc when checking if the document is being destroyed. 67163 1 18426 mitz 2008-01-13 15:43:40 -0800 Created attachment 18426 Move layer destruction into RenderObject::destroy() 67177 2 18426 darin 2008-01-13 19:53:50 -0800 Comment on attachment 18426 Move layer destruction into RenderObject::destroy() Looks fine. r=me 67180 3 mitz 2008-01-13 20:41:51 -0800 Fixed in <http://trac.webkit.org/projects/webkit/changeset/29457>. 18426 2008-01-13 15:43:40 -0800 2008-01-13 19:53:50 -0800 Move layer destruction into RenderObject::destroy() 16865_r1.diff text/plain 2068 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyOTQ1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDgtMDEtMTMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg2NQorICAgICAgICAg IGZhc3QvbGF5ZXJzL3Jlc2l6ZS1sYXllci1kZWxldGlvbi1jcmFzaC5odG1sIGNyYXNoZXMgdW5k ZXIgR3VhcmRNYWxsb2MKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyQm94OjpkZXN0cm95KTogUmVtb3ZlZCB0aGUgY2FsbCB0bwor ICAgICAgICBSZW5kZXJMYXllcjo6ZGVzdHJveSgpIGZyb20gaGVyZSwgYmVjYXVzZSB+UmVuZGVy TGF5ZXIoKSBjYWxscworICAgICAgICBSZW5kZXJPYmplY3QoKSBtZXRob2RzLgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2Jq ZWN0OjpkZXN0cm95KTogQWRkZWQgdGhlIGNhbGwgdG8KKyAgICAgICAgUmVuZGVyTGF5ZXI6OmRl c3Ryb3koKSBoZXJlLgorCiAyMDA4LTAxLTEzICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu Y3BwCShyZXZpc2lvbiAyOTQ1NSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE2NCwxNyArMTY0LDExIEBAIHZvaWQgUmVuZGVyQm94OjpkZXN0 cm95KCkKICAgICBpZiAoaGFzT3ZlcnJpZGVTaXplKCkpCiAgICAgICAgIGdPdmVycmlkZVNpemVN YXAtPnJlbW92ZSh0aGlzKTsKIAotICAgIFJlbmRlckxheWVyKiBsYXllciA9IG1fbGF5ZXI7Ci0g ICAgUmVuZGVyQXJlbmEqIGFyZW5hID0gcmVuZGVyQXJlbmEoKTsKLQogICAgIC8vIFRoaXMgbXVz dCBiZSBkb25lIGJlZm9yZSB3ZSBkZXN0cm95IHRoZSBSZW5kZXJPYmplY3QuCi0gICAgaWYgKGxh eWVyKQotICAgICAgICBsYXllci0+Y2xlYXJDbGlwUmVjdCgpOworICAgIGlmIChtX2xheWVyKQor ICAgICAgICBtX2xheWVyLT5jbGVhckNsaXBSZWN0KCk7CiAKICAgICBSZW5kZXJPYmplY3Q6OmRl c3Ryb3koKTsKLQotICAgIGlmIChsYXllcikKLSAgICAgICAgbGF5ZXItPmRlc3Ryb3koYXJlbmEp OwogfQogCiBpbnQgUmVuZGVyQm94OjptaW5QcmVmV2lkdGgoKSBjb25zdApJbmRleDogV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAyOTQ1NSkKKysrIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1NDUsNyArMjU0NSwxMiBA QCB2b2lkIFJlbmRlck9iamVjdDo6ZGVzdHJveSgpCiAKICAgICByZW1vdmUoKTsKIAotICAgIGFy ZW5hRGVsZXRlKGRvY3VtZW50KCktPnJlbmRlckFyZW5hKCksIHRoaXMpOworICAgIFJlbmRlckFy ZW5hKiBhcmVuYSA9IHJlbmRlckFyZW5hKCk7CisKKyAgICBpZiAoaGFzTGF5ZXIoKSkKKyAgICAg ICAgbGF5ZXIoKS0+ZGVzdHJveShhcmVuYSk7CisKKyAgICBhcmVuYURlbGV0ZShhcmVuYSwgdGhp cyk7CiB9CiAKIHZvaWQgUmVuZGVyT2JqZWN0OjphcmVuYURlbGV0ZShSZW5kZXJBcmVuYSogYXJl bmEsIHZvaWQqIGJhc2UpCg==