168648 2017-02-21 01:00:01 -0800 REGRESSION(r212681): Crash when dragging links without a drag image 2017-02-21 07:46:26 -0800 1 1 1 Unclassified WebKit UI Events WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned andersca bugs-noreply mcatanzaro thorton oldest_to_newest 1279280 0 cgarcia 2017-02-21 01:00:01 -0800 This happens in GTK+ port, because we don't use a drag image for links. It caused 10 crashes in the bots. 1279281 1 302247 cgarcia 2017-02-21 01:04:51 -0800 Created attachment 302247 Patch 1279294 2 cgarcia 2017-02-21 02:39:26 -0800 Committed r212711: <http://trac.webkit.org/changeset/212711> 1279321 3 mcatanzaro 2017-02-21 07:46:26 -0800 (In reply to comment #0) > This happens in GTK+ port, because we don't use a drag image for links. By the way, that's terrible. We really should. I'm positive that somebody implemented this for us before, because I remember r-ing the patch years after it was posted. 302247 2017-02-21 01:04:51 -0800 2017-02-21 01:07:47 -0800 Patch wk-dnd-crash.diff text/plain 3379 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlYTc2ZTk1MTI2ZS4uZjc4NjVjNDI3NDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNyBAQAorMjAxNy0wMi0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjEyNjgxKTogQ3Jhc2ggd2hlbiBkcmFn Z2luZyBsaW5rcyB3aXRob3V0IGEgZHJhZyBpbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBoYXBwZW5zIGluIEdUSysgcG9ydCwgYmVjYXVz ZSB3ZSBkb24ndCB1c2UgYSBkcmFnIGltYWdlIGZvciBsaW5rcy4KKworICAgICAgICBGaXhlczog ZWRpdGluZy9wYXN0ZWJvYXJkL2Ryb3AtbGluay5odG1sCisgICAgICAgICAgICAgICBlZGl0aW5n L3Bhc3RlYm9hcmQvZHJvcC10ZXh0LXdpdGhvdXQtc2VsZWN0aW9uLmh0bWwKKyAgICAgICAgICAg ICAgIGVkaXRpbmcvcGFzdGVib2FyZC9maWxlcy1kdXJpbmctcGFnZS1kcmFncy5odG1sCisgICAg ICAgICAgICAgICBmYXN0L2V2ZW50cy9jb250ZW50LWNoYW5nZWQtZHVyaW5nLWRyb3AuaHRtbAor ICAgICAgICAgICAgICAgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1saW5rLWZhc3QtbXVsdGlw bGUtdGltZXMtZG9lcy1ub3QtY3Jhc2guaHRtbAorICAgICAgICAgICAgICAgZmFzdC9ldmVudHMv ZHJhZy1hbmQtZHJvcC1saW5rLWludG8tZm9jdXNlZC1jb250ZW50ZWRpdGFibGUuaHRtbAorICAg ICAgICAgICAgICAgZmFzdC9ldmVudHMvZHJhZy1hbmQtZHJvcC1saW5rLmh0bWwKKyAgICAgICAg ICAgICAgIGZhc3QvZXZlbnRzL2RyYWctaW4tZnJhbWVzLmh0bWwKKyAgICAgICAgICAgICAgIGZh c3QvZXZlbnRzL2RyYWctcGFyZW50LW5vZGUuaHRtbAorICAgICAgICAgICAgICAgZmFzdC9ldmVu dHMvc2hpZnQtZHJhZy1zZWxlY3Rpb24tb24tbGluay10cmlnZ2Vycy1kcmFnLW4tZHJvcC5odG1s CisKKyAgICAgICAgKiBwYWdlL0RyYWdDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkRyYWdDb250cm9sbGVyOjpzdGFydERyYWcpOiBEbyBub3QgdHJ5IHRvIHVzZSBkcmFnIGltYWdl IGFuZCBpdHMgc2l6ZSB3aGVuIGNyZWF0ZURyYWdJbWFnZUZvckxpbmsKKyAgICAgICAgcmV0dXJu cyBudWxscHRyLgorCiAyMDE3LTAyLTIxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2Vu QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMjY5OS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKaW5kZXggNjM3OTZkZmUyMzEuLmU2 ZmFhYmZmZGJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcApAQCAtOTY2 LDEzICs5NjYsMTUgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6c3RhcnREcmFnKEZyYW1lJiBzcmMs IGNvbnN0IERyYWdTdGF0ZSYgc3RhdGUsIERyYWdPcGVyYXRpb24KICAgICAgICAgaWYgKCFkcmFn SW1hZ2UpIHsKICAgICAgICAgICAgIFRleHRJbmRpY2F0b3JEYXRhIHRleHRJbmRpY2F0b3I7CiAg ICAgICAgICAgICBkcmFnSW1hZ2UgPSBEcmFnSW1hZ2UgeyBjcmVhdGVEcmFnSW1hZ2VGb3JMaW5r KGVsZW1lbnQsIGxpbmtVUkwsIGhpdFRlc3RSZXN1bHQudGV4dENvbnRlbnQoKSwgdGV4dEluZGlj YXRvciwgc3JjLnNldHRpbmdzKCkuZm9udFJlbmRlcmluZ01vZGUoKSwgbV9wYWdlLmRldmljZVNj YWxlRmFjdG9yKCkpIH07Ci0gICAgICAgICAgICBJbnRTaXplIHNpemUgPSBkcmFnSW1hZ2VTaXpl KGRyYWdJbWFnZS5nZXQoKSk7Ci0gICAgICAgICAgICBtX2RyYWdPZmZzZXQgPSBJbnRQb2ludCgt c2l6ZS53aWR0aCgpIC8gMiwgLUxpbmtEcmFnQm9yZGVySW5zZXQpOwotICAgICAgICAgICAgZHJh Z0xvYyA9IEludFBvaW50KG1vdXNlRHJhZ2dlZFBvaW50LngoKSArIG1fZHJhZ09mZnNldC54KCks IG1vdXNlRHJhZ2dlZFBvaW50LnkoKSArIG1fZHJhZ09mZnNldC55KCkpOwotICAgICAgICAgICAg ZHJhZ0ltYWdlID0gRHJhZ0ltYWdlIHsgcGxhdGZvcm1BZGp1c3REcmFnSW1hZ2VGb3JEZXZpY2VT Y2FsZUZhY3RvcihkcmFnSW1hZ2UuZ2V0KCksIG1fcGFnZS5kZXZpY2VTY2FsZUZhY3RvcigpKSB9 OwotICAgICAgICAgICAgaWYgKHRleHRJbmRpY2F0b3IuY29udGVudEltYWdlKQotICAgICAgICAg ICAgICAgIGRyYWdJbWFnZS5zZXRJbmRpY2F0b3JEYXRhKHRleHRJbmRpY2F0b3IpOwotICAgICAg ICAgICAgZHJhZ0ltYWdlQW5jaG9yUG9pbnQgPSBGbG9hdFBvaW50IHsgMC41LCBzdGF0aWNfY2Fz dDxmbG9hdD4oKHNpemUuaGVpZ2h0KCkgLSBMaW5rRHJhZ0JvcmRlckluc2V0KSAvIHNpemUuaGVp Z2h0KCkpIH07CisgICAgICAgICAgICBpZiAoZHJhZ0ltYWdlKSB7CisgICAgICAgICAgICAgICAg SW50U2l6ZSBzaXplID0gZHJhZ0ltYWdlU2l6ZShkcmFnSW1hZ2UuZ2V0KCkpOworICAgICAgICAg ICAgICAgIG1fZHJhZ09mZnNldCA9IEludFBvaW50KC1zaXplLndpZHRoKCkgLyAyLCAtTGlua0Ry YWdCb3JkZXJJbnNldCk7CisgICAgICAgICAgICAgICAgZHJhZ0xvYyA9IEludFBvaW50KG1vdXNl RHJhZ2dlZFBvaW50LngoKSArIG1fZHJhZ09mZnNldC54KCksIG1vdXNlRHJhZ2dlZFBvaW50Lnko KSArIG1fZHJhZ09mZnNldC55KCkpOworICAgICAgICAgICAgICAgIGRyYWdJbWFnZSA9IERyYWdJ bWFnZSB7IHBsYXRmb3JtQWRqdXN0RHJhZ0ltYWdlRm9yRGV2aWNlU2NhbGVGYWN0b3IoZHJhZ0lt YWdlLmdldCgpLCBtX3BhZ2UuZGV2aWNlU2NhbGVGYWN0b3IoKSkgfTsKKyAgICAgICAgICAgICAg ICBpZiAodGV4dEluZGljYXRvci5jb250ZW50SW1hZ2UpCisgICAgICAgICAgICAgICAgICAgIGRy YWdJbWFnZS5zZXRJbmRpY2F0b3JEYXRhKHRleHRJbmRpY2F0b3IpOworICAgICAgICAgICAgICAg IGRyYWdJbWFnZUFuY2hvclBvaW50ID0gRmxvYXRQb2ludCB7IDAuNSwgc3RhdGljX2Nhc3Q8Zmxv YXQ+KChzaXplLmhlaWdodCgpIC0gTGlua0RyYWdCb3JkZXJJbnNldCkgLyBzaXplLmhlaWdodCgp KSB9OworICAgICAgICAgICAgfQogICAgICAgICB9CiAKICAgICAgICAgaWYgKG11c3RVc2VMZWdh Y3lEcmFnQ2xpZW50KSB7Cg==