168640 2017-02-20 23:06:07 -0800 AudioSampleDataSource doesn't need to use the m_scratchBuffer on the pulling thread 2017-02-21 15:20:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble commit-queue oldest_to_newest 1279241 0 jer.noble 2017-02-20 23:06:07 -0800 AudioSampleDataSource doesn't need to use the m_scratchBuffer on the pulling thread 1279242 1 302234 jer.noble 2017-02-20 23:07:34 -0800 Created attachment 302234 Patch 1279433 2 302286 jer.noble 2017-02-21 11:07:19 -0800 Created attachment 302286 Patch 1279458 3 302286 eric.carlson 2017-02-21 11:48:44 -0800 Comment on attachment 302286 Patch As we discussed, this isn't correct in the case where the ring buffer data is supposed to be mixed into the output, but the existing code is equally incorrect so I will file a new bug to fix that. 1279571 4 302286 commit-queue 2017-02-21 15:20:22 -0800 Comment on attachment 302286 Patch Clearing flags on attachment: 302286 Committed r212771: <http://trac.webkit.org/changeset/212771> 1279572 5 commit-queue 2017-02-21 15:20:26 -0800 All reviewed patches have been landed. Closing bug. 302234 2017-02-20 23:07:34 -0800 2017-02-21 11:07:15 -0800 Patch bug-168640-20170220230448.patch text/plain 2328 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NlNzNhMmUwOWMxMDIx OTA0Yzc1OTE4NDdhNWY0YWEzOTVkNmNiYy4uNzFjN2I2N2ZkZjc1NmY1NzI3MDg4M2U4OTE1ODk4 NzM0MTQzYWY5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE3LTAyLTIwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIEF1ZGlvU2FtcGxlRGF0YVNv dXJjZSBkb2Vzbid0IG5lZWQgdG8gdXNlIHRoZSBtX3NjcmF0Y2hCdWZmZXIgb24gdGhlIHB1bGxp bmcgdGhyZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjg2NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSYXRoZXIgdGhhbiBjb3B5aW5nIHRoZSBwdWxsZWQgZGF0YSBpbnRvIGEgc2NyYXRjaCBidWZm ZXIsIGFwcGx5aW5nIGEgdm9sdW1lIHRyYW5zZm9ybWF0aW9uCisgICAgICAgIGFuZCB0aGVuIGNv cHlpbmcgYmFjayBvdXQsIGp1c3QgZG8gdGhlIHZvbHVtZSB0cmFuc2Zvcm1hdGlvbiBpbi1wbGFj ZSBpbiB0aGUgZGVzdGluYXRpb24KKyAgICAgICAgYnVmZmVyLgorCisgICAgICAgICogcGxhdGZv cm0vYXVkaW8vbWFjL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBdWRpb1NhbXBsZURhdGFTb3VyY2U6OnB1bGxTYW1wbGVzSW50ZXJuYWwpOgorCisyMDE3LTAy LTIwICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCiAgICAgICAgIE1ha2UgbG9n Z2luZyBpbiBoaWdoLXByaW9yaXR5IGF1ZGlvIHRocmVhZHMgbGVzcyBleHBlbnNpdmUKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODYzOQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvQXVkaW9TYW1wbGVEYXRh U291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb1NhbXBs ZURhdGFTb3VyY2UuY3BwCmluZGV4IGJlY2Q3Mzk3ZDNlOGEzM2RiM2RjZjY5M2JjNDI4N2E0NjVj YzZmNTkuLmJiYTA3MGIxODM5YTBjNDU0OTVlY2UyYmU4ZGNhN2JkNDAzMjhmN2UgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb1NhbXBsZURhdGFTb3Vy Y2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb1NhbXBs ZURhdGFTb3VyY2UuY3BwCkBAIC0yODAsMTkgKzI4MCwxMCBAQCBib29sIEF1ZGlvU2FtcGxlRGF0 YVNvdXJjZTo6cHVsbFNhbXBsZXNJbnRlcm5hbChBdWRpb0J1ZmZlckxpc3QmIGJ1ZmZlciwgc2l6 ZV90JgogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKG1fdm9sdW1lID49IC45NSkgewotICAg ICAgICBtX3JpbmdCdWZmZXItPmZldGNoKCZidWZmZXIsIHNhbXBsZUNvdW50LCB0aW1lU3RhbXAs IG1vZGUgPT0gQ29weSA/IENBUmluZ0J1ZmZlcjo6Q29weSA6IENBUmluZ0J1ZmZlcjo6TWl4KTsK LSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQorICAgIG1fcmluZ0J1ZmZlci0+ZmV0Y2goJmJ1 ZmZlciwgc2FtcGxlQ291bnQsIHRpbWVTdGFtcCwgbW9kZSA9PSBDb3B5ID8gQ0FSaW5nQnVmZmVy OjpDb3B5IDogQ0FSaW5nQnVmZmVyOjpNaXgpOwogCi0gICAgaWYgKG1fc2NyYXRjaEJ1ZmZlci0+ Y29weUZyb20oKm1fcmluZ0J1ZmZlci5nZXQoKSwgc2FtcGxlQ291bnQsIHRpbWVTdGFtcCwgbW9k ZSA9PSBDb3B5ID8gQ0FSaW5nQnVmZmVyOjpDb3B5IDogQ0FSaW5nQnVmZmVyOjpNaXgpKSB7Ci0g ICAgICAgIEF1ZGlvU2FtcGxlQnVmZmVyTGlzdDo6emVyb0FCTChidWZmZXIsIHNhbXBsZUNvdW50 KTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLQotICAgIG1fc2NyYXRjaEJ1ZmZlci0+ YXBwbHlHYWluKG1fdm9sdW1lKTsKLSAgICBpZiAobV9zY3JhdGNoQnVmZmVyLT5jb3B5VG8oYnVm ZmVyLCBzYW1wbGVDb3VudCkpCi0gICAgICAgIEF1ZGlvU2FtcGxlQnVmZmVyTGlzdDo6emVyb0FC TChidWZmZXIsIGJ5dGVDb3VudCk7CisgICAgaWYgKG1fdm9sdW1lIDwgLjk1KQorICAgICAgICBB dWRpb1NhbXBsZUJ1ZmZlckxpc3Q6OmFwcGx5R2FpbihidWZmZXIsIG1fdm9sdW1lLCBtX291dHB1 dERlc2NyaXB0aW9uLT5mb3JtYXQoKSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K 302286 2017-02-21 11:07:19 -0800 2017-02-21 15:20:22 -0800 Patch bug-168640-20170221110433.patch text/plain 2266 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTJjMmFkNTBiMWQ5ODY4 NDIxZTI0MTQ4NzBlMDkyMDlhM2U3ODkyMi4uMmFmMTkyYzZlZWVjYzQxZjM3NTU2ODc0ZDI4ODBm ZTA4ZWZjNzkwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAyLTIwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEF1ZGlvU2FtcGxlRGF0YVNv dXJjZSBkb2Vzbid0IG5lZWQgdG8gdXNlIHRoZSBtX3NjcmF0Y2hCdWZmZXIgb24gdGhlIHB1bGxp bmcgdGhyZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjg2NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSYXRoZXIgdGhhbiBjb3B5aW5nIHRoZSBwdWxsZWQgZGF0YSBpbnRvIGEgc2NyYXRjaCBidWZm ZXIsIGFwcGx5aW5nIGEgdm9sdW1lIHRyYW5zZm9ybWF0aW9uCisgICAgICAgIGFuZCB0aGVuIGNv cHlpbmcgYmFjayBvdXQsIGp1c3QgZG8gdGhlIHZvbHVtZSB0cmFuc2Zvcm1hdGlvbiBpbi1wbGFj ZSBpbiB0aGUgZGVzdGluYXRpb24KKyAgICAgICAgYnVmZmVyLgorCisgICAgICAgICogcGxhdGZv cm0vYXVkaW8vbWFjL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpBdWRpb1NhbXBsZURhdGFTb3VyY2U6OnB1bGxTYW1wbGVzSW50ZXJuYWwpOgorCiAyMDE3LTAy LTIxICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgbG9n Z2luZyBpbiBoaWdoLXByaW9yaXR5IGF1ZGlvIHRocmVhZHMgbGVzcyBleHBlbnNpdmUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb1NhbXBsZURhdGFT b3VyY2UubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvQXVkaW9TYW1wbGVE YXRhU291cmNlLm1tCmluZGV4IDgyZjE5ZmU2OGMyYjQ1MDNkM2Y5ZDExMjRmYTg1MTI0YWUzZDU1 OGMuLjNkMzkxYjRjMDc4ZDBmYWE5YjY1MTFiOTU0MTIzN2UxMGUwYWJhNGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb1NhbXBsZURhdGFTb3VyY2Uu bW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0F1ZGlvU2FtcGxlRGF0 YVNvdXJjZS5tbQpAQCAtMjg4LDE5ICsyODgsMTAgQEAgYm9vbCBBdWRpb1NhbXBsZURhdGFTb3Vy Y2U6OnB1bGxTYW1wbGVzSW50ZXJuYWwoQXVkaW9CdWZmZXJMaXN0JiBidWZmZXIsIHNpemVfdCYK ICAgICAgICAgfQogICAgIH0KIAotICAgIGlmIChtX3ZvbHVtZSA+PSAuOTUpIHsKLSAgICAgICAg bV9yaW5nQnVmZmVyLT5mZXRjaCgmYnVmZmVyLCBzYW1wbGVDb3VudCwgdGltZVN0YW1wLCBtb2Rl ID09IENvcHkgPyBDQVJpbmdCdWZmZXI6OkNvcHkgOiBDQVJpbmdCdWZmZXI6Ok1peCk7Ci0gICAg ICAgIHJldHVybiB0cnVlOwotICAgIH0KKyAgICBtX3JpbmdCdWZmZXItPmZldGNoKCZidWZmZXIs IHNhbXBsZUNvdW50LCB0aW1lU3RhbXAsIG1vZGUgPT0gQ29weSA/IENBUmluZ0J1ZmZlcjo6Q29w eSA6IENBUmluZ0J1ZmZlcjo6TWl4KTsKIAotICAgIGlmIChtX3NjcmF0Y2hCdWZmZXItPmNvcHlG cm9tKCptX3JpbmdCdWZmZXIuZ2V0KCksIHNhbXBsZUNvdW50LCB0aW1lU3RhbXAsIG1vZGUgPT0g Q29weSA/IENBUmluZ0J1ZmZlcjo6Q29weSA6IENBUmluZ0J1ZmZlcjo6TWl4KSkgewotICAgICAg ICBBdWRpb1NhbXBsZUJ1ZmZlckxpc3Q6Onplcm9BQkwoYnVmZmVyLCBzYW1wbGVDb3VudCk7Ci0g ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci0KLSAgICBtX3NjcmF0Y2hCdWZmZXItPmFwcGx5 R2FpbihtX3ZvbHVtZSk7Ci0gICAgaWYgKG1fc2NyYXRjaEJ1ZmZlci0+Y29weVRvKGJ1ZmZlciwg c2FtcGxlQ291bnQpKQotICAgICAgICBBdWRpb1NhbXBsZUJ1ZmZlckxpc3Q6Onplcm9BQkwoYnVm ZmVyLCBieXRlQ291bnQpOworICAgIGlmIChtX3ZvbHVtZSA8IC45NSkKKyAgICAgICAgQXVkaW9T YW1wbGVCdWZmZXJMaXN0OjphcHBseUdhaW4oYnVmZmVyLCBtX3ZvbHVtZSwgbV9vdXRwdXREZXNj cmlwdGlvbi0+Zm9ybWF0KCkpOwogCiAgICAgcmV0dXJuIHRydWU7CiB9Cg==