168638 2017-02-20 22:53:42 -0800 Parsing -webkit-hyphenate-character uses confusingly named consumeLocale() 2017-03-07 19:15:24 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser hyatt mmaxfield simon.fraser oldest_to_newest 1279235 0 simon.fraser 2017-02-20 22:53:42 -0800 -webkit-hyphenate-character was implemented in http://trac.webkit.org/r61548 parsing as <auto> or a string, but now we just fall through to parsing a locale: CSSPropertyParser.cpp:3761 case CSSPropertyWebkitHyphenateCharacter: case CSSPropertyWebkitLocale: return consumeLocale(m_range); 1279236 1 simon.fraser 2017-02-20 22:55:14 -0800 https://www.w3.org/TR/css-text-4/#hyphenate-character 1279459 2 simon.fraser 2017-02-21 11:53:43 -0800 It's just bad function naming. 1284692 3 303756 simon.fraser 2017-03-07 18:30:58 -0800 Created attachment 303756 Patch 1284694 4 303756 zalan 2017-03-07 18:44:52 -0800 Comment on attachment 303756 Patch title is misleading. 1284702 5 simon.fraser 2017-03-07 19:15:24 -0800 https://trac.webkit.org/r213561 303756 2017-03-07 18:30:58 -0800 2017-03-07 18:44:52 -0800 Patch bug-168638-20170307183058.patch text/plain 2154 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjEzNTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY2MGRiOTM3OGIzYWFk NDQwMDZlMWJkNjNmNWMxZWE3NDVhMzc3ZS4uZmQ5MDJmZmMwZTk2NTk2MzgwNTM1ZThhMzgyZGMy M2QwNDI1MTRiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIC13ZWJraXQtaHlw aGVuYXRlLWNoYXJhY3RlciBicm9rZW4/CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjg2MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBQYXJzaW5nIENTU1Byb3BlcnR5V2Via2l0SHlwaGVuYXRlQ2hhcmFj dGVyIHZlcnkgY29uZnVzaW5nbHkgY2FsbGVkIGNvbnN1bWVMb2NhbGUoKSwKKyAgICAgICAgd2hp Y2ggaXMgcmVhbGx5IGp1c3QgImNvbnN1bWUgdGhlICdhdXRvJyBpZGVudCBvciBhIHN0cmluZyIs IHNvIHJlbmFtZSB0aGF0IGZ1bmN0aW9uLgorCisgICAgICAgICogY3NzL3BhcnNlci9DU1NQcm9w ZXJ0eVBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjb25zdW1lQXV0b09yU3RyaW5nKToK KyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5UGFyc2VyOjpwYXJzZVNpbmdsZVZhbHVlKToK KyAgICAgICAgKFdlYkNvcmU6OmNvbnN1bWVMb2NhbGUpOiBEZWxldGVkLgorCiAyMDE3LTAzLTA3 ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIHBsYXRmb3Jt RGV2aWNlKCkgbm90IGlubGluZSwgdG8gYXZvaWQgYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv cGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAppbmRleCBiOTk1OTgwNzVlYjcyMTQyMTVjZmFh M2I0NmVmYjg4NGJhOTg4NDI5Li4zZDNiNmMzMTViNDYxNWI2MjhjMGVlZDA3NjgzNTE1ZmMwMWYx ZTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFy c2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2Vy LmNwcApAQCAtMTM3OCw3ICsxMzc4LDcgQEAgc3RhdGljIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1 ZT4gY29uc3VtZUxpbmVDbGFtcChDU1NQYXJzZXJUb2tlblJhbmdlJiByYW5nZSkKICAgICByZXR1 cm4gY29uc3VtZVBvc2l0aXZlSW50ZWdlcihyYW5nZSk7CiB9CiAKLXN0YXRpYyBSZWZQdHI8Q1NT VmFsdWU+IGNvbnN1bWVMb2NhbGUoQ1NTUGFyc2VyVG9rZW5SYW5nZSYgcmFuZ2UpCitzdGF0aWMg UmVmUHRyPENTU1ZhbHVlPiBjb25zdW1lQXV0b09yU3RyaW5nKENTU1BhcnNlclRva2VuUmFuZ2Um IHJhbmdlKQogewogICAgIGlmIChyYW5nZS5wZWVrKCkuaWQoKSA9PSBDU1NWYWx1ZUF1dG8pCiAg ICAgICAgIHJldHVybiBjb25zdW1lSWRlbnQocmFuZ2UpOwpAQCAtMzkyMiw3ICszOTIyLDcgQEAg UmVmUHRyPENTU1ZhbHVlPiBDU1NQcm9wZXJ0eVBhcnNlcjo6cGFyc2VTaW5nbGVWYWx1ZShDU1NQ cm9wZXJ0eUlEIHByb3BlcnR5LCBDU1MKICAgICAgICAgcmV0dXJuIGNvbnN1bWVMZW5ndGgobV9y YW5nZSwgbV9jb250ZXh0Lm1vZGUsIFZhbHVlUmFuZ2VBbGwsIFVuaXRsZXNzUXVpcms6OkFsbG93 KTsKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0SHlwaGVuYXRlQ2hhcmFjdGVyOgogICAgIGNh c2UgQ1NTUHJvcGVydHlXZWJraXRMb2NhbGU6Ci0gICAgICAgIHJldHVybiBjb25zdW1lTG9jYWxl KG1fcmFuZ2UpOworICAgICAgICByZXR1cm4gY29uc3VtZUF1dG9PclN0cmluZyhtX3JhbmdlKTsK ICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0SHlwaGVuYXRlTGltaXRCZWZvcmU6CiAgICAgY2Fz ZSBDU1NQcm9wZXJ0eVdlYmtpdEh5cGhlbmF0ZUxpbWl0QWZ0ZXI6CiAgICAgICAgIHJldHVybiBj b25zdW1lSHlwaGVuYXRlTGltaXQobV9yYW5nZSwgQ1NTVmFsdWVBdXRvKTsK