168633 2017-02-20 20:36:36 -0800 Remove unnecessary PerformanceEntry virtual methods 2017-02-20 21:53:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck achristensen commit-queue rniwa oldest_to_newest 1279197 0 joepeck 2017-02-20 20:36:36 -0800 Remove unnecessary PerformanceEntry virtual methods PerformanceEntries can only be created internally with specific types. So we can use the type instead of a virtual method. 1279198 1 302221 joepeck 2017-02-20 20:37:57 -0800 Created attachment 302221 [PATCH] Proposed Fix 1279203 2 302222 joepeck 2017-02-20 20:48:23 -0800 Created attachment 302222 [PATCH] Proposed Fix 1279210 3 302222 commit-queue 2017-02-20 21:53:21 -0800 Comment on attachment 302222 [PATCH] Proposed Fix Clearing flags on attachment: 302222 Committed r212700: <http://trac.webkit.org/changeset/212700> 1279211 4 commit-queue 2017-02-20 21:53:27 -0800 All reviewed patches have been landed. Closing bug. 302221 2017-02-20 20:37:57 -0800 2017-02-20 20:48:23 -0800 [PATCH] Proposed Fix virtual-1.patch text/plain 3593 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlYjUwZTNhYWYxYy4uNTQwZGQ0MmEzNjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wMi0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBQZXJmb3JtYW5jZUVudHJ5IHZpcnR1 YWwgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY4NjMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwYWdlL1BlcmZvcm1hbmNlRW50cnkuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1h bmNlRW50cnk6OmlzUmVzb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6UGVyZm9ybWFuY2VFbnRy eTo6aXNNYXJrKToKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlRW50cnk6OmlzTWVhc3Vy ZSk6CisgICAgICAgIEltcGxlbWVudCBiYXNlZCBvbiB0aGUgVHlwZS4KKworICAgICAgICAqIHBh Z2UvUGVyZm9ybWFuY2VNYXJrLmg6CisgICAgICAgICogcGFnZS9QZXJmb3JtYW5jZU1lYXN1cmUu aDoKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuaDoKKyAgICAgICAg UmVtb3ZlIHZpcnR1YWwgb3ZlcnJpZGVzLgorCiAyMDE3LTAyLTIwICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBwbHVtYmluZyB0byB0aGUgVUkg cHJvY2VzcyBmb3IgVGV4dEluZGljYXRvckRhdGEgd2hlbiBjb21wdXRpbmcgdGhlIGRyYWcgaW1h Z2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VFbnRyeS5oIGIv U291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZUVudHJ5LmgKaW5kZXggN2ViZWU2YTRjM2Eu LmQ2Y2U2ZmZiZGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNl RW50cnkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlRW50cnkuaApAQCAt NjEsOSArNjEsOSBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgc3RkOjpvcHRpb25hbDxUeXBlPiBw YXJzZUVudHJ5VHlwZVN0cmluZyhjb25zdCBTdHJpbmcmIGVudHJ5VHlwZSk7CiAKLSAgICB2aXJ0 dWFsIGJvb2wgaXNSZXNvdXJjZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgdmlydHVh bCBib29sIGlzTWFyaygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgdmlydHVhbCBib29s IGlzTWVhc3VyZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CisgICAgYm9vbCBpc1Jlc291cmNl KCkgY29uc3QgeyByZXR1cm4gbV9lbnRyeVR5cGUgPT0gVHlwZTo6UmVzb3VyY2U7IH0KKyAgICBi b29sIGlzTWFyaygpIGNvbnN0IHsgcmV0dXJuIG1fZW50cnlUeXBlID09IFR5cGU6Ok1hcms7IH0K KyAgICBib29sIGlzTWVhc3VyZSgpIGNvbnN0IHsgcmV0dXJuIG1fZW50cnlUeXBlID09IFR5cGU6 Ok1lYXN1cmU7IH0KIAogICAgIHN0YXRpYyBib29sIHN0YXJ0VGltZUNvbXBhcmVMZXNzVGhhbihj b25zdCBSZWZQdHI8UGVyZm9ybWFuY2VFbnRyeT4mIGEsIGNvbnN0IFJlZlB0cjxQZXJmb3JtYW5j ZUVudHJ5PiYgYikKICAgICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZv cm1hbmNlTWFyay5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU1hcmsuaAppbmRl eCA1MjhiYTE5OTY3OC4uYmU2ZmIwOGZmNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvUGVyZm9ybWFuY2VNYXJrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5j ZU1hcmsuaApAQCAtMzUsOCArMzUsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBQZXJm b3JtYW5jZU1hcmsgZmluYWwgOiBwdWJsaWMgUGVyZm9ybWFuY2VFbnRyeSB7CiBwdWJsaWM6CiAg ICAgc3RhdGljIFJlZjxQZXJmb3JtYW5jZU1hcms+IGNyZWF0ZShjb25zdCBTdHJpbmcmIG5hbWUs IGRvdWJsZSBzdGFydFRpbWUpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUGVyZm9ybWFuY2VNYXJr KG5hbWUsIHN0YXJ0VGltZSkpOyB9Ci0KLSAgICBib29sIGlzTWFyaygpIGNvbnN0IG92ZXJyaWRl IHsgcmV0dXJuIHRydWU7IH0KICAgICAKIHByaXZhdGU6CiAgICAgUGVyZm9ybWFuY2VNYXJrKGNv bnN0IFN0cmluZyYgbmFtZSwgZG91YmxlIHN0YXJ0VGltZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VNZWFzdXJlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bl cmZvcm1hbmNlTWVhc3VyZS5oCmluZGV4IGNkYjBiNmM1ODhhLi44NDhjYmY1MjVlMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU1lYXN1cmUuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTWVhc3VyZS5oCkBAIC0zNiw4ICszNiw2IEBAIGNs YXNzIFBlcmZvcm1hbmNlTWVhc3VyZSBmaW5hbCA6IHB1YmxpYyBQZXJmb3JtYW5jZUVudHJ5IHsK IHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPFBlcmZvcm1hbmNlTWVhc3VyZT4gY3JlYXRlKGNvbnN0 IFN0cmluZyYgbmFtZSwgZG91YmxlIHN0YXJ0VGltZSwgZG91YmxlIGR1cmF0aW9uKSB7IHJldHVy biBhZG9wdFJlZigqbmV3IFBlcmZvcm1hbmNlTWVhc3VyZShuYW1lLCBzdGFydFRpbWUsIGR1cmF0 aW9uKSk7IH0KIAotICAgIGJvb2wgaXNNZWFzdXJlKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4g dHJ1ZTsgfQotCiBwcml2YXRlOgogICAgIFBlcmZvcm1hbmNlTWVhc3VyZShjb25zdCBTdHJpbmcm IG5hbWUsIGRvdWJsZSBzdGFydFRpbWUsIGRvdWJsZSBkdXJhdGlvbikKICAgICAgICAgOiBQZXJm b3JtYW5jZUVudHJ5KFBlcmZvcm1hbmNlRW50cnk6OlR5cGU6Ok1lYXN1cmUsIG5hbWUsIEFTQ0lJ TGl0ZXJhbCgibWVhc3VyZSIpLCBzdGFydFRpbWUsIGR1cmF0aW9uKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVJlc291cmNlVGltaW5nLmggYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuaAppbmRleCAyODcxNGU4NWVlMi4u YzZhN2U1MDhhZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VS ZXNvdXJjZVRpbWluZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VSZXNv dXJjZVRpbWluZy5oCkBAIC02Myw4ICs2Myw2IEBAIHB1YmxpYzoKICAgICBkb3VibGUgcmVzcG9u c2VTdGFydCgpIGNvbnN0OwogICAgIGRvdWJsZSByZXNwb25zZUVuZCgpIGNvbnN0OwogCi0gICAg Ym9vbCBpc1Jlc291cmNlKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gdHJ1ZTsgfQotCiBwcml2 YXRlOgogICAgIFBlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcoTW9ub3RvbmljVGltZSB0aW1lT3Jp Z2luLCBSZXNvdXJjZVRpbWluZyYmKTsKICAgICB+UGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZygp Owo= 302222 2017-02-20 20:48:23 -0800 2017-02-20 21:53:21 -0800 [PATCH] Proposed Fix virtual-2.patch text/plain 3578 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlYjUwZTNhYWYxYy4uNTQwZGQ0MmEzNjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wMi0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBQZXJmb3JtYW5jZUVudHJ5IHZpcnR1 YWwgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY4NjMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwYWdlL1BlcmZvcm1hbmNlRW50cnkuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1h bmNlRW50cnk6OmlzUmVzb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6UGVyZm9ybWFuY2VFbnRy eTo6aXNNYXJrKToKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlRW50cnk6OmlzTWVhc3Vy ZSk6CisgICAgICAgIEltcGxlbWVudCBiYXNlZCBvbiB0aGUgVHlwZS4KKworICAgICAgICAqIHBh Z2UvUGVyZm9ybWFuY2VNYXJrLmg6CisgICAgICAgICogcGFnZS9QZXJmb3JtYW5jZU1lYXN1cmUu aDoKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuaDoKKyAgICAgICAg UmVtb3ZlIHZpcnR1YWwgb3ZlcnJpZGVzLgorCiAyMDE3LTAyLTIwICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBwbHVtYmluZyB0byB0aGUgVUkg cHJvY2VzcyBmb3IgVGV4dEluZGljYXRvckRhdGEgd2hlbiBjb21wdXRpbmcgdGhlIGRyYWcgaW1h Z2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VFbnRyeS5oIGIv U291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZUVudHJ5LmgKaW5kZXggN2ViZWU2YTRjM2Eu LjRiMDEwZTM2NzliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNl RW50cnkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlRW50cnkuaApAQCAt NjEsOSArNjEsOSBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgc3RkOjpvcHRpb25hbDxUeXBlPiBw YXJzZUVudHJ5VHlwZVN0cmluZyhjb25zdCBTdHJpbmcmIGVudHJ5VHlwZSk7CiAKLSAgICB2aXJ0 dWFsIGJvb2wgaXNSZXNvdXJjZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgdmlydHVh bCBib29sIGlzTWFyaygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgdmlydHVhbCBib29s IGlzTWVhc3VyZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CisgICAgYm9vbCBpc1Jlc291cmNl KCkgY29uc3QgeyByZXR1cm4gbV90eXBlID09IFR5cGU6OlJlc291cmNlOyB9CisgICAgYm9vbCBp c01hcmsoKSBjb25zdCB7IHJldHVybiBtX3R5cGUgPT0gVHlwZTo6TWFyazsgfQorICAgIGJvb2wg aXNNZWFzdXJlKCkgY29uc3QgeyByZXR1cm4gbV90eXBlID09IFR5cGU6Ok1lYXN1cmU7IH0KIAog ICAgIHN0YXRpYyBib29sIHN0YXJ0VGltZUNvbXBhcmVMZXNzVGhhbihjb25zdCBSZWZQdHI8UGVy Zm9ybWFuY2VFbnRyeT4mIGEsIGNvbnN0IFJlZlB0cjxQZXJmb3JtYW5jZUVudHJ5PiYgYikKICAg ICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTWFyay5oIGIv U291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU1hcmsuaAppbmRleCA1MjhiYTE5OTY3OC4u YmU2ZmIwOGZmNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VN YXJrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU1hcmsuaApAQCAtMzUs OCArMzUsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBQZXJmb3JtYW5jZU1hcmsgZmlu YWwgOiBwdWJsaWMgUGVyZm9ybWFuY2VFbnRyeSB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFJlZjxQ ZXJmb3JtYW5jZU1hcms+IGNyZWF0ZShjb25zdCBTdHJpbmcmIG5hbWUsIGRvdWJsZSBzdGFydFRp bWUpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUGVyZm9ybWFuY2VNYXJrKG5hbWUsIHN0YXJ0VGlt ZSkpOyB9Ci0KLSAgICBib29sIGlzTWFyaygpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7 IH0KICAgICAKIHByaXZhdGU6CiAgICAgUGVyZm9ybWFuY2VNYXJrKGNvbnN0IFN0cmluZyYgbmFt ZSwgZG91YmxlIHN0YXJ0VGltZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVy Zm9ybWFuY2VNZWFzdXJlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlTWVhc3Vy ZS5oCmluZGV4IGNkYjBiNmM1ODhhLi44NDhjYmY1MjVlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9QZXJmb3JtYW5jZU1lYXN1cmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1BlcmZvcm1hbmNlTWVhc3VyZS5oCkBAIC0zNiw4ICszNiw2IEBAIGNsYXNzIFBlcmZvcm1hbmNl TWVhc3VyZSBmaW5hbCA6IHB1YmxpYyBQZXJmb3JtYW5jZUVudHJ5IHsKIHB1YmxpYzoKICAgICBz dGF0aWMgUmVmPFBlcmZvcm1hbmNlTWVhc3VyZT4gY3JlYXRlKGNvbnN0IFN0cmluZyYgbmFtZSwg ZG91YmxlIHN0YXJ0VGltZSwgZG91YmxlIGR1cmF0aW9uKSB7IHJldHVybiBhZG9wdFJlZigqbmV3 IFBlcmZvcm1hbmNlTWVhc3VyZShuYW1lLCBzdGFydFRpbWUsIGR1cmF0aW9uKSk7IH0KIAotICAg IGJvb2wgaXNNZWFzdXJlKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gdHJ1ZTsgfQotCiBwcml2 YXRlOgogICAgIFBlcmZvcm1hbmNlTWVhc3VyZShjb25zdCBTdHJpbmcmIG5hbWUsIGRvdWJsZSBz dGFydFRpbWUsIGRvdWJsZSBkdXJhdGlvbikKICAgICAgICAgOiBQZXJmb3JtYW5jZUVudHJ5KFBl cmZvcm1hbmNlRW50cnk6OlR5cGU6Ok1lYXN1cmUsIG5hbWUsIEFTQ0lJTGl0ZXJhbCgibWVhc3Vy ZSIpLCBzdGFydFRpbWUsIGR1cmF0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9QZXJmb3JtYW5jZVJlc291cmNlVGltaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZv cm1hbmNlUmVzb3VyY2VUaW1pbmcuaAppbmRleCAyODcxNGU4NWVlMi4uYzZhN2U1MDhhZjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZy5oCkBA IC02Myw4ICs2Myw2IEBAIHB1YmxpYzoKICAgICBkb3VibGUgcmVzcG9uc2VTdGFydCgpIGNvbnN0 OwogICAgIGRvdWJsZSByZXNwb25zZUVuZCgpIGNvbnN0OwogCi0gICAgYm9vbCBpc1Jlc291cmNl KCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gdHJ1ZTsgfQotCiBwcml2YXRlOgogICAgIFBlcmZv cm1hbmNlUmVzb3VyY2VUaW1pbmcoTW9ub3RvbmljVGltZSB0aW1lT3JpZ2luLCBSZXNvdXJjZVRp bWluZyYmKTsKICAgICB+UGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZygpOwo=