16863 2008-01-13 12:30:49 -0800 [GTK] tab focusing doesn't work 2008-02-19 05:06:16 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 lethalman88 webkit-unassigned alp lethalman88 oldest_to_newest 67145 0 lethalman88 2008-01-13 12:30:49 -0800 Open a page, then use the TAB to focus widgets in the page. It doesn't work. I'm using r29446. 67148 1 lethalman88 2008-01-13 12:45:47 -0800 The issue is there also with r29455. I've GTK+ 2.12.1-r2 installed. 67161 2 alp 2008-01-13 15:09:20 -0800 I couldn't reproduce this with r29455. Downgrading bug priority, P1 should only be for crashers and serious API issues in the GTK+ port. Did you do try a clean build? Can you describe what happens when you press tab/shift-tab? Are you using GtkLauncher? I'm using GTK+ 2.12.0-1ubuntu3 67246 3 lethalman88 2008-01-14 11:39:11 -0800 Clean build r29473 (HEAD) with both GtkLauncher and epiphany. The used library is right the latest built. 67666 4 alp 2008-01-18 23:52:14 -0800 Fix specified in Bug #16910 landed in r29665. 70726 5 lethalman88 2008-02-14 23:38:59 -0800 I noticed the problem about 2 week ago but didn't reopened the bug. Now the problem is there again. Pressing TAB doesn't change focus inside the view. Using svn gtk+/glib/pango/webkit. Straight normal ./configure. 70767 6 lethalman88 2008-02-15 09:19:01 -0800 Found the problem. Maybe my X configuration enables GDK_MOD2_MASK when num lock is on, which enables the event->metaKey (). Tab key event with meta keys is not handled by WebCore. Instead, disabling num lock will enable tab focusing again and bring the meta key to off. 70770 7 pierre-luc.beaudoin 2008-02-15 09:59:28 -0800 Same results here: Can't tab with num lock on. Tabs for perfectly with num lock off. 71104 8 19202 alp 2008-02-18 18:06:41 -0800 Created attachment 19202 Fix 71130 9 19202 mrowe 2008-02-19 04:46:04 -0800 Comment on attachment 19202 Fix It might be worth looking at setting things up such that you can do: #if HAVE(GDK_META_MASK) rather than: #if GTK_CHECK_VERSION(2,10,0) as it'd be clearer what the test is about. Either way, r=me. 71131 10 alp 2008-02-19 05:06:16 -0800 (In reply to comment #9) > (From update of attachment 19202 [edit]) > It might be worth looking at setting things up such that you can do: > > #if HAVE(GDK_META_MASK) > > rather than: > > #if GTK_CHECK_VERSION(2,10,0) > > as it'd be clearer what the test is about. Either way, r=me. > I'm going to give this cleanup a miss since I hope we can eventually combine the event class init code and get rid of the duplication completely. Landed in r30404. 19202 2008-02-18 18:06:41 -0800 2008-02-19 04:46:04 -0800 Fix meta.patch text/plain 4538 alp ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWFkMjJhYy4uYmMyNjE5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyOSBAQAogMjAwOC0wMi0xOCAgQWxwIFRva2VyICA8 YWxwQGF0b2tlci5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NjMKKyAg ICAgICAgW0dUS10gdGFiIGZvY3VzaW5nIGRvZXNuJ3Qgd29yaworCisgICAgICAgIEdES19NT0Qy X01BU0sgZG9lc24ndCBhbHdheXMgbWVhbiBtZXRhIHNvIHdlIGNhbid0IHVzZSBpdCB0byBpZGVu dGlmeQorICAgICAgICB0aGUgbWV0YSBrZXkgc3RhdGUuCisKKyAgICAgICAgVXNlIEdES19NRVRB X01BU0sgd2hlcmUgYXZhaWxhYmxlLCBvdGhlcndpc2UgZG8gbm90IHN1cHBvcnQgdGhlIG1ldGEK KyAgICAgICAga2V5LiBUaGlzIG1hdGNoZXMgdGhlIGJlaGF2aW91ciBvZiBvdGhlciBhcHBsaWNh dGlvbnMuCisKKyAgICAgICAgQWxzbyBhZGQgYSBjb21tZW50IG5vdGluZyB0aGF0IHRoZSBwbGF0 Zm9ybSBldmVudCBjb25zdHJ1Y3RvcnMgbmVlZCB0bworICAgICAgICBiZSBrZXB0IGluIHN5bmMg KGl0J3Mgbm90IG9idmlvdXMgdGhhdCB0aGVyZSBhcmUgbXVsdGlwbGUgcGxhY2VzIHRoYXQKKyAg ICAgICAgY2hlY2sgdGhlIGtleSBzdGF0ZSkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5 RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQ bGF0Zm9ybUtleWJvYXJkRXZlbnQpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9Nb3VzZUV2ZW50 R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtTW91c2VFdmVudDo6UGxhdGZvcm1N b3VzZUV2ZW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvV2hlZWxFdmVudEd0ay5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybVdoZWVsRXZlbnQ6OlBsYXRmb3JtV2hlZWxFdmVudCk6 CisKKzIwMDgtMDItMTggIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgorCiAgICAgICAgIFJl dmlld2VkIGJ5IE1hcmsgUm93ZS4KIAogICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzM4MQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvS2V5 RXZlbnRHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwCmluZGV4 IGYwZjcwNWUuLjEzOWZmN2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2 ZW50R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKQEAg LTM3LDYgKzM3LDcgQEAKIAogI2luY2x1ZGUgPGdkay9nZGsuaD4KICNpbmNsdWRlIDxnZGsvZ2Rr a2V5c3ltcy5oPgorI2luY2x1ZGUgPGd0ay9ndGt2ZXJzaW9uLmg+CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIApAQCAtNDg1LDYgKzQ4Niw3IEBAIHN0YXRpYyBTdHJpbmcgc2luZ2xlQ2hhcmFjdGVy U3RyaW5nKGd1aW50IHZhbCkKICAgICByZXR1cm4gcmV0VmFsOwogfQogCisvLyBLZWVwIHRoaXMg aW4gc3luYyB3aXRoIHRoZSBvdGhlciBwbGF0Zm9ybSBldmVudCBjb25zdHJ1Y3RvcnMKIC8vIFRP RE86IG1fZ2RrRXZlbnRLZXkgc2hvdWxkIGJlIHJlZmNvdW50ZWQKIFBsYXRmb3JtS2V5Ym9hcmRF dmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KEdka0V2ZW50S2V5KiBldmVudCkKICAgICA6IG1f dHlwZSgoZXZlbnQtPnR5cGUgPT0gR0RLX0tFWV9SRUxFQVNFKSA/IEtleVVwIDogS2V5RG93bikK QEAgLTQ5Nyw3ICs0OTksMTIgQEAgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJv YXJkRXZlbnQoR2RrRXZlbnRLZXkqIGV2ZW50KQogICAgICwgbV9zaGlmdEtleSgoZXZlbnQtPnN0 YXRlICYgR0RLX1NISUZUX01BU0spIHx8IChldmVudC0+a2V5dmFsID09IEdES18zMjcwX0JhY2tU YWIpKQogICAgICwgbV9jdHJsS2V5KGV2ZW50LT5zdGF0ZSAmIEdES19DT05UUk9MX01BU0spCiAg ICAgLCBtX2FsdEtleShldmVudC0+c3RhdGUgJiBHREtfTU9EMV9NQVNLKQotICAgICwgbV9tZXRh S2V5KGV2ZW50LT5zdGF0ZSAmIEdES19NT0QyX01BU0spCisjaWYgR1RLX0NIRUNLX1ZFUlNJT04o MiwxMCwwKQorICAgICwgbV9tZXRhS2V5KGV2ZW50LT5zdGF0ZSAmIEdES19NRVRBX01BU0spCisj ZWxzZQorICAgIC8vIEdES19NT0QyX01BU0sgZG9lc24ndCBhbHdheXMgbWVhbiBtZXRhIHNvIHdl IGNhbid0IHVzZSBpdAorICAgICwgbV9tZXRhS2V5KGZhbHNlKQorI2VuZGlmCiAgICAgLCBtX2dk a0V2ZW50S2V5KGV2ZW50KQogewogfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv TW91c2VFdmVudEd0ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Nb3VzZUV2ZW50R3RrLmNw cAppbmRleCAyOWVhMzcxLi5mNDQxZjAwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9Nb3VzZUV2ZW50R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Nb3VzZUV2ZW50 R3RrLmNwcApAQCAtMzEsMTEgKzMxLDEzIEBACiAjaW5jbHVkZSAiQXNzZXJ0aW9ucy5oIgogCiAj aW5jbHVkZSA8Z2RrL2dkay5oPgorI2luY2x1ZGUgPGd0ay9ndGt2ZXJzaW9uLmg+CiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogLy8gRklYTUU6IFdvdWxkIGJlIGV2ZW4gYmV0dGVyIHRvIGZpZ3Vy ZSBvdXQgd2hpY2ggbW9kaWZpZXIgaXMgQWx0IGluc3RlYWQgb2YgYWx3YXlzIHVzaW5nIEdES19N T0QxX01BU0suCiAKKy8vIEtlZXAgdGhpcyBpbiBzeW5jIHdpdGggdGhlIG90aGVyIHBsYXRmb3Jt IGV2ZW50IGNvbnN0cnVjdG9ycwogUGxhdGZvcm1Nb3VzZUV2ZW50OjpQbGF0Zm9ybU1vdXNlRXZl bnQoR2RrRXZlbnRCdXR0b24qIGV2ZW50KQogewogICAgIG1fdGltZXN0YW1wID0gZXZlbnQtPnRp bWU7CkBAIC00NCw3ICs0NiwxMiBAQCBQbGF0Zm9ybU1vdXNlRXZlbnQ6OlBsYXRmb3JtTW91c2VF dmVudChHZGtFdmVudEJ1dHRvbiogZXZlbnQpCiAgICAgbV9zaGlmdEtleSA9IGV2ZW50LT5zdGF0 ZSAmIEdES19TSElGVF9NQVNLOwogICAgIG1fY3RybEtleSA9IGV2ZW50LT5zdGF0ZSAmIEdES19D T05UUk9MX01BU0s7CiAgICAgbV9hbHRLZXkgPSBldmVudC0+c3RhdGUgJiBHREtfTU9EMV9NQVNL OwotICAgIG1fbWV0YUtleSA9IGV2ZW50LT5zdGF0ZSAmIEdES19NT0QyX01BU0s7CisjaWYgR1RL X0NIRUNLX1ZFUlNJT04oMiwxMCwwKQorICAgIG1fbWV0YUtleSA9IGV2ZW50LT5zdGF0ZSAmIEdE S19NRVRBX01BU0s7CisjZWxzZQorICAgIC8vIEdES19NT0QyX01BU0sgZG9lc24ndCBhbHdheXMg bWVhbiBtZXRhIHNvIHdlIGNhbid0IHVzZSBpdAorICAgIG1fbWV0YUtleSA9IGZhbHNlOworI2Vu ZGlmCiAKICAgICBzd2l0Y2ggKGV2ZW50LT50eXBlKSB7CiAgICAgY2FzZSBHREtfQlVUVE9OX1BS RVNTOgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvV2hlZWxFdmVudEd0ay5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9XaGVlbEV2ZW50R3RrLmNwcAppbmRleCAzMzY4ZjI1Li4w OGYwMmNjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9XaGVlbEV2ZW50R3RrLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9XaGVlbEV2ZW50R3RrLmNwcApAQCAtMjksOSAr MjksMTEgQEAKICNpbmNsdWRlICJQbGF0Zm9ybVdoZWVsRXZlbnQuaCIKIAogI2luY2x1ZGUgPGdk ay9nZGsuaD4KKyNpbmNsdWRlIDxndGsvZ3RrdmVyc2lvbi5oPgogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKKy8vIEtlZXAgdGhpcyBpbiBzeW5jIHdpdGggdGhlIG90aGVyIHBsYXRmb3JtIGV2ZW50 IGNvbnN0cnVjdG9ycwogUGxhdGZvcm1XaGVlbEV2ZW50OjpQbGF0Zm9ybVdoZWVsRXZlbnQoR2Rr RXZlbnRTY3JvbGwqIGV2ZW50KQogewogICAgIHN0YXRpYyBjb25zdCBmbG9hdCBkZWx0YSA9IDE7 CkBAIC02MSw3ICs2MywxMiBAQCBQbGF0Zm9ybVdoZWVsRXZlbnQ6OlBsYXRmb3JtV2hlZWxFdmVu dChHZGtFdmVudFNjcm9sbCogZXZlbnQpCiAgICAgbV9zaGlmdEtleSA9IGV2ZW50LT5zdGF0ZSAm IEdES19TSElGVF9NQVNLOwogICAgIG1fY3RybEtleSA9IGV2ZW50LT5zdGF0ZSAmIEdES19DT05U Uk9MX01BU0s7CiAgICAgbV9hbHRLZXkgPSBldmVudC0+c3RhdGUgJiBHREtfTU9EMV9NQVNLOwot ICAgIG1fbWV0YUtleSA9IGV2ZW50LT5zdGF0ZSAmIEdES19NT0QyX01BU0s7CisjaWYgR1RLX0NI RUNLX1ZFUlNJT04oMiwxMCwwKQorICAgIG1fbWV0YUtleSA9IGV2ZW50LT5zdGF0ZSAmIEdES19N RVRBX01BU0s7CisjZWxzZQorICAgIC8vIEdES19NT0QyX01BU0sgZG9lc24ndCBhbHdheXMgbWVh biBtZXRhIHNvIHdlIGNhbid0IHVzZSBpdAorICAgIG1fbWV0YUtleSA9IGZhbHNlOworI2VuZGlm CiAgICAgbV9pc0NvbnRpbnVvdXMgPSBmYWxzZTsKIH0KIAo=