168624 2017-02-20 17:31:09 -0800 Improve bot watcher's dashboard performance 2017-03-28 12:59:13 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170191 InRadar P2 Normal --- 1 ap ap dbates lforschler ryanhaddad oldest_to_newest 1279153 0 ap 2017-02-20 17:31:09 -0800 rdar://problem/30190109 1279155 1 302211 ap 2017-02-20 17:34:31 -0800 Created attachment 302211 proposed fix 1279353 2 302211 dbates 2017-02-21 09:00:36 -0800 Comment on attachment 302211 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=302211&action=review > Tools/ChangeLog:5 > + <rdar://problem/30190109> build-safari dashboard performance issues Did you mean to include more than the radar URL on this line? 1279438 3 ap 2017-02-21 11:13:25 -0800 Committed http://trac.webkit.org/r212729 302211 2017-02-20 17:34:31 -0800 2017-02-21 09:00:36 -0800 proposed fix DashboardPerf.txt text/plain 4275 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMjY4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTAyLTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEltcHJvdmUgYm90IHdhdGNoZXIncyBkYXNoYm9hcmQgcGVyZm9ybWFuY2UK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODYyNAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzAxOTAxMDk+IGJ1aWxkLXNhZmFyaSBkYXNoYm9hcmQg cGVyZm9ybWFuY2UgaXNzdWVzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9UcmFjLmpzOgorICAgICAgICBUaGVyZSB3YXMg YW4gdW5uZWNlc3NhcnkgbGluZWFyIGNvbXBsZXhpdHkgYWxnb3JpdGhtIGluIGluZGV4T2ZSZXZp c2lvbigpLgorCiAyMDE3LTAyLTIwICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlzdGljczogQWRkIGFsdGVybmF0ZSBjbGFz c2lmaWNhdGlvbiBtZXRob2QKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1RyYWMuanMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvVHJhYy5qcwkocmV2aXNpb24gMjEyNjU3 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvVHJhYy5qcwkod29ya2luZyBjb3B5KQpAQCAtMzcs NiArMzcsNyBAQCBUcmFjID0gZnVuY3Rpb24oYmFzZVVSTCwgb3B0aW9ucykKICAgICB9CiAKICAg ICB0aGlzLnJlY29yZGVkQ29tbWl0cyA9IFtdOyAvLyBXaWxsIGJlIHNvcnRlZCBpbiBhc2NlbmRp bmcgb3JkZXIuCisgICAgdGhpcy5yZWNvcmRlZENvbW1pdEluZGljZXNCeVJldmlzaW9uTnVtYmVy ID0ge307CiB9OwogCiBCYXNlT2JqZWN0LmFkZENvbnN0cnVjdG9yRnVuY3Rpb25zKFRyYWMpOwpA QCAtMjIzLDExICsyMjQsNiBAQCBUcmFjLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKCFkYXRh RG9jdW1lbnQpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdmFyIHJlY29yZGVkUmV2 aXNpb25OdW1iZXJzID0gdGhpcy5yZWNvcmRlZENvbW1pdHMucmVkdWNlKGZ1bmN0aW9uKHByZXZp b3VzUmVzdWx0LCBjb21taXQpIHsKLSAgICAgICAgICAgIHByZXZpb3VzUmVzdWx0W2NvbW1pdC5y ZXZpc2lvbk51bWJlcl0gPSBjb21taXQ7Ci0gICAgICAgICAgICByZXR1cm4gcHJldmlvdXNSZXN1 bHQ7Ci0gICAgICAgIH0sIHt9KTsKLQogICAgICAgICB2YXIga25vd25Db21taXRzV2VyZVVwZGF0 ZWQgPSBmYWxzZTsKICAgICAgICAgdmFyIG5ld0NvbW1pdHMgPSBbXTsKIApAQCAtMjM1LDE5ICsy MzEsMjUgQEAgVHJhYy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBjb21taXRJbmZvRWxlbWVu dDsKICAgICAgICAgd2hpbGUgKGNvbW1pdEluZm9FbGVtZW50ID0gY29tbWl0SW5mb0VsZW1lbnRz Lml0ZXJhdGVOZXh0KCkpIHsKICAgICAgICAgICAgIHZhciBjb21taXQgPSB0aGlzLl9jb252ZXJ0 Q29tbWl0SW5mb0VsZW1lbnRUb09iamVjdChkYXRhRG9jdW1lbnQsIGNvbW1pdEluZm9FbGVtZW50 KTsKLSAgICAgICAgICAgIGlmIChjb21taXQucmV2aXNpb25OdW1iZXIgaW4gcmVjb3JkZWRSZXZp c2lvbk51bWJlcnMpIHsKKyAgICAgICAgICAgIHZhciBrbm93bkNvbW1pdEluZGV4ID0gdGhpcy5y ZWNvcmRlZENvbW1pdEluZGljZXNCeVJldmlzaW9uTnVtYmVyW2NvbW1pdC5yZXZpc2lvbk51bWJl cl07CisgICAgICAgICAgICBpZiAoa25vd25Db21taXRJbmRleCA+PSAwKSB7CiAgICAgICAgICAg ICAgICAgLy8gQXV0aG9yIGNvdWxkIGhhdmUgY2hhbmdlZCwgYXMgY29tbWl0IHF1ZXVlIHJlcGxh Y2VzIGl0IGFmdGVyIHRoZSBmYWN0LgotICAgICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHJl Y29yZGVkUmV2aXNpb25OdW1iZXJzW2NvbW1pdC5yZXZpc2lvbk51bWJlcl0ucmV2aXNpb25OdW1i ZXIgPT09IGNvbW1pdC5yZXZpc2lvbk51bWJlcik7Ci0gICAgICAgICAgICAgICAgaWYgKHJlY29y ZGVkUmV2aXNpb25OdW1iZXJzW2NvbW1pdC5yZXZpc2lvbk51bWJlcl0uYXV0aG9yICE9IGNvbW1p dC5hdXRob3IpIHsKLSAgICAgICAgICAgICAgICAgICAgcmVjb3JkZWRSZXZpc2lvbk51bWJlcnNb Y29tbWl0LnJldmlzaW9uTnVtYmVyXS5hdXRob3IgPSBjb21taXQuYXV0aG9yOworICAgICAgICAg ICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMucmVjb3JkZWRDb21taXRzW2tub3duQ29tbWl0SW5k ZXhdLnJldmlzaW9uTnVtYmVyID09PSBjb21taXQucmV2aXNpb25OdW1iZXIpOworICAgICAgICAg ICAgICAgIGlmICh0aGlzLnJlY29yZGVkQ29tbWl0c1trbm93bkNvbW1pdEluZGV4XS5hdXRob3Ig IT0gY29tbWl0LmF1dGhvcikgeworICAgICAgICAgICAgICAgICAgICB0aGlzLnJlY29yZGVkQ29t bWl0c1trbm93bkNvbW1pdEluZGV4XS5hdXRob3IgPSBjb21taXQuYXV0aG9yOwogICAgICAgICAg ICAgICAgICAgICBrbm93bkNvbW1pdFdhc1VwZGF0ZWQgPSB0cnVlOwogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAgIG5ld0NvbW1pdHMucHVzaChj b21taXQpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKG5ld0NvbW1pdHMubGVuZ3RoKQorICAg ICAgICBpZiAobmV3Q29tbWl0cy5sZW5ndGgpIHsKICAgICAgICAgICAgIHRoaXMucmVjb3JkZWRD b21taXRzID0gbmV3Q29tbWl0cy5jb25jYXQodGhpcy5yZWNvcmRlZENvbW1pdHMpLnNvcnQoZnVu Y3Rpb24oYSwgYikgeyByZXR1cm4gYS5kYXRlIC0gYi5kYXRlOyB9KTsKKyAgICAgICAgICAgIHRo aXMucmVjb3JkZWRDb21taXRJbmRpY2VzQnlSZXZpc2lvbk51bWJlciA9IHt9OworICAgICAgICAg ICAgdGhpcy5yZWNvcmRlZENvbW1pdHMuZm9yRWFjaChmdW5jdGlvbihjdXJlbnRWYWx1ZSwgaW5k ZXgpIHsKKyAgICAgICAgICAgICAgICB0aGlzLnJlY29yZGVkQ29tbWl0SW5kaWNlc0J5UmV2aXNp b25OdW1iZXJbY3VyZW50VmFsdWUucmV2aXNpb25OdW1iZXJdID0gaW5kZXg7CisgICAgICAgICAg ICB9LCB0aGlzKTsKKyAgICAgICAgfQogCiAgICAgICAgIGlmIChuZXdDb21taXRzLmxlbmd0aCB8 fCBrbm93bkNvbW1pdHNXZXJlVXBkYXRlZCkKICAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVu dFRvTGlzdGVuZXJzKFRyYWMuRXZlbnQuQ29tbWl0c1VwZGF0ZWQsIG51bGwpOwpAQCAtMzE4LDEz ICszMjAsMTIgQEAgVHJhYy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiBUcmFjLk5PX01P UkVfUkVWSVNJT05TOwogICAgIH0sCiAKLSAgICBpbmRleE9mUmV2aXNpb246IGZ1bmN0aW9uKHJl dmlzaW9uKQorICAgIGluZGV4T2ZSZXZpc2lvbjogZnVuY3Rpb24ocmV2aXNpb25OdW1iZXIpCiAg ICAgewotICAgICAgICB2YXIgY29tbWl0cyA9IHRoaXMucmVjb3JkZWRDb21taXRzOwotICAgICAg ICBmb3IgKHZhciBpID0gMDsgaSA8IGNvbW1pdHMubGVuZ3RoOyArK2kpIHsKLSAgICAgICAgICAg IGlmIChjb21taXRzW2ldLnJldmlzaW9uTnVtYmVyID09PSByZXZpc2lvbikKLSAgICAgICAgICAg ICAgICByZXR1cm4gaTsKLSAgICAgICAgfQotICAgICAgICByZXR1cm4gLTE7CisgICAgICAgIHZh ciByZXN1bHQgPSB0aGlzLnJlY29yZGVkQ29tbWl0SW5kaWNlc0J5UmV2aXNpb25OdW1iZXJbcmV2 aXNpb25OdW1iZXJdOworICAgICAgICAvLyBGSVhNRTogVXBkYXRlIGNhbGxlcnMgdG8gaGFuZGxl IHVuZGVmaW5lZCByZXN1bHQuCisgICAgICAgIGlmIChyZXN1bHQgPT09IHVuZGVmaW5lZCkKKyAg ICAgICAgICAgIHJldHVybiAtMTsKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9LAogfTsK