168621 2017-02-20 16:12:55 -0800 Exclude various mac-specific header files from iOS build 2017-02-20 18:25:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue juergen mitz oldest_to_newest 1279111 0 aakash_jain 2017-02-20 16:12:55 -0800 WebKitLegacy.xcconfig contains a list EXCLUDED_SOURCE_FILE_NAMES which specifies the files that should be excluded for iOS build. Various mac-specific header files are missing from this list (while corresponding implementation file are present in the list). 1279112 1 302194 aakash_jain 2017-02-20 16:14:09 -0800 Created attachment 302194 Proposed patch 1279171 2 302194 commit-queue 2017-02-20 18:25:24 -0800 Comment on attachment 302194 Proposed patch Clearing flags on attachment: 302194 Committed r212694: <http://trac.webkit.org/changeset/212694> 1279172 3 commit-queue 2017-02-20 18:25:27 -0800 All reviewed patches have been landed. Closing bug. 302194 2017-02-20 16:14:09 -0800 2017-02-20 18:25:24 -0800 Proposed patch patch_xcconfig_exclude text/plain 2698 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjY4MSkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTIw ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBFeGNsdWRl IHZhcmlvdXMgbWFjLXNwZWNpZmljIGhlYWRlciBmaWxlcyBmcm9tIGlPUyBidWlsZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NjIxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9u cy9XZWJLaXRMZWdhY3kueGNjb25maWc6CisKIDIwMTctMDItMjAgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHBsdW1iaW5nIHRvIHRoZSBVSSBw cm9jZXNzIGZvciBUZXh0SW5kaWNhdG9yRGF0YSB3aGVuIGNvbXB1dGluZyB0aGUgZHJhZyBpbWFn ZQpJbmRleDogU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5Lnhj Y29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL1dl YktpdExlZ2FjeS54Y2NvbmZpZwkocmV2aXNpb24gMjEyNjgwKQorKysgU291cmNlL1dlYktpdC9t YWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBA IC0yNCw3ICsyNCw3IEBACiAjaW5jbHVkZSAiRmVhdHVyZURlZmluZXMueGNjb25maWciCiAjaW5j bHVkZSAiVmVyc2lvbi54Y2NvbmZpZyIKIAotRVhDTFVERURfU09VUkNFX0ZJTEVfTkFNRVNbc2Rr PWlwaG9uZSpdID0gKi5kZWZzICoubmliICoucGRmICoudGlmZiBDYXJib25VdGlscy5tIENhcmJv bldpbmRvd0FkYXB0ZXIubW0gQ2FyYm9uV2luZG93Q29udGVudFZpZXcubSBDYXJib25XaW5kb3dG cmFtZS5tIEhJVmlld0FkYXB0ZXIubSBISVdlYlZpZXcubW0gT3V0bG9va1F1aXJrc1VzZXJTY3Jp cHQuanMgUG9wdXBNZW51TWFjLm1tIFNlYXJjaFBvcHVwTWVudU1hYy5tbSBXZWJDbGlwVmlldy4q IFdlYkRhc2hib2FyZFJlZ2lvbi4qIFdlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy4qIFdlYkljb25E YXRhYmFzZS4qIFdlYkljb25EYXRhYmFzZVByaXZhdGUuKiBXZWJJbnNwZWN0b3JDbGllbnQubW0g V2ViSmF2YVNjcmlwdFRleHRJbnB1dFBhbmVsLiogV2ViTlNFdmVudEV4dHJhcy4qIFdlYk5TUGFz dGVib2FyZEV4dHJhcy4qIFdlYk5TV2luZG93RXh0cmFzLiogV2ViUGFuZWxBdXRoZW50aWNhdGlv bkhhbmRsZXIuKiBXZWJQbHVnaW5zUHJpdmF0ZS4qIFdlYlN0cmluZ1RydW5jYXRvci4qIFdlYlRl eHRDb21wbGV0aW9uQ29udHJvbGxlci4qOworRVhDTFVERURfU09VUkNFX0ZJTEVfTkFNRVNbc2Rr PWlwaG9uZSpdID0gKi5kZWZzICoubmliICoucGRmICoudGlmZiBDYXJib25VdGlscy4qIENhcmJv bldpbmRvd0FkYXB0ZXIuKiBDYXJib25XaW5kb3dDb250ZW50Vmlldy4qIENhcmJvbldpbmRvd0Zy YW1lLiogSElWaWV3QWRhcHRlci4qIEhJV2ViVmlldy4qIE91dGxvb2tRdWlya3NVc2VyU2NyaXB0 LmpzIFBvcHVwTWVudU1hYy4qIFNlYXJjaFBvcHVwTWVudU1hYy4qIFdlYkNsaXBWaWV3LiogV2Vi RGFzaGJvYXJkUmVnaW9uLiogV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3LiogV2ViSWNvbkRhdGFi YXNlLiogV2ViSWNvbkRhdGFiYXNlUHJpdmF0ZS4qIFdlYkluc3BlY3RvckNsaWVudC4qIFdlYkph dmFTY3JpcHRUZXh0SW5wdXRQYW5lbC4qIFdlYk5TRXZlbnRFeHRyYXMuKiBXZWJOU1Bhc3RlYm9h cmRFeHRyYXMuKiBXZWJOU1dpbmRvd0V4dHJhcy4qIFdlYlBhbmVsQXV0aGVudGljYXRpb25IYW5k bGVyLiogV2ViUGx1Z2luc1ByaXZhdGUuKiBXZWJTdHJpbmdUcnVuY2F0b3IuKiBXZWJUZXh0Q29t cGxldGlvbkNvbnRyb2xsZXIuKjsKIEVYQ0xVREVEX1NPVVJDRV9GSUxFX05BTUVTW3Nkaz1tYWNv c3gqXSA9ICpJT1MubW0gTWVtb3J5TWVhc3VyZS5oIFdlYkNhcmV0Q2hhbmdlTGlzdGVuZXIuaCBX ZWJGaXhlZFBvc2l0aW9uQ29udGVudC5oIFdlYkZyYW1lSU9TLmggV2ViRnJhbWVJUGhvbmUuaCBX ZWJHZW9sb2NhdGlvbkNvcmVMb2NhdGlvblByb3ZpZGVyLmggV2ViR2VvbG9jYXRpb25Qcml2YXRl LmggV2ViR2VvbG9jYXRpb25Qcm92aWRlcklPUy5oIFdlYk1JTUVUeXBlUmVnaXN0cnkuaCBXZWJO U1N0cmluZ0V4dHJhc0lPUy5oIFdlYk5TU3RyaW5nRXh0cmFzSVBob25lLmggV2ViUERGVmlld0lP Uy5oIFdlYlBERlZpZXdJUGhvbmUuaCBXZWJQREZWaWV3UGxhY2Vob2xkZXIuaCBXZWJTZWxlY3Rp b25SZWN0LmggV2ViVUlLaXREZWxlZ2F0ZS5oIFdlYlVJS2l0U3VwcG9ydC5oIFdlYlZpc2libGVQ b3NpdGlvbi5oIERPTUhUTUxUZXh0QXJlYUVsZW1lbnRQcml2YXRlLmggRE9NVUlLaXRFeHRlbnNp b25zLmg7CiAKIEVYUE9SVEVEX1NZTUJPTFNfRklMRSA9ICQoRVhQT1JURURfU1lNQk9MU19GSUxF XyQoQ1VSUkVOVF9BUkNIKSk7Cg==