168596 2017-02-20 07:30:01 -0800 [WebRTC] Fix some memory leaks in libwebrtc binding code 2017-02-20 10:41:39 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen commit-queue eric.carlson oldest_to_newest 1278923 0 youennf 2017-02-20 07:30:01 -0800 Fix some memory leaks in libwebrtc binding code 1278924 1 302144 youennf 2017-02-20 07:34:11 -0800 Created attachment 302144 Patch 1278962 2 302144 commit-queue 2017-02-20 09:26:00 -0800 Comment on attachment 302144 Patch Clearing flags on attachment: 302144 Committed r212644: <http://trac.webkit.org/changeset/212644> 1278963 3 commit-queue 2017-02-20 09:26:04 -0800 All reviewed patches have been landed. Closing bug. 1278992 4 achristensen 2017-02-20 10:41:39 -0800 http://trac.webkit.org/r212661 302144 2017-02-20 07:34:11 -0800 2017-02-20 09:26:00 -0800 Patch bug-168596-20170220073128.patch text/plain 6124 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNmNTNkYzE5OTUwZDMw NzdmYjA2MDY4ZDdmMTg3YmNhM2ZkZGVmYi4uODNkZWRjYWI4ZGI3NDhiNjQzMmYwNWE3M2Y5NTli MzdlOTFjY2Q0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAyLTIwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViUlRDXSBGaXggc29t ZSBtZW1vcnkgbGVha3MgaW4gbGlid2VicnRjIGJpbmRpbmcgY29kZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NTk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBtYW51YWwgdGVzdGlu Zy4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ01l ZGlhRW5kcG9pbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGliV2ViUlRDTWVkaWFFbmRwb2lu dDo6U3RhdHNDb2xsZWN0b3I6OlN0YXRzQ29sbGVjdG9yKTogVXNpbmcgdGhlIGxpYndlYnJ0YyB3 YXkgb2YgY3JlYXRpbmcgc3VjaCBvYmplY3RzLgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJl YW0vbGlid2VicnRjL0xpYldlYlJUQ01lZGlhRW5kcG9pbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6 OkxpYldlYlJUQ01lZGlhRW5kcG9pbnQ6OlN0YXRzQ29sbGVjdG9yOjpjcmVhdGUpOgorICAgICAg ICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQZWVyQ29ubmVjdGlvbkZhY3RvcnlBbmRUaHJlYWRzOjpPbk1l c3NhZ2UpOgorCiAyMDE3LTAyLTE5ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAog ICAgICAgICBBY3RpdmF0ZS9kZWFjdGl2YXRlIGhpZ2ggcGVyZm9ybWFuY2UgR1BVIHdoZW4gcmVx dWVzdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmViNWU0NTZlYWE1MTk4ZDY0Y2ZjY2QwMjMyMWMyNGRjNmVm NDUxZC4uOWZlYmRjNGQwYTlhYTEwZTEzOGI0MmMzNjUzNjk1MmQ2NDdiYjdiYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KKworICAgICAgICBbV2ViUlRDXSBGaXggc29tZSBtZW1vcnkgbGVha3MgaW4gbGli d2VicnRjIGJpbmRpbmcgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY4NTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNw cDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1JUQ1Byb3ZpZGVyOjpPbk1lc3NhZ2UpOgorCiAy MDE3LTAyLTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSZWR1Y2UgcGxhdGZvcm0gaWZkZWZzIGluIFdlYktpdDIgY3VzdG9tIHByb3RvY29s cyBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50 LmNwcAppbmRleCBlNDZjMzFjNGVkMGIxZGQzNDk5NmY4NWYyMjYyODc2NDg0NTEyOGNlLi5hMWNm MjRkMTI2MDRiNzdlNzZlMzk3MTVmYjY4YTIzOWUxYTlmYWJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBv aW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0 Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNwcApAQCAtMjE5LDggKzIxOSw4IEBAIHZvaWQgTGli V2ViUlRDTWVkaWFFbmRwb2ludDo6Z2V0U3RhdHMoTWVkaWFTdHJlYW1UcmFjayogdHJhY2ssIGNv bnN0IERlZmVycmVkUHJvCiAgICAgbV9iYWNrZW5kLT5HZXRTdGF0cyhTdGF0c0NvbGxlY3Rvcjo6 Y3JlYXRlKCp0aGlzLCBwcm9taXNlLCB0cmFjaykuZ2V0KCkpOwogfQogCi1MaWJXZWJSVENNZWRp YUVuZHBvaW50OjpTdGF0c0NvbGxlY3Rvcjo6U3RhdHNDb2xsZWN0b3IoTGliV2ViUlRDTWVkaWFF bmRwb2ludCYgZW5kcG9pbnQsIGNvbnN0IERlZmVycmVkUHJvbWlzZSYgcHJvbWlzZSwgTWVkaWFT dHJlYW1UcmFjayogdHJhY2spCi0gICAgOiBtX2VuZHBvaW50KGVuZHBvaW50KQorTGliV2ViUlRD TWVkaWFFbmRwb2ludDo6U3RhdHNDb2xsZWN0b3I6OlN0YXRzQ29sbGVjdG9yKFJlZjxMaWJXZWJS VENNZWRpYUVuZHBvaW50PiYmIGVuZHBvaW50LCBjb25zdCBEZWZlcnJlZFByb21pc2UmIHByb21p c2UsIE1lZGlhU3RyZWFtVHJhY2sqIHRyYWNrKQorICAgIDogbV9lbmRwb2ludChXVEZNb3ZlKGVu ZHBvaW50KSkKICAgICAsIG1fcHJvbWlzZShwcm9taXNlKQogewogICAgIGlmICh0cmFjaykKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xp YldlYlJUQ01lZGlhRW5kcG9pbnQuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vbGlid2VicnRjL0xpYldlYlJUQ01lZGlhRW5kcG9pbnQuaAppbmRleCA3YjMwOGUwYjE2NGY4 NTAxNDg3ZmRhNjc2NzVjMjA2NTdmNzNlZjdiLi5iZTRlZWEwMDMwMDRjMzg1NWUxZWMyMDQ1YzUz NDQzYjhiNTZkMzVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmgKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5o CkBAIC0xNDMsMTkgKzE0MywxNiBAQCBwcml2YXRlOgogICAgICAgICBMaWJXZWJSVENNZWRpYUVu ZHBvaW50JiBtX2VuZHBvaW50OwogICAgIH07CiAKLSAgICBjbGFzcyBTdGF0c0NvbGxlY3RvciBm aW5hbCA6IHB1YmxpYyB3ZWJydGM6OlJUQ1N0YXRzQ29sbGVjdG9yQ2FsbGJhY2sgeworICAgIGNs YXNzIFN0YXRzQ29sbGVjdG9yIDogcHVibGljIHdlYnJ0Yzo6UlRDU3RhdHNDb2xsZWN0b3JDYWxs YmFjayB7CiAgICAgcHVibGljOgotICAgICAgICBzdGF0aWMgcnRjOjpzY29wZWRfcmVmcHRyPFN0 YXRzQ29sbGVjdG9yPiBjcmVhdGUoTGliV2ViUlRDTWVkaWFFbmRwb2ludCYgZW5kcG9pbnQsIGNv bnN0IERlZmVycmVkUHJvbWlzZSYgcHJvbWlzZSwgTWVkaWFTdHJlYW1UcmFjayogdHJhY2spIHsg cmV0dXJuIG5ldyBTdGF0c0NvbGxlY3RvcihlbmRwb2ludCwgcHJvbWlzZSwgdHJhY2spOyB9Cisg ICAgICAgIHN0YXRpYyBydGM6OnNjb3BlZF9yZWZwdHI8U3RhdHNDb2xsZWN0b3I+IGNyZWF0ZShS ZWY8TGliV2ViUlRDTWVkaWFFbmRwb2ludD4mJiBlbmRwb2ludCwgY29uc3QgRGVmZXJyZWRQcm9t aXNlJiBwcm9taXNlLCBNZWRpYVN0cmVhbVRyYWNrKiB0cmFjaykgeyByZXR1cm4gbmV3IHJ0Yzo6 UmVmQ291bnRlZE9iamVjdDxTdGF0c0NvbGxlY3Rvcj4oV1RGTW92ZShlbmRwb2ludCksIHByb21p c2UsIHRyYWNrKTsgfQogCi0gICAgICAgIGludCBBZGRSZWYoKSBjb25zdCB7IHJldHVybiBtX2Vu ZHBvaW50LkFkZFJlZigpOyB9Ci0gICAgICAgIGludCBSZWxlYXNlKCkgY29uc3QgeyByZXR1cm4g bV9lbmRwb2ludC5SZWxlYXNlKCk7IH0KKyAgICAgICAgU3RhdHNDb2xsZWN0b3IoUmVmPExpYldl YlJUQ01lZGlhRW5kcG9pbnQ+JiYsIGNvbnN0IERlZmVycmVkUHJvbWlzZSYsIE1lZGlhU3RyZWFt VHJhY2sqKTsKIAogICAgIHByaXZhdGU6Ci0gICAgICAgIFN0YXRzQ29sbGVjdG9yKExpYldlYlJU Q01lZGlhRW5kcG9pbnQmLCBjb25zdCBEZWZlcnJlZFByb21pc2UmLCBNZWRpYVN0cmVhbVRyYWNr Kik7Ci0KICAgICAgICAgdm9pZCBPblN0YXRzRGVsaXZlcmVkKGNvbnN0IHJ0Yzo6c2NvcGVkX3Jl ZnB0cjxjb25zdCB3ZWJydGM6OlJUQ1N0YXRzUmVwb3J0PiYpIGZpbmFsOwogCi0gICAgICAgIExp YldlYlJUQ01lZGlhRW5kcG9pbnQmIG1fZW5kcG9pbnQ7CisgICAgICAgIFJlZjxMaWJXZWJSVENN ZWRpYUVuZHBvaW50PiBtX2VuZHBvaW50OwogICAgICAgICBjb25zdCBEZWZlcnJlZFByb21pc2Um IG1fcHJvbWlzZTsKICAgICAgICAgU3RyaW5nIG1faWQ7CiAgICAgfTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92 aWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMv TGliV2ViUlRDUHJvdmlkZXIuY3BwCmluZGV4IDAwOTVjNTE3ZjBmN2UwYzQzZWI4NjYyNzkxYTAx MzUzMTJlZTg1ODYuLjYyYmQ3MDRmMzBkZGFiNTc3NWNmNGM0OWViNjZkNDA5MWM5OTRkNTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyLmNwcApAQCAtNjUsNyArNjUsOSBAQCBz dHJ1Y3QgVGhyZWFkTWVzc2FnZURhdGEgOiBwdWJsaWMgcnRjOjpNZXNzYWdlRGF0YSB7CiB2b2lk IFBlZXJDb25uZWN0aW9uRmFjdG9yeUFuZFRocmVhZHM6Ok9uTWVzc2FnZShydGM6Ok1lc3NhZ2Uq IG1lc3NhZ2UpCiB7CiAgICAgQVNTRVJUKG1lc3NhZ2UtPm1lc3NhZ2VfaWQgPT0gMSk7Ci0gICAg c3RhdGljX2Nhc3Q8VGhyZWFkTWVzc2FnZURhdGEqPihtZXNzYWdlLT5wZGF0YSktPmNhbGxiYWNr KCk7CisgICAgYXV0byogZGF0YSA9IHN0YXRpY19jYXN0PFRocmVhZE1lc3NhZ2VEYXRhKj4obWVz c2FnZS0+cGRhdGEpOworICAgIGRhdGEtPmNhbGxiYWNrKCk7CisgICAgZGVsZXRlIGRhdGE7CiB9 CiAKIHZvaWQgTGliV2ViUlRDUHJvdmlkZXI6OmNhbGxPbldlYlJUQ05ldHdvcmtUaHJlYWQoRnVu Y3Rpb248dm9pZCgpPiYmIGNhbGxiYWNrKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcAppbmRleCBhNjRm MGYyY2RiN2UzOGU0ZmEzZTYzYzc1ZGM3MGM1OGY2OTc2OTE0Li5jYjJkMDBkNTg0NTg4ODY1NGU4 N2JhNWUzODJkMjRhM2U3NDk4MDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcApAQCAtMTczLDcg KzE3Myw5IEBAIHN0cnVjdCBOZXR3b3JrTWVzc2FnZURhdGEgOiBwdWJsaWMgcnRjOjpNZXNzYWdl RGF0YSB7CiB2b2lkIE5ldHdvcmtSVENQcm92aWRlcjo6T25NZXNzYWdlKHJ0Yzo6TWVzc2FnZSog bWVzc2FnZSkKIHsKICAgICBBU1NFUlQobWVzc2FnZS0+bWVzc2FnZV9pZCA9PSAxKTsKLSAgICBz dGF0aWNfY2FzdDxOZXR3b3JrTWVzc2FnZURhdGEqPihtZXNzYWdlLT5wZGF0YSktPmNhbGxiYWNr KCk7CisgICAgYXV0byogZGF0YSA9IHN0YXRpY19jYXN0PE5ldHdvcmtNZXNzYWdlRGF0YSo+KG1l c3NhZ2UtPnBkYXRhKTsKKyAgICBkYXRhLT5jYWxsYmFjaygpOworICAgIGRlbGV0ZSBkYXRhOwog fQogCiB2b2lkIE5ldHdvcmtSVENQcm92aWRlcjo6Y2FsbE9uUlRDTmV0d29ya1RocmVhZChGdW5j dGlvbjx2b2lkKCk+JiYgY2FsbGJhY2spCg==