168574 2017-02-19 08:17:40 -0800 functionTestWasmModuleFunctions() should use a MarkedArgumentBuffer for storing args instead of a Vector. 2017-02-20 09:27:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren jfbastien keith_miller msaboff saam oldest_to_newest 1278731 0 mark.lam 2017-02-19 08:17:40 -0800 Vectors don't tell GC about the need to scan the args. 1278752 1 jfbastien 2017-02-19 13:44:23 -0800 I think we're better off getting rid of the function entirely, now that we have the JS builder. 1278755 2 mark.lam 2017-02-19 13:54:12 -0800 (In reply to comment #1) > I think we're better off getting rid of the function entirely, now that we > have the JS builder. Is functionTestWasmModuleFunctions() no longer needed? 1278756 3 jfbastien 2017-02-19 13:56:07 -0800 (In reply to comment #2) > (In reply to comment #1) > > I think we're better off getting rid of the function entirely, now that we > > have the JS builder. > > Is functionTestWasmModuleFunctions() no longer needed? IIRC we need to update some tests to use the JS builder instead of that function. It's still needed until we update the tests. 1278833 4 302114 mark.lam 2017-02-19 19:53:45 -0800 Created attachment 302114 proposed patch. 1278835 5 mark.lam 2017-02-19 20:02:18 -0800 Thanks for the review. Landed in r212620: <http://trac.webkit.org/r212620>. 1278964 6 keith_miller 2017-02-20 09:27:34 -0800 Yeah, I'm pretty sure we don't have tests that use this function anymore. Also, as a note, we don't really need to use a MarkedArgumentBuffer since we can't put JSCells into that vector so the GC won't see anything of interest anyway. The only reason the contents of that vector were JSValues is to avoid casting when we did vmEntryToJavaScript. 302114 2017-02-19 19:53:45 -0800 2017-02-19 19:57:43 -0800 proposed patch. bug-168574.patch text/plain 3435 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjEyNjE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE3LTAyLTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBm dW5jdGlvblRlc3RXYXNtTW9kdWxlRnVuY3Rpb25zKCkgc2hvdWxkIHVzZSBhIE1hcmtlZEFyZ3Vt ZW50QnVmZmVyIGZvciBzdG9yaW5nIGFyZ3MgaW5zdGVhZCBvZiBhIFZlY3Rvci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODU3NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganNjLmNwcDoKKyAgICAg ICAgKGNhbGxXYXNtRnVuY3Rpb24pOgorICAgICAgICAoZnVuY3Rpb25UZXN0V2FzbU1vZHVsZUZ1 bmN0aW9ucyk6CisgICAgICAgICogcnVudGltZS9BcmdMaXN0Lmg6CisKIDIwMTctMDItMTkgIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIENhY2hlZENhbGwgc2hvdWxk IGxldCBHQyBrbm93IHRvIGtlZXAgaXRzIGFyZ3VtZW50cyBhbGl2ZS4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qc2MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qc2MuY3BwCShyZXZpc2lvbiAyMTI2MTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNj LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzA2OSw3ICszMDY5LDggQEAgc3RhdGljIEpTVmFsdWUg Ym94KEV4ZWNTdGF0ZSogZXhlYywgVk0mIAogICAgIHJldHVybiBKU1ZhbHVlOjpkZWNvZGUoYml0 d2lzZV9jYXN0PHVpbnQ2NF90PihyZXN1bHQpKTsKIH0KIAotc3RhdGljIEpTVmFsdWUgY2FsbFdh c21GdW5jdGlvbihWTSogdm0sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTV2ViQXNz ZW1ibHlDYWxsZWUqIHdhc21DYWxsZWUsIFZlY3RvcjxKU1ZhbHVlPiYgYm94ZWRBcmdzKQorLy8g RklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg1ODIuCitz dGF0aWMgSlNWYWx1ZSBjYWxsV2FzbUZ1bmN0aW9uKFZNKiB2bSwgSlNHbG9iYWxPYmplY3QqIGds b2JhbE9iamVjdCwgSlNXZWJBc3NlbWJseUNhbGxlZSogd2FzbUNhbGxlZSwgY29uc3QgQXJnTGlz dCYgYm94ZWRBcmdzKQogewogICAgIEpTVmFsdWUgZmlyc3RBcmd1bWVudDsKICAgICBpbnQgYXJn Q291bnQgPSAxOwpAQCAtMzEzNSw3ICszMTM2LDcgQEAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpT Q19IT1NUX0NBTEwgZnVuYwogICAgICAgICAgICAgSlNPYmplY3QqIHJlc3VsdCA9IGpzQ2FzdDxK U09iamVjdCo+KHRlc3QtPmdldEluZGV4UXVpY2tseSgwKSk7CiAgICAgICAgICAgICBKU0FycmF5 KiBhcmd1bWVudHMgPSBqc0Nhc3Q8SlNBcnJheSo+KHRlc3QtPmdldEluZGV4UXVpY2tseSgxKSk7 CiAKLSAgICAgICAgICAgIFZlY3RvcjxKU1ZhbHVlPiBib3hlZEFyZ3M7CisgICAgICAgICAgICBN YXJrZWRBcmd1bWVudEJ1ZmZlciBib3hlZEFyZ3M7CiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVk IGFyZ0luZGV4ID0gMDsgYXJnSW5kZXggPCBhcmd1bWVudHMtPmxlbmd0aCgpOyArK2FyZ0luZGV4 KQogICAgICAgICAgICAgICAgIGJveGVkQXJncy5hcHBlbmQoYm94KGV4ZWMsIHZtLCBhcmd1bWVu dHMtPmdldEluZGV4UXVpY2tseShhcmdJbmRleCkpKTsKIApAQCAtMzE1MCw3ICszMTUxLDcgQEAg c3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuYwogICAgICAgICAgICAgICAg IGRhdGFMb2coIkFyZ3VtZW50czogIik7CiAgICAgICAgICAgICAgICAgQ29tbWFQcmludGVyIGNv bW1hKCIsICIpOwogICAgICAgICAgICAgICAgIGZvciAodW5zaWduZWQgYXJnSW5kZXggPSAwOyBh cmdJbmRleCA8IGFyZ3VtZW50cy0+bGVuZ3RoKCk7ICsrYXJnSW5kZXgpCi0gICAgICAgICAgICAg ICAgICAgIGRhdGFMb2coY29tbWEsIHZhbHVlV2l0aFR5cGVPZldhc21WYWx1ZShleGVjLCB2bSwg Ym94ZWRBcmdzW2FyZ0luZGV4XSwgYXJndW1lbnRzLT5nZXRJbmRleFF1aWNrbHkoYXJnSW5kZXgp KSk7CisgICAgICAgICAgICAgICAgICAgIGRhdGFMb2coY29tbWEsIHZhbHVlV2l0aFR5cGVPZldh c21WYWx1ZShleGVjLCB2bSwgYm94ZWRBcmdzLmF0KGFyZ0luZGV4KSwgYXJndW1lbnRzLT5nZXRJ bmRleFF1aWNrbHkoYXJnSW5kZXgpKSk7CiAgICAgICAgICAgICAgICAgZGF0YUxvZ0xuKCk7CiAK ICAgICAgICAgICAgICAgICBXVEZSZXBvcnRBc3NlcnRpb25GYWlsdXJlKF9fRklMRV9fLCBfX0xJ TkVfXywgV1RGX1BSRVRUWV9GVU5DVElPTiwgdG9DU3RyaW5nKCIgKGNhbGxSZXN1bHQgPT0gIiwg dmFsdWVXaXRoVHlwZU9mV2FzbVZhbHVlKGV4ZWMsIHZtLCBjYWxsUmVzdWx0LCByZXN1bHQpLCAi LCBleHBlY3RlZCA9PSAiLCB2YWx1ZVdpdGhUeXBlT2ZXYXNtVmFsdWUoZXhlYywgdm0sIGV4cGVj dGVkLCByZXN1bHQpLCAiKSIpLmRhdGEoKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9BcmdMaXN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvQXJnTGlzdC5oCShyZXZpc2lvbiAyMTI2MTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9BcmdMaXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE2NCw5ICsxNjQsMTMgQEAg cHVibGljOgogICAgICAgICAKICAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGdldFNsaWNlKGlu dCBzdGFydEluZGV4LCBBcmdMaXN0JiByZXN1bHQpIGNvbnN0OwogCi1wcml2YXRlOgorICAgIC8v IEZJWE1FOiBUaGlzIGlzIG9ubHkgbWFkZSBwdWJsaWMgYXMgYSB3b3JrIGFyb3VuZCBmb3IganNj J3MgdGVzdCBoZWxwZXIgZnVuY3Rpb24sCisgICAgLy8gY2FsbFdhc21GdW5jdGlvbigpIHRvIHVz ZS4gTWFrZSB0aGlzIGEgcHJpdmF0ZSBtZXRob2QgYWdhaW4gb25jZSB3ZSBjYW4gcmVtb3ZlCisg ICAgLy8gY2FsbFdhc21GdW5jdGlvbigpLgorICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjg1ODIKICAgICBKU1ZhbHVlKiBkYXRhKCkgY29uc3QgeyByZXR1 cm4gbV9hcmdzOyB9CiAKK3ByaXZhdGU6CiAgICAgSlNWYWx1ZSogbV9hcmdzOwogICAgIGludCBt X2FyZ0NvdW50OwogfTsK