168571 2017-02-19 03:05:34 -0800 [SOUP] Call SoupNetworkSession::setShouldIgnoreTLSErrors when testRunner.setAllowsAnySSLCertificate() is called 2017-02-19 22:32:48 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned lforschler oldest_to_newest 1278717 0 cgarcia 2017-02-19 03:05:34 -0800 We only use that from web sockets. This would fix http/tests/ssl/upgrade-origin-usage.html 1278718 1 302074 cgarcia 2017-02-19 03:06:55 -0800 Created attachment 302074 Patch 1278738 2 302074 mcatanzaro 2017-02-19 09:24:57 -0800 Comment on attachment 302074 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302074&action=review > Source/WebCore/testing/InternalSettings.cpp:768 > Settings::setAllowsAnySSLCertificate(allowsAnyCertificate); > +#if USE(SOUP) > + SoupNetworkSession::setShouldIgnoreTLSErrors(allowsAnyCertificate); > +#endif Why is this the right place? Why not in Settings::setAllowsAnySSLCertificate? 1278842 3 cgarcia 2017-02-19 22:25:11 -0800 (In reply to comment #2) > Comment on attachment 302074 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302074&action=review > > > Source/WebCore/testing/InternalSettings.cpp:768 > > Settings::setAllowsAnySSLCertificate(allowsAnyCertificate); > > +#if USE(SOUP) > > + SoupNetworkSession::setShouldIgnoreTLSErrors(allowsAnyCertificate); > > +#endif > > Why is this the right place? Why not in Settings::setAllowsAnySSLCertificate? I wanted to make sure that this is only used from layout tests. 1278844 4 cgarcia 2017-02-19 22:32:48 -0800 Committed r212623: <http://trac.webkit.org/changeset/212623> 302074 2017-02-19 03:06:55 -0800 2017-02-19 09:24:57 -0800 Patch wcore-test-ssl.diff text/plain 1602 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYzRmMjk4MTcxNi4uY2I5OGU0ZTdiYjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wMi0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW1NPVVBdIENhbGwgU291cE5ldHdvcmtTZXNzaW9uOjpzZXRT aG91bGRJZ25vcmVUTFNFcnJvcnMgd2hlbiB0ZXN0UnVubmVyLnNldEFsbG93c0FueVNTTENlcnRp ZmljYXRlKCkgaXMgY2FsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjg1NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXhlczogaHR0cC90ZXN0cy9zc2wvdXBncmFkZS1vcmlnaW4tdXNhZ2UuaHRt bAorCisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkludGVybmFsU2V0dGluZ3M6OnNldEFsbG93c0FueVNTTENlcnRpZmljYXRlKToKKwog MjAxNy0wMi0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJl Y3Vyc2l2ZSBNZXNzYWdlUG9ydC5wb3N0TWVzc2FnZSgpIGNhbGxzIGNhdXNlcyB0YWIgdG8gYmVj b21lIHVucmVzcG9uc2l2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl cm5hbFNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5n cy5jcHAKaW5kZXggN2Q4ZGVhZDZmMGIuLjJmZDc5YjQ0MzQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAKQEAgLTQ1LDYgKzQ1LDEwIEBACiAjaW5jbHVk ZSAiQ29sb3JDaG9vc2VyLmgiCiAjZW5kaWYKIAorI2lmIFVTRShTT1VQKQorI2luY2x1ZGUgIlNv dXBOZXR3b3JrU2Vzc2lvbi5oIgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogSW50 ZXJuYWxTZXR0aW5nczo6QmFja3VwOjpCYWNrdXAoU2V0dGluZ3MmIHNldHRpbmdzKQpAQCAtNzU5 LDYgKzc2Myw5IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IEludGVybmFsU2V0dGluZ3M6OnNldFN5c3Rl bUxheW91dERpcmVjdGlvbihjb25zdCBTdHJpbmcmIGRpcmVjCiB2b2lkIEludGVybmFsU2V0dGlu Z3M6OnNldEFsbG93c0FueVNTTENlcnRpZmljYXRlKGJvb2wgYWxsb3dzQW55Q2VydGlmaWNhdGUp CiB7CiAgICAgU2V0dGluZ3M6OnNldEFsbG93c0FueVNTTENlcnRpZmljYXRlKGFsbG93c0FueUNl cnRpZmljYXRlKTsKKyNpZiBVU0UoU09VUCkKKyAgICBTb3VwTmV0d29ya1Nlc3Npb246OnNldFNo b3VsZElnbm9yZVRMU0Vycm9ycyhhbGxvd3NBbnlDZXJ0aWZpY2F0ZSk7CisjZW5kaWYKIH0KIAog RXhjZXB0aW9uT3I8Ym9vbD4gSW50ZXJuYWxTZXR0aW5nczo6ZGVmZXJyZWRDU1NQYXJzZXJFbmFi bGVkKCkK