168570 2017-02-19 02:08:21 -0800 [GTK] Test fast/events/message-port-postMessage-recursive.html times out 2017-02-22 00:32:13 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned benjamin bugs-noreply cdumez cmarcelo commit-queue dbates mcatanzaro oldest_to_newest 1278715 0 cgarcia 2017-02-19 02:08:21 -0800 This has recently been added and the patch is good. It's just revealing a problem with our timers. The test is posting a message recursively, and also starts a timeout timer to finish the test. The timeout timer is never fired for us, because WebCore timers have lower priority than the one used by postMessage. ScriptExecutionContext uses Document::postTask, that uses scheduleOnMainThread, that uses RunLoop::dispatch(). We are not setting any priority for the timer used by RunLoop::dispatch, so it's using the default. RunLoop::dispatch is normally used to schedule tasks between threads, or just to ensure something is run in a different run loop iteration, but in general nothing urgent as a graphics redraw or something like that. It's quite common to use g_idle_add to schedule tasks between threads, so I think it makes sense to use G_PRIORITY_DEFAULT_IDLE for the RunLoop timer. 1278716 1 302073 cgarcia 2017-02-19 02:10:24 -0800 Created attachment 302073 Patch 1278739 2 mcatanzaro 2017-02-19 09:28:01 -0800 I wonder what this will break! 1278841 3 cgarcia 2017-02-19 22:24:42 -0800 (In reply to comment #2) > I wonder what this will break! You always so negative, I wonder what other things will fix. 1278843 4 cgarcia 2017-02-19 22:31:03 -0800 Committed r212622: <http://trac.webkit.org/changeset/212622> 1278871 5 cgarcia 2017-02-20 01:11:18 -0800 Reverted r212622 for reason: Caused several test failures Committed r212627: <http://trac.webkit.org/changeset/212627> 1278872 6 cgarcia 2017-02-20 01:13:15 -0800 So, yes, this introduced a few failures (~10) most of them image only failures. I'm still not sure if they are actual regressions, or the patch actually revealed those bugs. But timer priorities is tricky thing that could also impact the performance, so we should think more carefully about it. 1278918 7 mcatanzaro 2017-02-20 07:03:47 -0800 (In reply to comment #6) > So, yes, this introduced a few failures (~10) most of them image only > failures. I'm still not sure if they are actual regressions, or the patch > actually revealed those bugs. But timer priorities is tricky thing that > could also impact the performance, so we should think more carefully about > it. I get to be right every once in a while! I'm actually most concerned about the original test, because it's testing the behavior of the timers themselves, and it shows us that our timers are definitely broken without your patch. But clearly we need to think about this some more and understand what's going on with the other tests. Timers are hard. 1279302 8 302252 cgarcia 2017-02-21 06:49:53 -0800 Created attachment 302252 Patch 1279320 9 302252 mcatanzaro 2017-02-21 07:43:41 -0800 Comment on attachment 302252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302252&action=review > Source/WTF/wtf/glib/MainThreadGLib.cpp:38 > +class MainThreadDispatcher { Please add a comment. You could take it from your commit message. > Source/WTF/wtf/glib/MainThreadGLib.cpp:43 > + m_timer.setPriority(G_PRIORITY_HIGH_IDLE + 20); Too fragile. It has to be exactly equal to WebCore timers? Then you should fine some common header to define it in. 1279326 10 cgarcia 2017-02-21 08:09:51 -0800 (In reply to comment #9) > Comment on attachment 302252 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302252&action=review > > > Source/WTF/wtf/glib/MainThreadGLib.cpp:38 > > +class MainThreadDispatcher { > > Please add a comment. You could take it from your commit message. Ok. > > Source/WTF/wtf/glib/MainThreadGLib.cpp:43 > > + m_timer.setPriority(G_PRIORITY_HIGH_IDLE + 20); > > Too fragile. It has to be exactly equal to WebCore timers? Then you should > fine some common header to define it in. Not really, I'm just conservative here and using at least the same priority. I still think we should re-think all the timer priorities anyway. 1279331 11 302260 cgarcia 2017-02-21 08:13:36 -0800 Created attachment 302260 Patch 1279812 12 cgarcia 2017-02-22 00:32:13 -0800 Committed r212814: <http://trac.webkit.org/changeset/212814> 302073 2017-02-19 02:10:24 -0800 2017-02-21 06:49:53 -0800 Patch wk-dispatch-priority.diff text/plain 2234 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggY2RiNzVkOTQ3NTkuLjMyYTFkNGZjMjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3 LTAyLTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBUZXN0IGZhc3QvZXZlbnRzL21lc3NhZ2UtcG9ydC1wb3N0TWVzc2FnZS1yZWN1 cnNpdmUuaHRtbCB0aW1lcyBvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2ODU3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgaGFzIHJlY2VudGx5IGJlZW4gYWRkZWQgYW5kIHRoZSBwYXRjaCBp cyBnb29kLiBJdCdzIGp1c3QgcmV2ZWFsaW5nIGEgcHJvYmxlbSB3aXRoIG91ciB0aW1lcnMuIFRo ZSB0ZXN0IGlzCisgICAgICAgIHBvc3RpbmcgYSBtZXNzYWdlIHJlY3Vyc2l2ZWx5LCBhbmQgYWxz byBzdGFydHMgYSB0aW1lb3V0IHRpbWVyIHRvIGZpbmlzaCB0aGUgdGVzdC4gVGhlIHRpbWVvdXQg dGltZXIgaXMgbmV2ZXIKKyAgICAgICAgZmlyZWQgZm9yIHVzLCBiZWNhdXNlIFdlYkNvcmUgdGlt ZXJzIGhhdmUgbG93ZXIgcHJpb3JpdHkgdGhhbiB0aGUgb25lIHVzZWQgYnkKKyAgICAgICAgcG9z dE1lc3NhZ2UuIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgdXNlcyBEb2N1bWVudDo6cG9zdFRhc2ss IHRoYXQgdXNlcyBzY2hlZHVsZU9uTWFpblRocmVhZCwgdGhhdCB1c2VzCisgICAgICAgIFJ1bkxv b3A6OmRpc3BhdGNoKCkuIFdlIGFyZSBub3Qgc2V0dGluZyBhbnkgcHJpb3JpdHkgZm9yIHRoZSB0 aW1lciB1c2VkIGJ5IFJ1bkxvb3A6OmRpc3BhdGNoLCBzbyBpdCdzIHVzaW5nIHRoZQorICAgICAg ICBkZWZhdWx0LiBSdW5Mb29wOjpkaXNwYXRjaCBpcyBub3JtYWxseSB1c2VkIHRvIHNjaGVkdWxl IHRhc2tzIGJldHdlZW4gdGhyZWFkcywgb3IganVzdCB0byBlbnN1cmUgc29tZXRoaW5nIGlzCisg ICAgICAgIHJ1biBpbiBhIGRpZmZlcmVudCBydW4gbG9vcCBpdGVyYXRpb24sIGJ1dCBpbiBnZW5l cmFsIG5vdGhpbmcgdXJnZW50IGFzIGEgZ3JhcGhpY3MgcmVkcmF3IG9yIHNvbWV0aGluZyBsaWtl CisgICAgICAgIHRoYXQuIEl0J3MgcXVpdGUgY29tbW9uIHRvIHVzZSBnX2lkbGVfYWRkIHRvIHNj aGVkdWxlIHRhc2tzIGJldHdlZW4gdGhyZWFkcywgc28gSSB0aGluayBpdCBtYWtlcyBzZW5zZSB0 byB1c2UKKyAgICAgICAgR19QUklPUklUWV9ERUZBVUxUX0lETEUgZm9yIHRoZSBSdW5Mb29wIHRp bWVyLgorCisgICAgICAgICogd3RmL2dsaWIvUnVuTG9vcEdMaWIuY3BwOgorICAgICAgICAoV1RG OjpSdW5Mb29wOjpSdW5Mb29wKToKKwogMjAxNy0wMi0xOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFJlY3Vyc2l2ZSBNZXNzYWdlUG9ydC5wb3N0TWVzc2FnZSgp IGNhbGxzIGNhdXNlcyB0YWIgdG8gYmVjb21lIHVucmVzcG9uc2l2ZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvZ2xpYi9SdW5Mb29wR0xpYi5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9nbGliL1J1 bkxvb3BHTGliLmNwcAppbmRleCA5MjdjZTMyNTRmOC4uYmZlM2IxZjdlZDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XVEYvd3RmL2dsaWIvUnVuTG9vcEdMaWIuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3Rm L2dsaWIvUnVuTG9vcEdMaWIuY3BwCkBAIC02MSw2ICs2MSw3IEBAIFJ1bkxvb3A6OlJ1bkxvb3Ao KQogCiAgICAgbV9zb3VyY2UgPSBhZG9wdEdSZWYoZ19zb3VyY2VfbmV3KCZydW5Mb29wU291cmNl RnVuY3Rpb25zLCBzaXplb2YoR1NvdXJjZSkpKTsKICAgICBnX3NvdXJjZV9zZXRfbmFtZShtX3Nv dXJjZS5nZXQoKSwgIltXZWJLaXRdIFJ1bkxvb3Agd29yayIpOworICAgIGdfc291cmNlX3NldF9w cmlvcml0eShtX3NvdXJjZS5nZXQoKSwgR19QUklPUklUWV9ERUZBVUxUX0lETEUpOwogICAgIGdf c291cmNlX3NldF9jYW5fcmVjdXJzZShtX3NvdXJjZS5nZXQoKSwgVFJVRSk7CiAgICAgZ19zb3Vy Y2Vfc2V0X2NhbGxiYWNrKG1fc291cmNlLmdldCgpLCBbXShncG9pbnRlciB1c2VyRGF0YSkgLT4g Z2Jvb2xlYW4gewogICAgICAgICBzdGF0aWNfY2FzdDxSdW5Mb29wKj4odXNlckRhdGEpLT5wZXJm b3JtV29yaygpOwo= 302252 2017-02-21 06:49:53 -0800 2017-02-21 08:13:36 -0800 Patch wk-schedule-on-main-thread.diff text/plain 4039 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1YTQyNTczYjlmZC4uYTU0MDhkYTFmZmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxNy0wMi0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gVGVzdCBmYXN0L2V2ZW50cy9tZXNzYWdlLXBvcnQtcG9zdE1lc3NhZ2Ut cmVjdXJzaXZlLmh0bWwgdGltZXMgb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjg1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3 LTAyLTIxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMjY5OS4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMTIwMDZjMDE0YTkuLjQ0NDRjMzNmOThmIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTc4OCw4ICsx Nzg4LDYgQEAgd2Via2l0Lm9yZy9iLzE2ODU2OCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Rp bWVvdXQtZ3JlYXRlci10aGFuLWRlZmF1bHQtbmV0d28KIAogd2Via2l0Lm9yZy9iLzE2ODU2OSBo dHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVzb3VyY2UtZmFsbGJhY2stZm9yLW5ldHdvcmstZXJy b3ItY3Jhc2guaHRtbCBbIFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvMTY4NTcwIGZhc3QvZXZl bnRzL21lc3NhZ2UtcG9ydC1wb3N0TWVzc2FnZS1yZWN1cnNpdmUuaHRtbCBbIFRpbWVvdXQgXQot CiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2YgVGVzdHMgdGltaW5n IG91dAogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggMjkzOTdiMjdhN2Uu LjkyZWI3MGY4Yzc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE3LTAyLTIxICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUZXN0IGZh c3QvZXZlbnRzL21lc3NhZ2UtcG9ydC1wb3N0TWVzc2FnZS1yZWN1cnNpdmUuaHRtbCB0aW1lcyBv dXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODU3 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg aGFzIHJlY2VudGx5IGJlZW4gYWRkZWQgYW5kIHRoZSBwYXRjaCBpcyBnb29kLiBJdCdzIGp1c3Qg cmV2ZWFsaW5nIGEgcHJvYmxlbSB3aXRoIG91ciB0aW1lcnMuIFRoZSB0ZXN0IGlzCisgICAgICAg IHBvc3RpbmcgYSBtZXNzYWdlIHJlY3Vyc2l2ZWx5LCBhbmQgYWxzbyBzdGFydHMgYSB0aW1lb3V0 IHRpbWVyIHRvIGZpbmlzaCB0aGUgdGVzdC4gVGhlIHRpbWVvdXQgdGltZXIgaXMgbmV2ZXIKKyAg ICAgICAgZmlyZWQgZm9yIHVzLCBiZWNhdXNlIFdlYkNvcmUgdGltZXJzIGhhdmUgbG93ZXIgcHJp b3JpdHkgdGhhbiB0aGUgb25lIHVzZWQgYnkgcG9zdE1lc3NhZ2UuIFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQKKyAgICAgICAgdXNlcyBEb2N1bWVudDo6cG9zdFRhc2ssIHRoYXQgdXNlcyBzY2hlZHVs ZU9uTWFpblRocmVhZCwgdGhhdCB1c2VzIFJ1bkxvb3A6OmRpc3BhdGNoKCkuIFdlIGFyZSBub3Qg c2V0dGluZyBhbnkKKyAgICAgICAgcHJpb3JpdHkgZm9yIHRoZSB0aW1lciB1c2VkIGJ5IFJ1bkxv b3A6OmRpc3BhdGNoLCBzbyBpdCdzIHVzaW5nIHRoZSBkZWZhdWx0LgorICAgICAgICBVc2UgYSBS dW5Mb29wOjpUaW1lciB0byBzY2hlZHVsZSB0YXNrcyB0byB0aGUgbWFpbiB0aHJlYWQgaW5zdGVh ZCBvZiB1c2luZyBSdW5Mb29wOjpkaXNwYXRjaCgpLiBUaGlzIGFsbG93cyB1cworICAgICAgICB0 byB1c2UgYSBkaWZmZXJlbnQgcHJpb3JpdHksIHRoYXQgaXMgbm93IHNldCB0byBHX1BSSU9SSVRZ X0hJR0hfSURMRSArIDIwIHRvIG1hdGNoIFdlYkNvcmUgdGltZXJzLiBCdXQgaXQgYWxzbworICAg ICAgICBhdm9pZHMgdGhlIGRvdWJsZSBxdWV1ZSB3ZSBoYWQgd2l0aCBSdW5Mb29wOjpkaXNwYXRj aCgpLCBiZWNhdXNlIHNjaGVkdWxlT25NYWluVGhyZWFkKCkgYWxzbyBxdWV1ZXMgdGhlIHRhc2tz LgorCisgICAgICAgICogd3RmL2dsaWIvTWFpblRocmVhZEdMaWIuY3BwOgorICAgICAgICAoV1RG OjpNYWluVGhyZWFkRGlzcGF0Y2hlcjo6TWFpblRocmVhZERpc3BhdGNoZXIpOgorICAgICAgICAo V1RGOjpNYWluVGhyZWFkRGlzcGF0Y2hlcjo6c2NoZWR1bGUpOgorICAgICAgICAoV1RGOjpNYWlu VGhyZWFkRGlzcGF0Y2hlcjo6ZmlyZWQpOgorICAgICAgICAoV1RGOjpzY2hlZHVsZURpc3BhdGNo RnVuY3Rpb25zT25NYWluVGhyZWFkKToKKwogMjAxNy0wMi0yMSAgQWxleCBDaHJpc3RlbnNlbiAg PGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIyMTI2OTkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nbGliL01haW5UaHJlYWRH TGliLmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvTWFpblRocmVhZEdMaWIuY3BwCmluZGV4IGQy ZTEyMWZiOTI3Li5kYzNiYjdhMGU5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvZ2xpYi9N YWluVGhyZWFkR0xpYi5jcHAKKysrIGIvU291cmNlL1dURi93dGYvZ2xpYi9NYWluVGhyZWFkR0xp Yi5jcHAKQEAgLTMwLDE3ICszMCw0MSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg Ik1haW5UaHJlYWQuaCIKIAorI2luY2x1ZGUgPGdsaWIuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9v cC5oPgogCiBuYW1lc3BhY2UgV1RGIHsKIAorY2xhc3MgTWFpblRocmVhZERpc3BhdGNoZXIgewor cHVibGljOgorICAgIE1haW5UaHJlYWREaXNwYXRjaGVyKCkKKyAgICAgICAgOiBtX3RpbWVyKFJ1 bkxvb3A6Om1haW4oKSwgdGhpcywgJk1haW5UaHJlYWREaXNwYXRjaGVyOjpmaXJlZCkKKyAgICB7 CisgICAgICAgIG1fdGltZXIuc2V0UHJpb3JpdHkoR19QUklPUklUWV9ISUdIX0lETEUgKyAyMCk7 CisgICAgfQorCisgICAgdm9pZCBzY2hlZHVsZSgpCisgICAgeworICAgICAgICBtX3RpbWVyLnN0 YXJ0T25lU2hvdCgwKTsKKyAgICB9CisKK3ByaXZhdGU6CisgICAgdm9pZCBmaXJlZCgpCisgICAg eworICAgICAgICBkaXNwYXRjaEZ1bmN0aW9uc0Zyb21NYWluVGhyZWFkKCk7CisgICAgfQorCisg ICAgUnVuTG9vcDo6VGltZXI8TWFpblRocmVhZERpc3BhdGNoZXI+IG1fdGltZXI7Cit9OworCiB2 b2lkIGluaXRpYWxpemVNYWluVGhyZWFkUGxhdGZvcm0oKQogewogfQogCiB2b2lkIHNjaGVkdWxl RGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQoKQogewotICAgIFJ1bkxvb3A6Om1haW4oKS5k aXNwYXRjaChzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oZGlzcGF0Y2hGdW5jdGlvbnNGcm9tTWFpblRo cmVhZCkpOworICAgIHN0YXRpYyBNYWluVGhyZWFkRGlzcGF0Y2hlciBkaXNwYXRjaGVyOworICAg IGRpc3BhdGNoZXIuc2NoZWR1bGUoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV1RGCg== 302260 2017-02-21 08:13:36 -0800 2017-02-21 11:12:40 -0800 Patch wk-schedule-on-main-thread.diff text/plain 4229 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1YTQyNTczYjlmZC4uYTU0MDhkYTFmZmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxNy0wMi0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gVGVzdCBmYXN0L2V2ZW50cy9tZXNzYWdlLXBvcnQtcG9zdE1lc3NhZ2Ut cmVjdXJzaXZlLmh0bWwgdGltZXMgb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjg1NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3 LTAyLTIxICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMjY5OS4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMTIwMDZjMDE0YTkuLjQ0NDRjMzNmOThmIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTc4OCw4ICsx Nzg4LDYgQEAgd2Via2l0Lm9yZy9iLzE2ODU2OCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Rp bWVvdXQtZ3JlYXRlci10aGFuLWRlZmF1bHQtbmV0d28KIAogd2Via2l0Lm9yZy9iLzE2ODU2OSBo dHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVzb3VyY2UtZmFsbGJhY2stZm9yLW5ldHdvcmstZXJy b3ItY3Jhc2guaHRtbCBbIFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvMTY4NTcwIGZhc3QvZXZl bnRzL21lc3NhZ2UtcG9ydC1wb3N0TWVzc2FnZS1yZWN1cnNpdmUuaHRtbCBbIFRpbWVvdXQgXQot CiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2YgVGVzdHMgdGltaW5n IG91dAogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggMjkzOTdiMjdhN2Uu LjkyZWI3MGY4Yzc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE3LTAyLTIxICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBUZXN0IGZh c3QvZXZlbnRzL21lc3NhZ2UtcG9ydC1wb3N0TWVzc2FnZS1yZWN1cnNpdmUuaHRtbCB0aW1lcyBv dXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODU3 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg aGFzIHJlY2VudGx5IGJlZW4gYWRkZWQgYW5kIHRoZSBwYXRjaCBpcyBnb29kLiBJdCdzIGp1c3Qg cmV2ZWFsaW5nIGEgcHJvYmxlbSB3aXRoIG91ciB0aW1lcnMuIFRoZSB0ZXN0IGlzCisgICAgICAg IHBvc3RpbmcgYSBtZXNzYWdlIHJlY3Vyc2l2ZWx5LCBhbmQgYWxzbyBzdGFydHMgYSB0aW1lb3V0 IHRpbWVyIHRvIGZpbmlzaCB0aGUgdGVzdC4gVGhlIHRpbWVvdXQgdGltZXIgaXMgbmV2ZXIKKyAg ICAgICAgZmlyZWQgZm9yIHVzLCBiZWNhdXNlIFdlYkNvcmUgdGltZXJzIGhhdmUgbG93ZXIgcHJp b3JpdHkgdGhhbiB0aGUgb25lIHVzZWQgYnkgcG9zdE1lc3NhZ2UuIFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQKKyAgICAgICAgdXNlcyBEb2N1bWVudDo6cG9zdFRhc2ssIHRoYXQgdXNlcyBzY2hlZHVs ZU9uTWFpblRocmVhZCwgdGhhdCB1c2VzIFJ1bkxvb3A6OmRpc3BhdGNoKCkuIFdlIGFyZSBub3Qg c2V0dGluZyBhbnkKKyAgICAgICAgcHJpb3JpdHkgZm9yIHRoZSB0aW1lciB1c2VkIGJ5IFJ1bkxv b3A6OmRpc3BhdGNoLCBzbyBpdCdzIHVzaW5nIHRoZSBkZWZhdWx0LgorICAgICAgICBVc2UgYSBS dW5Mb29wOjpUaW1lciB0byBzY2hlZHVsZSB0YXNrcyB0byB0aGUgbWFpbiB0aHJlYWQgaW5zdGVh ZCBvZiB1c2luZyBSdW5Mb29wOjpkaXNwYXRjaCgpLiBUaGlzIGFsbG93cyB1cworICAgICAgICB0 byB1c2UgYSBkaWZmZXJlbnQgcHJpb3JpdHksIHRoYXQgaXMgbm93IHNldCB0byBHX1BSSU9SSVRZ X0hJR0hfSURMRSArIDIwIHRvIG1hdGNoIFdlYkNvcmUgdGltZXJzLiBCdXQgaXQgYWxzbworICAg ICAgICBhdm9pZHMgdGhlIGRvdWJsZSBxdWV1ZSB3ZSBoYWQgd2l0aCBSdW5Mb29wOjpkaXNwYXRj aCgpLCBiZWNhdXNlIHNjaGVkdWxlT25NYWluVGhyZWFkKCkgYWxzbyBxdWV1ZXMgdGhlIHRhc2tz LgorCisgICAgICAgICogd3RmL2dsaWIvTWFpblRocmVhZEdMaWIuY3BwOgorICAgICAgICAoV1RG OjpNYWluVGhyZWFkRGlzcGF0Y2hlcjo6TWFpblRocmVhZERpc3BhdGNoZXIpOgorICAgICAgICAo V1RGOjpNYWluVGhyZWFkRGlzcGF0Y2hlcjo6c2NoZWR1bGUpOgorICAgICAgICAoV1RGOjpNYWlu VGhyZWFkRGlzcGF0Y2hlcjo6ZmlyZWQpOgorICAgICAgICAoV1RGOjpzY2hlZHVsZURpc3BhdGNo RnVuY3Rpb25zT25NYWluVGhyZWFkKToKKwogMjAxNy0wMi0yMSAgQWxleCBDaHJpc3RlbnNlbiAg PGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIyMTI2OTkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nbGliL01haW5UaHJlYWRH TGliLmNwcCBiL1NvdXJjZS9XVEYvd3RmL2dsaWIvTWFpblRocmVhZEdMaWIuY3BwCmluZGV4IGQy ZTEyMWZiOTI3Li5jZWVlYTI0YWNlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvZ2xpYi9N YWluVGhyZWFkR0xpYi5jcHAKKysrIGIvU291cmNlL1dURi93dGYvZ2xpYi9NYWluVGhyZWFkR0xp Yi5jcHAKQEAgLTMwLDE3ICszMCw0MyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg Ik1haW5UaHJlYWQuaCIKIAorI2luY2x1ZGUgPGdsaWIuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9v cC5oPgogCiBuYW1lc3BhY2UgV1RGIHsKIAorY2xhc3MgTWFpblRocmVhZERpc3BhdGNoZXIgewor cHVibGljOgorICAgIE1haW5UaHJlYWREaXNwYXRjaGVyKCkKKyAgICAgICAgOiBtX3RpbWVyKFJ1 bkxvb3A6Om1haW4oKSwgdGhpcywgJk1haW5UaHJlYWREaXNwYXRjaGVyOjpmaXJlZCkKKyAgICB7 CisgICAgICAgIG1fdGltZXIuc2V0UHJpb3JpdHkoR19QUklPUklUWV9ISUdIX0lETEUgKyAyMCk7 CisgICAgfQorCisgICAgdm9pZCBzY2hlZHVsZSgpCisgICAgeworICAgICAgICBtX3RpbWVyLnN0 YXJ0T25lU2hvdCgwKTsKKyAgICB9CisKK3ByaXZhdGU6CisgICAgdm9pZCBmaXJlZCgpCisgICAg eworICAgICAgICBkaXNwYXRjaEZ1bmN0aW9uc0Zyb21NYWluVGhyZWFkKCk7CisgICAgfQorCisg ICAgUnVuTG9vcDo6VGltZXI8TWFpblRocmVhZERpc3BhdGNoZXI+IG1fdGltZXI7Cit9OworCiB2 b2lkIGluaXRpYWxpemVNYWluVGhyZWFkUGxhdGZvcm0oKQogewogfQogCiB2b2lkIHNjaGVkdWxl RGlzcGF0Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQoKQogewotICAgIFJ1bkxvb3A6Om1haW4oKS5k aXNwYXRjaChzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oZGlzcGF0Y2hGdW5jdGlvbnNGcm9tTWFpblRo cmVhZCkpOworICAgIC8vIFVzZSBhIFJ1bkxvb3A6OlRpbWVyIGluc3RlYWQgb2YgUnVuTG9vcDo6 ZGlzcGF0Y2goKSB0byBiZSBhYmxlIHRvIHVzZSBhIGRpZmZlcmVudCBwcmlvcml0eSBhbmQKKyAg ICAvLyBhdm9pZCB0aGUgZG91YmxlIHF1ZXVlIGJlY2F1c2UgZGlzcGF0Y2hPbk1haW5UaHJlYWQg YWxzbyBxdWV1ZXMgdGhlIGZ1bmN0aW9ucy4KKyAgICBzdGF0aWMgTWFpblRocmVhZERpc3BhdGNo ZXIgZGlzcGF0Y2hlcjsKKyAgICBkaXNwYXRjaGVyLnNjaGVkdWxlKCk7CiB9CiAKIH0gLy8gbmFt ZXNwYWNlIFdURgo=