16856 2008-01-12 13:22:59 -0800 Tests depend on incorrect javascript URL implementation that does not replace the document 2008-06-09 00:41:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned ap mitz oldest_to_newest 67059 0 abarth 2008-01-12 13:22:59 -0800 A few LayoutTests have bugs that assume WebKit's buggy implementation of javascript URLs (see Bug 16855). I audited all the LayoutTests and found bugs in: fast/replaced/image-map.html fast/events/event-listener-html-non-html-confusion.html svg/custom/prevent-default.svg I'll attach a patch for the tests shortly. 67060 1 18410 abarth 2008-01-12 13:28:44 -0800 Created attachment 18410 Fixes wrong tests These tests to not intend to replace the document when navigating to their javascript URLs. This patch wraps the calls in void, which always returns undefined. This also keeps the old version of image-map.html to retain a regression test for Bug 16782, but maybe it should be turned into a reduced test case for that bug. 67069 2 ap 2008-01-12 14:39:16 -0800 Sorry for what may be a stupid question, but would something like "javascript:document.getElementById('rect').style.fill='red'" also replace the current document when entered in address bar? I'm not seeing such behavior in other browsers. 67070 3 abarth 2008-01-12 14:50:03 -0800 Try typing <javascript:document.getElementById('rect').style.fill='red'> into <http://crypto.stanford.edu/~abarth/research/webkit/16856/ap.html> in Firefox and IE. What's going on is the "=" operator returns the value 'red', which then becomes the current document. This is currently broken in Safari. 67096 4 ap 2008-01-13 00:01:15 -0800 Indeed. I was so sure that I never saw this, that I couldn't be bothered to double-check :). 67125 5 18410 darin 2008-01-13 11:21:24 -0800 Comment on attachment 18410 Fixes wrong tests +<map name="map"><area shape="poly" coords="0,0,0,100,100,100,100,0" href="void(javascript:document.getElementById('result').innerHTML='area clicked')"></map> You put "void" in the wrong place here. Did you try it? Did it work? Also need ChangeLog so we can land this. 67127 6 18410 darin 2008-01-13 11:24:44 -0800 Comment on attachment 18410 Fixes wrong tests Patch also needs to include expected results for the new image-map-bug16782.html test. 82515 7 21545 abarth 2008-06-07 00:00:56 -0700 Created attachment 21545 Improved patch Here is a patch that should work. Sorry about the confusion earlier. Now that I have a Mac, I can actually run the tests properly. 82667 8 21545 darin 2008-06-08 13:56:28 -0700 Comment on attachment 21545 Improved patch r=me 82719 9 abarth 2008-06-09 00:41:37 -0700 Fixed in r34463. 18410 2008-01-12 13:28:44 -0800 2008-06-07 00:00:56 -0700 Fixes wrong tests fix-wrong-tests.patch text/plain 2708 abarth SW5kZXg6IGZhc3QvcmVwbGFjZWQvaW1hZ2UtbWFwLWJ1ZzE2NzgyLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gZmFzdC9yZXBsYWNlZC9pbWFnZS1tYXAtYnVnMTY3ODIuaHRtbAkocmV2aXNpb24gMCkKKysr IGZhc3QvcmVwbGFjZWQvaW1hZ2UtbWFwLWJ1ZzE2NzgyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMTcgQEAKKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDUwLCA1 MCk7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgICAgICBldmVudFNlbmRl ci5tb3VzZVVwKCk7CisgICAgfQorfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9 InRlc3QoKSI+Cis8aW1nIGlkPSJpbWFnZSIgaGVpZ2h0PSIxMDAiIHdpZHRoPSIxMDAiIHNyYz0i cmVzb3VyY2VzL3NxdWFyZS1ibHVlLTEwMHgxMDAucG5nIiB1c2VtYXA9IiNtYXAiPgorPG1hcCBu YW1lPSJtYXAiPjxhcmVhIHNoYXBlPSJwb2x5IiBjb29yZHM9IjAsMCwwLDEwMCwxMDAsMTAwLDEw MCwwIiBocmVmPSJqYXZhc2NyaXB0OmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5p bm5lckhUTUw9J2FyZWEgY2xpY2tlZCciPjwvbWFwPgorPGRpdiBpZD0icmVzdWx0Ij5ubyBhcmVh IGNsaWNrIHNlZW4geWV0PC9kaXY+Cis8L2JvZHk+CkluZGV4OiBmYXN0L3JlcGxhY2VkL2ltYWdl LW1hcC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIGZhc3QvcmVwbGFjZWQvaW1hZ2UtbWFwLmh0bWwJKHJl dmlzaW9uIDI5MzYyKQorKysgZmFzdC9yZXBsYWNlZC9pbWFnZS1tYXAuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMTIsNiArMTIsNiBAQAogPC9oZWFkPgogPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgog PGltZyBpZD0iaW1hZ2UiIGhlaWdodD0iMTAwIiB3aWR0aD0iMTAwIiBzcmM9InJlc291cmNlcy9z cXVhcmUtYmx1ZS0xMDB4MTAwLnBuZyIgdXNlbWFwPSIjbWFwIj4KLTxtYXAgbmFtZT0ibWFwIj48 YXJlYSBzaGFwZT0icG9seSIgY29vcmRzPSIwLDAsMCwxMDAsMTAwLDEwMCwxMDAsMCIgaHJlZj0i amF2YXNjcmlwdDpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MPSdh cmVhIGNsaWNrZWQnIj48L21hcD4KKzxtYXAgbmFtZT0ibWFwIj48YXJlYSBzaGFwZT0icG9seSIg Y29vcmRzPSIwLDAsMCwxMDAsMTAwLDEwMCwxMDAsMCIgaHJlZj0idm9pZChqYXZhc2NyaXB0OmRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5pbm5lckhUTUw9J2FyZWEgY2xpY2tlZCcp Ij48L21hcD4KIDxkaXYgaWQ9InJlc3VsdCI+bm8gYXJlYSBjbGljayBzZWVuIHlldDwvZGl2Pgog PC9ib2R5PgpJbmRleDogZmFzdC9ldmVudHMvZXZlbnQtbGlzdGVuZXItaHRtbC1ub24taHRtbC1j b25mdXNpb24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L2V2ZW50cy9ldmVudC1saXN0ZW5lci1o dG1sLW5vbi1odG1sLWNvbmZ1c2lvbi5odG1sCShyZXZpc2lvbiAyOTM2MikKKysrIGZhc3QvZXZl bnRzL2V2ZW50LWxpc3RlbmVyLWh0bWwtbm9uLWh0bWwtY29uZnVzaW9uLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTUsNyArNSw3IEBACiAKIDxwIGlkPSJyZXN1bHQiPjwvcD4KIAotPGEgaHJlZj0i amF2YXNjcmlwdDpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0g J0ZBSUxVUkUnIiBpZD0iYW5jaG9yIj50ZXN0IGFuY2hvciAtIHNjcmlwdCBjbGlja3MgdGhpcyBh dXRvbWF0aWNhbGx5PC9hPgorPGEgaHJlZj0iamF2YXNjcmlwdDp2b2lkKGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdyZXN1bHQnKS5pbm5lckhUTUwgPSAnRkFJTFVSRScpIiBpZD0iYW5jaG9yIj50 ZXN0IGFuY2hvciAtIHNjcmlwdCBjbGlja3MgdGhpcyBhdXRvbWF0aWNhbGx5PC9hPgogCiA8c2Ny aXB0PgogCkluZGV4OiBzdmcvY3VzdG9tL3ByZXZlbnQtZGVmYXVsdC5zdmcKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gc3ZnL2N1c3RvbS9wcmV2ZW50LWRlZmF1bHQuc3ZnCShyZXZpc2lvbiAyOTM2MikKKysrIHN2 Zy9jdXN0b20vcHJldmVudC1kZWZhdWx0LnN2Zwkod29ya2luZyBjb3B5KQpAQCAtMjUsNyArMjUs NyBAQAogICAgICAgXV0+CiAgICAgPC9zY3JpcHQ+CiAgIDwvZGVmcz4KLSAgPGEgeGxpbms6aHJl Zj0iamF2YXNjcmlwdDpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVjdCcpLnN0eWxlLmZpbGw9 J3JlZCciPgorICA8YSB4bGluazpocmVmPSJqYXZhc2NyaXB0OnZvaWQoZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ3JlY3QnKS5zdHlsZS5maWxsPSdyZWQnKSI+CiAgICAgPHJlY3QgaWQ9J3JlY3Qn IG9uY2xpY2s9ImNoYW5nZUNvbG9yKGV2dCkiIHdpZHRoPScxMDAnIGhlaWdodD0nMTAwJyBmaWxs PSdvcmFuZ2UnIC8+CiAgIDwvYT4KIDwvc3ZnPgo= 21545 2008-06-07 00:00:56 -0700 2008-06-08 13:56:28 -0700 Improved patch fix-tests.patch text/plain 3993 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM0NDEyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDYtMDYgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NTYKKwor ICAgICAgICBGaXggdGVzdHMgbm90IHRvIHJlbHkgb24gYnJva2VuIGphdmFzY3JpcHQgVVJMIGJl aGF2aW9yLgorCisgICAgICAgICogZmFzdC9ldmVudHMvZXZlbnQtbGlzdGVuZXItaHRtbC1ub24t aHRtbC1jb25mdXNpb24uaHRtbDoKKyAgICAgICAgKiBmYXN0L3JlcGxhY2VkL2ltYWdlLW1hcC1i dWcxNjc4Mi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVwbGFjZWQvaW1h Z2UtbWFwLWJ1ZzE2NzgyLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVwbGFjZWQvaW1h Z2UtbWFwLmh0bWw6CisgICAgICAgICogc3ZnL2N1c3RvbS9wcmV2ZW50LWRlZmF1bHQuc3ZnOgor CiAyMDA4LTA2LTA2ICBSb2JlcnQgQmxhdXQgIDx3ZWJraXRAYmxhdXQuYml6PgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv ZXZlbnQtbGlzdGVuZXItaHRtbC1ub24taHRtbC1jb25mdXNpb24uaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9ldmVudC1saXN0ZW5lci1odG1sLW5vbi1odG1sLWNv bmZ1c2lvbi5odG1sCShyZXZpc2lvbiAzNDQxMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRz L2V2ZW50LWxpc3RlbmVyLWh0bWwtbm9uLWh0bWwtY29uZnVzaW9uLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTUsNyArNSw3IEBAIGZpcnN0IGFzIGEgbm9uLUhUTUwgYW5kIHRoZW4gYXMgYW4gSFRN TCAKIAogPHAgaWQ9InJlc3VsdCI+PC9wPgogCi08YSBocmVmPSJqYXZhc2NyaXB0OmRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5pbm5lckhUTUwgPSAnRkFJTFVSRSciIGlkPSJhbmNo b3IiPnRlc3QgYW5jaG9yIC0gc2NyaXB0IGNsaWNrcyB0aGlzIGF1dG9tYXRpY2FsbHk8L2E+Cis8 YSBocmVmPSJqYXZhc2NyaXB0OnZvaWQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3VsdCcp LmlubmVySFRNTCA9ICdGQUlMVVJFJykiIGlkPSJhbmNob3IiPnRlc3QgYW5jaG9yIC0gc2NyaXB0 IGNsaWNrcyB0aGlzIGF1dG9tYXRpY2FsbHk8L2E+CiAKIDxzY3JpcHQ+CiAKSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvcmVwbGFjZWQvaW1hZ2UtbWFwLWJ1ZzE2NzgyLWV4cGVjdGVkLnR4dAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlcGxhY2VkL2ltYWdlLW1hcC1idWcxNjc4Mi1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlcGxhY2VkL2lt YWdlLW1hcC1idWcxNjc4Mi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMiBA QAorCithcmVhIGNsaWNrZWQKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcmVwbGFjZWQvaW1hZ2Ut bWFwLWJ1ZzE2NzgyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9yZXBsYWNl ZC9pbWFnZS1tYXAtYnVnMTY3ODIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvcmVwbGFjZWQvaW1hZ2UtbWFwLWJ1ZzE2NzgyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTcgQEAKKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDUwLCA1MCk7 CisgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgICAgICBldmVudFNlbmRlci5t b3VzZVVwKCk7CisgICAgfQorfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InRl c3QoKSI+Cis8aW1nIGlkPSJpbWFnZSIgaGVpZ2h0PSIxMDAiIHdpZHRoPSIxMDAiIHNyYz0icmVz b3VyY2VzL3NxdWFyZS1ibHVlLTEwMHgxMDAucG5nIiB1c2VtYXA9IiNtYXAiPgorPG1hcCBuYW1l PSJtYXAiPjxhcmVhIHNoYXBlPSJwb2x5IiBjb29yZHM9IjAsMCwwLDEwMCwxMDAsMTAwLDEwMCww IiBocmVmPSJqYXZhc2NyaXB0OmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5pbm5l ckhUTUw9J2FyZWEgY2xpY2tlZCciPjwvbWFwPgorPGRpdiBpZD0icmVzdWx0Ij5ubyBhcmVhIGNs aWNrIHNlZW4geWV0PC9kaXY+Cis8L2JvZHk+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3JlcGxh Y2VkL2ltYWdlLW1hcC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcmVwbGFj ZWQvaW1hZ2UtbWFwLmh0bWwJKHJldmlzaW9uIDM0NDEwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9y ZXBsYWNlZC9pbWFnZS1tYXAuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTIsNiArMTIsNiBAQCBm dW5jdGlvbiB0ZXN0KCkgewogPC9oZWFkPgogPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgogPGltZyBp ZD0iaW1hZ2UiIGhlaWdodD0iMTAwIiB3aWR0aD0iMTAwIiBzcmM9InJlc291cmNlcy9zcXVhcmUt Ymx1ZS0xMDB4MTAwLnBuZyIgdXNlbWFwPSIjbWFwIj4KLTxtYXAgbmFtZT0ibWFwIj48YXJlYSBz aGFwZT0icG9seSIgY29vcmRzPSIwLDAsMCwxMDAsMTAwLDEwMCwxMDAsMCIgaHJlZj0iamF2YXNj cmlwdDpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MPSdhcmVhIGNs aWNrZWQnIj48L21hcD4KKzxtYXAgbmFtZT0ibWFwIj48YXJlYSBzaGFwZT0icG9seSIgY29vcmRz PSIwLDAsMCwxMDAsMTAwLDEwMCwxMDAsMCIgaHJlZj0iamF2YXNjcmlwdDp2b2lkKGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdyZXN1bHQnKS5pbm5lckhUTUw9J2FyZWEgY2xpY2tlZCcpIj48L21h cD4KIDxkaXYgaWQ9InJlc3VsdCI+bm8gYXJlYSBjbGljayBzZWVuIHlldDwvZGl2PgogPC9ib2R5 PgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9wcmV2ZW50LWRlZmF1bHQuc3ZnCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL3N2Zy9jdXN0b20vcHJldmVudC1kZWZhdWx0LnN2ZwkocmV2 aXNpb24gMzQ0MTApCisrKyBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3ByZXZlbnQtZGVmYXVsdC5z dmcJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDcgQEAKICAgICAgIF1dPgogICAgIDwvc2Ny aXB0PgogICA8L2RlZnM+Ci0gIDxhIHhsaW5rOmhyZWY9ImphdmFzY3JpcHQ6ZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3JlY3QnKS5zdHlsZS5maWxsPSdyZWQnIj4KKyAgPGEgeGxpbms6aHJlZj0i amF2YXNjcmlwdDp2b2lkKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyZWN0Jykuc3R5bGUuZmls bD0ncmVkJykiPgogICAgIDxyZWN0IGlkPSdyZWN0JyBvbmNsaWNrPSJjaGFuZ2VDb2xvcihldnQp IiB3aWR0aD0nMTAwJyBoZWlnaHQ9JzEwMCcgZmlsbD0nb3JhbmdlJyAvPgogICA8L2E+CiA8L3N2 Zz4K