168537 2017-02-17 15:27:54 -0800 [JSC] Fix missing header in AbstractMacroAssembler.h 2017-03-13 17:12:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other All All NEW P2 Normal --- 1 guijemont webkit-unassigned commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1278481 0 guijemont 2017-02-17 15:27:54 -0800 AbstractMacroAssembler.h should include wtf/Vector.h as it uses vectors. As of now, it relies on wtf/Vector.h being included by another header, which is why MacroAssemblerX86Common.h has to include X86Assembler.h before AbstractMacroAssembler.h, breaking our style rules. The same issue would arise for MIPS, and solving this bug would allow to provide a proper fix for #168402. 1278492 1 302004 guijemont 2017-02-17 15:59:33 -0800 Created attachment 302004 Patch Patch adding the include and fixing include orders. 1278627 2 302004 buildbot 2017-02-18 02:59:57 -0800 Comment on attachment 302004 Patch Attachment 302004 did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/3148592 New failing tests: stress/regress-159537.js.default 1287432 3 302004 mark.lam 2017-03-13 17:12:54 -0700 Comment on attachment 302004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302004&action=review > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:31 > -#include "X86Assembler.h" > #include "AbstractMacroAssembler.h" > +#include "X86Assembler.h" This breaks the Mac (and iOS) builds (debug builds previously, and now release builds too after r213743). 302004 2017-02-17 15:59:33 -0800 2017-03-13 17:12:54 -0700 Patch bug-168537-20170217175651.patch text/plain 2368 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZjEyNzk3OTk4MTA2NjM4ZTRiYmNhNzAxZGYwYWQwYjRiZTU3OGYzLi5lNDg5Yzk3OTVhMWI0ZGMx YzM0MmE0ODQ5NTIxOGRiOTNmODZjMzUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNy0wMi0xNyAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IG1pc3NpbmcgaGVhZGVyIGluIEFic3RyYWN0TWFj cm9Bc3NlbWJsZXIuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY4NTM3CisKKyAgICAgICAgQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oIHNob3VsZCBp bmNsdWRlIHd0Zi9WZWN0b3IuaCBhcyBpdCB1c2VzCisgICAgICAgIHZlY3RvcnMuIEFzIG9mIG5v dywgaXQgcmVsaWVzIG9uIHd0Zi9WZWN0b3IuaCBiZWluZyBpbmNsdWRlZCBieQorICAgICAgICBh bm90aGVyIGhlYWRlciwgd2hpY2ggaXMgd2h5IE1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmggaGFz IHRvIGluY2x1ZGUKKyAgICAgICAgWDg2QXNzZW1ibGVyLmggYmVmb3JlIEFic3RyYWN0TWFjcm9B c3NlbWJsZXIuaCwgYnJlYWtpbmcgb3VyIHN0eWxlCisgICAgICAgIHJ1bGVzLgorCisgICAgICAg IFRoZSBzYW1lIGlzc3VlIHdvdWxkIGFyaXNlIGZvciBNSVBTLCBhbmQgdGhpcyBmaXggYWxsb3dz IHRvIHByb3ZpZGUgYQorICAgICAgICBwcm9wZXIgZml4IGZvciAjMTY4NDAyLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL0Fic3Ry YWN0TWFjcm9Bc3NlbWJsZXIuaDoKKyAgICAgICAgSW5jbHVkZSB3dGYvVmVjdG9yLmguCisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmg6CisgICAgICAgIENoYW5n ZSBvcmRlciBvZiBpbmNsdWRlcyB0byByZXNwZWN0IGFscGhhYmV0aWNhbCBvcmRlci4KKwogMjAx Ny0wMi0xNyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dMaWJdIEdDQWN0aXZpdHlDYWxsYmFjazo6c2NoZWR1bGVUaW1lcigpIGtlZXBzIHB1c2hpbmcg ZGlzcGF0Y2ggaW50byB0aGUgZnV0dXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oCmluZGV4IGI3OTFlNWNiMTli ZDY4MmJkM2M4NGVjMjRjZjdjODg1ZjUzOWMxNzQuLjkxZGJiMTc0MWY4ZThkZGJkMTE1NTk4ZmRm YjA1OWJmODA2ZjZkMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oCkBAIC0zNiw2ICszNiw3IEBACiAjaW5j bHVkZSA8d3RmL0NyeXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyLmg+CiAjaW5jbHVkZSA8d3Rm L05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL1NoYXJlZFRhc2suaD4KKyNpbmNsdWRlIDx3 dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL1dlYWtSYW5kb20uaD4KIAogbmFtZXNwYWNlIEpT QyB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyWDg2Q29tbW9uLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyWDg2Q29tbW9uLmgKaW5kZXggNjk1ZTY0MGYwMGU3NTljNDEyNTVmYjAxODAyMmRi NzY1ZDcyMmU2OC4uNDg1OWUwZjdiMTkxZTFkZjc3OGQ4NjJiNGMxM2RjMjVmMmI4YmRmYSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4 NkNvbW1vbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJYODZDb21tb24uaApAQCAtMjcsOCArMjcsOCBAQAogCiAjaWYgRU5BQkxFKEFTU0VNQkxF UikKIAotI2luY2x1ZGUgIlg4NkFzc2VtYmxlci5oIgogI2luY2x1ZGUgIkFic3RyYWN0TWFjcm9B c3NlbWJsZXIuaCIKKyNpbmNsdWRlICJYODZBc3NlbWJsZXIuaCIKICNpbmNsdWRlIDx3dGYvT3B0 aW9uYWwuaD4KIAogI2lmIENPTVBJTEVSKE1TVkMpCg==