168529 2017-02-17 12:49:04 -0800 Web Inspector: Timeline DataGridNodes are lacking detail in title 2017-02-17 13:32:00 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck oldest_to_newest 1278371 0 joepeck 2017-02-17 12:49:04 -0800 Timeline DataGridNodes are lacking detail in title Steps to Reproduce: 1. Inspect LayoutTests/inspector/heap/garbageCollected.html 2. js> periodicallyTriggerGCs() 3. Record Script Timeline 4. Stop Script Timeline => Expected details about Partial and Full GCs. Instead they just say "Garbage Collection" Regression: - This absolutely was working in the past. Appears to have broken around r194932 / r197909 with Timeline UI changes 1278372 1 joepeck 2017-02-17 12:49:17 -0800 <rdar://problem/30579959> 1278373 2 301969 joepeck 2017-02-17 12:50:22 -0800 Created attachment 301969 [PATCH] Proposed Fix 1278376 3 301969 bburg 2017-02-17 12:54:17 -0800 Comment on attachment 301969 [PATCH] Proposed Fix r=me 1278408 4 301969 commit-queue 2017-02-17 13:31:56 -0800 Comment on attachment 301969 [PATCH] Proposed Fix Clearing flags on attachment: 301969 Committed r212570: <http://trac.webkit.org/changeset/212570> 1278409 5 commit-queue 2017-02-17 13:32:00 -0800 All reviewed patches have been landed. Closing bug. 301969 2017-02-17 12:50:22 -0800 2017-02-17 13:31:56 -0800 [PATCH] Proposed Fix data-grid-1.patch text/plain 1621 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQzYmY2YmJhZGE3Li4wNzNhOThmMmVhZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDItMTcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBUaW1lbGluZSBEYXRhR3JpZE5vZGVzIGFyZSBsYWNraW5nIGRldGFpbCBpbiB0aXRsZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NTI5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8zMDU3OTk1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRh R3JpZE5vZGUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVEYXRhR3JpZE5vZGUu cHJvdG90eXBlLmRpc3BsYXlOYW1lKToKKyAgICAgICAgSW5jbHVkZSBkZXRhaWxlZCBpbmZvcm1h dGlvbiBmb3IgRGF0YUdyaWROb2RlIGRpc3BsYXkgbmFtZXMsIHNpbmNlIHdlCisgICAgICAgIHdh bnQgdG8gc2hvdyBtYXhpbXVtIGRldGFpbCBmb3IgcmVjb3JkcyBpbiB0aGUgRGF0YUdyaWQuCisK IDIwMTctMDItMTYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogYWRkIERlYnVnVUkgc2V0dGluZyB0byBtYW51YWxseSBvdmVycmlkZSBVSSBs YXlvdXQgZGlyZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkTm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWROb2RlLmpzCmluZGV4IDA5 Yzc3MzkxNmYwLi42MjU1MjYwZjMyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZE5vZGUuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZE5vZGUu anMKQEAgLTMxOSw3ICszMTksOCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVEYXRhR3JpZE5vZGUg PSBjbGFzcyBUaW1lbGluZURhdGFHcmlkTm9kZSBleHRlbmRzIFdlYkluc3BlYwogICAgIGRpc3Bs YXlOYW1lKCkKICAgICB7CiAgICAgICAgIC8vIENhbiBiZSBvdmVycmlkZGVuIGJ5IHN1YmNsYXNz ZXMuCi0gICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVGltZWxpbmVUYWJDb250ZW50Vmlldy5k aXNwbGF5TmFtZUZvclJlY29yZCh0aGlzLnJlY29yZCk7CisgICAgICAgIGNvbnN0IGluY2x1ZGVE ZXRhaWxzID0gdHJ1ZTsKKyAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5UaW1lbGluZVRhYkNv bnRlbnRWaWV3LmRpc3BsYXlOYW1lRm9yUmVjb3JkKHRoaXMucmVjb3JkLCB0cnVlKTsKICAgICB9 CiAKICAgICBpY29uQ2xhc3NOYW1lcygpCg==