168509 2017-02-17 06:09:52 -0800 [SOUP] Stop removing the fragment identifier from resource requests 2017-02-17 07:17:05 -0800 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply commit-queue danw gustavo mcatanzaro mrobinson svillar oldest_to_newest 1278214 0 cgarcia 2017-02-17 06:09:52 -0800 I don't know why, but have always removed the fragment identifiers from the URL when creating the SoupURI that is passed to libsoup. Maybe it was a bug in a very old version of libsoup, but it doesn't look necessary anymore and it's causing several layout tests failures. 1278215 1 301918 cgarcia 2017-02-17 06:12:25 -0800 Created attachment 301918 Patch 1278216 2 301919 cgarcia 2017-02-17 06:13:38 -0800 Created attachment 301919 Patch 1278232 3 cgarcia 2017-02-17 06:48:26 -0800 Committed r212548: <http://trac.webkit.org/changeset/212548> 1278234 4 mrobinson 2017-02-17 06:50:14 -0800 Out of curiosity I tracked down this behavior to: https://trac.webkit.org/changeset/41058 Here's the original comment: // GIO doesn't know how to handle refs and queries, so remove them // TODO: use KURL.fileSystemPath after KURLGtk and FileSystemGtk are // using GIO internally, and providing URIs instead of file paths 1278236 5 mrobinson 2017-02-17 06:51:29 -0800 The origin of the behavior is here: https://trac.webkit.org/changeset/33594 1278243 6 cgarcia 2017-02-17 06:55:23 -0800 (In reply to comment #4) > Out of curiosity I tracked down this behavior to: > https://trac.webkit.org/changeset/41058 > > Here's the original comment: > // GIO doesn't know how to handle refs and queries, so remove them > // TODO: use KURL.fileSystemPath after KURLGtk and FileSystemGtk are > // using GIO internally, and providing URIs instead of file paths But I think this was only done for local files. This code was removed actually. For URLS we have always done it. 1278252 7 mcatanzaro 2017-02-17 07:17:05 -0800 So this is why anchor links have always been buggy for us...? WTF. :( 301918 2017-02-17 06:12:25 -0800 2017-02-17 06:13:38 -0800 Patch wcore-soup-fragment.diff text/plain 2468 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjODg3ZjQ4NTI5Ni4uMzczOGFkYWI4ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNy0wMi0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW1NPVVBdIFN0ZXAgcmVtb3ZpbmcgdGhlIGZyYWdtZW50IGlk ZW50aWZpZXIgZnJvbSByZXNvdXJjZSByZXF1ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSSBkb24ndCBrbm93IHdoeSwgYnV0IGhhdmUgYWx3YXlz IHJlbW92ZWQgdGhlIGZyYWdtZW50IGlkZW50aWZpZXIgZnJvbSB0aGUgVVJMIHdoZW4gY3JlYXRp bmcgdGhlIFNvdXBVUkkgdGhhdAorICAgICAgICBpcyBwYXNzZWQgdG8gbGlic291cC4gTWF5YmUg aXQgd2FzIGEgYnVnIGluIGEgdmVyeSBvbGQgdmVyc2lvbiBvZiBsaWJzb3VwLCBidXQgaXQgZG9l c24ndCBsb29rIG5lY2Vzc2FyeSBhbnltb3JlCisgICAgICAgIGFuZCBpdCdzIGNhdXNpbmcgc2V2 ZXJhbCBsYXlvdXQgdGVzdCBmYWlsdXJlcy4KKworICAgICAgICBGaXhlczogaHR0cC90ZXN0cy9z dmcvc3ZnLXVzZS1leHRlcm5hbC5odG1sCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvd2ViYXBwYXBpcy9zY3JpcHRpbmcvcHJvY2Vzc2luZy1tb2Rl bC0yL2NvbXBpbGUtZXJyb3Itc2FtZS1vcmlnaW4td2l0aC1oYXNoLmh0bWwKKyAgICAgICAgICAg ICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC93ZWJhcHBhcGlzL3Njcmlw dGluZy9wcm9jZXNzaW5nLW1vZGVsLTIvcnVudGltZS1lcnJvci1zYW1lLW9yaWdpbi13aXRoLWhh c2guaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVz dFNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpjcmVhdGVTb3Vw VVJJKTogRG8gbm90IHJlbW92ZSB0aGUgZnJhZ21lbnQgaWRlbnRpZmllciBmcm9tIHRoZSBVUkwu CisKKzIwMTctMDItMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCiAgICAgICAgIFJFR1JFU1NJT04ocjIxMjM0NSk6IFtHVEtdIEFTU0VSVChjb29raWVDaGFu Z2VDYWxsYmFja01hcCgpLmNvbnRhaW5zKGphcikpIGZhaWxlZCBpbiBXZWJDb3JlOjpzdG9wT2Jz ZXJ2aW5nQ29va2llQ2hhbmdlczo1NAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY4Mzc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcAppbmRleCBjNTc2 N2U4NDc2Yy4uNjQ1Nzg2MTVjMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKQEAgLTIwOCwx MyArMjA4LDcgQEAgR1VuaXF1ZVB0cjxTb3VwVVJJPiBSZXNvdXJjZVJlcXVlc3Q6OmNyZWF0ZVNv dXBVUkkoKSBjb25zdAogICAgICAgICByZXR1cm4gR1VuaXF1ZVB0cjxTb3VwVVJJPihzb3VwX3Vy aV9uZXcodXJsU3RyaW5nLnV0ZjgoKS5kYXRhKCkpKTsKICAgICB9CiAKLSAgICBHVW5pcXVlUHRy PFNvdXBVUkk+IHNvdXBVUkk7Ci0gICAgaWYgKG1fdXJsLmhhc0ZyYWdtZW50SWRlbnRpZmllcigp KSB7Ci0gICAgICAgIFVSTCB1cmwgPSBtX3VybDsKLSAgICAgICAgdXJsLnJlbW92ZUZyYWdtZW50 SWRlbnRpZmllcigpOwotICAgICAgICBzb3VwVVJJLnJlc2V0KHNvdXBfdXJpX25ldyh1cmwuc3Ry aW5nKCkudXRmOCgpLmRhdGEoKSkpOwotICAgIH0gZWxzZQotICAgICAgICBzb3VwVVJJID0gbV91 cmwuY3JlYXRlU291cFVSSSgpOworICAgIEdVbmlxdWVQdHI8U291cFVSST4gc291cFVSSSA9IG1f dXJsLmNyZWF0ZVNvdXBVUkkoKTsKIAogICAgIC8vIFZlcnNpb25zIG9mIGxpYnNvdXAgcHJpb3Ig dG8gMi40MiBoYXZlIGEgc291cF91cmlfbmV3IHRoYXQgd2lsbCBjb252ZXJ0IGVtcHR5IHBhc3N3 b3JkcyB0aGF0IGFyZSBub3QKICAgICAvLyBwcmVmaXhlZCBieSBhIGNvbG9uIGludG8gbnVsbC4g U29tZSBwYXJ0cyBvZiBzb3VwIGxpa2UgdGhlIFNvdXBBdXRoZW50aWNhdGlvbk1hbmFnZXIgd2ls bCBvbmx5IGJlIGFjdGl2ZQo= 301919 2017-02-17 06:13:38 -0800 2017-02-17 06:39:35 -0800 Patch wcore-soup-fragment.diff text/plain 2468 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjODg3ZjQ4NTI5Ni4uODgxNGQ0NjNhYjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNy0wMi0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW1NPVVBdIFN0b3AgcmVtb3ZpbmcgdGhlIGZyYWdtZW50IGlk ZW50aWZpZXIgZnJvbSByZXNvdXJjZSByZXF1ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSSBkb24ndCBrbm93IHdoeSwgYnV0IGhhdmUgYWx3YXlz IHJlbW92ZWQgdGhlIGZyYWdtZW50IGlkZW50aWZpZXIgZnJvbSB0aGUgVVJMIHdoZW4gY3JlYXRp bmcgdGhlIFNvdXBVUkkgdGhhdAorICAgICAgICBpcyBwYXNzZWQgdG8gbGlic291cC4gTWF5YmUg aXQgd2FzIGEgYnVnIGluIGEgdmVyeSBvbGQgdmVyc2lvbiBvZiBsaWJzb3VwLCBidXQgaXQgZG9l c24ndCBsb29rIG5lY2Vzc2FyeSBhbnltb3JlCisgICAgICAgIGFuZCBpdCdzIGNhdXNpbmcgc2V2 ZXJhbCBsYXlvdXQgdGVzdCBmYWlsdXJlcy4KKworICAgICAgICBGaXhlczogaHR0cC90ZXN0cy9z dmcvc3ZnLXVzZS1leHRlcm5hbC5odG1sCisgICAgICAgICAgICAgICBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvd2ViYXBwYXBpcy9zY3JpcHRpbmcvcHJvY2Vzc2luZy1tb2Rl bC0yL2NvbXBpbGUtZXJyb3Itc2FtZS1vcmlnaW4td2l0aC1oYXNoLmh0bWwKKyAgICAgICAgICAg ICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC93ZWJhcHBhcGlzL3Njcmlw dGluZy9wcm9jZXNzaW5nLW1vZGVsLTIvcnVudGltZS1lcnJvci1zYW1lLW9yaWdpbi13aXRoLWhh c2guaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVz dFNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0OjpjcmVhdGVTb3Vw VVJJKTogRG8gbm90IHJlbW92ZSB0aGUgZnJhZ21lbnQgaWRlbnRpZmllciBmcm9tIHRoZSBVUkwu CisKKzIwMTctMDItMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCiAgICAgICAgIFJFR1JFU1NJT04ocjIxMjM0NSk6IFtHVEtdIEFTU0VSVChjb29raWVDaGFu Z2VDYWxsYmFja01hcCgpLmNvbnRhaW5zKGphcikpIGZhaWxlZCBpbiBXZWJDb3JlOjpzdG9wT2Jz ZXJ2aW5nQ29va2llQ2hhbmdlczo1NAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY4Mzc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcAppbmRleCBjNTc2 N2U4NDc2Yy4uNjQ1Nzg2MTVjMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKQEAgLTIwOCwx MyArMjA4LDcgQEAgR1VuaXF1ZVB0cjxTb3VwVVJJPiBSZXNvdXJjZVJlcXVlc3Q6OmNyZWF0ZVNv dXBVUkkoKSBjb25zdAogICAgICAgICByZXR1cm4gR1VuaXF1ZVB0cjxTb3VwVVJJPihzb3VwX3Vy aV9uZXcodXJsU3RyaW5nLnV0ZjgoKS5kYXRhKCkpKTsKICAgICB9CiAKLSAgICBHVW5pcXVlUHRy PFNvdXBVUkk+IHNvdXBVUkk7Ci0gICAgaWYgKG1fdXJsLmhhc0ZyYWdtZW50SWRlbnRpZmllcigp KSB7Ci0gICAgICAgIFVSTCB1cmwgPSBtX3VybDsKLSAgICAgICAgdXJsLnJlbW92ZUZyYWdtZW50 SWRlbnRpZmllcigpOwotICAgICAgICBzb3VwVVJJLnJlc2V0KHNvdXBfdXJpX25ldyh1cmwuc3Ry aW5nKCkudXRmOCgpLmRhdGEoKSkpOwotICAgIH0gZWxzZQotICAgICAgICBzb3VwVVJJID0gbV91 cmwuY3JlYXRlU291cFVSSSgpOworICAgIEdVbmlxdWVQdHI8U291cFVSST4gc291cFVSSSA9IG1f dXJsLmNyZWF0ZVNvdXBVUkkoKTsKIAogICAgIC8vIFZlcnNpb25zIG9mIGxpYnNvdXAgcHJpb3Ig dG8gMi40MiBoYXZlIGEgc291cF91cmlfbmV3IHRoYXQgd2lsbCBjb252ZXJ0IGVtcHR5IHBhc3N3 b3JkcyB0aGF0IGFyZSBub3QKICAgICAvLyBwcmVmaXhlZCBieSBhIGNvbG9uIGludG8gbnVsbC4g U29tZSBwYXJ0cyBvZiBzb3VwIGxpa2UgdGhlIFNvdXBBdXRoZW50aWNhdGlvbk1hbmFnZXIgd2ls bCBvbmx5IGJlIGFjdGl2ZQo=