168486 2017-02-16 17:18:18 -0800 [WinCairo][MiniBrowser] Add ca-bundle to display secure pages 2020-01-15 12:48:09 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Windows 10 RESOLVED INVALID InRadar P2 Minor --- 177630 1 basuke basuke achristensen basuke bfulgham commit-queue don.olmstead fujii galpeter lforschler webkit-bug-importer oldest_to_newest 1278037 0 basuke 2017-02-16 17:18:18 -0800 The MiniBrowser of WinCairo doesn't have ca bundle and cannot display https pages. There are many solutions: 1. this is up to the user. they have to prepare ca-bundle and set the environment variable to point it. 2. download the latest ca-bundle from somewhere we can trust and place it in WebKit bundle directory while building. 3. disable certificate validation when no ca-bundle is supplied. for 2, the location will be WebKitBuild\Release\bin64\WebKit.resources\certificates\ 1278814 1 fujii 2017-02-19 18:51:58 -0800 (In reply to comment #0) > 3. disable certificate validation when no ca-bundle is supplied. You can disable it by a following env var. set WEBKIT_IGNORE_SSL_ERRORS=1 https://trac.webkit.org/changeset/30359 1280800 2 302675 basuke 2017-02-24 11:14:16 -0800 Created attachment 302675 Patch Added download phase on CMake if the build is WinCairo. The source of the ca-bundle is Curl website. It is chosen because of its good maintenance of the latest ca-bundle. 1280809 3 302677 basuke 2017-02-24 11:44:21 -0800 Created attachment 302677 Patch change the order of path location trial to make the posibility of configuration with environment variable. 1280863 4 commit-queue 2017-02-24 14:05:53 -0800 Attachment 302677 did not pass style-queue: ERROR: Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1280874 5 302689 basuke 2017-02-24 14:20:34 -0800 Created attachment 302689 Patch fix format error 1281371 6 302689 achristensen 2017-02-27 07:06:08 -0800 Comment on attachment 302689 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302689&action=review > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:102 > + char* envPath = getenv("CURL_CA_BUNDLE_PATH"); Preferring this if it exists seems ok. > Tools/MiniBrowser/win/CMakeLists.txt:41 > + file(DOWNLOAD ${MiniBrowser_CABUNDLE_URL} "${MiniBrowser_CERTIFICATES_DIR}/cacert.pem" SHOW_PROGRESS) I'm not sure it's a good idea to download this file every time you build. It could slow things down, it would require network access while building or fail, it would ping the curl server every time a developer runs cmake and developers might worry that they are being tracked, and CMake's file(DOWNLOAD ...) seems to ignore ssl errors, so it's unclear how secure it really is. It would be nice to print out instructions for how to get the cacert.pem, but I don't think this is a good idea to commit to the repository as-is. 1281425 7 basuke 2017-02-27 10:48:53 -0800 (In reply to comment #6) > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302689&action=review > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:102 > > + char* envPath = getenv("CURL_CA_BUNDLE_PATH"); > > Preferring this if it exists seems ok. > > I'm not sure it's a good idea to download this file every time you build. > It could slow things down, it would require network access while building or > fail, it would ping the curl server every time a developer runs cmake and > developers might worry that they are being tracked, That's right. Actually that is exactly annoying thing by update-webkit-dependency do for me. I agree to avoid this kind of download on build process. > CMake's > file(DOWNLOAD ...) seems to ignore ssl errors, so it's unclear how secure it > really is. OMG, this must be the biggest reason to deny this patch. > It would be nice to print out instructions for how to get the > cacert.pem, but I don't think this is a good idea to commit to the > repository as-is. My idea is not downloading it separately, but include it inside WinCairoRequirements, because that library must maintain regularly. But at this moment, it seems not easy to make change to WinCairoRequirements. Until then, I just want to remove the download patch. 1281461 8 302858 basuke 2017-02-27 11:43:10 -0800 Created attachment 302858 Patch Remove the download sequence from Cmake script. 1281473 9 achristensen 2017-02-27 12:25:09 -0800 (In reply to comment #7) > My idea is not downloading it separately, but include it inside > WinCairoRequirements, because that library must maintain regularly. But at > this moment, it seems not easy to make change to WinCairoRequirements. That sounds like a good idea. It should be easy. Just fork https://github.com/peavo/WinCairoRequirements and off you go. 1281486 10 302858 commit-queue 2017-02-27 12:53:35 -0800 Comment on attachment 302858 Patch Clearing flags on attachment: 302858 Committed r213087: <http://trac.webkit.org/changeset/213087> 1281487 11 commit-queue 2017-02-27 12:53:40 -0800 All reviewed patches have been landed. Closing bug. 1354314 12 basuke 2017-09-28 14:57:53 -0700 WinCairoRequirements now includes the cacert.pem. Reopen this bug to copy the cert into application bundle. 1354360 13 322139 basuke 2017-09-28 16:20:00 -0700 Created attachment 322139 added 1354363 14 322139 bfulgham 2017-09-28 16:26:24 -0700 Comment on attachment 322139 added Thank you! r=me 1354364 15 basuke 2017-09-28 16:31:51 -0700 Oh my. It was already copied by PlatformWin.cmake! I don't judge the location of bundle copy. 1354375 16 322139 commit-queue 2017-09-28 16:53:01 -0700 Comment on attachment 322139 added Clearing flags on attachment: 322139 Committed r222639: <http://trac.webkit.org/changeset/222639> 1354376 17 commit-queue 2017-09-28 16:53:03 -0700 All reviewed patches have been landed. Closing bug. 1354379 18 commit-queue 2017-09-28 17:02:25 -0700 Re-opened since this is blocked by bug 177630 1607093 19 basuke 2020-01-15 12:47:52 -0800 The code was completely rewritten and this feature was implemented in it. 1607094 20 webkit-bug-importer 2020-01-15 12:48:09 -0800 <rdar://problem/58615544> 302675 2017-02-24 11:14:16 -0800 2017-02-24 11:18:29 -0800 Patch patch-168486.diff text/plain 1270 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOWI2 YmM5ZWJjNy4uMzRiNjc0MjAzNzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wMi0yNCAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAYW0uc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtNaW5p QnJvd3Nlcl0gQWRkIGNhLWJ1bmRsZSB0byBkaXNwbGF5IHNlY3VyZSBwYWdlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NDg2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4v Q01ha2VMaXN0cy50eHQ6CisKIDIwMTctMDItMjQgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBh cHBsZS5jb20+CiAKICAgICAgICAgUmVzb3VyY2UgTG9hZCBTdGF0aXN0aWNzOiBBZGQgYWx0ZXJu YXRlIGNsYXNzaWZpY2F0aW9uIG1ldGhvZApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIv d2luL0NNYWtlTGlzdHMudHh0IGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlzdHMudHh0 CmluZGV4IDQwNzRiMmNhMWZhLi5jZTA5ZTBmMDQyYSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJy b3dzZXIvd2luL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9DTWFr ZUxpc3RzLnR4dApAQCAtMzQsNiArMzQsMTEgQEAgaWYgKFdURl9QTEFURk9STV9XSU5fQ0FJUk8p CiAgICAgbGlzdChBUFBFTkQgTWluaUJyb3dzZXJfTElCUkFSSUVTCiAgICAgICAgIENGTGl0ZQog ICAgICkKKworICAgIHNldChNaW5pQnJvd3Nlcl9DQUJVTkRMRV9VUkwgImh0dHBzOi8vY3VybC5o YXh4LnNlL2NhL2NhY2VydC5wZW0iKQorICAgIHNldChNaW5pQnJvd3Nlcl9DRVJUSUZJQ0FURVNf RElSICR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfS9XZWJLaXQucmVzb3VyY2VzL2Nl cnRpZmljYXRlcykKKyAgICBtYWtlX2RpcmVjdG9yeSgke01pbmlCcm93c2VyX0NFUlRJRklDQVRF U19ESVJ9KQorICAgIGZpbGUoRE9XTkxPQUQgJHtNaW5pQnJvd3Nlcl9DQUJVTkRMRV9VUkx9ICIk e01pbmlCcm93c2VyX0NFUlRJRklDQVRFU19ESVJ9L2NhY2VydC5wZW0iIFNIT1dfUFJPR1JFU1Mp CiBlbHNlICgpCiAgICAgbGlzdChBUFBFTkQgTWluaUJyb3dzZXJfTElCUkFSSUVTCiAgICAgICAg IENvcmVGb3VuZGF0aW9uCg== 302677 2017-02-24 11:44:21 -0800 2017-02-24 14:19:49 -0800 Patch patch-168486.diff text/plain 2904 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZWMxODdiYjE2NS4uYmUwMDRiM2JjZDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMi0yNCAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAYW0u c29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtNaW5pQnJvd3Nlcl0gQWRkIGNhLWJ1bmRs ZSB0byBkaXNwbGF5IHNlY3VyZSBwYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgY2hhbmdlIHRoZSBvcmRlciBvZiBwYXRoIGxvY2F0aW9uIHNlYXJj aCB0byBtYWtlIGl0IHBvc3NpYmxlIHRvIAorICAgICAgICBjb25maWd1cmUgd2l0aCBlbnZpcm9u bWVudCB2YXJpYWJsZSBiZWNhdXNlIGJ1bmRsZWQgY2EtYnVuZGxlIGlzCisgICAgICAgIGFsd2F5 cyBhdmFpbGFibGUgbm93LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291 cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjZXJ0aWZpY2F0ZVBhdGgp OgorCiAyMDE3LTAyLTI0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW01hY11bY21ha2VdIFVucmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjIxMjczNi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJj ZUhhbmRsZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKaW5kZXggYTk5MjFkYmNlYTUuLjlkZmIwMTM5OWVi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcApAQCAtOTksNiArOTksMTAgQEAgc3RhdGlj IGNvbnN0IGJvb2wgaWdub3JlU1NMRXJyb3JzID0gZ2V0ZW52KCJXRUJLSVRfSUdOT1JFX1NTTF9F UlJPUlMiKTsKIAogc3RhdGljIENTdHJpbmcgY2VydGlmaWNhdGVQYXRoKCkKIHsKKyAgICBjaGFy KiBlbnZQYXRoID0gZ2V0ZW52KCJDVVJMX0NBX0JVTkRMRV9QQVRIIik7CisgICAgaWYgKGVudlBh dGgpCisgICAgICAgcmV0dXJuIGVudlBhdGg7CisKICNpZiBVU0UoQ0YpCiAgICAgQ0ZCdW5kbGVS ZWYgd2ViS2l0QnVuZGxlUmVmID0gd2ViS2l0QnVuZGxlKCk7CiAgICAgaWYgKHdlYktpdEJ1bmRs ZVJlZikgewpAQCAtMTEwLDkgKzExNCw2IEBAIHN0YXRpYyBDU3RyaW5nIGNlcnRpZmljYXRlUGF0 aCgpCiAgICAgICAgIH0KICAgICB9CiAjZW5kaWYKLSAgICBjaGFyKiBlbnZQYXRoID0gZ2V0ZW52 KCJDVVJMX0NBX0JVTkRMRV9QQVRIIik7Ci0gICAgaWYgKGVudlBhdGgpCi0gICAgICAgcmV0dXJu IGVudlBhdGg7CiAKICAgICByZXR1cm4gQ1N0cmluZygpOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMv Q2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDE5YjZiYzllYmM3Li4zNGI2NzQyMDM3 NiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEyIEBACisyMDE3LTAyLTI0ICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBh bS5zb255LmNvbT4KKworICAgICAgICBbV2luQ2Fpcm9dW01pbmlCcm93c2VyXSBBZGQgY2EtYnVu ZGxlIHRvIGRpc3BsYXkgc2VjdXJlIHBhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL3dpbi9DTWFrZUxpc3RzLnR4dDoKKwog MjAxNy0wMi0yNCAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXNvdXJjZSBMb2FkIFN0YXRpc3RpY3M6IEFkZCBhbHRlcm5hdGUgY2xhc3NpZmljYXRpb24g bWV0aG9kCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vQ01ha2VMaXN0cy50eHQg Yi9Ub29scy9NaW5pQnJvd3Nlci93aW4vQ01ha2VMaXN0cy50eHQKaW5kZXggNDA3NGIyY2ExZmEu LmNlMDllMGYwNDJhIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vQ01ha2VMaXN0 cy50eHQKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlzdHMudHh0CkBAIC0zNCw2 ICszNCwxMSBAQCBpZiAoV1RGX1BMQVRGT1JNX1dJTl9DQUlSTykKICAgICBsaXN0KEFQUEVORCBN aW5pQnJvd3Nlcl9MSUJSQVJJRVMKICAgICAgICAgQ0ZMaXRlCiAgICAgKQorCisgICAgc2V0KE1p bmlCcm93c2VyX0NBQlVORExFX1VSTCAiaHR0cHM6Ly9jdXJsLmhheHguc2UvY2EvY2FjZXJ0LnBl bSIpCisgICAgc2V0KE1pbmlCcm93c2VyX0NFUlRJRklDQVRFU19ESVIgJHtDTUFLRV9SVU5USU1F X09VVFBVVF9ESVJFQ1RPUll9L1dlYktpdC5yZXNvdXJjZXMvY2VydGlmaWNhdGVzKQorICAgIG1h a2VfZGlyZWN0b3J5KCR7TWluaUJyb3dzZXJfQ0VSVElGSUNBVEVTX0RJUn0pCisgICAgZmlsZShE T1dOTE9BRCAke01pbmlCcm93c2VyX0NBQlVORExFX1VSTH0gIiR7TWluaUJyb3dzZXJfQ0VSVElG SUNBVEVTX0RJUn0vY2FjZXJ0LnBlbSIgU0hPV19QUk9HUkVTUykKIGVsc2UgKCkKICAgICBsaXN0 KEFQUEVORCBNaW5pQnJvd3Nlcl9MSUJSQVJJRVMKICAgICAgICAgQ29yZUZvdW5kYXRpb24K 302689 2017-02-24 14:20:34 -0800 2017-02-27 11:41:47 -0800 Patch patch-168486.diff text/plain 2905 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZWMxODdiYjE2NS4uYmUwMDRiM2JjZDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMi0yNCAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAYW0u c29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtNaW5pQnJvd3Nlcl0gQWRkIGNhLWJ1bmRs ZSB0byBkaXNwbGF5IHNlY3VyZSBwYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgY2hhbmdlIHRoZSBvcmRlciBvZiBwYXRoIGxvY2F0aW9uIHNlYXJj aCB0byBtYWtlIGl0IHBvc3NpYmxlIHRvIAorICAgICAgICBjb25maWd1cmUgd2l0aCBlbnZpcm9u bWVudCB2YXJpYWJsZSBiZWNhdXNlIGJ1bmRsZWQgY2EtYnVuZGxlIGlzCisgICAgICAgIGFsd2F5 cyBhdmFpbGFibGUgbm93LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291 cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjZXJ0aWZpY2F0ZVBhdGgp OgorCiAyMDE3LTAyLTI0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW01hY11bY21ha2VdIFVucmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjIxMjczNi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJj ZUhhbmRsZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKaW5kZXggYTk5MjFkYmNlYTUuLmQ5Y2E1OTA1YmIy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcApAQCAtOTksNiArOTksMTAgQEAgc3RhdGlj IGNvbnN0IGJvb2wgaWdub3JlU1NMRXJyb3JzID0gZ2V0ZW52KCJXRUJLSVRfSUdOT1JFX1NTTF9F UlJPUlMiKTsKIAogc3RhdGljIENTdHJpbmcgY2VydGlmaWNhdGVQYXRoKCkKIHsKKyAgICBjaGFy KiBlbnZQYXRoID0gZ2V0ZW52KCJDVVJMX0NBX0JVTkRMRV9QQVRIIik7CisgICAgaWYgKGVudlBh dGgpCisgICAgICAgIHJldHVybiBlbnZQYXRoOworCiAjaWYgVVNFKENGKQogICAgIENGQnVuZGxl UmVmIHdlYktpdEJ1bmRsZVJlZiA9IHdlYktpdEJ1bmRsZSgpOwogICAgIGlmICh3ZWJLaXRCdW5k bGVSZWYpIHsKQEAgLTExMCw5ICsxMTQsNiBAQCBzdGF0aWMgQ1N0cmluZyBjZXJ0aWZpY2F0ZVBh dGgoKQogICAgICAgICB9CiAgICAgfQogI2VuZGlmCi0gICAgY2hhciogZW52UGF0aCA9IGdldGVu digiQ1VSTF9DQV9CVU5ETEVfUEFUSCIpOwotICAgIGlmIChlbnZQYXRoKQotICAgICAgIHJldHVy biBlbnZQYXRoOwogCiAgICAgcmV0dXJuIENTdHJpbmcoKTsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOWI2YmM5ZWJjNy4uMzRiNjc0MjAz NzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMiBAQAorMjAxNy0wMi0yNCAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lA YW0uc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtNaW5pQnJvd3Nlcl0gQWRkIGNhLWJ1 bmRsZSB0byBkaXNwbGF5IHNlY3VyZSBwYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4vQ01ha2VMaXN0cy50eHQ6CisK IDIwMTctMDItMjQgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVzb3VyY2UgTG9hZCBTdGF0aXN0aWNzOiBBZGQgYWx0ZXJuYXRlIGNsYXNzaWZpY2F0aW9u IG1ldGhvZApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlzdHMudHh0 IGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlzdHMudHh0CmluZGV4IDQwNzRiMmNhMWZh Li5jZTA5ZTBmMDQyYSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlz dHMudHh0CisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9DTWFrZUxpc3RzLnR4dApAQCAtMzQs NiArMzQsMTEgQEAgaWYgKFdURl9QTEFURk9STV9XSU5fQ0FJUk8pCiAgICAgbGlzdChBUFBFTkQg TWluaUJyb3dzZXJfTElCUkFSSUVTCiAgICAgICAgIENGTGl0ZQogICAgICkKKworICAgIHNldChN aW5pQnJvd3Nlcl9DQUJVTkRMRV9VUkwgImh0dHBzOi8vY3VybC5oYXh4LnNlL2NhL2NhY2VydC5w ZW0iKQorICAgIHNldChNaW5pQnJvd3Nlcl9DRVJUSUZJQ0FURVNfRElSICR7Q01BS0VfUlVOVElN RV9PVVRQVVRfRElSRUNUT1JZfS9XZWJLaXQucmVzb3VyY2VzL2NlcnRpZmljYXRlcykKKyAgICBt YWtlX2RpcmVjdG9yeSgke01pbmlCcm93c2VyX0NFUlRJRklDQVRFU19ESVJ9KQorICAgIGZpbGUo RE9XTkxPQUQgJHtNaW5pQnJvd3Nlcl9DQUJVTkRMRV9VUkx9ICIke01pbmlCcm93c2VyX0NFUlRJ RklDQVRFU19ESVJ9L2NhY2VydC5wZW0iIFNIT1dfUFJPR1JFU1MpCiBlbHNlICgpCiAgICAgbGlz dChBUFBFTkQgTWluaUJyb3dzZXJfTElCUkFSSUVTCiAgICAgICAgIENvcmVGb3VuZGF0aW9uCg== 302858 2017-02-27 11:43:10 -0800 2017-09-28 16:20:00 -0700 Patch patch-168486.diff text/plain 1635 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZWMxODdiYjE2NS4uYmUwMDRiM2JjZDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMi0yNCAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAYW0u c29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtNaW5pQnJvd3Nlcl0gQWRkIGNhLWJ1bmRs ZSB0byBkaXNwbGF5IHNlY3VyZSBwYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgY2hhbmdlIHRoZSBvcmRlciBvZiBwYXRoIGxvY2F0aW9uIHNlYXJj aCB0byBtYWtlIGl0IHBvc3NpYmxlIHRvIAorICAgICAgICBjb25maWd1cmUgd2l0aCBlbnZpcm9u bWVudCB2YXJpYWJsZSBiZWNhdXNlIGJ1bmRsZWQgY2EtYnVuZGxlIGlzCisgICAgICAgIGFsd2F5 cyBhdmFpbGFibGUgbm93LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291 cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjZXJ0aWZpY2F0ZVBhdGgp OgorCiAyMDE3LTAyLTI0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW01hY11bY21ha2VdIFVucmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjIxMjczNi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJj ZUhhbmRsZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKaW5kZXggYTk5MjFkYmNlYTUuLmQ5Y2E1OTA1YmIy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcApAQCAtOTksNiArOTksMTAgQEAgc3RhdGlj IGNvbnN0IGJvb2wgaWdub3JlU1NMRXJyb3JzID0gZ2V0ZW52KCJXRUJLSVRfSUdOT1JFX1NTTF9F UlJPUlMiKTsKIAogc3RhdGljIENTdHJpbmcgY2VydGlmaWNhdGVQYXRoKCkKIHsKKyAgICBjaGFy KiBlbnZQYXRoID0gZ2V0ZW52KCJDVVJMX0NBX0JVTkRMRV9QQVRIIik7CisgICAgaWYgKGVudlBh dGgpCisgICAgICAgIHJldHVybiBlbnZQYXRoOworCiAjaWYgVVNFKENGKQogICAgIENGQnVuZGxl UmVmIHdlYktpdEJ1bmRsZVJlZiA9IHdlYktpdEJ1bmRsZSgpOwogICAgIGlmICh3ZWJLaXRCdW5k bGVSZWYpIHsKQEAgLTExMCw5ICsxMTQsNiBAQCBzdGF0aWMgQ1N0cmluZyBjZXJ0aWZpY2F0ZVBh dGgoKQogICAgICAgICB9CiAgICAgfQogI2VuZGlmCi0gICAgY2hhciogZW52UGF0aCA9IGdldGVu digiQ1VSTF9DQV9CVU5ETEVfUEFUSCIpOwotICAgIGlmIChlbnZQYXRoKQotICAgICAgIHJldHVy biBlbnZQYXRoOwogCiAgICAgcmV0dXJuIENTdHJpbmcoKTsKIH0K 322139 2017-09-28 16:20:00 -0700 2017-09-28 16:53:01 -0700 added 168486-1.diff text/plain 1333 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMDM5 NDY5NmFlZC4uOWI0NDMyNzhkM2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wOS0yOCAgQmFzdWtlIFN1enVr aSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtNaW5pQnJv d3Nlcl0gQWRkIGNhLWJ1bmRsZSB0byBkaXNwbGF5IHNlY3VyZSBwYWdlcy4KKyAgICAgICAgQ29w eSBjYWNlcnQucGVtIGZpbGUgaW50byBidW5kbGUgZGlyZWN0b3J5LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4NDg2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci93aW4vQ01ha2VM aXN0cy50eHQ6CisKIDIwMTctMDktMjYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgW2lvcy1zaW11bGF0b3JdIEFQSSB0ZXN0IERhdGFJbnRlcmFjdGlv blRlc3RzLkV4dGVybmFsU291cmNlRGF0YVRyYW5zZmVySXRlbUdldEZvbGRlckFzRW50cnkgaXMg ZmFpbGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlzdHMudHh0 IGIvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlzdHMudHh0CmluZGV4IDc5NmYwMTVhOWJm Li4zYzJhMmUyNjFjYSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvd2luL0NNYWtlTGlz dHMudHh0CisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3dpbi9DTWFrZUxpc3RzLnR4dApAQCAtMzQs NiArMzQsMTAgQEAgaWYgKFVTRV9DRikKICAgICBsaXN0KEFQUEVORCBNaW5pQnJvd3Nlcl9MSUJS QVJJRVMKICAgICAgICAgJHtDT1JFRk9VTkRBVElPTl9MSUJSQVJZfQogICAgICkKKworICAgIHNl dChNaW5pQnJvd3Nlcl9DRVJUSUZJQ0FURVNfRElSICR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElS RUNUT1JZfS9XZWJLaXQucmVzb3VyY2VzL2NlcnRpZmljYXRlcykKKyAgICBtYWtlX2RpcmVjdG9y eSgke01pbmlCcm93c2VyX0NFUlRJRklDQVRFU19ESVJ9KQorICAgIGZpbGUoQ09QWSAiJHtXRUJL SVRfTElCUkFSSUVTX0RJUn0vY2FjZXJ0LnBlbSIgREVTVElOQVRJT04gJHtNaW5pQnJvd3Nlcl9D RVJUSUZJQ0FURVNfRElSfSkKIGVuZGlmICgpCiAKIHNldChDTUFLRV9TSEFSRURfTElOS0VSX0ZM QUdTICIke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1N9IC9OT0RFRkFVTFRMSUI6TVNWQ1JUIC9O T0RFRkFVTFRMSUI6TVNWQ1JURCIpCg==