168423 2017-02-16 05:00:55 -0800 [GTK] Test fast/shadow-dom/input-element-in-shadow.html is failing in the bots 2017-02-16 22:28:39 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply commit-queue darin koivisto lforschler mcatanzaro rniwa oldest_to_newest 1277618 0 cgarcia 2017-02-16 05:00:55 -0800 It's failing only because the result has the spell checker underline, while the the reference image doesn't. I don't know why the slot is spell checked and the input in the reference isn't, but we could make the test pass by using real words, since the contents are not important for this test. 1277619 1 301747 cgarcia 2017-02-16 05:02:57 -0800 Created attachment 301747 Patch 1277707 2 mcatanzaro 2017-02-16 09:36:35 -0800 I think you're changing the test to work around a real bug in our text checker. Entering a misspelled word should not trigger a spell checker underline until a separator character (space, period, etc.) is inserted, and this test does not insert such a separator character, so this test should not trigger the spell checker underline. On the other hand, this test is definitely not intended to test the text checker. I'll give Ryusuke a chance to review this since shadow DOM is his area, even if the change is trivial. 1277909 3 301747 rniwa 2017-02-16 14:37:08 -0800 Comment on attachment 301747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301747&action=review > LayoutTests/ChangeLog:10 > + by using real words, since the contents are not important for this test. Use "one", "two" instead of "abc", "def". That's because we use eventSender to type in text. Spellchecker only kicks in for user-typed text The fix is correct. 1278129 4 301747 commit-queue 2017-02-16 22:28:35 -0800 Comment on attachment 301747 Patch Clearing flags on attachment: 301747 Committed r212536: <http://trac.webkit.org/changeset/212536> 1278130 5 commit-queue 2017-02-16 22:28:39 -0800 All reviewed patches have been landed. Closing bug. 301747 2017-02-16 05:02:57 -0800 2017-02-16 22:28:35 -0800 Patch wk-ref-spell.diff text/plain 2081 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNWE1M2U0MDZkMy4uYzA5ZGQ3MzI1ODYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxNy0wMi0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0dUS10gVGVzdCBmYXN0L3NoYWRvdy1kb20vaW5wdXQtZWxlbWVudC1pbi1zaGFk b3cuaHRtbCBpcyBmYWlsaW5nIGluIHRoZSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg0MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIGZhaWxpbmcgb25seSBiZWNhdXNlIHRoZSByZXN1 bHQgaGFzIHRoZSBzcGVsbCBjaGVja2VyIHVuZGVybGluZSwgd2hpbGUgdGhlIHRoZSByZWZlcmVu Y2UgaW1hZ2UgZG9lc24ndC4gSQorICAgICAgICBkb24ndCBrbm93IHdoeSB0aGUgc2xvdCBpcyBz cGVsbCBjaGVja2VkIGFuZCB0aGUgaW5wdXQgaW4gdGhlIHJlZmVyZW5jZSBpc24ndCwgYnV0IHdl IGNvdWxkIG1ha2UgdGhlIHRlc3QgcGFzcworICAgICAgICBieSB1c2luZyByZWFsIHdvcmRzLCBz aW5jZSB0aGUgY29udGVudHMgYXJlIG5vdCBpbXBvcnRhbnQgZm9yIHRoaXMgdGVzdC4gVXNlICJv bmUiLCAidHdvIiBpbnN0ZWFkIG9mICJhYmMiLCAiZGVmIi4KKworICAgICAgICAqIGZhc3Qvc2hh ZG93LWRvbS9pbnB1dC1lbGVtZW50LWluLXNoYWRvdy1leHBlY3RlZC5odG1sOgorICAgICAgICAq IGZhc3Qvc2hhZG93LWRvbS9pbnB1dC1lbGVtZW50LWluLXNoYWRvdy5odG1sOgorCiAyMDE3LTAy LTE1ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIE1hcmsg aW5zcGVjdG9yL2RlYnVnZ2VyL3NlYXJjaC1zY3JpcHRzLmh0bWwgYXMgZmxha3kuCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vaW5wdXQtZWxlbWVudC1pbi1zaGFkb3ct ZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9pbnB1dC1lbGVtZW50 LWluLXNoYWRvdy1leHBlY3RlZC5odG1sCmluZGV4IDFkNDc3ZTliYzE0Li5mZDdmOTFkYzFhNSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2lucHV0LWVsZW1lbnQtaW4t c2hhZG93LWV4cGVjdGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2lu cHV0LWVsZW1lbnQtaW4tc2hhZG93LWV4cGVjdGVkLmh0bWwKQEAgLTUsOCArNSw4IEBACiA8Ym9k eT4KIFRlc3QgdGhhdCBpbnB1dCBlbGVtZW50cyBpbiBzaGFkb3cgdHJlZXMgdXBkYXRlIHdoZW4g dGV4dCBpcyBlbnRlcmVkLgogPGRpdj4KLTxpbnB1dCB2YWx1ZT0iYWJjIj48YnI+Ci08dGV4dGFy ZWE+ZGVmPC90ZXh0YXJlYT4KKzxpbnB1dCB2YWx1ZT0ib25lIj48YnI+Cis8dGV4dGFyZWE+dHdv PC90ZXh0YXJlYT4KIDwvZGl2PgogPC9ib2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2lucHV0LWVsZW1lbnQtaW4tc2hhZG93Lmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L3NoYWRvdy1kb20vaW5wdXQtZWxlbWVudC1pbi1zaGFkb3cuaHRtbAppbmRl eCAyNTdhMWQwNGMwNS4uZDNiMjVkYmJhYmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv c2hhZG93LWRvbS9pbnB1dC1lbGVtZW50LWluLXNoYWRvdy5odG1sCisrKyBiL0xheW91dFRlc3Rz L2Zhc3Qvc2hhZG93LWRvbS9pbnB1dC1lbGVtZW50LWluLXNoYWRvdy5odG1sCkBAIC0yNiw4ICsy Niw4IEBAIGZ1bmN0aW9uIGVudGVyVGV4dChzZWxlY3RvciwgY2hhcmFjdGVycykKICAgICB9CiB9 CiAKLWVudGVyVGV4dCgiaW5wdXQiLCAiYWJjIik7Ci1lbnRlclRleHQoInRleHRhcmVhIiwgImRl ZiIpOworZW50ZXJUZXh0KCJpbnB1dCIsICJvbmUiKTsKK2VudGVyVGV4dCgidGV4dGFyZWEiLCAi dHdvIik7CiAKIDwvc2NyaXB0PgogPC9odG1sPgo=