168403 2017-02-15 18:44:39 -0800 sync-layer-positions-after-scroll fails if run after non-stable-viewport-scroll due to extraneous layouts 2017-02-20 22:57:34 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 thorton webkit-unassigned ap lforschler simon.fraser oldest_to_newest 1277450 0 301685 thorton 2017-02-15 18:44:39 -0800 Created attachment 301685 logging If you remove the viewport meta tag added to sync-layer-positions-after-scroll in https://bugs.webkit.org/show_bug.cgi?id=168376, and then: run-webkit-tests -v --ios-simulator --no-retry-failures scrollingcoordinator/ios You will see sync-layer-positions-after-scroll fail. If you run it by itself, it does not. The attached logging is from a debugging session with smfr. For some reason, we get into a state where we are calling setViewportConstrainedObjectsNeedLayout repeatedly during scrolling with a fixedpos element, which breaks various assumptions of the test (causing the layer position to get set, and clearing the approximatePosition). It seems like this is related to changing scale or useFlexibleViewport, or something, and smfr says he's seen it before. 301685 2017-02-15 18:44:39 -0800 2017-02-15 18:44:39 -0800 logging smfr-logging.diff application/octet-stream 6287 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCA5Yzg1NTI1MDU0YS4uZDM0ZjJkOTQzZTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTI0ODUsNiArMjQ4NSw4IEBAIHZvaWQg RnJhbWVWaWV3OjpzZXRWaWV3cG9ydENvbnN0cmFpbmVkT2JqZWN0c05lZWRMYXlvdXQoKQogICAg IGlmICghaGFzVmlld3BvcnRDb25zdHJhaW5lZE9iamVjdHMoKSkKICAgICAgICAgcmV0dXJuOwog CisgICAgV1RGTG9nQWx3YXlzKCJzZXRWaWV3cG9ydENvbnN0cmFpbmVkT2JqZWN0c05lZWRMYXlv dXQoKSEiKTsKKwogICAgIGZvciAoYXV0byYgcmVuZGVyZXIgOiAqbV92aWV3cG9ydENvbnN0cmFp bmVkT2JqZWN0cykKICAgICAgICAgcmVuZGVyZXItPnNldE5lZWRzTGF5b3V0KCk7CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3Jk aW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5n Q29vcmRpbmF0b3IuY3BwCmluZGV4IGQwOGY1YTg3MmVmLi5kNjZhMzcxNjIwOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdD b29yZGluYXRvci5jcHAKQEAgLTM5OCw2ICszOTgsNyBAQCB2b2lkIEFzeW5jU2Nyb2xsaW5nQ29v cmRpbmF0b3I6OnJlY29uY2lsZVNjcm9sbGluZ1N0YXRlKEZyYW1lVmlldyYgZnJhbWVWaWV3LCBj bwogICAgIGZyYW1lVmlldy5zZXRJblByb2dyYW1tYXRpY1Njcm9sbChvbGRQcm9ncmFtbWF0aWNT Y3JvbGwpOwogCiAgICAgaWYgKCFwcm9ncmFtbWF0aWNTY3JvbGwgJiYgc2Nyb2xsaW5nTGF5ZXJQ b3NpdGlvbkFjdGlvbiAhPSBTY3JvbGxpbmdMYXllclBvc2l0aW9uQWN0aW9uOjpTZXQpIHsKKyAg ICAgICAgV1RGTG9nQWx3YXlzKCJBc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yOjpyZWNvbmNpbGVT Y3JvbGxpbmdTdGF0ZSwgc3RhYmxlPSVkLCBmaXhlZFBvc1k9JWQsIGhhc0xheW91dFZpZXdwb3J0 UmVjdD0lZCwgeT0lZiIsIGluU3RhYmxlU3RhdGUsIGZyYW1lVmlldy5yZWN0Rm9yRml4ZWRQb3Np dGlvbkxheW91dCgpLnkoKS50b0ludCgpLCAhIWxheW91dFZpZXdwb3J0UmVjdCwgbGF5b3V0Vmll d3BvcnRSZWN0ID8gbGF5b3V0Vmlld3BvcnRSZWN0LT55KCkgOiAtMSk7CiAgICAgICAgIGlmIChp blN0YWJsZVN0YXRlKQogICAgICAgICAgICAgcmVjb25jaWxlVmlld3BvcnRDb25zdHJhaW5lZExh eWVyUG9zaXRpb25zKGZyYW1lVmlldy5yZWN0Rm9yRml4ZWRQb3NpdGlvbkxheW91dCgpLCBzY3Jv bGxpbmdMYXllclBvc2l0aW9uQWN0aW9uKTsKICAgICAgICAgZWxzZSBpZiAobGF5b3V0Vmlld3Bv cnRSZWN0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nU3RhdGVGaXhlZE5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Ny b2xsaW5nU3RhdGVGaXhlZE5vZGUuY3BwCmluZGV4IDE3ZDAxNjU5NzRlLi42MDJiMjk2MjQ1MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVG aXhlZE5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z1N0YXRlRml4ZWROb2RlLmNwcApAQCAtNzYsNiArNzYsOCBAQCB2b2lkIFNjcm9sbGluZ1N0YXRl Rml4ZWROb2RlOjpyZWNvbmNpbGVMYXllclBvc2l0aW9uRm9yVmlld3BvcnRSZWN0KGNvbnN0IExh eW91dAogICAgICAgICBHcmFwaGljc0xheWVyKiBncmFwaGljc0xheWVyID0gc3RhdGljX2Nhc3Q8 R3JhcGhpY3NMYXllcio+KGxheWVyKCkpOwogCiAgICAgICAgIExPR19XSVRIX1NUUkVBTShDb21w b3NpdGluZywgc3RyZWFtIDw8ICJTY3JvbGxpbmdTdGF0ZUZpeGVkTm9kZTo6cmVjb25jaWxlTGF5 ZXJQb3NpdGlvbkZvclZpZXdwb3J0UmVjdCBzZXR0aW5nIHBvc2l0aW9uIG9mIGxheWVyICIgPDwg Z3JhcGhpY3NMYXllci0+cHJpbWFyeUxheWVySUQoKSA8PCAiIHRvICIgPDwgcG9zaXRpb24pOwor CisgICAgICAgIFdURkxvZ0Fsd2F5cygiU2Nyb2xsaW5nU3RhdGVGaXhlZE5vZGU6OnJlY29uY2ls ZUxheWVyUG9zaXRpb25Gb3JWaWV3cG9ydFJlY3Qgc2V0dGluZyBwb3NpdGlvbiBvZiBsYXllciAl bGx1IHRvICVmIHdpdGggYWN0aW9uICVkIiwgZ3JhcGhpY3NMYXllci0+cHJpbWFyeUxheWVySUQo KSwgcG9zaXRpb24ueSgpLCAoaW50KWFjdGlvbik7CiAgICAgICAgIAogICAgICAgICBzd2l0Y2gg KGFjdGlvbikgewogICAgICAgICBjYXNlIFNjcm9sbGluZ0xheWVyUG9zaXRpb25BY3Rpb246OlNl dDoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNz TGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXll ci5jcHAKaW5kZXggMmU5ODFjNjZjY2EuLjhiMTUwOWFmZGEwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcApAQCAtNzgyLDEyICs3 ODIsMTIgQEAgdm9pZCBHcmFwaGljc0xheWVyOjpkdW1wUHJvcGVydGllcyhUZXh0U3RyZWFtJiB0 cywgaW50IGluZGVudCwgTGF5ZXJUcmVlQXNUZXh0QmUKICAgICAgICAgdHMgPDwgIihiYWNrZmFj ZVZpc2liaWxpdHkgIiA8PCAobV9iYWNrZmFjZVZpc2liaWxpdHkgPyAidmlzaWJsZSIgOiAiaGlk ZGVuIikgPDwgIilcbiI7CiAgICAgfQogCi0gICAgaWYgKGJlaGF2aW9yICYgTGF5ZXJUcmVlQXNU ZXh0RGVidWcpIHsKKy8vICAgIGlmIChiZWhhdmlvciAmIExheWVyVHJlZUFzVGV4dERlYnVnKSB7 CiAgICAgICAgIHdyaXRlSW5kZW50KHRzLCBpbmRlbnQgKyAxKTsKICAgICAgICAgdHMgPDwgIihw cmltYXJ5LWxheWVyLWlkICIgPDwgcHJpbWFyeUxheWVySUQoKSA8PCAiKVxuIjsKICAgICAgICAg d3JpdGVJbmRlbnQodHMsIGluZGVudCArIDEpOwogICAgICAgICB0cyA8PCAiKGNsaWVudCAiIDw8 IHN0YXRpY19jYXN0PHZvaWQqPigmbV9jbGllbnQpIDw8ICIpXG4iOwotICAgIH0KKy8vICAgIH0K IAogICAgIGlmIChtX2JhY2tncm91bmRDb2xvci5pc1ZhbGlkKCkgJiYgbV9jbGllbnQuc2hvdWxk RHVtcFByb3BlcnR5Rm9yTGF5ZXIodGhpcywgImJhY2tncm91bmRDb2xvciIpKSB7CiAgICAgICAg IHdyaXRlSW5kZW50KHRzLCBpbmRlbnQgKyAxKTsKQEAgLTkzOCwxMCArOTM4LDE2IEBAIFRleHRT dHJlYW0mIG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYgdHMsIGNvbnN0IFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXI6OkN1c3RvbUFwcGVhCiAKIFN0cmluZyBHcmFwaGljc0xheWVyOjpsYXllclRyZWVBc1Rl eHQoTGF5ZXJUcmVlQXNUZXh0QmVoYXZpb3IgYmVoYXZpb3IpIGNvbnN0CiB7CisgICAgV1RGTG9n QWx3YXlzKCItLS0tLSBsYXllclRyZWVBc1RleHQhISIpOwogICAgIFRleHRTdHJlYW0gdHMoVGV4 dFN0cmVhbTo6TGluZU1vZGU6Ok11bHRpcGxlTGluZSwgVGV4dFN0cmVhbTo6Rm9ybWF0dGluZzo6 U1ZHU3R5bGVSZWN0KTsKIAogICAgIGR1bXBMYXllcih0cywgMCwgYmVoYXZpb3IpOwotICAgIHJl dHVybiB0cy5yZWxlYXNlKCk7CisKKyAgICBTdHJpbmcgb3V0ID0gdHMucmVsZWFzZSgpOworCisg ICAgV1RGTG9nQWx3YXlzKCIlcyIsIG91dC51dGY4KCkuZGF0YSgpKTsKKworICAgIHJldHVybiBv dXQ7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggMGE2YmYwMzgxNDcuLmE1ZDRjODU4 ZDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNr aW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5n LmNwcApAQCAtODY3LDYgKzg2Nyw4IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVH ZW9tZXRyeSgpCiAKICAgICBDb21wdXRlZE9mZnNldHMgY29tcG9zaXRlZEJvdW5kc09mZnNldCht X293bmluZ0xheWVyLCBjb21wb3NpdGVkQm91bmRzKCksIHBhcmVudEdyYXBoaWNzTGF5ZXJSZWN0 LCBwcmltYXJ5R3JhcGhpY3NMYXllclJlY3QpOwogICAgIG1fY29tcG9zaXRlZEJvdW5kc09mZnNl dEZyb21HcmFwaGljc0xheWVyID0gY29tcG9zaXRlZEJvdW5kc09mZnNldC5mcm9tUHJpbWFyeUdy YXBoaWNzTGF5ZXIoKTsKKyAgICBpZiAocmVuZGVyZXIoKS5zdHlsZSgpLnBvc2l0aW9uKCkgPT0g Rml4ZWRQb3NpdGlvbikKKyAgICAgICAgV1RGUmVwb3J0QmFja3RyYWNlKCk7CiAgICAgbV9ncmFw aGljc0xheWVyLT5zZXRQb3NpdGlvbihwcmltYXJ5R3JhcGhpY3NMYXllclJlY3QubG9jYXRpb24o KSk7CiAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRTaXplKHByaW1hcnlHcmFwaGljc0xheWVyUmVj dC5zaXplKCkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Mb2dnaW5n LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0xvZ2dpbmcuY3BwCmluZGV4IDllMDYzOGVi MGE1Li5kODk3MmE2MWEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTG9n Z2luZy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTG9nZ2luZy5jcHAKQEAgLTU2 LDYgKzU2LDggQEAgdm9pZCBpbml0aWFsaXplTG9nQ2hhbm5lbHNJZk5lY2Vzc2FyeSgpCiAgICAg aGF2ZUluaXRpYWxpemVkTG9nZ2luZ0NoYW5uZWxzID0gdHJ1ZTsKICAgICAKICAgICBXVEZJbml0 aWFsaXplTG9nQ2hhbm5lbFN0YXRlc0Zyb21TdHJpbmcobG9nQ2hhbm5lbHMsIGxvZ0NoYW5uZWxD b3VudCwgbG9nTGV2ZWxTdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsKKworICAgIFdlYktpdDJMb2dW aXNpYmxlUmVjdHMuc3RhdGUgPSBXVEZMb2dDaGFubmVsT247CiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll dy5tbQppbmRleCA2MjA2Zjg3NTUwOS4uYWRlOTRjOGM3MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0yMDQ3LDYgKzIwNDcsOCBA QCBzdGF0aWMgV2ViQ29yZTo6RmxvYXRQb2ludCBjb25zdHJhaW5Db250ZW50T2Zmc2V0KFdlYkNv cmU6OkZsb2F0UG9pbnQgY29udGVudE9mZgogCiAtICh2b2lkKXNjcm9sbFZpZXdEaWRTY3JvbGw6 KFVJU2Nyb2xsVmlldyAqKXNjcm9sbFZpZXcKIHsKKyAgICBXVEZMb2dBbHdheXMoInNjcm9sbFZp ZXdEaWRTY3JvbGwgdG8geT0lZiIsIHNjcm9sbFZpZXcuY29udGVudE9mZnNldC55KTsKKwogICAg IGlmICghW3NlbGYgdXNlc1N0YW5kYXJkQ29udGVudFZpZXddKQogICAgICAgICBbX2N1c3RvbUNv bnRlbnRWaWV3IHNjcm9sbFZpZXdEaWRTY3JvbGw6KFVJU2Nyb2xsVmlldyAqKXNjcm9sbFZpZXdd OwogCkBAIC0yMzIxLDYgKzIzMjMsNyBAQCBzdGF0aWMgYm9vbCBzY3JvbGxWaWV3Q2FuU2Nyb2xs KFVJU2Nyb2xsVmlldyAqc2Nyb2xsVmlldykKICAgICAgICAgZW5jbG9zZWRJblNjcm9sbGFibGVB bmNlc3RvclZpZXc6c2Nyb2xsVmlld0NhblNjcm9sbChbc2VsZiBfc2Nyb2xsZXJdKV07CiAKICAg ICB3aGlsZSAoIV92aXNpYmxlQ29udGVudFJlY3RVcGRhdGVDYWxsYmFja3MuaXNFbXB0eSgpKSB7 CisgICAgICAgIFdURkxvZ0Fsd2F5cygiLS0tLS0tIFNFTkRJTkcgVmlzaWJsZUNvbnRlbnRSZWN0 IHVwZGF0ZSBjYWxsYmFjayAoZm9yIHRlc3QpIik7CiAgICAgICAgIGF1dG8gY2FsbGJhY2sgPSBf dmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlQ2FsbGJhY2tzLnRha2VMYXN0KCk7CiAgICAgICAgIGNh bGxiYWNrKCk7CiAgICAgfQo=