168402 2017-02-15 18:38:32 -0800 JSC: fix compilation errors for MIPS 2017-03-13 17:34:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Other Linux RESOLVED FIXED P2 Normal --- 1 guijemont webkit-unassigned annulen commit-queue jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1277449 0 guijemont 2017-02-15 18:38:32 -0800 This is to introduce a patch that fixes misceallaneous issues for MIPS compilation (small missing bits). 1277457 1 301689 guijemont 2017-02-15 19:27:36 -0800 Created attachment 301689 Patch Patch by Suresh Kumar with small modifications by myself. 1277458 2 guijemont 2017-02-15 19:29:19 -0800 (In reply to comment #1) > Created attachment 301689 [details] > Patch > > Patch by Suresh Kumar with small modifications by myself. Note that there is a style error in the order of includes in MacroAssemblerMIPS.h. I don't know how to solve it since compilation fails if the includes are in the opposite order. I imagine this means we miss an include somewhere, but I could not find which one so far. 1277459 3 commit-queue 2017-02-15 19:30:16 -0800 Attachment 301689 did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1277761 4 guijemont 2017-02-16 11:15:41 -0800 (In reply to comment #2) > Note that there is a style error in the order of includes in > MacroAssemblerMIPS.h. I don't know how to solve it since compilation fails > if the includes are in the opposite order. I imagine this means we miss an > include somewhere, but I could not find which one so far. Note that MacroAssemblerX86Common.h has the same non-alphabetical order of includes. 1278062 5 guijemont 2017-02-16 18:30:15 -0800 Just fount that the header issue is due to AbstractMacroAssembler.h not including wtf/Vector.h, which means in some cases its use of Vector ends up using the template in wtf/Forward.h which requires 4 arguments. Will send a patch for that later tonight or tomorrow. 1278504 6 guijemont 2017-02-17 16:34:35 -0800 I proposed a patch for the header issue in https://bugs.webkit.org/show_bug.cgi?id=168537 but it seems to create compilation issues on Mac so I think I need to examine that further. 1287426 7 guijemont 2017-03-13 16:54:20 -0700 After further investigation, I don't think there is an easy fix for the header issue. Can this patch be accepted despite this issue? 1287430 8 301689 mark.lam 2017-03-13 17:05:48 -0700 Comment on attachment 301689 Patch rs=me 1287436 9 301689 commit-queue 2017-03-13 17:34:32 -0700 Comment on attachment 301689 Patch Clearing flags on attachment: 301689 Committed r213881: <http://trac.webkit.org/changeset/213881> 1287437 10 commit-queue 2017-03-13 17:34:36 -0700 All reviewed patches have been landed. Closing bug. 301689 2017-02-15 19:27:36 -0800 2017-03-13 17:34:32 -0700 Patch bug-168402-20170215212500.patch text/plain 3684 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 OTYzOWRiMzkwNDcwYzRkMGEzMTllY2E3ZjZlOGE4MDUwODk0ZTdhLi5lYzlkNTIxMWMwYzQwNjc5 YzMwNjczNzllOGVhOGRkODg2NjNmNDJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wMi0xNSAgU0t1bWFyTWV0cm8gIDxzLmt1bWFyQG1ldHJvbG9naWNh bC5jb20+CisKKyAgICAgICAgSlNDOiBmaXggY29tcGlsYXRpb24gZXJyb3JzIGZvciBNSVBTCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg0MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxl ci9NSVBTQXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6Ok1JUFNBc3NlbWJsZXI6OmZpbGxOb3Bz KToKKyAgICAgICAgQWRkZWQuCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQ Uy5oOgorICAgICAgICBBZGRlZCBNYWNyb0Fzc2VtYmxlck1JUFM6Om51bUdQUnMgYW5kIE1hY3Jv QXNzZW1ibGVyTUlQUzo6bnVtRlBScyAuCisgICAgICAgICogYnl0ZWNvZGUvSW5saW5lQWNjZXNz Lmg6CisgICAgICAgIChKU0M6OklubGluZUFjY2Vzczo6c2l6ZUZvclByb3BlcnR5QWNjZXNzKToK KyAgICAgICAgKEpTQzo6SW5saW5lQWNjZXNzOjpzaXplRm9yUHJvcGVydHlSZXBsYWNlKToKKyAg ICAgICAgKEpTQzo6SW5saW5lQWNjZXNzOjpzaXplRm9yTGVuZ3RoQWNjZXNzKToKKyAgICAgICAg QWRkZWQgTUlQUyBjYXNlcy4KKwogMjAxNy0wMi0xNCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVt b250QGlnYWxpYS5jb20+CiAKICAgICAgICAgTUlQUzogYWRkIG1pc3NpbmcgaW1wbGVtZW50YXRp b25zIG9mIGxvYWQ4U2lnbmVkRXh0ZW5kVG8zMigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCmluZGV4IGIxYzQyMzI2YzNiNjlkNmM2NTM0YTM0 OTVjZGNlNTljMDJiMDgzNTUuLmNhM2ZhODNjYmQzYWM2NjMzMWJlMDAyZjViY2YwNjVkMDI2YWEz NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2Vt Ymxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxl ci5oCkBAIC0zMiw2ICszMiw3IEBACiAKICNpbmNsdWRlICJBc3NlbWJsZXJCdWZmZXIuaCIKICNp bmNsdWRlICJKSVRDb21waWxhdGlvbkVmZm9ydC5oIgorI2luY2x1ZGUgPGxpbWl0cy5oPgogI2lu Y2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW5jbHVkZSA8d3RmL1NlZ21lbnRlZFZlY3Rvci5o PgogCkBAIC0xOTEsNyArMTkyLDE5IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIGVtaXRJbnN0 KDB4MDAwMDAwMDApOwogICAgIH0KKyAgICAKKyAgICBzdGF0aWMgdm9pZCBmaWxsTm9wcyh2b2lk KiBiYXNlLCBzaXplX3Qgc2l6ZSwgYm9vbCBpc0NvcHlpbmdUb0V4ZWN1dGFibGVNZW1vcnkpCisg ICAgeworICAgICAgICBVTlVTRURfUEFSQU0oaXNDb3B5aW5nVG9FeGVjdXRhYmxlTWVtb3J5KTsK KyAgICAgICAgUkVMRUFTRV9BU1NFUlQoIShzaXplICUgc2l6ZW9mKGludDMyX3QpKSk7CiAKKyAg ICAgICAgaW50MzJfdCogcHRyID0gc3RhdGljX2Nhc3Q8aW50MzJfdCo+KGJhc2UpOworICAgICAg ICBjb25zdCBzaXplX3QgbnVtMzJzID0gc2l6ZSAvIHNpemVvZihpbnQzMl90KTsKKyAgICAgICAg Y29uc3QgaW50MzJfdCBpbnNuID0gMHgwMDAwMDAwMDsKKyAgICAgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCBudW0zMnM7IGkrKykKKyAgICAgICAgICAgICpwdHIrKyA9IGluc247CisgICAgfQor ICAgIAogICAgIHZvaWQgc3luYygpCiAgICAgewogICAgICAgICBlbWl0SW5zdCgweDAwMDAwMDBm KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJNSVBTLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyTUlQUy5oCmluZGV4IDhkMGFjOTE1YTc5ODhiN2IyOTQ5ZDQ5NDdiYTRkZjZkMjZkZTM2MmUu LmJjNTRiMzcwMWNlYjg4OThiNTViMmY5YzM1YzYxYzNiODViMDUwZTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaApAQCAt MjgsMTQgKzI4LDE2IEBACiAKICNpZiBFTkFCTEUoQVNTRU1CTEVSKSAmJiBDUFUoTUlQUykKIAot I2luY2x1ZGUgIkFic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaCIKICNpbmNsdWRlICJNSVBTQXNzZW1i bGVyLmgiCisjaW5jbHVkZSAiQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oIgogCiBuYW1lc3BhY2Ug SlNDIHsKIAogY2xhc3MgTWFjcm9Bc3NlbWJsZXJNSVBTIDogcHVibGljIEFic3RyYWN0TWFjcm9B c3NlbWJsZXI8TUlQU0Fzc2VtYmxlciwgTWFjcm9Bc3NlbWJsZXJNSVBTPiB7CiBwdWJsaWM6CiAg ICAgdHlwZWRlZiBNSVBTUmVnaXN0ZXJzOjpGUFJlZ2lzdGVySUQgRlBSZWdpc3RlcklEOworICAg IHN0YXRpYyBjb25zdCB1bnNpZ25lZCBudW1HUFJzID0gMzI7CisgICAgc3RhdGljIGNvbnN0IHVu c2lnbmVkIG51bUZQUnMgPSAzMjsKIAogICAgIE1hY3JvQXNzZW1ibGVyTUlQUygpCiAgICAgICAg IDogbV9maXhlZFdpZHRoKGZhbHNlKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0lubGluZUFjY2Vzcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0lubGluZUFjY2Vzcy5oCmluZGV4IDM5MTBjNWIzYjk1ZjEzNWY0NTk0MzFmYTFlY2U1YmQ1NGZi ZTk2OGEuLmNhMDdlM2EyMDYzMTQ2YjQ1M2U0ZGExNWYzMjAzYTQ4NTk0MmRlZjMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9JbmxpbmVBY2Nlc3MuaAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvSW5saW5lQWNjZXNzLmgKQEAgLTU1LDYgKzU1 LDggQEAgcHVibGljOgogI2Vsc2UKICAgICAgICAgcmV0dXJuIDUyOwogI2VuZGlmCisjZWxpZiBD UFUoTUlQUykKKyAgICAgICAgcmV0dXJuIDcyOwogI2Vsc2UKICNlcnJvciAidW5zdXBwb3J0ZWQg cGxhdGZvcm0iCiAjZW5kaWYKQEAgLTc1LDYgKzc3LDggQEAgcHVibGljOgogI2Vsc2UKICAgICAg ICAgcmV0dXJuIDQ4OwogI2VuZGlmCisjZWxpZiBDUFUoTUlQUykKKyAgICAgICAgcmV0dXJuIDcy OwogI2Vsc2UKICNlcnJvciAidW5zdXBwb3J0ZWQgcGxhdGZvcm0iCiAjZW5kaWYKQEAgLTk4LDYg KzEwMiw4IEBAIHB1YmxpYzoKICNlbHNlCiAgICAgICAgIHNpemVfdCBzaXplID0gMzI7CiAjZW5k aWYKKyNlbGlmIENQVShNSVBTKQorICAgICAgICBzaXplX3Qgc2l6ZSA9IDU2OwogI2Vsc2UKICNl cnJvciAidW5zdXBwb3J0ZWQgcGxhdGZvcm0iCiAjZW5kaWYK