168400 2017-02-15 17:38:14 -0800 AX: Make form validation accessible on iOS 2017-02-16 10:09:02 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach cdumez commit-queue webkit-bug-importer oldest_to_newest 1277437 0 cfleizach 2017-02-15 17:38:14 -0800 Make form validation accessible on iOS <rdar://problem/30357253> 1277438 1 301680 cfleizach 2017-02-15 17:43:03 -0800 Created attachment 301680 patch 1277482 2 301680 cdumez 2017-02-15 20:39:41 -0800 Comment on attachment 301680 patch View in context: https://bugs.webkit.org/attachment.cgi?id=301680&action=review > Source/WebCore/platform/ios/ValidationBubbleIOS.mm:145 > + getUIAccessibilityPostNotification(getUIAccessibilityAnnouncementNotification(), m_message); I do not think you need the get prefix for the first one given the define statement above. 1277681 3 301772 cfleizach 2017-02-16 08:50:34 -0800 Created attachment 301772 patch 1277718 4 301772 commit-queue 2017-02-16 10:08:58 -0800 Comment on attachment 301772 patch Clearing flags on attachment: 301772 Committed r212441: <http://trac.webkit.org/changeset/212441> 1277719 5 commit-queue 2017-02-16 10:09:02 -0800 All reviewed patches have been landed. Closing bug. 301680 2017-02-15 17:43:03 -0800 2017-02-16 08:50:34 -0800 patch patch text/plain 2416 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjQxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAyLTE1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1ha2UgZm9ybSB2 YWxpZGF0aW9uIGFjY2Vzc2libGUgb24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBIaWRlIHRoZSBwb3BvdmVyIGNvbnRlbnQgb2YgZm9ybSB2YWxp ZGF0aW9uIGZyb20gYWNjZXNzaWJpbGl0eSAoc2luY2UgaXRzIG5vdCBpbnRlcmFjdGFibGUpCisg ICAgICAgIGFuZCBpbnN0ZWFkIGFubm91bmNlIHRoZSBtZXNzYWdlLgorCisgICAgICAgICogcGxh dGZvcm0vaW9zL1ZhbGlkYXRpb25CdWJibGVJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpWYWxp ZGF0aW9uQnViYmxlOjpzaG93KToKKwogMjAxNy0wMi0xNSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFtXZWJJRExdIFJlbW92ZSBjdXN0b20gY29udmVyc2lvbiBmcm9t IEZvbnRGYWNlIGNvZGUgYnkgdXNpbmcgYSBWYXJpYW50CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvVmFsaWRhdGlvbkJ1YmJsZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmFsaWRhdGlvbkJ1YmJsZUlPUy5tbQkocmV2aXNpb24gMjEy NDE3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1ZhbGlkYXRpb25CdWJibGVJT1Mu bW0JKHdvcmtpbmcgY29weSkKQEAgLTQxLDYgKzQxLDkgQEAKIFNPRlRfTElOS19DTEFTUyhVSUtp dCwgVUlWaWV3KTsKIFNPRlRfTElOS19DTEFTUyhVSUtpdCwgVUlWaWV3Q29udHJvbGxlcik7CiBT T0ZUX0xJTktfQ09OU1RBTlQoVUlLaXQsIFVJRm9udFRleHRTdHlsZUNhbGxvdXQsIFVJRm9udFRl eHRTdHlsZSk7CitTT0ZUX0xJTktfQ09OU1RBTlQoVUlLaXQsIFVJQWNjZXNzaWJpbGl0eUFubm91 bmNlbWVudE5vdGlmaWNhdGlvbiwgVUlBY2Nlc3NpYmlsaXR5Tm90aWZpY2F0aW9ucyk7CisjZGVm aW5lIFVJQWNjZXNzaWJpbGl0eVBvc3ROb3RpZmljYXRpb24gZ2V0VUlBY2Nlc3NpYmlsaXR5UG9z dE5vdGlmaWNhdGlvbgorU09GVF9MSU5LKFVJS2l0LCBVSUFjY2Vzc2liaWxpdHlQb3N0Tm90aWZp Y2F0aW9uLCB2b2lkLCAoVUlBY2Nlc3NpYmlsaXR5Tm90aWZpY2F0aW9ucyBuLCBpZCBhcmd1bWVu dCksIChuLCBhcmd1bWVudCkpOwogCiBAaW50ZXJmYWNlIFdlYlZhbGlkYXRpb25CdWJibGVUYXBS ZWNvZ25pemVyIDogTlNPYmplY3QKIEBlbmQKQEAgLTEzNCw3ICsxMzcsMTIgQEAKICAgICAvLyBQ cm90ZWN0IHRoZSB2YWxpZGF0aW9uIGJ1YmJsZSBzbyBpdCBzdGF5cyBhbGl2ZSB1bnRpbCBpdCBp cyBlZmZlY3RpdmVseSBwcmVzZW50ZWQuIFVJS2l0IGRvZXMgbm90IGRlYWwgbmljZWx5IHdpdGgK ICAgICAvLyBkaXNtaXNzaW5nIGEgcG9wb3ZlciB0aGF0IGlzIGJlaW5nIHByZXNlbnRlZC4KICAg ICBSZWZQdHI8VmFsaWRhdGlvbkJ1YmJsZT4gcHJvdGVjdGVkVGhpcyh0aGlzKTsKLSAgICBbbV9w cmVzZW50aW5nVmlld0NvbnRyb2xsZXIgcHJlc2VudFZpZXdDb250cm9sbGVyOm1fcG9wb3ZlckNv bnRyb2xsZXIuZ2V0KCkgYW5pbWF0ZWQ6Tk8gY29tcGxldGlvbjpbcHJvdGVjdGVkVGhpc10oKSB7 IH1dOworICAgIFttX3ByZXNlbnRpbmdWaWV3Q29udHJvbGxlciBwcmVzZW50Vmlld0NvbnRyb2xs ZXI6bV9wb3BvdmVyQ29udHJvbGxlci5nZXQoKSBhbmltYXRlZDpOTyBjb21wbGV0aW9uOltwcm90 ZWN0ZWRUaGlzXSgpIHsKKyAgICAgICAgLy8gSGlkZSB0aGlzIHBvcG92ZXIgZnJvbSBWb2ljZU92 ZXIgYW5kIGluc3RlYWQgYW5ub3VuY2UgdGhlIG1lc3NhZ2UuCisgICAgICAgIFtwcm90ZWN0ZWRU aGlzLT5tX3BvcG92ZXJDb250cm9sbGVyLmdldCgpLnZpZXcgc2V0QWNjZXNzaWJpbGl0eUVsZW1l bnRzSGlkZGVuOllFU107CisgICAgfV07CisKKyAgICBnZXRVSUFjY2Vzc2liaWxpdHlQb3N0Tm90 aWZpY2F0aW9uKGdldFVJQWNjZXNzaWJpbGl0eUFubm91bmNlbWVudE5vdGlmaWNhdGlvbigpLCBt X21lc3NhZ2UpOwogfQogCiBzdGF0aWMgVUlWaWV3Q29udHJvbGxlciAqZmFsbGJhY2tWaWV3Q29u dHJvbGxlcihVSVZpZXcgKnZpZXcpCg== 301772 2017-02-16 08:50:34 -0800 2017-02-16 10:08:58 -0800 patch patch text/plain 2413 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjQxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAyLTE1ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IE1ha2UgZm9ybSB2 YWxpZGF0aW9uIGFjY2Vzc2libGUgb24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjg0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBIaWRlIHRoZSBwb3BvdmVyIGNvbnRlbnQgb2YgZm9ybSB2YWxp ZGF0aW9uIGZyb20gYWNjZXNzaWJpbGl0eSAoc2luY2UgaXRzIG5vdCBpbnRlcmFjdGFibGUpCisg ICAgICAgIGFuZCBpbnN0ZWFkIGFubm91bmNlIHRoZSBtZXNzYWdlLgorCisgICAgICAgICogcGxh dGZvcm0vaW9zL1ZhbGlkYXRpb25CdWJibGVJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpWYWxp ZGF0aW9uQnViYmxlOjpzaG93KToKKwogMjAxNy0wMi0xNSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFtXZWJJRExdIFJlbW92ZSBjdXN0b20gY29udmVyc2lvbiBmcm9t IEZvbnRGYWNlIGNvZGUgYnkgdXNpbmcgYSBWYXJpYW50CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvVmFsaWRhdGlvbkJ1YmJsZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmFsaWRhdGlvbkJ1YmJsZUlPUy5tbQkocmV2aXNpb24gMjEy NDE3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1ZhbGlkYXRpb25CdWJibGVJT1Mu bW0JKHdvcmtpbmcgY29weSkKQEAgLTQxLDYgKzQxLDkgQEAKIFNPRlRfTElOS19DTEFTUyhVSUtp dCwgVUlWaWV3KTsKIFNPRlRfTElOS19DTEFTUyhVSUtpdCwgVUlWaWV3Q29udHJvbGxlcik7CiBT T0ZUX0xJTktfQ09OU1RBTlQoVUlLaXQsIFVJRm9udFRleHRTdHlsZUNhbGxvdXQsIFVJRm9udFRl eHRTdHlsZSk7CitTT0ZUX0xJTktfQ09OU1RBTlQoVUlLaXQsIFVJQWNjZXNzaWJpbGl0eUFubm91 bmNlbWVudE5vdGlmaWNhdGlvbiwgVUlBY2Nlc3NpYmlsaXR5Tm90aWZpY2F0aW9ucyk7CisjZGVm aW5lIFVJQWNjZXNzaWJpbGl0eVBvc3ROb3RpZmljYXRpb24gZ2V0VUlBY2Nlc3NpYmlsaXR5UG9z dE5vdGlmaWNhdGlvbgorU09GVF9MSU5LKFVJS2l0LCBVSUFjY2Vzc2liaWxpdHlQb3N0Tm90aWZp Y2F0aW9uLCB2b2lkLCAoVUlBY2Nlc3NpYmlsaXR5Tm90aWZpY2F0aW9ucyBuLCBpZCBhcmd1bWVu dCksIChuLCBhcmd1bWVudCkpOwogCiBAaW50ZXJmYWNlIFdlYlZhbGlkYXRpb25CdWJibGVUYXBS ZWNvZ25pemVyIDogTlNPYmplY3QKIEBlbmQKQEAgLTEzNCw3ICsxMzcsMTIgQEAKICAgICAvLyBQ cm90ZWN0IHRoZSB2YWxpZGF0aW9uIGJ1YmJsZSBzbyBpdCBzdGF5cyBhbGl2ZSB1bnRpbCBpdCBp cyBlZmZlY3RpdmVseSBwcmVzZW50ZWQuIFVJS2l0IGRvZXMgbm90IGRlYWwgbmljZWx5IHdpdGgK ICAgICAvLyBkaXNtaXNzaW5nIGEgcG9wb3ZlciB0aGF0IGlzIGJlaW5nIHByZXNlbnRlZC4KICAg ICBSZWZQdHI8VmFsaWRhdGlvbkJ1YmJsZT4gcHJvdGVjdGVkVGhpcyh0aGlzKTsKLSAgICBbbV9w cmVzZW50aW5nVmlld0NvbnRyb2xsZXIgcHJlc2VudFZpZXdDb250cm9sbGVyOm1fcG9wb3ZlckNv bnRyb2xsZXIuZ2V0KCkgYW5pbWF0ZWQ6Tk8gY29tcGxldGlvbjpbcHJvdGVjdGVkVGhpc10oKSB7 IH1dOworICAgIFttX3ByZXNlbnRpbmdWaWV3Q29udHJvbGxlciBwcmVzZW50Vmlld0NvbnRyb2xs ZXI6bV9wb3BvdmVyQ29udHJvbGxlci5nZXQoKSBhbmltYXRlZDpOTyBjb21wbGV0aW9uOltwcm90 ZWN0ZWRUaGlzXSgpIHsKKyAgICAgICAgLy8gSGlkZSB0aGlzIHBvcG92ZXIgZnJvbSBWb2ljZU92 ZXIgYW5kIGluc3RlYWQgYW5ub3VuY2UgdGhlIG1lc3NhZ2UuCisgICAgICAgIFtwcm90ZWN0ZWRU aGlzLT5tX3BvcG92ZXJDb250cm9sbGVyLmdldCgpLnZpZXcgc2V0QWNjZXNzaWJpbGl0eUVsZW1l bnRzSGlkZGVuOllFU107CisgICAgfV07CisKKyAgICBVSUFjY2Vzc2liaWxpdHlQb3N0Tm90aWZp Y2F0aW9uKGdldFVJQWNjZXNzaWJpbGl0eUFubm91bmNlbWVudE5vdGlmaWNhdGlvbigpLCBtX21l c3NhZ2UpOwogfQogCiBzdGF0aWMgVUlWaWV3Q29udHJvbGxlciAqZmFsbGJhY2tWaWV3Q29udHJv bGxlcihVSVZpZXcgKnZpZXcpCg==