168385 2017-02-15 12:31:15 -0800 Web Inspector: Split console should be allowed when docked bottom on Elements/Resources/Debugger/Storage tabs 2017-02-15 14:50:27 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes oldest_to_newest 1277303 0 hi 2017-02-15 12:31:15 -0800 Issue caused by r210911 <https://webkit.org/b/167075>. 1277349 1 301655 hi 2017-02-15 14:22:12 -0800 Created attachment 301655 Patch 1277353 2 301655 mattbaker 2017-02-15 14:26:54 -0800 Comment on attachment 301655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301655&action=review > Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:52 > + get supportsSplitContentBrowser() This override and the three that follow could be eliminated by changing ContentView.prototype.supportsSplitContentBrowser back to `return true`. This should work because of your change above. 1277359 3 301655 hi 2017-02-15 14:34:39 -0800 Comment on attachment 301655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301655&action=review >> Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js:52 >> + get supportsSplitContentBrowser() > > This override and the three that follow could be eliminated by changing ContentView.prototype.supportsSplitContentBrowser back to `return true`. This should work because of your change above. I figured that it would be safer to make the default functionality be no split console when docked bottom and use a whitelist style of enabling tabs that we know work. Then again we don't have many tabs so this doesn't matter too much. If you would prefer it to be switched then I can change it :D 1277371 4 301655 commit-queue 2017-02-15 14:50:18 -0800 Comment on attachment 301655 Patch Clearing flags on attachment: 301655 Committed r212400: <http://trac.webkit.org/changeset/212400> 1277372 5 commit-queue 2017-02-15 14:50:27 -0800 All reviewed patches have been landed. Closing bug. 301655 2017-02-15 14:22:12 -0800 2017-02-15 14:50:18 -0800 Patch bug-168385-20170215141937.patch text/plain 5215 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEzNjc1NDNkMzRmMWMwZDBjNzU1MjNjNzg5ZjJi NmE1ODg2Y2QxODEuLjFlYzNhOTA5YTk5NWEwMTg1NzQzMjdjMmY5NGI4OTNiMjg4NDFlMjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTAyLTE1ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFNwbGl0IGNvbnNvbGUgc2hvdWxkIGJlIGFsbG93ZWQgd2hlbiBkb2NrZWQgYm90dG9t IG9uIEVsZW1lbnRzL1Jlc291cmNlcy9EZWJ1Z2dlci9TdG9yYWdlIHRhYnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODM4NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNl L01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IudXBkYXRlRG9ja2VkU3RhdGUpOgorICAg ICAgICBJZiB0aGUgbmV3IGRvY2tlZCBjb25maWd1cmF0aW9uIGRvZXMgbm90IHN1cHBvcnQgdGhl IHNwbGl0IGNvbnNvbGUsIGhpZGUgaXQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L0RlYnVnZ2VyVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVidWdn ZXJUYWJDb250ZW50Vmlldy5wcm90b3R5cGUuZ2V0IHN1cHBvcnRzU3BsaXRDb250ZW50QnJvd3Nl cik6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9FbGVtZW50c1RhYkNvbnRlbnRWaWV3 LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVGFiQ29udGVudFZpZXcucHJvdG90 eXBlLmdldCBzdXBwb3J0c1NwbGl0Q29udGVudEJyb3dzZXIpOgorICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VzVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuUmVzb3VyY2VzVGFiQ29udGVudFZpZXcucHJvdG90eXBlLmdldCBzdXBwb3J0c1NwbGl0 Q29udGVudEJyb3dzZXIpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVRh YkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0b3JhZ2VUYWJDb250ZW50 Vmlldy5wcm90b3R5cGUuZ2V0IHN1cHBvcnRzU3BsaXRDb250ZW50QnJvd3Nlcik6CisKIDIwMTct MDItMTQgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogUlRMOiBhZGp1c3QgcGFkZGluZyBvZiBkYXNoYm9hcmQgaWNvbnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCAxNDZmNjJi YzQwMDgyNTFlNGQ1ZjFjYjc2Zjk0NGRhMGFhNDAwY2RjLi4zODMxNTJhMGQ4OGQxODAwOWNiMTU2 ZTUxZWYxYTJmZjYxMWI1MTg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC03NjYsNyArNzY2LDcgQEAgV2ViSW5zcGVjdG9yLnVw ZGF0ZURvY2tlZFN0YXRlID0gZnVuY3Rpb24oc2lkZSkKIAogICAgIHRoaXMuX3VwZGF0ZURvY2tO YXZpZ2F0aW9uSXRlbXMoKTsKIAotICAgIGlmICghdGhpcy5kb2NrZWRDb25maWd1cmF0aW9uU3Vw cG9ydHNTcGxpdENvbnRlbnRCcm93c2VyKCkgJiYgdGhpcy5pc1Nob3dpbmdTcGxpdENvbnNvbGUo KSkKKyAgICBpZiAoIXRoaXMuZG9ja2VkQ29uZmlndXJhdGlvblN1cHBvcnRzU3BsaXRDb250ZW50 QnJvd3NlcigpICYmICF0aGlzLmRvZXNDdXJyZW50VGFiU3VwcG9ydFNwbGl0Q29udGVudEJyb3dz ZXIoKSkKICAgICAgICAgdGhpcy5oaWRlU3BsaXRDb25zb2xlKCk7CiB9OwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EZWJ1Z2dlclRhYkNv bnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RGVidWdnZXJUYWJDb250ZW50Vmlldy5qcwppbmRleCA0ZjQ4ODU3ZTFlNmNiNTk5MWM0NDI0OTNm Y2NiMjM2NDRiZGM1M2IzLi5hMTU0MDZkYTExM2JlOWNkZjY0MGI3ZThiZjE1Mzk5ZTU2YWMxYjYw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9E ZWJ1Z2dlclRhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0RlYnVnZ2VyVGFiQ29udGVudFZpZXcuanMKQEAgLTQ5LDYgKzQ5LDEx IEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlclRhYkNvbnRlbnRWaWV3ID0gY2xhc3MgRGVidWdnZXJU YWJDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3Iu RGVidWdnZXJUYWJDb250ZW50Vmlldy5UeXBlOwogICAgIH0KIAorICAgIGdldCBzdXBwb3J0c1Nw bGl0Q29udGVudEJyb3dzZXIoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQor CiAgICAgY2FuU2hvd1JlcHJlc2VudGVkT2JqZWN0KHJlcHJlc2VudGVkT2JqZWN0KQogICAgIHsK ICAgICAgICAgaWYgKHJlcHJlc2VudGVkT2JqZWN0IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlNj cmlwdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0VsZW1lbnRzVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9FbGVtZW50c1RhYkNvbnRlbnRWaWV3LmpzCmluZGV4IDJlZGNiOGU4 N2FmZTExNzY3YzZkYjYzMGY1ZTdmYmIzM2NjOTI2YzcuLjliNGE3ZjI0NDhjZWM0OWI5ZjBmNTVl ODAzMzRmNzRlYWFlZDNhZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0VsZW1lbnRzVGFiQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRWxlbWVudHNUYWJDb250ZW50Vmlldy5q cwpAQCAtNjAsNiArNjAsMTEgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVGFiQ29udGVudFZpZXcg PSBjbGFzcyBFbGVtZW50c1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW4KICAgICAgICAgcmV0 dXJuIFdlYkluc3BlY3Rvci5FbGVtZW50c1RhYkNvbnRlbnRWaWV3LlR5cGU7CiAgICAgfQogCisg ICAgZ2V0IHN1cHBvcnRzU3BsaXRDb250ZW50QnJvd3NlcigpCisgICAgeworICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICB9CisKICAgICBjYW5TaG93UmVwcmVzZW50ZWRPYmplY3QocmVwcmVzZW50 ZWRPYmplY3QpCiAgICAgewogICAgICAgICByZXR1cm4gcmVwcmVzZW50ZWRPYmplY3QgaW5zdGFu Y2VvZiBXZWJJbnNwZWN0b3IuRE9NVHJlZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlc1RhYkNvbnRlbnRWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VzVGFiQ29udGVu dFZpZXcuanMKaW5kZXggOWQ0ODRhZjk2ZTkwZWJhMDJhMmZiZGI0OWVjZTcxMjBhYzI3MGQyZi4u NWQzOTYwN2Q2ODhjMjAxN2ZhYjY4MTQ1YWQ3ODUzZWQ2MjhiNWE1MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VzVGFiQ29udGVu dFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UmVzb3VyY2VzVGFiQ29udGVudFZpZXcuanMKQEAgLTU0LDYgKzU0LDExIEBAIFdlYkluc3BlY3Rv ci5SZXNvdXJjZXNUYWJDb250ZW50VmlldyA9IGNsYXNzIFJlc291cmNlc1RhYkNvbnRlbnRWaWV3 IGV4dGVuZHMgV2ViCiAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuUmVzb3VyY2VzVGFiQ29u dGVudFZpZXcuVHlwZTsKICAgICB9CiAKKyAgICBnZXQgc3VwcG9ydHNTcGxpdENvbnRlbnRCcm93 c2VyKCkKKyAgICB7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKwogICAgIGNhblNob3dS ZXByZXNlbnRlZE9iamVjdChyZXByZXNlbnRlZE9iamVjdCkKICAgICB7CiAgICAgICAgIHJldHVy biByZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5GcmFtZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVRh YkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvU3RvcmFnZVRhYkNvbnRlbnRWaWV3LmpzCmluZGV4IGQ0NDNlMzQzNmMyYWM0NmY5YzlmNzI5 MjZhZDc0MTk3ZWI0ZDU3NGEuLjQwNDY3ZjAzMGMzZmE3ZjRjYjhiM2RlYzQwZTE5YzUyMWNjOGI1 MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1N0b3JhZ2VUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9TdG9yYWdlVGFiQ29udGVudFZpZXcuanMKQEAgLTU0LDYgKzU0LDEx IEBAIFdlYkluc3BlY3Rvci5TdG9yYWdlVGFiQ29udGVudFZpZXcgPSBjbGFzcyBTdG9yYWdlVGFi Q29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbnNwCiAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3Iu U3RvcmFnZVRhYkNvbnRlbnRWaWV3LlR5cGU7CiAgICAgfQogCisgICAgZ2V0IHN1cHBvcnRzU3Bs aXRDb250ZW50QnJvd3NlcigpCisgICAgeworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisK ICAgICBjYW5TaG93UmVwcmVzZW50ZWRPYmplY3QocmVwcmVzZW50ZWRPYmplY3QpCiAgICAgewog ICAgICAgICByZXR1cm4gcmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3Iu RE9NU3RvcmFnZU9iamVjdCB8fCByZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFdlYkluc3Bl Y3Rvci5Db29raWVTdG9yYWdlT2JqZWN0IHx8Cg==