168372 2017-02-15 09:03:46 -0800 webkitpy: Fix DarwinPort._get_crash_log() 2017-02-15 12:02:48 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue dbates glenn lforschler webkit-bug-importer oldest_to_newest 1277206 0 jbedard 2017-02-15 09:03:46 -0800 DarwinPort's implementation of _get_crash_log will cause run-webkit-tests to crash unless classes which inherit from DarwinPort re-implement this function. DarwinPort's implementation of _get_crash_log should be valid, even though it is expected to be re-implemented by inheriting classes. 1277208 1 webkit-bug-importer 2017-02-15 09:04:16 -0800 <rdar://problem/30535156> 1277221 2 301626 jbedard 2017-02-15 09:13:54 -0800 Created attachment 301626 Patch 1277265 3 301626 dbates 2017-02-15 10:45:13 -0800 Comment on attachment 301626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301626&action=review > Tools/ChangeLog:10 > + crash unless classes which inherit from DarwinPort re-implement this function. What do you by crash? Raise an exception? If so, be specific. Also it is an unwritten convention to wrap ChangeLog lines at around 100 characters 1277277 4 301636 jbedard 2017-02-15 11:25:26 -0800 Created attachment 301636 Patch for landing 1277299 5 301636 commit-queue 2017-02-15 12:02:41 -0800 Comment on attachment 301636 Patch for landing Clearing flags on attachment: 301636 Committed r212387: <http://trac.webkit.org/changeset/212387> 1277300 6 commit-queue 2017-02-15 12:02:48 -0800 All reviewed patches have been landed. Closing bug. 301626 2017-02-15 09:13:54 -0800 2017-02-15 11:25:21 -0800 Patch bug-168372-20170215091119.patch text/plain 1660 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMjM2NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTAyLTE1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogRml4IERhcndpblBvcnQuX2dldF9jcmFzaF9sb2coKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4MzcyCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDUzNTE1Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEYXJ3aW5Qb3J0J3MgaW1wbGVtZW50YXRpb24gb2Yg X2dldF9jcmFzaF9sb2cgd2lsbCBjYXVzZSBydW4td2Via2l0LXRlc3RzIHRvCisgICAgICAgIGNy YXNoIHVubGVzcyBjbGFzc2VzIHdoaWNoIGluaGVyaXQgZnJvbSBEYXJ3aW5Qb3J0IHJlLWltcGxl bWVudCB0aGlzIGZ1bmN0aW9uLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rh cndpbi5weToKKyAgICAgICAgKERhcndpblBvcnQuX2dldF9jcmFzaF9sb2cpOiBDYWxsIHBhcmVu dCBjbGFzcydzIGltcGxlbWVudGF0aW9uIG9mIF9nZXRfY3Jhc2hfbG9nLgorCiAyMDE3LTAyLTE1 ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb U09VUF0gQ3JlZGVudGlhbHMgc3RvcmVkIGJ5IGxpYnNvdXAgYXJlIHVzZWQgZXZlbiBTdG9yZWRD cmVkZW50aWFscyBwb2xpY3kgaXMgRG9Ob3RBbGxvd1N0b3JlZENyZWRlbnRpYWxzCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFyd2luLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kYXJ3aW4ucHkJKHJldmlzaW9uIDIxMjM2NCkKKysrIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kYXJ3aW4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTEw MSw3ICsxMDEsNyBAQCBjbGFzcyBEYXJ3aW5Qb3J0KEFwcGxlUG9ydCk6CiAgICAgICAgIHJldHVy biBjcmFzaF9sb2cuZmluZF9hbGxfbG9ncyhpbmNsdWRlX2Vycm9ycz1UcnVlLCBuZXdlcl90aGFu PW5ld2VyX3RoYW4pCiAKICAgICBkZWYgX2dldF9jcmFzaF9sb2coc2VsZiwgbmFtZSwgcGlkLCBz dGRvdXQsIHN0ZGVyciwgbmV3ZXJfdGhhbiwgdGltZV9mbj1Ob25lLCBzbGVlcF9mbj1Ob25lLCB3 YWl0X2Zvcl9sb2c9VHJ1ZSk6Ci0gICAgICAgIHJldHVybiBOb25lCisgICAgICAgIHJldHVybiBz dXBlcihEYXJ3aW5Qb3J0LCBzZWxmKS5fZ2V0X2NyYXNoX2xvZyhuYW1lLCBwaWQsIHN0ZG91dCwg c3RkZXJyLCBuZXdlcl90aGFuKQogCiAgICAgZGVmIGxvb2tfZm9yX25ld19jcmFzaF9sb2dzKHNl bGYsIGNyYXNoZWRfcHJvY2Vzc2VzLCBzdGFydF90aW1lKToKICAgICAgICAgIiIiU2luY2UgY3Jh c2ggbG9ncyBjYW4gdGFrZSBhIGxvbmcgdGltZSB0byBiZSB3cml0dGVuIG91dCBpZiB0aGUgc3lz dGVtIGlzCg== 301636 2017-02-15 11:25:26 -0800 2017-02-15 12:02:41 -0800 Patch for landing bug-168372-20170215112251.patch text/plain 1613 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMjM4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTAyLTE1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogRml4IERhcndpblBvcnQuX2dldF9jcmFzaF9sb2coKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4MzcyCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDUzNTE1Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBE YW5pZWwgQmF0ZXMuCisKKyAgICAgICAgQ2FsbGVycyBvZiBfZ2V0X2NyYXNoX2xvZyBleHBlY3Qg YSBwYWlyIHRvIGJlIHJldHVybmVkIGFuZCBkbyBub3QgY2hlY2sgaXQncyByZXR1cm4gdmFsdWUu ICAKKyAgICAgICAgRGFyd2luUG9ydCBzaG91bGQgcmV0dXJuIHRoZSBleHBlY3RlZCByZXR1cm4g dmFsdWUgZm9yIF9nZXRfY3Jhc2hfbG9nLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9w b3J0L2Rhcndpbi5weToKKyAgICAgICAgKERhcndpblBvcnQuX2dldF9jcmFzaF9sb2cpOiBDYWxs IHBhcmVudCBjbGFzcydzIGltcGxlbWVudGF0aW9uIG9mIF9nZXRfY3Jhc2hfbG9nLgorCiAyMDE3 LTAyLTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g Rm9ybSBWYWxpZGF0aW9uIEJ1YmJsZSBzaG91bGQgYmUgc2Vuc2l0aXZlIHRvIER5bmFtaWMgVHlw ZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Rhcndpbi5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFyd2luLnB5CShyZXZpc2lvbiAyMTIz ODApCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFyd2luLnB5CSh3b3JraW5nIGNv cHkpCkBAIC0xMDEsNyArMTAxLDcgQEAgY2xhc3MgRGFyd2luUG9ydChBcHBsZVBvcnQpOgogICAg ICAgICByZXR1cm4gY3Jhc2hfbG9nLmZpbmRfYWxsX2xvZ3MoaW5jbHVkZV9lcnJvcnM9VHJ1ZSwg bmV3ZXJfdGhhbj1uZXdlcl90aGFuKQogCiAgICAgZGVmIF9nZXRfY3Jhc2hfbG9nKHNlbGYsIG5h bWUsIHBpZCwgc3Rkb3V0LCBzdGRlcnIsIG5ld2VyX3RoYW4sIHRpbWVfZm49Tm9uZSwgc2xlZXBf Zm49Tm9uZSwgd2FpdF9mb3JfbG9nPVRydWUpOgotICAgICAgICByZXR1cm4gTm9uZQorICAgICAg ICByZXR1cm4gc3VwZXIoRGFyd2luUG9ydCwgc2VsZikuX2dldF9jcmFzaF9sb2cobmFtZSwgcGlk LCBzdGRvdXQsIHN0ZGVyciwgbmV3ZXJfdGhhbikKIAogICAgIGRlZiBsb29rX2Zvcl9uZXdfY3Jh c2hfbG9ncyhzZWxmLCBjcmFzaGVkX3Byb2Nlc3Nlcywgc3RhcnRfdGltZSk6CiAgICAgICAgICIi IlNpbmNlIGNyYXNoIGxvZ3MgY2FuIHRha2UgYSBsb25nIHRpbWUgdG8gYmUgd3JpdHRlbiBvdXQg aWYgdGhlIHN5c3RlbSBpcwo=