<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>168361</bug_id>
          
          <creation_ts>2017-02-15 02:32:25 -0800</creation_ts>
          <short_desc>Handle EINTR during webkitpy server process select()</short_desc>
          <delta_ts>2017-02-20 04:25:01 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Florian Bruhin">webkit.org</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>annulen</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>glenn</cc>
    
    <cc>lforschler</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1277136</commentid>
    <comment_count>0</comment_count>
    <who name="Florian Bruhin">webkit.org</who>
    <bug_when>2017-02-15 02:32:25 -0800</bug_when>
    <thetext>Otherwise, on my machine, resizing the terminal run-webkit-tests is running in makes it die.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1277137</commentid>
    <comment_count>1</comment_count>
      <attachid>301600</attachid>
    <who name="Florian Bruhin">webkit.org</who>
    <bug_when>2017-02-15 02:35:08 -0800</bug_when>
    <thetext>Created attachment 301600
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1277578</commentid>
    <comment_count>2</comment_count>
      <attachid>301600</attachid>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2017-02-16 03:00:43 -0800</bug_when>
    <thetext>Comment on attachment 301600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301600&amp;action=review

(Note: This is an informal review)

Just a small nit, otherwise it looks fine.

&gt; Tools/Scripts/webkitpy/port/server_process.py:250
&gt; +            if e.args[0] in [errno.EINVAL, errno.EINTR]:

I would use a tuple here, i.e:

   if e.args[0] in (errno.EINVAL, errno.EINTR):</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1277610</commentid>
    <comment_count>3</comment_count>
    <who name="Florian Bruhin">webkit.org</who>
    <bug_when>2017-02-16 04:46:57 -0800</bug_when>
    <thetext>&gt;&gt; Tools/Scripts/webkitpy/port/server_process.py:250
&gt;&gt; +            if e.args[0] in [errno.EINVAL, errno.EINTR]:
&gt;
&gt; I would use a tuple here, i.e:
&gt;
&gt;   if e.args[0] in (errno.EINVAL, errno.EINTR):

I&apos;m curious - why? I view a tuple mostly as structured heterogeneous collections of data where the order/length matter (e.g., a (name, age) tuple), and a list as a collection of heterogeneous collection (i.e. a list of error numbers, like here).

If this is about tuples being immutable, that doesn&apos;t really matter much IMHO when used as literals like here.

FWIW I&apos;m happy to change it, but I&apos;d like to understand why :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1277701</commentid>
    <comment_count>4</comment_count>
      <attachid>301600</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-02-16 09:30:48 -0800</bug_when>
    <thetext>Comment on attachment 301600
Patch

[(I don&apos;t care if it&apos;s a tuple or a list. Ping again to ask for cq+ after sorting it out.)]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1278899</commentid>
    <comment_count>5</comment_count>
      <attachid>301600</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-20 04:24:57 -0800</bug_when>
    <thetext>Comment on attachment 301600
Patch

Clearing flags on attachment: 301600

Committed r212631: &lt;http://trac.webkit.org/changeset/212631&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1278900</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-20 04:25:01 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>301600</attachid>
            <date>2017-02-15 02:35:08 -0800</date>
            <delta_ts>2017-02-20 04:24:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-168361-20170215113143.patch</filename>
            <type>text/plain</type>
            <size>1642</size>
            <attacher name="Florian Bruhin">webkit.org</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMzUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWNlNDFlYjVhNmIzOWJiZmZkYmJlMjUxMGE5NWQ1MmE4
NGQ3N2U4Ny4uMzk4ODc1MDA0YjEwZDJmZjBmYTBjYjVhY2Q1NjU2NzJhOTNiYjlkZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDE3LTAyLTE1ICBGbG9yaWFuIEJydWhpbiAgPGdpdEB0aGUtY29tcGlsZXIub3JnPgor
CisgICAgICAgIEhhbmRsZSBFSU5UUiBkdXJpbmcgd2Via2l0cHkgc2VydmVyIHByb2Nlc3Mgc2Vs
ZWN0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2
ODM2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE90
aGVyd2lzZSwgb24gbXkgbWFjaGluZSwgcmVzaXppbmcgdGhlIHRlcm1pbmFsIHJ1bi13ZWJraXQt
dGVzdHMgaXMgcnVubmluZyBpbgorICAgICAgICBtYWtlcyBpdCBkaWUuCisKKyAgICAgICAgKiBT
Y3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHk6CisgICAgICAgIChTZXJ2ZXJQ
cm9jZXNzLl93YWl0X2Zvcl9kYXRhX2FuZF91cGRhdGVfYnVmZmVyc191c2luZ19zZWxlY3QpOgor
CiAyMDE3LTAyLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K
IAogICAgICAgICBbR1RLXSBVcGRhdGUgY29va2llIG1hbmFnZXIgQVBJIHRvIHByb3Blcmx5IHdv
cmsgd2l0aCBlcGhlbWVyYWwgc2Vzc2lvbnMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi
a2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y
dC9zZXJ2ZXJfcHJvY2Vzcy5weQppbmRleCA1NzVlNDk2NDE0M2YwZWY5NjAyZTRjZjVhZjczN2Iz
YmJlMTEwYTZkLi4zZThjNDg3ZmM3NjQ1MWIwNjU3YTdkMmY4ZjUwYjdiNGYyNDUxODA4IDEwMDY0
NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKKysr
IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5CkBAIC0yNDUs
NyArMjQ1LDkgQEAgY2xhc3MgU2VydmVyUHJvY2VzcyhvYmplY3QpOgogICAgICAgICBleGNlcHQg
c2VsZWN0LmVycm9yLCBlOgogICAgICAgICAgICAgIyBXZSBjYW4gaWdub3JlIEVJTlZBTCBzaW5j
ZSBpdCdzIGxpa2VseSB0aGUgcHJvY2VzcyBqdXN0IGNyYXNoZWQgYW5kIHdlJ2xsCiAgICAgICAg
ICAgICAjIGZpZ3VyZSB0aGF0IG91dCB0aGUgbmV4dCB0aW1lIHRocm91Z2ggdGhlIGxvb3AgaW4g
X3JlYWQoKS4KLSAgICAgICAgICAgIGlmIGUuYXJnc1swXSA9PSBlcnJuby5FSU5WQUw6CisgICAg
ICAgICAgICAjIFdlIGFsc28gaWdub3JlIEVJTlRSIGFzIHdlIGNhbiByZXN1bWUgcmVhZGluZyB0
aGUgbmV4dCB0aW1lCisgICAgICAgICAgICAjIHRocm91Z2ggdGhlIGxvb3AgaW4gX3JlYWQoKS4K
KyAgICAgICAgICAgIGlmIGUuYXJnc1swXSBpbiBbZXJybm8uRUlOVkFMLCBlcnJuby5FSU5UUl06
CiAgICAgICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgICAgICByYWlzZQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>