168350 2017-02-14 19:01:02 -0800 JSC: missing implementations of MacroAssemblerMIPS::load8SignedExtendTo32() 2017-02-15 20:25:08 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 guijemont webkit-unassigned commit-queue keith_miller mark.lam msaboff ossy saam oldest_to_newest 1277032 0 guijemont 2017-02-14 19:01:02 -0800 Some implementations of MacroAssemblerMIPS::load8SignedExtendTo32() are missing, which prevents compilation on MIPS. 1277035 1 301574 guijemont 2017-02-14 19:23:53 -0800 Created attachment 301574 Patch Proposed patch to add missing implementations. 1277036 2 guijemont 2017-02-14 19:24:57 -0800 I'm in the process of sending a bunch of patches that make MIPS work again, more to come tomorrow. 1277195 3 ossy 2017-02-15 08:42:03 -0800 Just a note, this function is needed 3 months ago - https://trac.webkit.org/changeset/208450. Wouldn't be better to have a MIPS buildbot to notice similar breakages in time? 1277203 4 guijemont 2017-02-15 08:55:52 -0800 (In reply to comment #3) > Just a note, this function is needed 3 months ago - > https://trac.webkit.org/changeset/208450. Wouldn't be better to have a MIPS > buildbot to notice similar breakages in time? Absolutely! That's why we are working on that, but first we wanted to get things to a state where they build. 1277205 5 301574 ysuzuki 2017-02-15 08:58:48 -0800 Comment on attachment 301574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301574&action=review r=me with a fix. > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:764 > + } Looks good. > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:796 > + load8(address.m_ptr, dest); Why is it OK? I think we should use load8SignedExtendTo32 here (and delegate to `void load8SignedExtendTo32(const void* address, RegisterID dest)`), correct? > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:806 > + m_assembler.lb(dest, addrTempRegister, 0); OK. The difference from load8 is using lb instead of lbu. 1277290 6 301639 guijemont 2017-02-15 11:45:15 -0800 Created attachment 301639 Patch Corrected patch, thanks for the review! 1277469 7 301639 ysuzuki 2017-02-15 19:59:30 -0800 Comment on attachment 301639 Patch r=me 1277479 8 301639 commit-queue 2017-02-15 20:25:03 -0800 Comment on attachment 301639 Patch Clearing flags on attachment: 301639 Committed r212419: <http://trac.webkit.org/changeset/212419> 1277480 9 commit-queue 2017-02-15 20:25:08 -0800 All reviewed patches have been landed. Closing bug. 301574 2017-02-14 19:23:53 -0800 2017-02-15 11:45:06 -0800 Patch bug-168350-20170214212118.patch text/plain 2752 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MGFiY2MwMDg0YTJjMjg4Njc1MGFkNWMxYTNjMzI2YjZjZWJhZmJjLi43OTYzOWRiMzkwNDcwYzRk MGEzMTllY2E3ZjZlOGE4MDUwODk0ZTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wMi0xNCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgTUlQUzogYWRkIG1pc3NpbmcgaW1wbGVtZW50YXRpb25zIG9mIGxv YWQ4U2lnbmVkRXh0ZW5kVG8zMigpCisKKyAgICAgICAgSlNDOiBtaXNzaW5nIGltcGxlbWVudGF0 aW9ucyBvZiBNYWNyb0Fzc2VtYmxlck1JUFM6OmxvYWQ4U2lnbmVkRXh0ZW5kVG8zMigpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgzNTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9N YWNyb0Fzc2VtYmxlck1JUFMuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjps b2FkOFNpZ25lZEV4dGVuZFRvMzIpOgorICAgICAgICBBZGQgbWlzc2luZyBpbXBsZW1lbnRhdGlv bnMKKwogMjAxNy0wMi0xNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIEpTQ19zd2VlcFN5bmNocm9ub3VzbHkgYW5kIGZpeCBKU0NfdXNlWm9tYmllTW9kZSBv cHRpb25zLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlck1JUFMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJNSVBTLmgKaW5kZXggYTY4OGU5ODBkOWQ0OTY5YmNlZGYxNzMzN2FiN2U1ZDhlM2I0 OGE4OS4uM2RiYmNiZDMyMTM4OTFiZjYzNWJkY2YzYmU3NmM4NDQ0NzU3MWYyOSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5o CkBAIC03NDYsNiArNzQ2LDIzIEBAIHB1YmxpYzoKICAgICAgICAgbV9hc3NlbWJsZXIubGJ1KGRl c3QsIGFkZHJUZW1wUmVnaXN0ZXIsIDApOwogICAgIH0KIAorICAgIHZvaWQgbG9hZDhTaWduZWRF eHRlbmRUbzMyKEltcGxpY2l0QWRkcmVzcyBhZGRyZXNzLCBSZWdpc3RlcklEIGRlc3QpCisgICAg eworICAgICAgICBpZiAoYWRkcmVzcy5vZmZzZXQgPj0gLTMyNzY4ICYmIGFkZHJlc3Mub2Zmc2V0 IDw9IDMyNzY3CisgICAgICAgICAgICAmJiAhbV9maXhlZFdpZHRoKQorICAgICAgICAgICAgbV9h c3NlbWJsZXIubGIoZGVzdCwgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLm9mZnNldCk7CisgICAgICAg IGVsc2UgeworICAgICAgICAgICAgLyoKKyAgICAgICAgICAgICAgICBsdWkgICAgIGFkZHJUZW1w LCAob2Zmc2V0ICsgMHg4MDAwKSA+PiAxNgorICAgICAgICAgICAgICAgIGFkZHUgICAgYWRkclRl bXAsIGFkZHJUZW1wLCBiYXNlCisgICAgICAgICAgICAgICAgbGIgICAgICBkZXN0LCAob2Zmc2V0 ICYgMHhmZmZmKShhZGRyVGVtcCkKKyAgICAgICAgICAgICAgKi8KKyAgICAgICAgICAgIG1fYXNz ZW1ibGVyLmx1aShhZGRyVGVtcFJlZ2lzdGVyLCAoYWRkcmVzcy5vZmZzZXQgKyAweDgwMDApID4+ IDE2KTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmFkZHUoYWRkclRlbXBSZWdpc3RlciwgYWRk clRlbXBSZWdpc3RlciwgYWRkcmVzcy5iYXNlKTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmxi KGRlc3QsIGFkZHJUZW1wUmVnaXN0ZXIsIGFkZHJlc3Mub2Zmc2V0KTsKKyAgICAgICAgfQorICAg IH0KKwogICAgIHZvaWQgbG9hZDhTaWduZWRFeHRlbmRUbzMyKEJhc2VJbmRleCBhZGRyZXNzLCBS ZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICBpZiAoYWRkcmVzcy5vZmZzZXQgPj0gLTMy NzY4ICYmIGFkZHJlc3Mub2Zmc2V0IDw9IDMyNzY3CkBAIC03NzQsNiArNzkxLDIyIEBAIHB1Ymxp YzoKICAgICAgICAgfQogICAgIH0KIAorICAgIEFMV0FZU19JTkxJTkUgdm9pZCBsb2FkOFNpZ25l ZEV4dGVuZFRvMzIoQWJzb2x1dGVBZGRyZXNzIGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVzdCkKKyAg ICB7CisgICAgICAgIGxvYWQ4KGFkZHJlc3MubV9wdHIsIGRlc3QpOworICAgIH0KKworICAgIHZv aWQgbG9hZDhTaWduZWRFeHRlbmRUbzMyKGNvbnN0IHZvaWQqIGFkZHJlc3MsIFJlZ2lzdGVySUQg ZGVzdCkKKyAgICB7CisgICAgICAgIC8qCisgICAgICAgICAgICBsaSAgYWRkclRlbXAsIGFkZHJl c3MKKyAgICAgICAgICAgIGxiICBkZXN0LCAwKGFkZHJUZW1wKQorICAgICAgICAqLworICAgICAg ICBtb3ZlKFRydXN0ZWRJbW1QdHIoYWRkcmVzcyksIGFkZHJUZW1wUmVnaXN0ZXIpOworICAgICAg ICBtX2Fzc2VtYmxlci5sYihkZXN0LCBhZGRyVGVtcFJlZ2lzdGVyLCAwKTsKKyAgICB9CisKKwog ICAgIHZvaWQgbG9hZDMyKEltcGxpY2l0QWRkcmVzcyBhZGRyZXNzLCBSZWdpc3RlcklEIGRlc3Qp CiAgICAgewogICAgICAgICBpZiAoYWRkcmVzcy5vZmZzZXQgPj0gLTMyNzY4ICYmIGFkZHJlc3Mu b2Zmc2V0IDw9IDMyNzY3Cg== 301639 2017-02-15 11:45:15 -0800 2017-02-15 20:25:03 -0800 Patch bug-168350-20170215134240.patch text/plain 2768 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MGFiY2MwMDg0YTJjMjg4Njc1MGFkNWMxYTNjMzI2YjZjZWJhZmJjLi43OTYzOWRiMzkwNDcwYzRk MGEzMTllY2E3ZjZlOGE4MDUwODk0ZTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wMi0xNCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgTUlQUzogYWRkIG1pc3NpbmcgaW1wbGVtZW50YXRpb25zIG9mIGxv YWQ4U2lnbmVkRXh0ZW5kVG8zMigpCisKKyAgICAgICAgSlNDOiBtaXNzaW5nIGltcGxlbWVudGF0 aW9ucyBvZiBNYWNyb0Fzc2VtYmxlck1JUFM6OmxvYWQ4U2lnbmVkRXh0ZW5kVG8zMigpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgzNTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9N YWNyb0Fzc2VtYmxlck1JUFMuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjps b2FkOFNpZ25lZEV4dGVuZFRvMzIpOgorICAgICAgICBBZGQgbWlzc2luZyBpbXBsZW1lbnRhdGlv bnMKKwogMjAxNy0wMi0xNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIEpTQ19zd2VlcFN5bmNocm9ub3VzbHkgYW5kIGZpeCBKU0NfdXNlWm9tYmllTW9kZSBv cHRpb25zLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlck1JUFMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJNSVBTLmgKaW5kZXggYTY4OGU5ODBkOWQ0OTY5YmNlZGYxNzMzN2FiN2U1ZDhlM2I0 OGE4OS4uOGQwYWM5MTVhNzk4OGI3YjI5NDlkNDk0N2JhNGRmNmQyNmRlMzYyZSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5o CkBAIC03NDYsNiArNzQ2LDIzIEBAIHB1YmxpYzoKICAgICAgICAgbV9hc3NlbWJsZXIubGJ1KGRl c3QsIGFkZHJUZW1wUmVnaXN0ZXIsIDApOwogICAgIH0KIAorICAgIHZvaWQgbG9hZDhTaWduZWRF eHRlbmRUbzMyKEltcGxpY2l0QWRkcmVzcyBhZGRyZXNzLCBSZWdpc3RlcklEIGRlc3QpCisgICAg eworICAgICAgICBpZiAoYWRkcmVzcy5vZmZzZXQgPj0gLTMyNzY4ICYmIGFkZHJlc3Mub2Zmc2V0 IDw9IDMyNzY3CisgICAgICAgICAgICAmJiAhbV9maXhlZFdpZHRoKQorICAgICAgICAgICAgbV9h c3NlbWJsZXIubGIoZGVzdCwgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLm9mZnNldCk7CisgICAgICAg IGVsc2UgeworICAgICAgICAgICAgLyoKKyAgICAgICAgICAgICAgICBsdWkgICAgIGFkZHJUZW1w LCAob2Zmc2V0ICsgMHg4MDAwKSA+PiAxNgorICAgICAgICAgICAgICAgIGFkZHUgICAgYWRkclRl bXAsIGFkZHJUZW1wLCBiYXNlCisgICAgICAgICAgICAgICAgbGIgICAgICBkZXN0LCAob2Zmc2V0 ICYgMHhmZmZmKShhZGRyVGVtcCkKKyAgICAgICAgICAgICAgKi8KKyAgICAgICAgICAgIG1fYXNz ZW1ibGVyLmx1aShhZGRyVGVtcFJlZ2lzdGVyLCAoYWRkcmVzcy5vZmZzZXQgKyAweDgwMDApID4+ IDE2KTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmFkZHUoYWRkclRlbXBSZWdpc3RlciwgYWRk clRlbXBSZWdpc3RlciwgYWRkcmVzcy5iYXNlKTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmxi KGRlc3QsIGFkZHJUZW1wUmVnaXN0ZXIsIGFkZHJlc3Mub2Zmc2V0KTsKKyAgICAgICAgfQorICAg IH0KKwogICAgIHZvaWQgbG9hZDhTaWduZWRFeHRlbmRUbzMyKEJhc2VJbmRleCBhZGRyZXNzLCBS ZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICBpZiAoYWRkcmVzcy5vZmZzZXQgPj0gLTMy NzY4ICYmIGFkZHJlc3Mub2Zmc2V0IDw9IDMyNzY3CkBAIC03NzQsNiArNzkxLDIyIEBAIHB1Ymxp YzoKICAgICAgICAgfQogICAgIH0KIAorICAgIEFMV0FZU19JTkxJTkUgdm9pZCBsb2FkOFNpZ25l ZEV4dGVuZFRvMzIoQWJzb2x1dGVBZGRyZXNzIGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVzdCkKKyAg ICB7CisgICAgICAgIGxvYWQ4U2lnbmVkRXh0ZW5kVG8zMihhZGRyZXNzLm1fcHRyLCBkZXN0KTsK KyAgICB9CisKKyAgICB2b2lkIGxvYWQ4U2lnbmVkRXh0ZW5kVG8zMihjb25zdCB2b2lkKiBhZGRy ZXNzLCBSZWdpc3RlcklEIGRlc3QpCisgICAgeworICAgICAgICAvKgorICAgICAgICAgICAgbGkg IGFkZHJUZW1wLCBhZGRyZXNzCisgICAgICAgICAgICBsYiAgZGVzdCwgMChhZGRyVGVtcCkKKyAg ICAgICAgKi8KKyAgICAgICAgbW92ZShUcnVzdGVkSW1tUHRyKGFkZHJlc3MpLCBhZGRyVGVtcFJl Z2lzdGVyKTsKKyAgICAgICAgbV9hc3NlbWJsZXIubGIoZGVzdCwgYWRkclRlbXBSZWdpc3Rlciwg MCk7CisgICAgfQorCisKICAgICB2b2lkIGxvYWQzMihJbXBsaWNpdEFkZHJlc3MgYWRkcmVzcywg UmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgaWYgKGFkZHJlc3Mub2Zmc2V0ID49IC0z Mjc2OCAmJiBhZGRyZXNzLm9mZnNldCA8PSAzMjc2Nwo=