168345 2017-02-14 16:43:07 -0800 [CURL] ResourceError created with error information should have default type Type::General 2017-02-14 23:36:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Windows 10 RESOLVED FIXED P2 Normal --- 1 basuke webkit-unassigned basuke commit-queue galpeter oldest_to_newest 1276997 0 basuke 2017-02-14 16:43:07 -0800 CURL implementation of ResourceError has default value Type::General for type argument as like other implementations, but it is Type::None. This causes assertion error later. Source/WebCore/platform/network/curl/ResourceError.h ResourceError(const String& domain, int errorCode, const URL& failingURL, const String& localizedDescription, Type type = Type::Null) 1276999 1 301564 basuke 2017-02-14 16:51:37 -0800 Created attachment 301564 fix 1277017 2 301569 basuke 2017-02-14 18:13:03 -0800 Created attachment 301569 Patch 1277029 3 301569 commit-queue 2017-02-14 18:52:38 -0800 Comment on attachment 301569 Patch Clearing flags on attachment: 301569 Committed r212340: <http://trac.webkit.org/changeset/212340> 1277030 4 commit-queue 2017-02-14 18:52:41 -0800 All reviewed patches have been landed. Closing bug. 301564 2017-02-14 16:51:37 -0800 2017-02-14 23:36:28 -0800 fix patch-168345.diff text/plain 721 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJj ZUVycm9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VF cnJvci5oCmluZGV4IGUzNGY2ZWJjOGY1Li4wMDNmOWI2OTUwMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlRXJyb3IuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VFcnJvci5oCkBAIC00Niw3 ICs0Niw3IEBAIHB1YmxpYzoKICAgICB7CiAgICAgfQogCi0gICAgUmVzb3VyY2VFcnJvcihjb25z dCBTdHJpbmcmIGRvbWFpbiwgaW50IGVycm9yQ29kZSwgY29uc3QgVVJMJiBmYWlsaW5nVVJMLCBj b25zdCBTdHJpbmcmIGxvY2FsaXplZERlc2NyaXB0aW9uLCBUeXBlIHR5cGUgPSBUeXBlOjpOdWxs KQorICAgIFJlc291cmNlRXJyb3IoY29uc3QgU3RyaW5nJiBkb21haW4sIGludCBlcnJvckNvZGUs IGNvbnN0IFVSTCYgZmFpbGluZ1VSTCwgY29uc3QgU3RyaW5nJiBsb2NhbGl6ZWREZXNjcmlwdGlv biwgVHlwZSB0eXBlID0gVHlwZTo6R2VuZXJhbCkKICAgICAgICAgOiBSZXNvdXJjZUVycm9yQmFz ZShkb21haW4sIGVycm9yQ29kZSwgZmFpbGluZ1VSTCwgbG9jYWxpemVkRGVzY3JpcHRpb24sIHR5 cGUpCiAgICAgICAgICwgbV9zc2xFcnJvcnMoMCkKICAgICB7Cg== 301569 2017-02-14 18:13:03 -0800 2017-02-14 18:52:38 -0800 Patch bug-168345-20170214181028.patch text/plain 1883 basuke U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmM1MDI4Y2U4OGYyOWM1 Y2Q2Y2ZiMmFmNTU4ODFkZDRjYjY5ZTU3YS4uNzkyMWEzYjE4ODhmYjNmMjhhNTE0OTYzYzg3NmEy YmE1NmU2ZjY1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAyLTE0ICBCYXN1 a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBhbS5zb255LmNvbT4KKworICAgICAgICBbQ1VSTF0g UmVzb3VyY2VFcnJvciBjcmVhdGVkIHdpdGggZXJyb3IgaW5mb3JtYXRpb24gc2hvdWxkIGhhdmUg ZGVmYXVsdCB0eXBlIFR5cGU6OkdlbmVyYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2ODM0NQorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXggQ2hy aXN0ZW5zZW4uCisKKyAgICAgICAgUmVzb3VyY2VFcnJvciBoYXMgc2VwYXJhdGUgaW1wbGVtZW50 YWlvbiBmb3IgZWFjaCBwbGF0Zm9ybQorICAgICAgICBzbyB0aGF0IHRoZSBpbnRlcmZhY2Ugc2hv dWxkIGJlIHNhbWUuCisgICAgICAgIE9uIENVUkwgcG9ydCwgdGhlIGNvbnN0cnVjdG9yIHdpdGgg ZXJyb3IgaW5mb3JtYXRpb24gaGFzCisgICAgICAgIGRpZmZlcmVudCBkZWZhdWx0IHZhbHVlIG9u IGB0eXBlYCBwYXJhbWV0ZXIuIEl0IGlzIFR5cGU6Ok51bGwgYnV0IG90aGVyIGltcGxlbWVudGFp dG9ucyBoYXZlIFR5cGU6OkdlbmVyYWwuCisgICAgICAgIFRoaXMgY2F1c2VzIHNvbWUgUmVzb3Vy Y2VFcnJvciBpcyBjcmVhdGVkIGluY29uc2lzdGVudC4gCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvUmVzb3VyY2VFcnJvci5oOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VF cnJvcjo6UmVzb3VyY2VFcnJvcik6CisKIDIwMTctMDItMTMgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTG9nIHRvIHRoZSBIaXN0b3J5IENoYW5uZWwg aW4gYSBmZXcgbW9yZSBwbGFjZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9SZXNvdXJjZUVycm9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvUmVzb3VyY2VFcnJvci5oCmluZGV4IGUzNGY2ZWJjOGY1NmY4YzVkNzg2MmJl ODBiYjlmYTFhYzU0YmNhNjQuLjAwM2Y5YjY5NTAyNTNlNTRiY2UxNjUzOTNiYjkzZmI3MWFhMzA5 N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNv dXJjZUVycm9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jl c291cmNlRXJyb3IuaApAQCAtNDYsNyArNDYsNyBAQCBwdWJsaWM6CiAgICAgewogICAgIH0KIAot ICAgIFJlc291cmNlRXJyb3IoY29uc3QgU3RyaW5nJiBkb21haW4sIGludCBlcnJvckNvZGUsIGNv bnN0IFVSTCYgZmFpbGluZ1VSTCwgY29uc3QgU3RyaW5nJiBsb2NhbGl6ZWREZXNjcmlwdGlvbiwg VHlwZSB0eXBlID0gVHlwZTo6TnVsbCkKKyAgICBSZXNvdXJjZUVycm9yKGNvbnN0IFN0cmluZyYg ZG9tYWluLCBpbnQgZXJyb3JDb2RlLCBjb25zdCBVUkwmIGZhaWxpbmdVUkwsIGNvbnN0IFN0cmlu ZyYgbG9jYWxpemVkRGVzY3JpcHRpb24sIFR5cGUgdHlwZSA9IFR5cGU6OkdlbmVyYWwpCiAgICAg ICAgIDogUmVzb3VyY2VFcnJvckJhc2UoZG9tYWluLCBlcnJvckNvZGUsIGZhaWxpbmdVUkwsIGxv Y2FsaXplZERlc2NyaXB0aW9uLCB0eXBlKQogICAgICAgICAsIG1fc3NsRXJyb3JzKDApCiAgICAg ewo=