168341 2017-02-14 15:20:22 -0800 LayoutTest fast/multicol/column-span-parent-continuation-crash.html is a flaky timeout 2017-02-20 14:30:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad ap ap commit-queue oldest_to_newest 1276961 0 ryanhaddad 2017-02-14 15:20:22 -0800 LayoutTest fast/multicol/column-span-parent-continuation-crash.html is a flaky timeout https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r212316%20(3763)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fmulticol%2Fcolumn-span-parent-continuation-crash.html 1278437 1 ryanhaddad 2017-02-17 14:18:38 -0800 From the diff: CONSOLE MESSAGE: line 20: TypeError: null is not an object (evaluating 'child.parentNode') 1278659 2 302057 ap 2017-02-18 14:31:21 -0800 Created attachment 302057 proposed fix 1278661 3 302059 ap 2017-02-18 14:36:45 -0800 Created attachment 302059 proposed fix The patch didn't apply because the file had CRLF line endings. This one should work I hope. 1279048 4 302059 dbates 2017-02-20 13:55:55 -0800 Comment on attachment 302059 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=302059&action=review > LayoutTests/fast/multicol/column-span-parent-continuation-crash.html:6 > +<style> Is the test intentionally needing the <style> here? Otherwise this markup is invalid by the HTML standard as <style> is expected to be a child of <head>. > LayoutTests/fast/multicol/column-span-parent-continuation-crash.html:20 > + child = document.getElementById('test'); I know you are just moving code. I do not not see the need for |child| to be a global variable. I would add the keywords "var " or "let" to the left hand side of this expression. > LayoutTests/fast/multicol/column-span-parent-continuation-crash.html:22 > + child = document.getElementById('anything'); This file alternatives between using single and double quoted sting literals. We should take this opportunity to pick one style and use throughout this file for consistently. 1279051 5 302059 ap 2017-02-20 14:04:43 -0800 Comment on attachment 302059 proposed fix I'm not eager to change more than absolutely needed in this file, as it's a regression test for something that was timing dependent, and I can't confirm that the test is still effective after the changes. As for style fixes, my preference is to not enforce style rules in tests, as minor variations have been known to uncover unexpected bugs that we don't explicitly test for. 1279055 6 302059 commit-queue 2017-02-20 14:30:46 -0800 Comment on attachment 302059 proposed fix Clearing flags on attachment: 302059 Committed r212678: <http://trac.webkit.org/changeset/212678> 1279056 7 commit-queue 2017-02-20 14:30:50 -0800 All reviewed patches have been landed. Closing bug. 302057 2017-02-18 14:31:21 -0800 2017-02-18 14:36:45 -0800 proposed fix column-span-parent-continuation-crash.txt text/plain 1380 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxMjYwNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAyLTE4ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFRlc3QgZmFzdC9tdWx0aWNvbC9j b2x1bW4tc3Bhbi1wYXJlbnQtY29udGludWF0aW9uLWNyYXNoLmh0bWwgaXMgYSBmbGFreSB0aW1l b3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgz NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvbXVsdGljb2wvY29sdW1uLXNwYW4tcGFyZW50LWNvbnRpbnVhdGlvbi1jcmFzaC5odG1sOiBN YWtlIHN1cmUgdGhhdCB0aGUKKyAgICAgICAgZG9jdW1lbnQgaXMgZnVsbHkgcGFyc2VkIGJlZm9y ZSB0aGUgdGVzdCBydW5zLiBJJ20gbm90IHN1cmUgaWYgdGhlIHplcm8gZGVsYXkKKyAgICAgICAg aXMgc3RpbGwgbmVlZGVkLCBidXQgaXQgZG9lc24ndCBodXJ0LgorCiAyMDE3LTAyLTE4ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkIEdUSysgZ2FyZGVuaW5nLiBVcGRhdGUgZXhwZWN0YXRpb25zIG9mIGEgZmV3IG1vcmUgdGVz dHMgdGhhdCBhcmUgZmFpbGluZy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvY29s dW1uLXNwYW4tcGFyZW50LWNvbnRpbnVhdGlvbi1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvY29sdW1uLXNwYW4tcGFyZW50LWNvbnRpbnVhdGlvbi1j cmFzaC5odG1sCShyZXZpc2lvbiAyMTI2MDcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29s L2NvbHVtbi1zcGFuLXBhcmVudC1jb250aW51YXRpb24tY3Jhc2guaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMjYsNyArMjYsNyBAQCBmdW5jdGlvbiBydW5UZXN0KCkNCiAgICAgICAgIHRlc3RSdW5u ZXIubm90aWZ5RG9uZSgpOw0KIH0NCiANCi1zZXRUaW1lb3V0KCJydW5UZXN0KCkiLCAwKTsNCitv bmxvYWQgPSBmdW5jdGlvbigpIHsgc2V0VGltZW91dChydW5UZXN0LCAwKTsgfQ0KIDwvc2NyaXB0 Pg0KIDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4NCiA8ZGl2Pg0K 302059 2017-02-18 14:36:45 -0800 2017-02-20 14:30:46 -0800 proposed fix column-span-parent-continuation-crash.txt text/plain 2793 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxMjYwNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAyLTE4ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFRlc3QgZmFzdC9tdWx0aWNvbC9j b2x1bW4tc3Bhbi1wYXJlbnQtY29udGludWF0aW9uLWNyYXNoLmh0bWwgaXMgYSBmbGFreSB0aW1l b3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgz NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZh c3QvbXVsdGljb2wvY29sdW1uLXNwYW4tcGFyZW50LWNvbnRpbnVhdGlvbi1jcmFzaC5odG1sOiBN YWtlIHN1cmUgdGhhdCB0aGUKKyAgICAgICAgZG9jdW1lbnQgaXMgZnVsbHkgcGFyc2VkIGJlZm9y ZSB0aGUgdGVzdCBydW5zLiBJJ20gbm90IHN1cmUgaWYgdGhlIHplcm8gZGVsYXkKKyAgICAgICAg aXMgc3RpbGwgbmVlZGVkLCBidXQgaXQgZG9lc24ndCBodXJ0LgorCiAyMDE3LTAyLTE4ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkIEdUSysgZ2FyZGVuaW5nLiBVcGRhdGUgZXhwZWN0YXRpb25zIG9mIGEgZmV3IG1vcmUgdGVz dHMgdGhhdCBhcmUgZmFpbGluZy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvY29s dW1uLXNwYW4tcGFyZW50LWNvbnRpbnVhdGlvbi1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvY29sdW1uLXNwYW4tcGFyZW50LWNvbnRpbnVhdGlvbi1j cmFzaC5odG1sCShyZXZpc2lvbiAyMTI2MDcpCisrKyBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29s L2NvbHVtbi1zcGFuLXBhcmVudC1jb250aW51YXRpb24tY3Jhc2guaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMSwzNiArMSwzNiBAQAotPCFET0NUWVBFIGh0bWw+DQotPGh0bWw+DQotPGJvZHk+DQot PGRpdiBpZD0iY29uc29sZSI+PC9kaXY+DQotPHN0eWxlPg0KLWRpdiB7IC13ZWJraXQtY29sdW1u LWNvdW50OiAxOyB9DQotaDIgeyAtd2Via2l0LWNvbHVtbi1zcGFuOiBhbGw7IH0NCi08L3N0eWxl Pg0KLTxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 Pg0KLTxzY3JpcHQ+DQotaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7DQotICAgIHRlc3RSdW5uZXIu ZHVtcEFzVGV4dCgpOw0KLSAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsNCi19DQotDQot ZnVuY3Rpb24gcnVuVGVzdCgpDQotew0KLSAgICBkb2N1bWVudC5ib2R5Lm9mZnNldFRvcDsNCi0g ICAgY2hpbGQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdCcpOw0KLSAgICBjaGlsZC5w YXJlbnROb2RlLnJlbW92ZUNoaWxkKGNoaWxkKTsNCi0gICAgY2hpbGQgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgnYW55dGhpbmcnKTsNCi0gICAgZ2MoKTsNCi0gICAgZG9jdW1lbnQuYm9keS5p bm5lckhUTUwgPSAiUEFTUyI7DQotDQotICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikNCi0gICAg ICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOw0KLX0NCi0NCi1zZXRUaW1lb3V0KCJydW5UZXN0 KCkiLCAwKTsNCi08L3NjcmlwdD4NCi08c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcG9zdC5qcyI+PC9zY3JpcHQ+DQotPGRpdj4NCi08c3BhbiBpZD0idGVzdCI+PGgyPjwvc3Bh bj4NCi08L2Rpdj4NCi08L2JvZHk+DQotPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorPHN0eWxlPgorZGl2IHsgLXdlYmtpdC1jb2x1bW4tY291bnQ6IDE7IH0KK2gyIHsgLXdl YmtpdC1jb2x1bW4tc3BhbjogYWxsOyB9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50 ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5l ci53YWl0VW50aWxEb25lKCk7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3QoKQoreworICAgIGRvY3Vt ZW50LmJvZHkub2Zmc2V0VG9wOworICAgIGNoaWxkID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3Rlc3QnKTsKKyAgICBjaGlsZC5wYXJlbnROb2RlLnJlbW92ZUNoaWxkKGNoaWxkKTsKKyAgICBj aGlsZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhbnl0aGluZycpOworICAgIGdjKCk7Cisg ICAgZG9jdW1lbnQuYm9keS5pbm5lckhUTUwgPSAiUEFTUyI7CisKKyAgICBpZiAod2luZG93LnRl c3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfQorCitvbmxvYWQg PSBmdW5jdGlvbigpIHsgc2V0VGltZW91dChydW5UZXN0LCAwKTsgfQorPC9zY3JpcHQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8ZGl2 PgorPHNwYW4gaWQ9InRlc3QiPjxoMj48L3NwYW4+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K