168323 2017-02-14 08:24:36 -0800 [CMake] build-webkit should allow building with the default cmake configuration 2017-02-14 10:10:12 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168318 P2 Normal --- 168321 1 clopez clopez achristensen bugs-noreply dbates lforschler mcatanzaro ossy oldest_to_newest 1276750 0 clopez 2017-02-14 08:24:36 -0800 When using the build-webkit script its currently not possible to use the default features enabled on the cmake configuration for the port. The --minimal option disabled all optional features. I propose adding a --default option that build the CMake port without specifying any value for the features, that way the default value from the cmake config will be used. This will be needed for the new bots we plan to add on bug 168321 1276755 1 mcatanzaro 2017-02-14 08:30:22 -0800 You need to come up with a better name than --default. We can't have a --default flag that changes all the arguments to something that's not default for build-webkit, that would be super confusing. :) Maybe --disable-developer-options? 1276761 2 301505 clopez 2017-02-14 08:40:00 -0800 Created attachment 301505 Patch 1276798 3 301515 clopez 2017-02-14 09:43:16 -0800 Created attachment 301515 Patch Use --default-cmake-features for this 1276799 4 301515 mcatanzaro 2017-02-14 09:48:22 -0800 Comment on attachment 301515 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301515&action=review This is great! Now build-webkit will actually be useful. :) > Tools/Scripts/build-webkit:55 > +my $defaultCmakeFeatures = 0; $defaultCMakeFeatures 1276802 5 clopez 2017-02-14 10:09:23 -0800 Committed r212306: <http://trac.webkit.org/changeset/212306> 301505 2017-02-14 08:40:00 -0800 2017-02-14 09:43:09 -0800 Patch bug-168323-20170214173725.patch text/plain 2547 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMjg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGE0MWU4MDU4MTYzYTM1MTZhYjM1NzJmN2NhYzZhYjIy MzNjYzNlZi4uY2Q5MTBkYTk0MmJmM2Y3NGVmMTFhYWU5MjlkNjc4OWI2YWJkMjYwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE3LTAyLTE0ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gYnVpbGQtd2Via2l0IHNob3VsZCBhbGxvdyBidWls ZGluZyB3aXRoIHRoZSBkZWZhdWx0IGNtYWtlIGNvbmZpZ3VyYXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODMyMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5ldyAtLWRlZmF1bHQgc3dp dGNoIHRoYXQgbWFrZXMgdGhlIHNjcmlwdCBwYXNzIG5vIHZhbHVlIGZvcgorICAgICAgICBhbnkg b2YgdGhlIGZlYXR1cmVzLCB0aGF0IHdheSB0aGUgZGVmYXVsdCB2YWx1ZXMgZnJvbSB0aGUgcG9y dCBjbWFrZQorICAgICAgICBjb25maWcgd2lsbCBiZSB1c2VkLgorCisgICAgICAgICogU2NyaXB0 cy9idWlsZC13ZWJraXQ6CisgICAgICAgIChjTWFrZUFyZ3NGcm9tRmVhdHVyZXMpOgorCiAyMDE3 LTAyLTE0ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjEyMjM3LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCA4YmM4 NTU4ZjAzNDRhYWI2MThhMjU3NjBkOTkwZWM1Y2Y1M2I2NjAxLi44N2ZhMmExY2FjOTBkZjJjNTg3 MzE1YzgwYjJiYmIxMjQ5M2E1MDQyIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtNTIsNiArNTIsNyBAQCBj aGRpcldlYktpdCgpOwogCiBteSAkc2hvd0hlbHAgPSAwOwogbXkgJGNsZWFuID0gMDsKK215ICRk ZWZhdWx0ID0gMDsKIG15ICRtaW5pbWFsID0gMDsKIG15ICRpbnN0YWxsSGVhZGVyczsKIG15ICRp bnN0YWxsTGliczsKQEAgLTEwNCw2ICsxMDUsNyBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRp b25zXSBbb3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3RlbV0KICAgLS1jbWFrZWFyZ3M9PGFy Z3VtZW50cz4gICAgICAgICAgIE9uZSBvciBtb3JlIG9wdGlvbmFsIENNYWtlIGZsYWdzIChlLmcu IC0tY21ha2VhcmdzPSItREZPTz1iYXIgLURDTUFLRV9QUkVGSVhfUEFUSD0vdXNyL2xvY2FsIikK IAogICAtLW1pbmltYWwgICAgICAgICAgICAgICAgICAgICAgICAgTm8gb3B0aW9uYWwgZmVhdHVy ZXMsIHVubGVzcyBleHBsaWNpdGx5IGVuYWJsZWQKKyAgLS1kZWZhdWx0ICAgICAgICAgICAgICAg ICAgICAgICAgIFVzZSB0aGUgZGVmYXVsdCBmZWF0dXJlcyBlbmFibGVkIGZvciB0aGUgcG9ydCAo Q01ha2UgYmFzZWQgcG9ydHMpCiAKICAgLS1vbmx5LXdlYmtpdCAgICAgICAgICAgICAgICAgICAg IEJ1aWxkIG9ubHkgdGhlIFdlYktpdCBwcm9qZWN0CiAKQEAgLTEyMSw2ICsxMjMsNyBAQCBteSAl b3B0aW9ucyA9ICgKICAgICAnb25seS13ZWJraXQnID0+IFwkb25seVdlYktpdFByb2plY3QsCiAg ICAgJ2NvdmVyYWdlJyA9PiBcJGNvdmVyYWdlU3VwcG9ydCwKICAgICAnYW5hbHl6ZScgPT4gXCRz aG91bGRSdW5TdGF0aWNBbmFseXplciwKKyAgICAnZGVmYXVsdCcgPT4gXCRkZWZhdWx0LAogKTsK IAogIyBCdWlsZCB1c2FnZSB0ZXh0IGFuZCBvcHRpb25zIGxpc3QgZnJvbSBmZWF0dXJlcwpAQCAt MzA2LDExICszMDksMTMgQEAgZXhpdCAwOwogc3ViIGNNYWtlQXJnc0Zyb21GZWF0dXJlcygpCiB7 CiAgICAgbXkgQGFyZ3M7Ci0gICAgZm9yZWFjaCAoQGZlYXR1cmVzKSB7Ci0gICAgICAgIG15ICRm ZWF0dXJlTmFtZSA9ICRfLT57ZGVmaW5lfTsKLSAgICAgICAgaWYgKCRmZWF0dXJlTmFtZSkgewot ICAgICAgICAgICAgbXkgJGZlYXR1cmVFbmFibGVkID0gJHskXy0+e3ZhbHVlfX0gPyAiT04iIDog Ik9GRiI7Ci0gICAgICAgICAgICBwdXNoIEBhcmdzLCAiLUQkZmVhdHVyZU5hbWU9JGZlYXR1cmVF bmFibGVkIjsKKyAgICBpZiAoISRkZWZhdWx0KSB7CisgICAgICAgIGZvcmVhY2ggKEBmZWF0dXJl cykgeworICAgICAgICAgICAgbXkgJGZlYXR1cmVOYW1lID0gJF8tPntkZWZpbmV9OworICAgICAg ICAgICAgaWYgKCRmZWF0dXJlTmFtZSkgeworICAgICAgICAgICAgICAgIG15ICRmZWF0dXJlRW5h YmxlZCA9ICR7JF8tPnt2YWx1ZX19ID8gIk9OIiA6ICJPRkYiOworICAgICAgICAgICAgICAgIHB1 c2ggQGFyZ3MsICItRCRmZWF0dXJlTmFtZT0kZmVhdHVyZUVuYWJsZWQiOworICAgICAgICAgICAg fQogICAgICAgICB9CiAgICAgfQogICAgIHJldHVybiBAYXJnczsK 301515 2017-02-14 09:43:16 -0800 2017-02-14 10:10:12 -0800 Patch bug-168323-20170214184042.patch text/plain 2736 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWJjZDk3ZmIzZWY0NmZjOWMzNmJmMjg3MmRmNGVmYmI4 NGRkMzc3Ni4uZTU3NmQ5Nzc1NmJmNzMzYzU2NTAzYzQ0YzVkNzcxMzQ2YWY4NWQzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDE3LTAyLTE0ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgogCisgICAgICAgIFtDTWFrZV0gYnVpbGQtd2Via2l0IHNob3VsZCBhbGxvdyBidWls ZGluZyB3aXRoIHRoZSBkZWZhdWx0IGNtYWtlIGNvbmZpZ3VyYXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODMyMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIC0tZGVmYXVsdC1jbWFrZS1m ZWF0dXJlcyBzd2l0Y2ggdGhhdCBtYWtlcyB0aGUgc2NyaXB0IHBhc3MKKyAgICAgICAgbm8gdmFs dWUgZm9yIGFueSBvZiB0aGUgZmVhdHVyZXMgZGVmaW5lZCBieSBidWlsZC13ZWJraXQsIHRoYXQK KyAgICAgICAgd2F5IHRoZSBkZWZhdWx0IHZhbHVlcyBmcm9tIHRoZSBwb3J0IGNtYWtlIGNvbmZp ZyB3aWxsIGJlIHVzZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAgICAg ICAgKGNNYWtlQXJnc0Zyb21GZWF0dXJlcyk6CisKKzIwMTctMDItMTQgIENhcmxvcyBBbGJlcnRv IExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CisKICAgICAgICAgW0NNYWtlXSBidWls ZC13ZWJraXQgc2hvdWxkIHByaW50IHRoZSBjbWFrZSBjb21tYW5kIGV4ZWN1dGVkCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgzMTgKIApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdAppbmRleCA4YmM4NTU4ZjAzNDRhYWI2MThhMjU3NjBkOTkwZWM1Y2Y1M2I2NjAxLi44Nzg2 MjY3OWI1M2IwZTU3ZWZjM2Q3YjVmZjk3MzNlMWFjOTgxMGU2IDEwMDc1NQotLS0gYS9Ub29scy9T Y3JpcHRzL2J1aWxkLXdlYmtpdAorKysgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAt NTIsNiArNTIsNyBAQCBjaGRpcldlYktpdCgpOwogCiBteSAkc2hvd0hlbHAgPSAwOwogbXkgJGNs ZWFuID0gMDsKK215ICRkZWZhdWx0Q21ha2VGZWF0dXJlcyA9IDA7CiBteSAkbWluaW1hbCA9IDA7 CiBteSAkaW5zdGFsbEhlYWRlcnM7CiBteSAkaW5zdGFsbExpYnM7CkBAIC0xMDQsNiArMTA1LDcg QEAgVXNhZ2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW29wdGlvbnMgdG8gcGFzcyB0byBidWls ZCBzeXN0ZW1dCiAgIC0tY21ha2VhcmdzPTxhcmd1bWVudHM+ICAgICAgICAgICBPbmUgb3IgbW9y ZSBvcHRpb25hbCBDTWFrZSBmbGFncyAoZS5nLiAtLWNtYWtlYXJncz0iLURGT089YmFyIC1EQ01B S0VfUFJFRklYX1BBVEg9L3Vzci9sb2NhbCIpCiAKICAgLS1taW5pbWFsICAgICAgICAgICAgICAg ICAgICAgICAgIE5vIG9wdGlvbmFsIGZlYXR1cmVzLCB1bmxlc3MgZXhwbGljaXRseSBlbmFibGVk CisgIC0tZGVmYXVsdC1jbWFrZS1mZWF0dXJlcyAgICAgICAgICBVc2UgdGhlIGRlZmF1bHQgQ01h a2UgZmVhdHVyZXMgZW5hYmxlZCBmb3IgdGhlIHBvcnQgKENNYWtlIGJhc2VkIHBvcnRzKQogCiAg IC0tb25seS13ZWJraXQgICAgICAgICAgICAgICAgICAgICBCdWlsZCBvbmx5IHRoZSBXZWJLaXQg cHJvamVjdAogCkBAIC0xMjEsNiArMTIzLDcgQEAgbXkgJW9wdGlvbnMgPSAoCiAgICAgJ29ubHkt d2Via2l0JyA9PiBcJG9ubHlXZWJLaXRQcm9qZWN0LAogICAgICdjb3ZlcmFnZScgPT4gXCRjb3Zl cmFnZVN1cHBvcnQsCiAgICAgJ2FuYWx5emUnID0+IFwkc2hvdWxkUnVuU3RhdGljQW5hbHl6ZXIs CisgICAgJ2RlZmF1bHQtY21ha2UtZmVhdHVyZXMnID0+IFwkZGVmYXVsdENtYWtlRmVhdHVyZXMs CiApOwogCiAjIEJ1aWxkIHVzYWdlIHRleHQgYW5kIG9wdGlvbnMgbGlzdCBmcm9tIGZlYXR1cmVz CkBAIC0zMDYsMTEgKzMwOSwxMyBAQCBleGl0IDA7CiBzdWIgY01ha2VBcmdzRnJvbUZlYXR1cmVz KCkKIHsKICAgICBteSBAYXJnczsKLSAgICBmb3JlYWNoIChAZmVhdHVyZXMpIHsKLSAgICAgICAg bXkgJGZlYXR1cmVOYW1lID0gJF8tPntkZWZpbmV9OwotICAgICAgICBpZiAoJGZlYXR1cmVOYW1l KSB7Ci0gICAgICAgICAgICBteSAkZmVhdHVyZUVuYWJsZWQgPSAkeyRfLT57dmFsdWV9fSA/ICJP TiIgOiAiT0ZGIjsKLSAgICAgICAgICAgIHB1c2ggQGFyZ3MsICItRCRmZWF0dXJlTmFtZT0kZmVh dHVyZUVuYWJsZWQiOworICAgIGlmICghJGRlZmF1bHRDbWFrZUZlYXR1cmVzKSB7CisgICAgICAg IGZvcmVhY2ggKEBmZWF0dXJlcykgeworICAgICAgICAgICAgbXkgJGZlYXR1cmVOYW1lID0gJF8t PntkZWZpbmV9OworICAgICAgICAgICAgaWYgKCRmZWF0dXJlTmFtZSkgeworICAgICAgICAgICAg ICAgIG15ICRmZWF0dXJlRW5hYmxlZCA9ICR7JF8tPnt2YWx1ZX19ID8gIk9OIiA6ICJPRkYiOwor ICAgICAgICAgICAgICAgIHB1c2ggQGFyZ3MsICItRCRmZWF0dXJlTmFtZT0kZmVhdHVyZUVuYWJs ZWQiOworICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQogICAgIHJldHVybiBAYXJnczsK