168321 2017-02-14 08:15:51 -0800 [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS 2017-02-16 09:28:47 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 168323 1 clopez clopez achristensen annulen ap bugs-noreply dbates lforschler mcatanzaro mrobinson ossy oldest_to_newest 1276747 0 clopez 2017-02-14 08:15:51 -0800 One of the problems we currently have is that we are using ancient versions of libraries in our JHBuild, and old versions of GCC on the bots. One of the reasons we do this is to unintentionally avoid breaking the build on systems that require using this old versions of the libraries or the compiler. However, a majority of our users are using distributions that ship the last version of this libraries or the compiler. So we end testing WebKit with a different version of the dependencies than what the users end running. Not ideal. The proposed solution is: 1) Add two new buildbots that buid-test WebKitGTK+ on the last Debian stable and Ubuntu LTS without using the internal JHBuild. This bots will build against the system libraries. This will ensure we don't unintentionally break our policy about dependency versions https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy 2) Then we will have complete freedom to raise the dependencies on the JHBuild without fearing unintentionally build breakage on older systems. Ideally we would like to keep the versions of the libraries on our jhbuild synced with the last GNOME modulesets. That way we can test WebKit with the version of libraries that most users will end using. 1277498 1 301703 clopez 2017-02-15 21:32:13 -0800 Created attachment 301703 Patch 1277604 2 301703 clopez 2017-02-16 04:18:11 -0800 Comment on attachment 301703 Patch Clearing flags on attachment: 301703 Committed r212429: <http://trac.webkit.org/changeset/212429> 1277605 3 clopez 2017-02-16 04:18:20 -0800 All reviewed patches have been landed. Closing bug. 1277607 4 annulen 2017-02-16 04:39:10 -0800 IMHO name of "--default-cmake-features" argument does not imply it is disabling JHBuild. 1277626 5 clopez 2017-02-16 05:41:03 -0800 (In reply to comment #4) > IMHO name of "--default-cmake-features" argument does not imply it is > disabling JHBuild. You can build webkit with the jhbuild and --default-cmake-features, or you can build webkit without jhbuild and --default-cmake-features. All possible combinations are supported. But we want this bots to run without jhbuild, so we can be sure webkit remains build-able on the base configuration using only the distribution dependencies. Checking for this argument on the buildbot config *and* for the gtk port on the buildbot config in order to decide if disable the jhbuild step is not ideal. But i don't think there is ideal solution here. If we add a explicit optional argument to disable jhbuild, then we have to take care of filtering that argument on the build step, as otherwise it would be passed to the build... causing the step to fail. 1277700 6 clopez 2017-02-16 09:28:47 -0800 Committed r212437: <http://trac.webkit.org/changeset/212437> 301703 2017-02-15 21:32:13 -0800 2017-02-16 04:18:11 -0800 Patch bug-168321-20170216062936.patch text/plain 6268 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNDE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTlhNGJjOTYzZDY1ZWM1ZDQ0YTU4MjlhOTU4Njk4YmVj NDE1Y2UzZi4uNWRjY2Y1NDIwZDhmZTdjZTc0NGM5YWJhNGQ2Y2VmMTc4MjUwYWVjMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTAyLTE1ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCB0d28gbmV3IGJ1aWxkYm90cyB0aGF0IGJ1aWxk LW9ubHkgdGVzdCBvbiBEZWJpYW4gc3RhYmxlIGFuZCBVYnVudHUgTFRTCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgzMjEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYWRkaXRpb25hbEFyZ3VtZW50 IC0tZGVmYXVsdC1jbWFrZS1mZWF0dXJlcyBpcyB1c2VkIGJvdGggdG8KKyAgICAgICAgc2tpcCB0 aGUgSkhCdWlsZCAoSW5zdGFsbEd0a0RlcGVuZGVuY2llcykgYnVpbGQgc3RlcCBhbmQgdG8gYnVp bGQKKyAgICAgICAgd2l0aCB0aGUgZGVmYXVsdCBmZWF0dXJlcyBmcm9tIHRoZSBDTWFrZSBjb25m aWcuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9jb25maWcuanNvbjoKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoRmFjdG9yeS5fX2luaXRfXyk6CisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2Zn X3VuaXR0ZXN0LnB5OgorCiAyMDE3LTAyLTE1ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVy QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY4Mzg2CmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9jb25maWcuanNvbiBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL2NvbmZpZy5qc29uCmluZGV4IDYwZTA3ZTRmNDRkNzY2MGE4 NTAwNTMyYjUxYzVkYTI0MzU2NTAxODEuLmU4NjY5MWZkZTY2MWQ1MjZmMmVhZjI0Njg5Mzc5Mjc3 NGNjNGU1MTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL2NvbmZpZy5qc29uCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL2NvbmZpZy5qc29uCkBAIC03Miw2ICs3Miw4IEBACiAgICAg ICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiZ3RrLWxpbnV4LXNsYXZlLTciLCAicGxhdGZvcm0i OiAiZ3RrIiB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImd0ay1saW51eC1zbGF2 ZS04IiwgInBsYXRmb3JtIjogImd0ayIgfSwKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6 ICJndGstbGludXgtc2xhdmUtOSIsICJwbGF0Zm9ybSI6ICJndGsiIH0sCisgICAgICAgICAgICAg ICAgICAgIHsgIm5hbWUiOiAiZ3RrLWxpbnV4LXNsYXZlLTEwIiwgInBsYXRmb3JtIjogImd0ayIg fSwKKyAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJndGstbGludXgtc2xhdmUtMTEiLCAi cGxhdGZvcm0iOiAiZ3RrIiB9LAogCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAianNj b25seS1saW51eC1zemVnZWQtc2xhdmUtMSIsICJwbGF0Zm9ybSI6ICJqc2Mtb25seSIgfSwKICAg ICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJqc2Nvbmx5LWxpbnV4LXN6ZWdlZC1zbGF2ZS0y IiwgInBsYXRmb3JtIjogImpzYy1vbmx5IiB9LApAQCAtMzAyLDYgKzMwNCwxOCBAQAogICAgICAg ICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJndGstbGludXgtc2xhdmUtOSJdCiAgICAg ICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAg ICAgICAgICAibmFtZSI6ICJHVEsgTGludXggNjQtYml0IFJlbGVhc2UgRGViaWFuIFN0YWJsZSAo QnVpbGQpIiwgInR5cGUiOiAiQnVpbGQiLCAiYnVpbGRkaXIiOiAiZ3RrLWxpbnV4LTY0LXJlbGVh c2UtZGViaWFuIiwKKyAgICAgICAgICAgICAgICAgICAgICAicGxhdGZvcm0iOiAiZ3RrIiwgImNv bmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsICJhcmNoaXRlY3R1cmVzIjogWyJ4ODZfNjQiXSwKKyAg ICAgICAgICAgICAgICAgICAgICAiYWRkaXRpb25hbEFyZ3VtZW50cyI6IFsiLS1kZWZhdWx0LWNt YWtlLWZlYXR1cmVzIl0sCisgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBbImd0 ay1saW51eC1zbGF2ZS0xMCJdCisgICAgICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICAg ICAgICAgIHsKKyAgICAgICAgICAgICAgICAgICAgICAibmFtZSI6ICJHVEsgTGludXggNjQtYml0 IFJlbGVhc2UgVWJ1bnR1IExUUyAoQnVpbGQpIiwgInR5cGUiOiAiQnVpbGQiLCAiYnVpbGRkaXIi OiAiZ3RrLWxpbnV4LTY0LXJlbGVhc2UtdWJ1bnR1IiwKKyAgICAgICAgICAgICAgICAgICAgICAi cGxhdGZvcm0iOiAiZ3RrIiwgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsICJhcmNoaXRlY3R1 cmVzIjogWyJ4ODZfNjQiXSwKKyAgICAgICAgICAgICAgICAgICAgICAiYWRkaXRpb25hbEFyZ3Vt ZW50cyI6IFsiLS1kZWZhdWx0LWNtYWtlLWZlYXR1cmVzIl0sCisgICAgICAgICAgICAgICAgICAg ICAgInNsYXZlbmFtZXMiOiBbImd0ay1saW51eC1zbGF2ZS0xMSJdCisgICAgICAgICAgICAgICAg ICAgIH0sCisgICAgICAgICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAgICAgICAibmFt ZSI6ICJXaW5DYWlybyA2NC1CaXQgUmVsZWFzZSIsICJ0eXBlIjogIkJ1aWxkIiwgImJ1aWxkZGly IjogIndpbi1jYWlyby1yZWxlYXNlIiwKICAgICAgICAgICAgICAgICAgICAgICAicGxhdGZvcm0i OiAid2luY2Fpcm8iLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVjdHVyZXMi OiBbIng4Nl82NCJdLAogICAgICAgICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJ3aW5j YWlyby0xIiwgIndpbmNhaXJvLTIiXQpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZyBiL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKaW5kZXggOTk1ZjEwN2Nk MTI3Y2Y2MWEwMGE2NmM3YmM3YzRjYzA5ZWRiMmM1Ni4uZjU0OWIwZjU5NjA3Y2VhNmFhMjhlYmY3 MDhjNjZlYTdmMDFlYmY2OCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZworKysgYi9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCkBAIC03NzMsNyArNzczLDcg QEAgY2xhc3MgRmFjdG9yeShmYWN0b3J5LkJ1aWxkRmFjdG9yeSk6CiAgICAgICAgIHNlbGYuYWRk U3RlcChEZWxldGVTdGFsZUJ1aWxkRmlsZXMoKSkKICAgICAgICAgaWYgcGxhdGZvcm0gPT0gIndp biI6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoSW5zdGFsbFdpbjMyRGVwZW5kZW5jaWVzKCkp Ci0gICAgICAgIGlmIHBsYXRmb3JtID09ICJndGsiOgorICAgICAgICBpZiBwbGF0Zm9ybSA9PSAi Z3RrIiBhbmQgYWRkaXRpb25hbEFyZ3VtZW50cyAhPSBbIi0tZGVmYXVsdC1jbWFrZS1mZWF0dXJl cyJdOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKEluc3RhbGxHdGtEZXBlbmRlbmNpZXMoKSkK IAogCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXJjZmdfdW5pdHRlc3QucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXJjZmdfdW5pdHRlc3QucHkKaW5kZXggZTc2Mjdl NWNiMGY5ZTQzMjQ2NWE2ZDhlMTRmZDZjNzEzNzM5OTkzOS4uYjY3NjIyZWVmNDRmOGQ0MzE2NzEy YWYwYjcwYWJkYjVhOWMwYTVmYyAxMDA3NTUKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyY2ZnX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3RlcmNmZ191bml0 dGVzdC5weQpAQCAtNDE3LDYgKzQxNyw4IEBAIGV4cGVjdGVkX2J1aWxkX3N0ZXBzID0gewogICAg ICdHVEsgTGludXggNjQtYml0IFJlbGVhc2UgKFBlcmYpJyA6IFsnY29uZmlndXJlIGJ1aWxkJywg J3N2bicsICdraWxsIG9sZCBwcm9jZXNzZXMnLCAnZGVsZXRlIFdlYktpdEJ1aWxkIGRpcmVjdG9y eScsICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAnamhidWlsZCcsICdkb3dubG9hZC1idWls dC1wcm9kdWN0JywgJ2V4dHJhY3QtYnVpbHQtcHJvZHVjdCcsICdwZXJmLXRlc3QnLCAnYmVuY2ht YXJrLXRlc3QnXSwKICAgICAnR1RLIExpbnV4IDY0LWJpdCBSZWxlYXNlIChUZXN0cyknIDogWydj b25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHByb2Nlc3NlcycsICdkZWxldGUgV2Vi S2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWlsZCBmaWxlcycsICdqaGJ1aWxk JywgJ2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnZXh0cmFjdC1idWlsdC1wcm9kdWN0JywgJ2pz Y29yZS10ZXN0JywgJ2xheW91dC10ZXN0JywgJ3dlYmtpdHB5LXRlc3QnLCAnd2Via2l0cGVybC10 ZXN0JywgJ2JpbmRpbmdzLWdlbmVyYXRpb24tdGVzdHMnLCAnYnVpbHRpbnMtZ2VuZXJhdG9yLXRl c3RzJywgJ2FyY2hpdmUtdGVzdC1yZXN1bHRzJywgJ3VwbG9hZCcsICdNYXN0ZXJTaGVsbENvbW1h bmQnLCAnQVBJIHRlc3RzJ10sCiAgICAgJ0dUSyBMaW51eCA2NC1iaXQgUmVsZWFzZSBXYXlsYW5k IChUZXN0cyknIDogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywgJ2tpbGwgb2xkIHByb2Nlc3Nl cycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2RlbGV0ZSBzdGFsZSBidWlsZCBm aWxlcycsICdqaGJ1aWxkJywgJ2Rvd25sb2FkLWJ1aWx0LXByb2R1Y3QnLCAnZXh0cmFjdC1idWls dC1wcm9kdWN0JywgJ2pzY29yZS10ZXN0JywgJ2xheW91dC10ZXN0JywgJ3dlYmtpdHB5LXRlc3Qn LCAnd2Via2l0cGVybC10ZXN0JywgJ2JpbmRpbmdzLWdlbmVyYXRpb24tdGVzdHMnLCAnYnVpbHRp bnMtZ2VuZXJhdG9yLXRlc3RzJywgJ2FyY2hpdmUtdGVzdC1yZXN1bHRzJywgJ3VwbG9hZCcsICdN YXN0ZXJTaGVsbENvbW1hbmQnLCAnQVBJIHRlc3RzJ10sCisgICAgJ0dUSyBMaW51eCA2NC1iaXQg UmVsZWFzZSBVYnVudHUgTFRTIChCdWlsZCknIDogWydjb25maWd1cmUgYnVpbGQnLCAnc3ZuJywg J2tpbGwgb2xkIHByb2Nlc3NlcycsICdkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5JywgJ2Rl bGV0ZSBzdGFsZSBidWlsZCBmaWxlcycsICdjb21waWxlLXdlYmtpdCddLAorICAgICdHVEsgTGlu dXggNjQtYml0IFJlbGVhc2UgRGViaWFuIFN0YWJsZSAoQnVpbGQpJyA6IFsnY29uZmlndXJlIGJ1 aWxkJywgJ3N2bicsICdraWxsIG9sZCBwcm9jZXNzZXMnLCAnZGVsZXRlIFdlYktpdEJ1aWxkIGRp cmVjdG9yeScsICdkZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAnY29tcGlsZS13ZWJraXQnXSwK ICAgICAnR1RLIExpbnV4IEFSTSBSZWxlYXNlJyA6IFsnY29uZmlndXJlIGJ1aWxkJywgJ3N2bics ICdraWxsIG9sZCBwcm9jZXNzZXMnLCAnZGVsZXRlIFdlYktpdEJ1aWxkIGRpcmVjdG9yeScsICdk ZWxldGUgc3RhbGUgYnVpbGQgZmlsZXMnLCAnamhidWlsZCcsICdjb21waWxlLXdlYmtpdCcsICdq c2NvcmUtdGVzdCcsICd3ZWJraXRweS10ZXN0JywgJ3dlYmtpdHBlcmwtdGVzdCcsICdiaW5kaW5n cy1nZW5lcmF0aW9uLXRlc3RzJywgJ2J1aWx0aW5zLWdlbmVyYXRvci10ZXN0cycsICdBUEkgdGVz dHMnXSwKIAogICAgICdXaW5DYWlybyA2NC1CaXQgUmVsZWFzZScgOiBbJ2NvbmZpZ3VyZSBidWls ZCcsICdzdm4nLCAna2lsbCBvbGQgcHJvY2Vzc2VzJywgJ2RlbGV0ZSBXZWJLaXRCdWlsZCBkaXJl Y3RvcnknLCAnZGVsZXRlIHN0YWxlIGJ1aWxkIGZpbGVzJywgJ2NvbXBpbGUtd2Via2l0J10sCg==