168318 2017-02-14 07:36:50 -0800 [CMake] build-webkit should print the cmake command executed 2017-02-14 08:48:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168323 P2 Normal --- 1 clopez clopez achristensen ap bugs-noreply commit-queue dbates ggaren lforschler mcatanzaro mitz oldest_to_newest 1276729 0 clopez 2017-02-14 07:36:50 -0800 When using the script build-webkit, is not obvious at all what we end passing to the CMake build system. On one hand I think it should be easy to see that info. On the other hand, I find this info very valuable to be fully aware of what options we (and the bots) build and how (actually I'm really surprised to discover that on the GTK+ port we are passing more than 90 parameters to CMake on the release build) So I propose that we print the CMake commands that we are going to run on stdout. I think this don't adds unneeded extra noise, it only prints one extra line (a long one when starting from a clean build state) each time you run the build-webkit script. 1276734 1 301499 clopez 2017-02-14 07:46:50 -0800 Created attachment 301499 Patch 1276768 2 301499 commit-queue 2017-02-14 08:48:28 -0800 Comment on attachment 301499 Patch Clearing flags on attachment: 301499 Committed r212298: <http://trac.webkit.org/changeset/212298> 1276769 3 commit-queue 2017-02-14 08:48:33 -0800 All reviewed patches have been landed. Closing bug. 301499 2017-02-14 07:46:50 -0800 2017-02-14 08:48:28 -0800 Patch bug-168318-20170214164416.patch text/plain 2605 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMjg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGE0MWU4MDU4MTYzYTM1MTZhYjM1NzJmN2NhYzZhYjIy MzNjYzNlZi4uYWQxZGQyY2ViMTU0Njc1MjFkODVkMjcxZDVmMDVlNmUxYjkyY2I0MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE3LTAyLTE0ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gYnVpbGQtd2Via2l0IHNob3VsZCBwcmludCB0aGUg Y21ha2UgY29tbWFuZCBleGVjdXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY4MzE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUnVuIHRoZSBjbWFrZSBjb21tYW5kcyB0byBjb25maWd1cmUgb3Igc3Rh cnQgdGhlIGJ1aWxkIHRocm91Z2gKKyAgICAgICAgYSB3cmFwcGVyIHRoYXQgcHJpbnRzIHRoZSBj b21tYW5kIGJlZm9yZSBleGVjdXRpbmcgaXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRp cnMucG06CisgICAgICAgIChzeXN0ZW1WZXJib3NlKToKKyAgICAgICAgKGdlbmVyYXRlQnVpbGRT eXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KToKKyAgICAgICAgKGJ1aWxkQ01ha2VHZW5lcmF0ZWRQcm9q ZWN0KToKKyAgICAgICAgKGNsZWFuQ01ha2VHZW5lcmF0ZWRQcm9qZWN0KToKKwogMjAxNy0wMi0x NCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMjIzNy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA5NTE2ZmQ3 OTYxMmNhODI5N2NiYjRhM2M1Yzk1NzJlMzNmYWNmOTdjLi4wMzBjZDlmZjJiNjk1OWNlYzYxN2Ex ZTM2ZTQ5MWFmODkyMWZhMWViIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yODcsNiArMjg3LDExIEBA IHN1YiBkZXRlcm1pbmVCYXNlUHJvZHVjdERpcgogICAgIH0KIH0KIAorc3ViIHN5c3RlbVZlcmJv c2UgeworICAgIHByaW50ICIrIEBfXG4iOworICAgIHJldHVybiBzeXN0ZW0oQF8pOworfQorCiBz dWIgc2V0QmFzZVByb2R1Y3REaXIoJCkKIHsKICAgICAoJGJhc2VQcm9kdWN0RGlyKSA9IEBfOwpA QCAtMTk2Nyw3ICsxOTcyLDcgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9q ZWN0CiAgICAgIyBXZSBjYWxsIHN5c3RlbSgiY21ha2UgQGFyZ3MiKSBpbnN0ZWFkIG9mIHN5c3Rl bSgiY21ha2UiLCBAYXJncykgc28gdGhhdCBAYXJncyBpcwogICAgICMgcGFyc2VkIGZvciBzaGVs bCBtZXRhY2hhcmFjdGVycy4KICAgICBteSAkd3JhcHBlciA9IGpvaW4oIiAiLCB3cmFwcGVyUHJl Zml4SWZOZWVkZWQoKSkgLiAiICI7Ci0gICAgbXkgJHJldHVybkNvZGUgPSBzeXN0ZW0oJHdyYXBw ZXIgLiAiY21ha2UgQGFyZ3MiKTsKKyAgICBteSAkcmV0dXJuQ29kZSA9IHN5c3RlbVZlcmJvc2Uo JHdyYXBwZXIgLiAiY21ha2UgQGFyZ3MiKTsKIAogICAgIGNoZGlyKCRvcmlnaW5hbFdvcmtpbmdE aXJlY3RvcnkpOwogICAgIHJldHVybiAkcmV0dXJuQ29kZTsKQEAgLTIwMDEsNyArMjAwNiw3IEBA IHN1YiBidWlsZENNYWtlR2VuZXJhdGVkUHJvamVjdCgkKQogICAgICMgV2UgY2FsbCBzeXN0ZW0o ImNtYWtlIEBhcmdzIikgaW5zdGVhZCBvZiBzeXN0ZW0oImNtYWtlIiwgQGFyZ3MpIHNvIHRoYXQg QGFyZ3MgaXMKICAgICAjIHBhcnNlZCBmb3Igc2hlbGwgbWV0YWNoYXJhY3RlcnMuIEluIHBhcnRp Y3VsYXIsICRtYWtlQXJncyBtYXkgY29udGFpbiBzdWNoIG1ldGFjaGFyYWN0ZXJzLgogICAgIG15 ICR3cmFwcGVyID0gam9pbigiICIsIHdyYXBwZXJQcmVmaXhJZk5lZWRlZCgpKSAuICIgIjsKLSAg ICByZXR1cm4gc3lzdGVtKCR3cmFwcGVyIC4gIiRjb21tYW5kIEBhcmdzIik7CisgICAgcmV0dXJu IHN5c3RlbVZlcmJvc2UoJHdyYXBwZXIgLiAiJGNvbW1hbmQgQGFyZ3MiKTsKIH0KIAogc3ViIGNs ZWFuQ01ha2VHZW5lcmF0ZWRQcm9qZWN0KCkKQEAgLTIwMDksNyArMjAxNCw3IEBAIHN1YiBjbGVh bkNNYWtlR2VuZXJhdGVkUHJvamVjdCgpCiAgICAgbXkgJGNvbmZpZyA9IGNvbmZpZ3VyYXRpb24o KTsKICAgICBteSAkYnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0RGly KCksICRjb25maWcpOwogICAgIGlmICgtZCAkYnVpbGRQYXRoKSB7Ci0gICAgICAgIHJldHVybiBz eXN0ZW0oImNtYWtlIiwgIi0tYnVpbGQiLCAkYnVpbGRQYXRoLCAiLS1jb25maWciLCAkY29uZmln LCAiLS10YXJnZXQiLCAiY2xlYW4iKTsKKyAgICAgICAgcmV0dXJuIHN5c3RlbVZlcmJvc2UoImNt YWtlIiwgIi0tYnVpbGQiLCAkYnVpbGRQYXRoLCAiLS1jb25maWciLCAkY29uZmlnLCAiLS10YXJn ZXQiLCAiY2xlYW4iKTsKICAgICB9CiAgICAgcmV0dXJuIDA7CiB9Cg==