16828 2008-01-10 15:32:24 -0800 WebView never paints if first page load is canceled after being committed but before layout 2008-01-11 13:06:39 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar P2 Normal --- 1 aroben aroben hyatt oldest_to_newest 66826 0 aroben 2008-01-10 15:32:24 -0800 WebView never paints if the first page load is canceled after the load is committed but before the first layout occurs. To reproduce: 1. Run a WebKit nightly <http://nightly.webkit.org/> 2. Set your Safari preferences to open new windows with a web page that loads slowly 3. Press Ctrl-N to create a new window 4. Quickly press Esc to cancel the load The result is that the WebView portion of the Safari window never paints until you load a new page. Dragging another window over the WebView area leaves behind garbage pixels. Resizing the window doesn't help. 66827 1 aroben 2008-01-10 15:33:39 -0800 The problem line of code seems to be this <http://trac.webkit.org/projects/webkit/browser/trunk/WebKit/win/WebView.cpp?rev=29369#L1590>: if (!webView->isPainting() && (!dataSource || coreFrame && (coreFrame->view()->didFirstLayout() || !coreFrame->loader()->committedFirstRealDocumentLoad()))) didFirstLayout() is returning false and committedFirstRealDocumentLoad() is returning true. 66828 2 aroben 2008-01-10 15:34:15 -0800 <rdar://problem/5682402> 66830 3 hyatt 2008-01-10 15:35:33 -0800 firstLayout was a hack put in on Windows prior to having the full networking layer (with its notion of being "committed") ported over from Mac. I suspect the firstLayout check is no longer needed (and does not match Mac anyway). 66831 4 aroben 2008-01-10 15:38:14 -0800 Hyatt also says we should make sure the Windows and Mac agree on when painting should be suppressed. 66947 5 aroben 2008-01-11 12:25:29 -0800 I have a fix for this. 66950 6 18399 aroben 2008-01-11 12:34:30 -0800 Created attachment 18399 patch 1/2 66951 7 18400 aroben 2008-01-11 12:40:14 -0800 Created attachment 18400 patch 2/2 66952 8 18399 hyatt 2008-01-11 12:41:21 -0800 Comment on attachment 18399 patch 1/2 r=me 66953 9 18400 hyatt 2008-01-11 12:42:01 -0800 Comment on attachment 18400 patch 2/2 r=me 66957 10 aroben 2008-01-11 13:06:39 -0800 Landed as r29415 and r29416 18399 2008-01-11 12:34:30 -0800 2008-01-11 12:41:21 -0800 patch 1/2 0001-Fix-Bug-16828-WebView-never-paints-if-first.patch text/plain 2883 aroben RnJvbSA2OGI4ZTdiODkyMmI5YjA4ZjJkMWJkZjAxYjE4Mzc0YzQxOGU2OTI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBG cmksIDExIEphbiAyMDA4IDE1OjIwOjUwIC0wNTAwClN1YmplY3Q6IFtQRlIgMS8yXSAgICAgICAg IEZpeCBCdWcgMTY4Mjg6IFdlYlZpZXcgbmV2ZXIgcGFpbnRzIGlmIGZpcnN0IHBhZ2UgbG9hZCBp cyBjYW5jZWxlZCBhZnRlciBiZWluZyBjb21taXR0ZWQgYnV0IGJlZm9yZSBsYXlvdXQKCiAgICAg ICAgPGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODI4PgogICAgICAg IDxyZGFyOi8vNTY4MjQwMj4KCiAgICAgICAgTm93IHRoYXQgd2UgaGF2ZSAxKSBhIHJlYWwgbG9h ZGVyIGFuZCAyKSBtdWx0aXBsZSBGcmFtZVZpZXdzIHBlcgogICAgICAgIEZyYW1lLCB3ZSBubyBs b25nZXIgbmVlZCB0aGUgaGFja2VyeSB3ZSBoYWQgaW4gb3VyIFdNX1BBSU5UIGhhbmRsZXIKICAg ICAgICB0aGF0IGRlY2lkZWQgd2hldGhlciBvciBub3QgdG8gcGFpbnQuIFdlIG5vdyBhbHdheXMg d2FudCB0byBwYWludCwKICAgICAgICBsZXR0aW5nIHRoZSBzd2FwcGluZyBvZiBGcmFtZVZpZXdz IHRoYXQgaGFwcGVucyBpbgogICAgICAgIHRyYW5zaXRpb25Ub0NvbW1pdHRlZEZvck5ld1BhZ2Ug aGFuZGxlIHdoaWNoIGRvY3VtZW50IGdldHMgcGFpbnRlZC4KCiAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViVmlldy5jcHA6CiAgICAgICAgKFdlYlZpZXdX bmRQcm9jKTogUmVtb3ZlZCBoYWNrZXJ5IHRoYXQgZGVjaWRlZCBzb21ldGltZXMgbm90IHRvIHBh aW50LgotLS0KIFdlYktpdC93aW4vQ2hhbmdlTG9nICAgfCAgIDE4ICsrKysrKysrKysrKysrKysr KwogV2ViS2l0L3dpbi9XZWJWaWV3LmNwcCB8ICAgIDggKy0tLS0tLS0KIDIgZmlsZXMgY2hhbmdl ZCwgMTkgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQv d2luL0NoYW5nZUxvZyBiL1dlYktpdC93aW4vQ2hhbmdlTG9nCmluZGV4IDhhNzgzN2MuLjI0YTA1 ZDMgMTAwNjQ0Ci0tLSBhL1dlYktpdC93aW4vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC93aW4vQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMDEtMTEgIEFkYW0gUm9iZW4gIDxhcm9iZW5A YXBwbGUuY29tPgorCisgICAgICAgIEZpeCBCdWcgMTY4Mjg6IFdlYlZpZXcgbmV2ZXIgcGFpbnRz IGlmIGZpcnN0IHBhZ2UgbG9hZCBpcyBjYW5jZWxlZCBhZnRlciBiZWluZyBjb21taXR0ZWQgYnV0 IGJlZm9yZSBsYXlvdXQKKworICAgICAgICA8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY4Mjg+CisgICAgICAgIDxyZGFyOi8vNTY4MjQwMj4KKworICAgICAgICBOb3cg dGhhdCB3ZSBoYXZlIDEpIGEgcmVhbCBsb2FkZXIgYW5kIDIpIG11bHRpcGxlIEZyYW1lVmlld3Mg cGVyCisgICAgICAgIEZyYW1lLCB3ZSBubyBsb25nZXIgbmVlZCB0aGUgaGFja2VyeSB3ZSBoYWQg aW4gb3VyIFdNX1BBSU5UIGhhbmRsZXIKKyAgICAgICAgdGhhdCBkZWNpZGVkIHdoZXRoZXIgb3Ig bm90IHRvIHBhaW50LiBXZSBub3cgYWx3YXlzIHdhbnQgdG8gcGFpbnQsCisgICAgICAgIGxldHRp bmcgdGhlIHN3YXBwaW5nIG9mIEZyYW1lVmlld3MgdGhhdCBoYXBwZW5zIGluCisgICAgICAgIHRy YW5zaXRpb25Ub0NvbW1pdHRlZEZvck5ld1BhZ2UgaGFuZGxlIHdoaWNoIGRvY3VtZW50IGdldHMg cGFpbnRlZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlld1duZFByb2MpOiBSZW1vdmVkIGhhY2tl cnkgdGhhdCBkZWNpZGVkIHNvbWV0aW1lcyBub3QgdG8gcGFpbnQuCisKIDIwMDgtMDEtMTEgIE1h cmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeC4g IFVwZGF0ZSB0byBtYXRjaCBtZXRob2QgbmFtZSBpbiBXZWJDb3JlLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L3dpbi9XZWJWaWV3LmNwcCBiL1dlYktpdC93aW4vV2ViVmlldy5jcHAKaW5kZXggOGRiODdh NS4uNmI4ZWFjMiAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAorKysgYi9XZWJL aXQvd2luL1dlYlZpZXcuY3BwCkBAIC0xNTg0LDEzICsxNTg0LDcgQEAgc3RhdGljIExSRVNVTFQg Q0FMTEJBQ0sgV2ViVmlld1duZFByb2MoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQQVJBTSB3 UGFyYW0sIEwKIAogICAgIHN3aXRjaCAobWVzc2FnZSkgewogICAgICAgICBjYXNlIFdNX1BBSU5U OiB7Ci0gICAgICAgICAgICBDT01QdHI8SVdlYkRhdGFTb3VyY2U+IGRhdGFTb3VyY2U7Ci0gICAg ICAgICAgICBtYWluRnJhbWVJbXBsLT5kYXRhU291cmNlKCZkYXRhU291cmNlKTsKLSAgICAgICAg ICAgIEZyYW1lKiBjb3JlRnJhbWUgPSBjb3JlKG1haW5GcmFtZUltcGwpOwotICAgICAgICAgICAg aWYgKCF3ZWJWaWV3LT5pc1BhaW50aW5nKCkgJiYgKCFkYXRhU291cmNlIHx8IGNvcmVGcmFtZSAm JiAoY29yZUZyYW1lLT52aWV3KCktPmRpZEZpcnN0TGF5b3V0KCkgfHwgIWNvcmVGcmFtZS0+bG9h ZGVyKCktPmNvbW1pdHRlZEZpcnN0UmVhbERvY3VtZW50TG9hZCgpKSkpCi0gICAgICAgICAgICAg ICAgd2ViVmlldy0+cGFpbnQoMCwgMCk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAg ICAgVmFsaWRhdGVSZWN0KGhXbmQsIDApOworICAgICAgICAgICAgd2ViVmlldy0+cGFpbnQoMCwg MCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBjYXNlIFdNX1BSSU5U Q0xJRU5UOgotLSAKMS41LjMuNC4xMzQyLmc4YjZhMQoK 18400 2008-01-11 12:40:14 -0800 2008-01-11 12:42:01 -0800 patch 2/2 0002-Remove-FrameLoader-committedFirstRealDocume.patch text/plain 1523 aroben RnJvbSA0MGNlMWIxMDE3ZTIyNzA5YzY5NWFhNDM0MDBhN2Y2Yzk5OTA5NWY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBG cmksIDExIEphbiAyMDA4IDE1OjIyOjUzIC0wNTAwClN1YmplY3Q6IFtQRlIgMi8yXSAgICAgICAg IFJlbW92ZSBGcmFtZUxvYWRlcjo6Y29tbWl0dGVkRmlyc3RSZWFsRG9jdW1lbnRMb2FkCgogICAg ICAgIFRoaXMgbWV0aG9kIG5vIGxvbmdlciBoYXMgYW55IGNhbGxlcnMuCgogICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5oOgot LS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIFdlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmggfCAgICAxIC0KIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDllN2NhYzguLmQwMzc3ZTUgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMDgtMDEtMTEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAg IFJlbW92ZSBGcmFtZUxvYWRlcjo6Y29tbWl0dGVkRmlyc3RSZWFsRG9jdW1lbnRMb2FkCisgICAg ICAgIAorICAgICAgICBUaGlzIG1ldGhvZCBubyBsb25nZXIgaGFzIGFueSBjYWxsZXJzLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL0Zy YW1lTG9hZGVyLmg6CisKIDIwMDgtMDEtMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4K IAogICAgICAgICBRdCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5oIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAppbmRleCBiMDEwNTRiLi41 NTgxOThjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCisrKyBiL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKQEAgLTE3OSw3ICsxNzksNiBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgICAgIGJvb2wgaXNMb2FkaW5nTWFpblJlc291cmNlKCkgY29uc3QgeyBy ZXR1cm4gbV9pc0xvYWRpbmdNYWluUmVzb3VyY2U7IH0KICAgICAgICAgYm9vbCBpc0xvYWRpbmco KSBjb25zdDsKICAgICAgICAgYm9vbCBmcmFtZUhhc0xvYWRlZCgpIGNvbnN0OwotICAgICAgICBi b29sIGNvbW1pdHRlZEZpcnN0UmVhbERvY3VtZW50TG9hZCgpIGNvbnN0IHsgcmV0dXJuIG1fY29t bWl0dGVkRmlyc3RSZWFsRG9jdW1lbnRMb2FkOyB9CiAKICAgICAgICAgaW50IG51bVBlbmRpbmdP ckxvYWRpbmdSZXF1ZXN0cyhib29sIHJlY3Vyc2UpIGNvbnN0OwogICAgICAgICBib29sIGlzUmVs b2FkaW5nKCkgY29uc3Q7Ci0tIAoxLjUuMy40LjEzNDIuZzhiNmExCgo=