<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>168252</bug_id>
          
          <creation_ts>2017-02-13 13:51:27 -0800</creation_ts>
          <short_desc>Log to the History Channel in a few more places</short_desc>
          <delta_ts>2017-02-13 14:55:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Simon Fraser (smfr)">simon.fraser</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>japhet</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1276351</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2017-02-13 13:51:27 -0800</bug_when>
    <thetext>Log to the History Channel in a few more places</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1276352</commentid>
    <comment_count>1</comment_count>
      <attachid>301385</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2017-02-13 13:52:11 -0800</bug_when>
    <thetext>Created attachment 301385
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1276354</commentid>
    <comment_count>2</comment_count>
      <attachid>301385</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2017-02-13 13:55:25 -0800</bug_when>
    <thetext>Comment on attachment 301385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301385&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        *** Aliens ***

?

http://i.imgur.com/W84BtfO.jpg ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1276380</commentid>
    <comment_count>3</comment_count>
      <attachid>301385</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-13 14:55:23 -0800</bug_when>
    <thetext>Comment on attachment 301385
Patch

Clearing flags on attachment: 301385

Committed r212250: &lt;http://trac.webkit.org/changeset/212250&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1276381</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-13 14:55:30 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>301385</attachid>
            <date>2017-02-13 13:52:11 -0800</date>
            <delta_ts>2017-02-13 14:55:23 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-168252-20170213134939.patch</filename>
            <type>text/plain</type>
            <size>5373</size>
            <attacher name="Simon Fraser (smfr)">simon.fraser</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NhNjFjZTY2Y2JjY2Qw
MTUxNzg2OGRkOWFhMjMyNDlmZGM5YWM3NS4uY2M1YjAyYmIyODA5ZGU2ZTRhYjM5OTU1N2ZjYWE1
OWEyYWIxM2E5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTAyLTEzICBTaW1v
biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIExvZyB0byB0aGUg
SGlzdG9yeSBDaGFubmVsIGluIGEgZmV3IG1vcmUgcGxhY2VzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgyNTIKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqKiogQWxpZW5zICoqKgorCisgICAgICAgICog
bG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlD
b250cm9sbGVyOjpyZXN0b3JlU2Nyb2xsUG9zaXRpb25BbmRWaWV3U3RhdGUpOgorICAgICAgICAo
V2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6OnVwZGF0ZUZvclJlbG9hZCk6CisgICAgICAgICog
bG9hZGVyL05hdmlnYXRpb25TY2hlZHVsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmF2aWdh
dGlvblNjaGVkdWxlcjo6c2NoZWR1bGVIaXN0b3J5TmF2aWdhdGlvbik6CisgICAgICAgIChXZWJD
b3JlOjpOYXZpZ2F0aW9uU2NoZWR1bGVyOjp0aW1lckZpcmVkKToKKyAgICAgICAgKFdlYkNvcmU6
Ok5hdmlnYXRpb25TY2hlZHVsZXI6OmNhbmNlbCk6CisgICAgICAgICogcGFnZS9IaXN0b3J5LmNw
cDoKKyAgICAgICAgKFdlYkNvcmU6Okhpc3Rvcnk6OmdvKToKKwogMjAxNy0wMi0xMiAgQ2FybG9z
IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gSGFu
ZGxlIGNhcHMgbG9jayBpbmRpY2F0b3IgaW4gZXZlbnQgbW9kaWZpZXJzCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNv
cmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAppbmRleCAwOWI4ZDY2ODQxMWI5ODI0NjQ1
MzY0ZGU3MDc1OGM2NjdiMThiMDk3Li5mZDFiNTE2YTM2MzgxMmIyMGFjNGIzNGUzNmNjZWY5YTMy
NTIyNjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xs
ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAK
QEAgLTE1OSw3ICsxNTksNyBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZXN0b3JlU2Nyb2xs
UG9zaXRpb25BbmRWaWV3U3RhdGUoKQogICAgIGlmICh2aWV3ICYmICF2aWV3LT53YXNTY3JvbGxl
ZEJ5VXNlcigpKSB7CiAgICAgICAgIFBhZ2UqIHBhZ2UgPSBtX2ZyYW1lLnBhZ2UoKTsKICAgICAg
ICAgYXV0byBkZXNpcmVkU2Nyb2xsUG9zaXRpb24gPSBtX2N1cnJlbnRJdGVtLT5zY3JvbGxQb3Np
dGlvbigpOwotCisgICAgICAgIExPRyhTY3JvbGxpbmcsICJIaXN0b3J5Q29udHJvbGxlcjo6cmVz
dG9yZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlIHNjcm9sbGluZyB0byAlZCwlZCIsIGRlc2ly
ZWRTY3JvbGxQb3NpdGlvbi54KCksIGRlc2lyZWRTY3JvbGxQb3NpdGlvbi55KCkpOwogICAgICAg
ICBpZiAocGFnZSAmJiBtX2ZyYW1lLmlzTWFpbkZyYW1lKCkgJiYgbV9jdXJyZW50SXRlbS0+cGFn
ZVNjYWxlRmFjdG9yKCkpCiAgICAgICAgICAgICBwYWdlLT5zZXRQYWdlU2NhbGVGYWN0b3IobV9j
dXJyZW50SXRlbS0+cGFnZVNjYWxlRmFjdG9yKCkgKiBwYWdlLT52aWV3U2NhbGVGYWN0b3IoKSwg
ZGVzaXJlZFNjcm9sbFBvc2l0aW9uKTsKICAgICAgICAgZWxzZQpAQCAtMzQ5LDcgKzM0OSw3IEBA
IHZvaWQgSGlzdG9yeUNvbnRyb2xsZXI6OnVwZGF0ZUZvckJhY2tGb3J3YXJkTmF2aWdhdGlvbigp
CiAKIHZvaWQgSGlzdG9yeUNvbnRyb2xsZXI6OnVwZGF0ZUZvclJlbG9hZCgpCiB7Ci0gICAgTE9H
KEhpc3RvcnksICJIaXN0b3J5Q29udHJvbGxlciAlcCB1cGRhdGVGb3JCYWNrRm9yd2FyZE5hdmln
YXRpb246IFVwZGF0aW5nIEhpc3RvcnkgZm9yIHJlbG9hZCBpbiBmcmFtZSAlcCAobWFpbiBmcmFt
ZSAlZCkgJXMiLCB0aGlzLCAmbV9mcmFtZSwgbV9mcmFtZS5pc01haW5GcmFtZSgpLCBtX2ZyYW1l
LmxvYWRlcigpLmRvY3VtZW50TG9hZGVyKCkgPyBtX2ZyYW1lLmxvYWRlcigpLmRvY3VtZW50TG9h
ZGVyKCktPnVybCgpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCkgOiAiIik7CisgICAgTE9HKEhpc3Rv
cnksICJIaXN0b3J5Q29udHJvbGxlciAlcCB1cGRhdGVGb3JSZWxvYWQ6IFVwZGF0aW5nIEhpc3Rv
cnkgZm9yIHJlbG9hZCBpbiBmcmFtZSAlcCAobWFpbiBmcmFtZSAlZCkgJXMiLCB0aGlzLCAmbV9m
cmFtZSwgbV9mcmFtZS5pc01haW5GcmFtZSgpLCBtX2ZyYW1lLmxvYWRlcigpLmRvY3VtZW50TG9h
ZGVyKCkgPyBtX2ZyYW1lLmxvYWRlcigpLmRvY3VtZW50TG9hZGVyKCktPnVybCgpLnN0cmluZygp
LnV0ZjgoKS5kYXRhKCkgOiAiIik7CiAKICAgICBpZiAobV9jdXJyZW50SXRlbSkgewogICAgICAg
ICBQYWdlQ2FjaGU6OnNpbmdsZXRvbigpLnJlbW92ZSgqbV9jdXJyZW50SXRlbSk7CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvTmF2aWdhdGlvblNjaGVkdWxlci5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS9sb2FkZXIvTmF2aWdhdGlvblNjaGVkdWxlci5jcHAKaW5kZXggMGU1YjY0ZGM3
OGRjN2ZiNDU0NTEzOTU0ODIwNzdhNWMyNmIxMGRlYS4uNmU1YWRlZmJiNzZkMGQwYTRjNzY5Zjll
Y2Q0MjI1OTNjYzMyYmY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL05hdmln
YXRpb25TY2hlZHVsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9OYXZpZ2F0aW9u
U2NoZWR1bGVyLmNwcApAQCAtNDYsNiArNDYsNyBAQAogI2luY2x1ZGUgIkhUTUxGcmFtZU93bmVy
RWxlbWVudC5oIgogI2luY2x1ZGUgIkhpc3RvcnlJdGVtLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9y
SW5zdHJ1bWVudGF0aW9uLmgiCisjaW5jbHVkZSAiTG9nZ2luZy5oIgogI2luY2x1ZGUgIlBhZ2Uu
aCIKICNpbmNsdWRlICJTY3JpcHRDb250cm9sbGVyLmgiCiAjaW5jbHVkZSAiVXNlckdlc3R1cmVJ
bmRpY2F0b3IuaCIKQEAgLTQ2Miw2ICs0NjMsNyBAQCB2b2lkIE5hdmlnYXRpb25TY2hlZHVsZXI6
OnNjaGVkdWxlUmVmcmVzaChEb2N1bWVudCYgaW5pdGlhdGluZ0RvY3VtZW50KQogCiB2b2lkIE5h
dmlnYXRpb25TY2hlZHVsZXI6OnNjaGVkdWxlSGlzdG9yeU5hdmlnYXRpb24oaW50IHN0ZXBzKQog
eworICAgIExPRyhIaXN0b3J5LCAiTmF2aWdhdGlvblNjaGVkdWxlciAlcCBzY2hlZHVsZUhpc3Rv
cnlOYXZpZ2F0aW9uKCVkKSAtIHNob3VsZFNjaGVkdWxlICVkIiwgdGhpcywgc3RlcHMsIHNob3Vs
ZFNjaGVkdWxlTmF2aWdhdGlvbigpKTsKICAgICBpZiAoIXNob3VsZFNjaGVkdWxlTmF2aWdhdGlv
bigpKQogICAgICAgICByZXR1cm47CiAKQEAgLTQ5NSw2ICs0OTcsOCBAQCB2b2lkIE5hdmlnYXRp
b25TY2hlZHVsZXI6OnRpbWVyRmlyZWQoKQogICAgIFJlZjxGcmFtZT4gcHJvdGVjdChtX2ZyYW1l
KTsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxTY2hlZHVsZWROYXZpZ2F0aW9uPiByZWRpcmVjdCA9
IFdURk1vdmUobV9yZWRpcmVjdCk7CisgICAgTE9HKEhpc3RvcnksICJOYXZpZ2F0aW9uU2NoZWR1
bGVyICVwIHRpbWVyRmlyZWQgLSBmaXJpbmcgcmVkaXJlY3QgJXAiLCB0aGlzLCByZWRpcmVjdC5n
ZXQoKSk7CisKICAgICByZWRpcmVjdC0+ZmlyZShtX2ZyYW1lKTsKICAgICBJbnNwZWN0b3JJbnN0
cnVtZW50YXRpb246OmZyYW1lQ2xlYXJlZFNjaGVkdWxlZE5hdmlnYXRpb24obV9mcmFtZSk7CiB9
CkBAIC01NDUsNiArNTQ5LDggQEAgdm9pZCBOYXZpZ2F0aW9uU2NoZWR1bGVyOjpzdGFydFRpbWVy
KCkKIAogdm9pZCBOYXZpZ2F0aW9uU2NoZWR1bGVyOjpjYW5jZWwoYm9vbCBuZXdMb2FkSW5Qcm9n
cmVzcykKIHsKKyAgICBMT0coSGlzdG9yeSwgIk5hdmlnYXRpb25TY2hlZHVsZXIgJXAgY2FuY2Vs
KG5ld0xvYWRJblByb2dyZXNzPSVkKSIsIHRoaXMsIG5ld0xvYWRJblByb2dyZXNzKTsKKwogICAg
IGlmIChtX3RpbWVyLmlzQWN0aXZlKCkpCiAgICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlv
bjo6ZnJhbWVDbGVhcmVkU2NoZWR1bGVkTmF2aWdhdGlvbihtX2ZyYW1lKTsKICAgICBtX3RpbWVy
LnN0b3AoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5jcHAgYi9T
b3VyY2UvV2ViQ29yZS9wYWdlL0hpc3RvcnkuY3BwCmluZGV4IDBkYWVkZDQ5NWEyZjhkMzMxMWRh
MWZkMzBlZTViNGM2MDViYzg5M2YuLmZiYzUyZjNjOTI5YjRkMjIyZmU4ZmE3YzVlZmZiMzQ1NGQ3
ZmRiYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvSGlzdG9yeS5jcHAKKysrIGIv
U291cmNlL1dlYkNvcmUvcGFnZS9IaXN0b3J5LmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1
ZGUgIkZyYW1lTG9hZGVyQ2xpZW50LmgiCiAjaW5jbHVkZSAiSGlzdG9yeUNvbnRyb2xsZXIuaCIK
ICNpbmNsdWRlICJIaXN0b3J5SXRlbS5oIgorI2luY2x1ZGUgIkxvZ2dpbmcuaCIKICNpbmNsdWRl
ICJNYWluRnJhbWUuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiU2NyaXB0Q29udHJv
bGxlci5oIgpAQCAtMTA2LDYgKzEwNyw4IEBAIHZvaWQgSGlzdG9yeTo6Zm9yd2FyZChEb2N1bWVu
dCYgZG9jdW1lbnQpCiAKIHZvaWQgSGlzdG9yeTo6Z28oaW50IGRpc3RhbmNlKQogeworICAgIExP
RyhIaXN0b3J5LCAiSGlzdG9yeSAlcCBnbyglZCkgZnJhbWUgJXAgKG1haW4gZnJhbWUgJWQpIiwg
dGhpcywgZGlzdGFuY2UsIG1fZnJhbWUsIG1fZnJhbWUgPyBtX2ZyYW1lLT5pc01haW5GcmFtZSgp
IDogZmFsc2UpOworCiAgICAgaWYgKCFtX2ZyYW1lKQogICAgICAgICByZXR1cm47CiAKQEAgLTEx
NCw2ICsxMTcsOCBAQCB2b2lkIEhpc3Rvcnk6OmdvKGludCBkaXN0YW5jZSkKIAogdm9pZCBIaXN0
b3J5OjpnbyhEb2N1bWVudCYgZG9jdW1lbnQsIGludCBkaXN0YW5jZSkKIHsKKyAgICBMT0coSGlz
dG9yeSwgIkhpc3RvcnkgJXAgZ28oJWQpIGluIGRvY3VtZW50ICVwIGZyYW1lICVwIChtYWluIGZy
YW1lICVkKSIsIHRoaXMsIGRpc3RhbmNlLCAmZG9jdW1lbnQsIG1fZnJhbWUsIG1fZnJhbWUgPyBt
X2ZyYW1lLT5pc01haW5GcmFtZSgpIDogZmFsc2UpOworCiAgICAgaWYgKCFtX2ZyYW1lKQogICAg
ICAgICByZXR1cm47CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>