168187 2017-02-12 03:34:48 -0800 [SOUP] Downloads fail when the given destination is not a URI 2017-02-12 09:07:21 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Soup P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply commit-queue oldest_to_newest 1275959 0 cgarcia 2017-02-12 03:34:48 -0800 It always expects a uri, and fails if a local path is given. This is causing several test to fail. 1275960 1 301302 cgarcia 2017-02-12 03:39:05 -0800 Created attachment 301302 Patch 1275983 2 301302 commit-queue 2017-02-12 09:07:18 -0800 Comment on attachment 301302 Patch Clearing flags on attachment: 301302 Committed r212206: <http://trac.webkit.org/changeset/212206> 1275984 3 commit-queue 2017-02-12 09:07:21 -0800 All reviewed patches have been landed. Closing bug. 301302 2017-02-12 03:39:05 -0800 2017-02-12 09:07:18 -0800 Patch wk2-download-local-path.diff text/plain 3330 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0YmU1NDQwZTYzYS4uMjliMzhlMzM3NGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNy0wMi0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW1NPVVBdIERvd25sb2FkcyBmYWlsIHdoZW4gdGhlIGdpdmVu IGRlc3RpbmF0aW9uIGlzIG5vdCBhIFVSSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY4MTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSXQgYWx3YXlzIGV4cGVjdHMgYSB1cmksIGFuZCBmYWlscyBpZiBh IGxvY2FsIHBhdGggaXMgZ2l2ZW4uCisKKyAgICAgICAgRml4ZXM6IGh0dHAvdGVzdHMvZG93bmxv YWQvYW5jaG9yLWRvd25sb2FkLW5vLWV4dGVuc2lvbi5odG1sCisgICAgICAgICAgICAgICBodHRw L3Rlc3RzL2Rvd25sb2FkL2FyZWEtZG93bmxvYWQuaHRtbAorICAgICAgICAgICAgICAgaHR0cC90 ZXN0cy9zZWN1cml0eS9hbmNob3ItZG93bmxvYWQtYWxsb3ctZGF0YS5odG1sCisgICAgICAgICAg ICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L2FuY2hvci1kb3dubG9hZC1hbGxvdy1zYW1lb3JpZ2lu Lmh0bWwKKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291 cC5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFza1NvdXA6OmRvd25sb2FkKTog VXNlIGdfZmlsZV9uZXdfZm9yX3BhdGgoKSBpZiB0aGUgcGVuZGluZyBkZXN0aW5hdGlvbiBpcyBh IHBhdGggaW5zdGVhZAorICAgICAgICBvZiBhIFVSSS4KKworMjAxNy0wMi0xMiAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gSGFuZGxl IGNhcHMgbG9jayBpbmRpY2F0b3IgaW4gZXZlbnQgbW9kaWZpZXJzCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgxODYKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0YVRhc2tTb3VwLmNwcCBi L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5j cHAKaW5kZXggYzVkYTg2NTVmMGMuLmZiZTMyNTlkNjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5jcHAK QEAgLTgzOSw3ICs4MzksMTAgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3VwOjpkb3dubG9hZCgp CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBtX2Rvd25sb2FkRGVzdGluYXRpb25GaWxl ID0gYWRvcHRHUmVmKGdfZmlsZV9uZXdfZm9yX3VyaShtX3BlbmRpbmdEb3dubG9hZExvY2F0aW9u LnV0ZjgoKS5kYXRhKCkpKTsKKyAgICBpZiAoZ19wYXRoX2lzX2Fic29sdXRlKG1fcGVuZGluZ0Rv d25sb2FkTG9jYXRpb24udXRmOCgpLmRhdGEoKSkpCisgICAgICAgIG1fZG93bmxvYWREZXN0aW5h dGlvbkZpbGUgPSBhZG9wdEdSZWYoZ19maWxlX25ld19mb3JfcGF0aChtX3BlbmRpbmdEb3dubG9h ZExvY2F0aW9uLnV0ZjgoKS5kYXRhKCkpKTsKKyAgICBlbHNlCisgICAgICAgIG1fZG93bmxvYWRE ZXN0aW5hdGlvbkZpbGUgPSBhZG9wdEdSZWYoZ19maWxlX25ld19mb3JfdXJpKG1fcGVuZGluZ0Rv d25sb2FkTG9jYXRpb24udXRmOCgpLmRhdGEoKSkpOwogICAgIEdSZWZQdHI8R0ZpbGVPdXRwdXRT dHJlYW0+IG91dHB1dFN0cmVhbTsKICAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7CiAg ICAgaWYgKG1fYWxsb3dPdmVyd3JpdGVEb3dubG9hZCkKQEAgLTg1MSw4ICs4NTQsOSBAQCB2b2lk IE5ldHdvcmtEYXRhVGFza1NvdXA6OmRvd25sb2FkKCkKICAgICAgICAgcmV0dXJuOwogICAgIH0K IAotICAgIFN0cmluZyBpbnRlcm1lZGlhdGVVUkkgPSBtX3BlbmRpbmdEb3dubG9hZExvY2F0aW9u ICsgIi53a2Rvd25sb2FkIjsKLSAgICBtX2Rvd25sb2FkSW50ZXJtZWRpYXRlRmlsZSA9IGFkb3B0 R1JlZihnX2ZpbGVfbmV3X2Zvcl91cmkoaW50ZXJtZWRpYXRlVVJJLnV0ZjgoKS5kYXRhKCkpKTsK KyAgICBHVW5pcXVlUHRyPGNoYXI+IGRvd25sb2FkRGVzdGluYXRpb25VUkkoZ19maWxlX2dldF91 cmkobV9kb3dubG9hZERlc3RpbmF0aW9uRmlsZS5nZXQoKSkpOworICAgIEdVbmlxdWVQdHI8Y2hh cj4gaW50ZXJtZWRpYXRlVVJJKGdfc3RyZHVwX3ByaW50ZigiJXMud2tkb3dubG9hZCIsIGRvd25s b2FkRGVzdGluYXRpb25VUkkuZ2V0KCkpKTsKKyAgICBtX2Rvd25sb2FkSW50ZXJtZWRpYXRlRmls ZSA9IGFkb3B0R1JlZihnX2ZpbGVfbmV3X2Zvcl91cmkoaW50ZXJtZWRpYXRlVVJJLmdldCgpKSk7 CiAgICAgb3V0cHV0U3RyZWFtID0gYWRvcHRHUmVmKGdfZmlsZV9yZXBsYWNlKG1fZG93bmxvYWRJ bnRlcm1lZGlhdGVGaWxlLmdldCgpLCAwLCBUUlVFLCBHX0ZJTEVfQ1JFQVRFX05PTkUsIDAsICZl cnJvci5vdXRQdHIoKSkpOwogICAgIGlmICghb3V0cHV0U3RyZWFtKSB7CiAgICAgICAgIGRpZEZh aWxEb3dubG9hZChwbGF0Zm9ybURvd25sb2FkRGVzdGluYXRpb25FcnJvcihtX3Jlc3BvbnNlLCBl cnJvci0+bWVzc2FnZSkpOwpAQCAtODY0LDcgKzg2OCw3IEBAIHZvaWQgTmV0d29ya0RhdGFUYXNr U291cDo6ZG93bmxvYWQoKQogICAgIGF1dG8gZG93bmxvYWQgPSBzdGQ6Om1ha2VfdW5pcXVlPERv d25sb2FkPihkb3dubG9hZE1hbmFnZXIsIG1fcGVuZGluZ0Rvd25sb2FkSUQsICp0aGlzLCBtX3Nl c3Npb24tPnNlc3Npb25JRCgpLCBzdWdnZXN0ZWRGaWxlbmFtZSgpKTsKICAgICBhdXRvKiBkb3du bG9hZFB0ciA9IGRvd25sb2FkLmdldCgpOwogICAgIGRvd25sb2FkTWFuYWdlci5kYXRhVGFza0Jl Y2FtZURvd25sb2FkVGFzayhtX3BlbmRpbmdEb3dubG9hZElELCBXVEZNb3ZlKGRvd25sb2FkKSk7 Ci0gICAgZG93bmxvYWRQdHItPmRpZENyZWF0ZURlc3RpbmF0aW9uKG1fcGVuZGluZ0Rvd25sb2Fk TG9jYXRpb24pOworICAgIGRvd25sb2FkUHRyLT5kaWRDcmVhdGVEZXN0aW5hdGlvbihTdHJpbmc6 OmZyb21VVEY4KGRvd25sb2FkRGVzdGluYXRpb25VUkkuZ2V0KCkpKTsKIAogICAgIEFTU0VSVCgh bV9jbGllbnQpOwogICAgIHJlYWQoKTsK