168163 2017-02-11 00:46:05 -0800 [GTK][EFL] Implement MIMETypeRegistry::getPreferredExtensionForMIMEType 2017-02-12 11:08:20 -0800 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168193 Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1275768 0 cgarcia 2017-02-11 00:46:05 -0800 It's missing causing several HTML anchor download tests to fail because the suggested filename missed the extension. 1275769 1 301248 cgarcia 2017-02-11 00:49:34 -0800 Created attachment 301248 Patch 1275782 2 301248 mcatanzaro 2017-02-11 06:28:12 -0800 Comment on attachment 301248 Patch r=me but I'm not happy about the code duplication between MIMETypeRegistryEfl.cpp and MIMETypeRegistryGtk.cpp. Normally that means EFL gets an older and buggier version of our code for no good reason, but in this case it looks like the opposite is true, since EFL has more MIME types than us in its map. This should really be refactored into MIMETypeRegistryGeneric.cpp, which would be easy. 1275783 3 cgarcia 2017-02-11 06:31:39 -0800 Committed r212192: <http://trac.webkit.org/changeset/212192> 1276006 4 mcatanzaro 2017-02-12 11:08:20 -0800 It broke TestDownloads: bug #168193 301248 2017-02-11 00:49:34 -0800 2017-02-11 06:28:12 -0800 Patch wk-extension-from-mime.diff text/plain 5253 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiNTU3ODc5NmJkMy4uZjc5Y2ZlMjNkYTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOSBAQAorMjAxNy0wMi0xMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bRUZMXSBJbXBsZW1lbnQgTUlNRVR5cGVSZWdpc3Ry eTo6Z2V0UHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlNRVR5cGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODE2MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0J3MgbWlzc2luZyBjYXVzaW5nIHNldmVyYWwg SFRNTCBhbmNob3IgZG93bmxvYWQgdGVzdHMgdG8gZmFpbCBiZWNhdXNlIHRoZSBzdWdnZXN0ZWQg ZmlsZW5hbWUgbWlzc2VkIHRoZQorICAgICAgICBleHRlbnNpb24uIFRoaXMgcGF0Y2ggbW92ZXMg TUlNRVR5cGVSZWdpc3RyeTo6YXBwZW5kRmlsZUV4dGVuc2lvbklmTmVjZXNzYXJ5KCkgZnJvbSB0 aGUgY29jb2Egc3BlY2lmaWMgZmlsZSB0byB0aGUKKyAgICAgICAgY29tbW9uIGZpbGUgYmVjYXVz ZSBpdCdzIG5vdCBhY3R1YWxseSBwbGF0Zm9ybSBzcGVjaWZpYy4gTUlNRVR5cGVSZWdpc3RyeTo6 Z2V0UHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlNRVR5cGUoKSBpcworICAgICAgICB3aGF0IHBsYXRm b3JtcyBzaG91bGQgaW1wbGVtZW50LgorCisgICAgICAgIEZpeGVzOiBmYXN0L2RvbS9IVE1MQW5j aG9yRWxlbWVudC9hbmNob3ItZG93bmxvYWQtdXNlci10cmlnZ2VyZWQtc3ludGhldGljLWNsaWNr Lmh0bWwKKyAgICAgICAgICAgICAgIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1k b3dubG9hZC5odG1sCisgICAgICAgICAgICAgICBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9h bmNob3ItZmlsZS1ibG9iLWRvd25sb2FkLW5vLWV4dGVuc2lvbi5odG1sCisgICAgICAgICAgICAg ICBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3Itbm9kb3dubG9hZC1zZXQuaHRtbAor CisgICAgICAgICogcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpNSU1FVHlwZVJlZ2lzdHJ5OjphcHBlbmRGaWxlRXh0ZW5zaW9uSWZOZWNlc3NhcnkpOgor ICAgICAgICAqIHBsYXRmb3JtL2NvY29hL01JTUVUeXBlUmVnaXN0cnlDb2NvYS5tbToKKyAgICAg ICAgKFdlYkNvcmU6Ok1JTUVUeXBlUmVnaXN0cnk6OmFwcGVuZEZpbGVFeHRlbnNpb25JZk5lY2Vz c2FyeSk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vZWZsL01JTUVUeXBlUmVnaXN0cnlF ZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TUlNRVR5cGVSZWdpc3RyeTo6Z2V0UHJlZmVycmVk RXh0ZW5zaW9uRm9yTUlNRVR5cGUpOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9NSU1FVHlwZVJl Z2lzdHJ5R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1JTUVUeXBlUmVnaXN0cnk6OmdldFBy ZWZlcnJlZEV4dGVuc2lvbkZvck1JTUVUeXBlKToKKwogMjAxNy0wMi0xMCAgSm9obiBXaWxhbmRl ciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGVzIHRvIFJlc291cmNlIExv YWQgU3RhdGlzdGljczogR2V0IHRoZSByaWdodCB3ZWJzaXRlIGRhdGEgc3RvcmUgYW5kIGludHJv ZHVjZSB0aW1lb3V0IGZvciB1c2VyIGludGVyYWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL01JTUVUeXBlUmVnaXN0cnkuY3BwCmluZGV4IDY2NGU2ZDQzM2I4Li4zNGI4N2ZlMDk5MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAKQEAgLTc4 OCwxMyArNzg4LDE5IEBAIFN0cmluZyBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXROb3JtYWxpemVkTUlN RVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIAogI2VuZGlmCiAKLSNpZiAhUExBVEZPUk0o Q09DT0EpCi0KLVN0cmluZyBNSU1FVHlwZVJlZ2lzdHJ5OjphcHBlbmRGaWxlRXh0ZW5zaW9uSWZO ZWNlc3NhcnkoY29uc3QgU3RyaW5nJiBmaWxlbmFtZSwgY29uc3QgU3RyaW5nJikKK1N0cmluZyBN SU1FVHlwZVJlZ2lzdHJ5OjphcHBlbmRGaWxlRXh0ZW5zaW9uSWZOZWNlc3NhcnkoY29uc3QgU3Ry aW5nJiBmaWxlbmFtZSwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKIHsKLSAgICByZXR1cm4gZmls ZW5hbWU7Ci19CisgICAgaWYgKGZpbGVuYW1lLmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIGVt cHR5U3RyaW5nKCk7CiAKLSNlbmRpZgorICAgIGlmIChmaWxlbmFtZS5yZXZlcnNlRmluZCgnLicp ICE9IG5vdEZvdW5kKQorICAgICAgICByZXR1cm4gZmlsZW5hbWU7CisKKyAgICBTdHJpbmcgcHJl ZmVycmVkRXh0ZW5zaW9uID0gZ2V0UHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlNRVR5cGUobWltZVR5 cGUpOworICAgIGlmIChwcmVmZXJyZWRFeHRlbnNpb24uaXNFbXB0eSgpKQorICAgICAgICByZXR1 cm4gZmlsZW5hbWU7CisKKyAgICByZXR1cm4gZmlsZW5hbWUgKyAiLiIgKyBwcmVmZXJyZWRFeHRl bnNpb247Cit9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2NvY29hL01JTUVUeXBlUmVnaXN0cnlDb2NvYS5tbSBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2NvY29hL01JTUVUeXBlUmVnaXN0cnlDb2NvYS5tbQppbmRleCA1MWRi M2NlYmZjOS4uMzU3MzcwNDFkM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2NvY29hL01JTUVUeXBlUmVnaXN0cnlDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9jb2NvYS9NSU1FVHlwZVJlZ2lzdHJ5Q29jb2EubW0KQEAgLTcxLDE5ICs3MSw0IEBAIGJv b2wgTUlNRVR5cGVSZWdpc3RyeTo6aXNBcHBsaWNhdGlvblBsdWdpbk1JTUVUeXBlKGNvbnN0IFN0 cmluZyYgTUlNRVR5cGUpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi1TdHJpbmcgTUlNRVR5cGVS ZWdpc3RyeTo6YXBwZW5kRmlsZUV4dGVuc2lvbklmTmVjZXNzYXJ5KGNvbnN0IFN0cmluZyYgZmls ZW5hbWUsIGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCi17Ci0gICAgaWYgKGZpbGVuYW1lLmlzRW1w dHkoKSkKLSAgICAgICAgcmV0dXJuIGVtcHR5U3RyaW5nKCk7Ci0KLSAgICBpZiAoZmlsZW5hbWUu cmV2ZXJzZUZpbmQoJy4nKSAhPSBub3RGb3VuZCkKLSAgICAgICAgcmV0dXJuIGZpbGVuYW1lOwot Ci0gICAgU3RyaW5nIHByZWZlcnJlZEV4dGVuc2lvbiA9IGdldFByZWZlcnJlZEV4dGVuc2lvbkZv ck1JTUVUeXBlKG1pbWVUeXBlKTsKLSAgICBpZiAocHJlZmVycmVkRXh0ZW5zaW9uLmlzRW1wdHko KSkKLSAgICAgICAgcmV0dXJuIGZpbGVuYW1lOwotCi0gICAgcmV0dXJuIGZpbGVuYW1lICsgIi4i ICsgcHJlZmVycmVkRXh0ZW5zaW9uOwotfQotCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvTUlNRVR5cGVSZWdpc3RyeUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvTUlNRVR5cGVSZWdpc3RyeUVmbC5jcHAKaW5kZXggN2M4ZWU5NTgwYzkuLjI4 ZjdjMDU0MDYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTUlNRVR5 cGVSZWdpc3RyeUVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL01JTUVU eXBlUmVnaXN0cnlFZmwuY3BwCkBAIC04Niw0ICs4NiwxMyBAQCBib29sIE1JTUVUeXBlUmVnaXN0 cnk6OmlzQXBwbGljYXRpb25QbHVnaW5NSU1FVHlwZShjb25zdCBTdHJpbmcmKQogICAgIHJldHVy biBmYWxzZTsKIH0KIAorU3RyaW5nIE1JTUVUeXBlUmVnaXN0cnk6OmdldFByZWZlcnJlZEV4dGVu c2lvbkZvck1JTUVUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCit7CisgICAgZm9yIChhdXRv JiBlbnRyeSA6IGV4dGVuc2lvbk1hcCkgeworICAgICAgICBpZiAoZXF1YWxJZ25vcmluZ0FTQ0lJ Q2FzZShtaW1lVHlwZSwgZW50cnkubWltZVR5cGUpKQorICAgICAgICAgICAgcmV0dXJuIGVudHJ5 LmV4dGVuc2lvbjsKKyAgICB9CisgICAgcmV0dXJuIGVtcHR5U3RyaW5nKCk7Cit9CisKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9NSU1FVHlwZVJlZ2lzdHJ5R3Rr LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9NSU1FVHlwZVJlZ2lzdHJ5R3RrLmNw cAppbmRleCA5YTQxZGEzMzU3Yy4uYjI3YmUxMDJlOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9NSU1FVHlwZVJlZ2lzdHJ5R3RrLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvTUlNRVR5cGVSZWdpc3RyeUd0ay5jcHAKQEAgLTM5LDggKzM5LDgg QEAgc3RhdGljIGNvbnN0IEV4dGVuc2lvbk1hcCBleHRlbnNpb25NYXAgW10gPSB7CiAgICAgeyAi Ym1wIiwgImltYWdlL2JtcCIgfSwKICAgICB7ICJjc3MiLCAidGV4dC9jc3MiIH0sCiAgICAgeyAi Z2lmIiwgImltYWdlL2dpZiIgfSwKLSAgICB7ICJodG0iLCAidGV4dC9odG1sIiB9LAogICAgIHsg Imh0bWwiLCAidGV4dC9odG1sIiB9LAorICAgIHsgImh0bSIsICJ0ZXh0L2h0bWwiIH0sCiAgICAg eyAiaWNvIiwgImltYWdlL3gtaWNvbiIgfSwKICAgICB7ICJqcGVnIiwgImltYWdlL2pwZWciIH0s CiAgICAgeyAianBnIiwgImltYWdlL2pwZWciIH0sCkBAIC03NCw0ICs3NCwxMyBAQCBib29sIE1J TUVUeXBlUmVnaXN0cnk6OmlzQXBwbGljYXRpb25QbHVnaW5NSU1FVHlwZShjb25zdCBTdHJpbmcm KQogICAgIHJldHVybiBmYWxzZTsKIH0KIAorU3RyaW5nIE1JTUVUeXBlUmVnaXN0cnk6OmdldFBy ZWZlcnJlZEV4dGVuc2lvbkZvck1JTUVUeXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCit7Cisg ICAgZm9yIChhdXRvJiBlbnRyeSA6IGV4dGVuc2lvbk1hcCkgeworICAgICAgICBpZiAoZXF1YWxJ Z25vcmluZ0FTQ0lJQ2FzZShtaW1lVHlwZSwgZW50cnkubWltZVR5cGUpKQorICAgICAgICAgICAg cmV0dXJuIGVudHJ5LmV4dGVuc2lvbjsKKyAgICB9CisgICAgcmV0dXJuIGVtcHR5U3RyaW5nKCk7 Cit9CisKIH0K