168158 2017-02-10 18:54:23 -0800 WebKitLegacy doesn't re-export various symbols from WebCore required by clients 2017-03-07 22:10:13 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168342 https://bugs.webkit.org/show_bug.cgi?id=169341 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain andersca ap commit-queue juergen mitz oldest_to_newest 1275703 0 aakash_jain 2017-02-10 18:54:23 -0800 WebKitLegacy doesn't re-export various symbols from WebCore, which are required by clients. Therefore many clients are forced to link WebCore, while they should be linking against WebKit. WebKit should re-export all such required symbols from WebCore. 1275707 1 301236 aakash_jain 2017-02-10 18:57:32 -0800 Created attachment 301236 Proposed patch 1275709 2 aakash_jain 2017-02-10 19:05:11 -0800 see rdar://problem/26182452 and rdar://problem/24527933 1275726 3 301236 mitz 2017-02-10 20:04:56 -0800 Comment on attachment 301236 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=301236&action=review > Source/WebKit/ios/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=168158 Please add the Radar URL(s) here as well. 1275737 4 301241 aakash_jain 2017-02-10 20:41:55 -0800 Created attachment 301241 Updated patch 1275741 5 301241 commit-queue 2017-02-10 20:56:07 -0800 Comment on attachment 301241 Updated patch Clearing flags on attachment: 301241 Committed r212179: <http://trac.webkit.org/changeset/212179> 1275742 6 commit-queue 2017-02-10 20:56:11 -0800 All reviewed patches have been landed. Closing bug. 301236 2017-02-10 18:57:32 -0800 2017-02-10 20:41:55 -0800 Proposed patch patch_symbols_reexport_from_webcore text/plain 2452 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2lvcy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjE3MikKKysrIFNvdXJjZS9XZWJLaXQv aW9zL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTEw ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXRM ZWdhY3kgZG9lc24ndCByZS1leHBvcnQgdmFyaW91cyBzeW1ib2xzIGZyb20gV2ViQ29yZSByZXF1 aXJlZCBieSBjbGllbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjgxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYktpdC5pT1MuZXhwOiBFeHBvcnRpbmcgdmFyaW91cyBzeW1ib2xzIHdoaWNo IGFyZSByZXF1aXJlZCBieSBjbGllbnRzLiBUaGlzIAorICAgICAgICB3b3VsZCBlbmFibGUgY2xp ZW50cyB0byBzdG9wIGxpbmtpbmcgYWdhaW5zdCBXZWJDb3JlIGFuZCBpbnN0ZWFkIGxpbmsgYWdh aW5zdCBXZWJLaXQuCisKIDIwMTctMDItMDIgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5n QGFwcGxlLmNvbT4KIAogICAgICAgICBJbiBpT1MsIHdlIHNob3VsZCB0YWtlIGJhY2tncm91bmQg YXNzZXJ0aW9uIHdoZW4gYWNjZXNzaW5nIGxvY2Fsc3RvcmFnZSBkYXRhYmFzZXMuCkluZGV4OiBT b3VyY2UvV2ViS2l0L2lvcy9XZWJLaXQuaU9TLmV4cAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L2lvcy9XZWJLaXQuaU9TLmV4cAkocmV2aXNpb24gMjExOTY3KQorKysgU291cmNlL1dlYktp dC9pb3MvV2ViS2l0LmlPUy5leHAJKHdvcmtpbmcgY29weSkKQEAgLTEsOSArMSwxNSBAQAorLm9i amNfY2xhc3NfbmFtZV9XQUtXaW5kb3cKKy5vYmpjX2NsYXNzX25hbWVfV2ViRXZlbnQKIC5vYmpj X2NsYXNzX25hbWVfV2ViR2VvbG9jYXRpb25Qcm92aWRlcklPUwogLm9iamNfY2xhc3NfbmFtZV9X ZWJNSU1FVHlwZVJlZ2lzdHJ5CiAub2JqY19jbGFzc19uYW1lX1dlYlBERlZpZXcKIC5vYmpjX2Ns YXNzX25hbWVfV2ViUERGVmlld1BsYWNlaG9sZGVyCiAub2JqY19jbGFzc19uYW1lX1dlYlBsdWdp bkNvbnRyb2xsZXIKKy5vYmpjX2NsYXNzX25hbWVfV2ViU2NyaXB0T2JqZWN0CiAub2JqY19jbGFz c19uYW1lX1dlYlNlbGVjdGlvblJlY3QKKy5vYmpjX2NsYXNzX25hbWVfV2ViVW5kZWZpbmVkCisu b2JqY19jbGFzc19uYW1lX1dBS1ZpZXcKK19XQUtWaWV3RnJhbWVTaXplRGlkQ2hhbmdlTm90aWZp Y2F0aW9uCiBfV2ViRGF0YWJhc2VPcmlnaW5zRGlkQ2hhbmdlTm90aWZpY2F0aW9uCiBfV2ViS2l0 Q3JlYXRlUGF0aFdpdGhTaHJpbmtXcmFwcGVkUmVjdHMKIF9XZWJLaXRHZXRMYXN0TGluZUJyZWFr SW5CdWZmZXIKQEAgLTIwLDYgKzI2LDIyIEBAIF9XZWJPcGVuUGFuZWxDb25maWd1cmF0aW9uTWlt ZVR5cGVzS2V5CiBfV2ViT3BlblBhbmVsQ29uZmlndXJhdGlvbk1lZGlhQ2FwdHVyZVR5cGVLZXkK IF9XZWJRdWlja0xvb2tGaWxlTmFtZUtleQogX1dlYlF1aWNrTG9va1VUSUtleQorX1dlYlRocmVh ZENhbGxEZWxlZ2F0ZUFzeW5jCitfV2ViVGhyZWFkQ2FsbERlbGVnYXRlCitfV2ViVGhyZWFkSXND dXJyZW50CitfV2ViVGhyZWFkSXNFbmFibGVkCitfV2ViVGhyZWFkSXNMb2NrZWQKK19XZWJUaHJl YWRMb2NrCitfV2ViVGhyZWFkTG9ja0Zyb21BbnlUaHJlYWQKK19XZWJUaHJlYWRMb2NrUG9wTW9k YWwKK19XZWJUaHJlYWRMb2NrUHVzaE1vZGFsCitfV2ViVGhyZWFkTWFrZU5TSW52b2NhdGlvbgor X1dlYlRocmVhZE5vdEN1cnJlbnQKK19XZWJUaHJlYWRSdW4KK19XZWJUaHJlYWRSdW5Pbk1haW5U aHJlYWQKK19XZWJUaHJlYWRVbmxvY2sKK19XZWJUaHJlYWRVbmxvY2tGcm9tQW55VGhyZWFkCitf V2ViVGhyZWFkVW5sb2NrR3VhcmRGb3JNYWlsCiBfV2ViVmlld3BvcnRIZWlnaHRLZXkKIF9XZWJW aWV3cG9ydEluaXRpYWxTY2FsZUtleQogX1dlYlZpZXdwb3J0TWF4aW11bVNjYWxlS2V5CkBAIC0y Nyw2ICs0OSw4IEBAIF9XZWJWaWV3cG9ydE1pbmltdW1TY2FsZUtleQogX1dlYlZpZXdwb3J0VXNl clNjYWxhYmxlS2V5CiBfV2ViVmlld3BvcnRTaHJpbmtUb0ZpdEtleQogX1dlYlZpZXdwb3J0V2lk dGhLZXkKK19XS0dldEN1cnJlbnRHcmFwaGljc0NvbnRleHQKK19XS1NldEN1cnJlbnRHcmFwaGlj c0NvbnRleHQKIAogIyBTbyB0aGF0IHdlIGNhbiB1c2UgdGhlIE1lbW9yeU1lYXN1cmUgY2xhc3Mg aW4gTW9iaWxlU2FmYXJpCiBfX1pONldlYktpdDEzTWVtb3J5TWVhc3VyZTEwdGFza01lbW9yeUV2 Cg== 301241 2017-02-10 20:41:55 -0800 2017-02-10 20:56:07 -0800 Updated patch patch_symbols_reexport_from_webcore_v2 text/plain 2486 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2lvcy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjE3MikKKysrIFNvdXJjZS9XZWJLaXQv aW9zL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAyLTEw ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXRM ZWdhY3kgZG9lc24ndCByZS1leHBvcnQgdmFyaW91cyBzeW1ib2xzIGZyb20gV2ViQ29yZSByZXF1 aXJlZCBieSBjbGllbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjgxNTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0NTI3OTMzPgorCisgICAg ICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCisKKyAgICAgICAgKiBXZWJLaXQuaU9TLmV4 cDogRXhwb3J0aW5nIHZhcmlvdXMgc3ltYm9scyB3aGljaCBhcmUgcmVxdWlyZWQgYnkgY2xpZW50 cy4gVGhpcyAKKyAgICAgICAgd291bGQgZW5hYmxlIGNsaWVudHMgdG8gc3RvcCBsaW5raW5nIGFn YWluc3QgV2ViQ29yZSBhbmQgaW5zdGVhZCBsaW5rIGFnYWluc3QgV2ViS2l0LgorCiAyMDE3LTAy LTAyICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CiAKICAgICAgICAg SW4gaU9TLCB3ZSBzaG91bGQgdGFrZSBiYWNrZ3JvdW5kIGFzc2VydGlvbiB3aGVuIGFjY2Vzc2lu ZyBsb2NhbHN0b3JhZ2UgZGF0YWJhc2VzLgpJbmRleDogU291cmNlL1dlYktpdC9pb3MvV2ViS2l0 LmlPUy5leHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9pb3MvV2ViS2l0LmlPUy5leHAJ KHJldmlzaW9uIDIxMTk2NykKKysrIFNvdXJjZS9XZWJLaXQvaW9zL1dlYktpdC5pT1MuZXhwCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDkgKzEsMTUgQEAKKy5vYmpjX2NsYXNzX25hbWVfV0FLV2luZG93 Cisub2JqY19jbGFzc19uYW1lX1dlYkV2ZW50CiAub2JqY19jbGFzc19uYW1lX1dlYkdlb2xvY2F0 aW9uUHJvdmlkZXJJT1MKIC5vYmpjX2NsYXNzX25hbWVfV2ViTUlNRVR5cGVSZWdpc3RyeQogLm9i amNfY2xhc3NfbmFtZV9XZWJQREZWaWV3CiAub2JqY19jbGFzc19uYW1lX1dlYlBERlZpZXdQbGFj ZWhvbGRlcgogLm9iamNfY2xhc3NfbmFtZV9XZWJQbHVnaW5Db250cm9sbGVyCisub2JqY19jbGFz c19uYW1lX1dlYlNjcmlwdE9iamVjdAogLm9iamNfY2xhc3NfbmFtZV9XZWJTZWxlY3Rpb25SZWN0 Cisub2JqY19jbGFzc19uYW1lX1dlYlVuZGVmaW5lZAorLm9iamNfY2xhc3NfbmFtZV9XQUtWaWV3 CitfV0FLVmlld0ZyYW1lU2l6ZURpZENoYW5nZU5vdGlmaWNhdGlvbgogX1dlYkRhdGFiYXNlT3Jp Z2luc0RpZENoYW5nZU5vdGlmaWNhdGlvbgogX1dlYktpdENyZWF0ZVBhdGhXaXRoU2hyaW5rV3Jh cHBlZFJlY3RzCiBfV2ViS2l0R2V0TGFzdExpbmVCcmVha0luQnVmZmVyCkBAIC0yMCw2ICsyNiwy MiBAQCBfV2ViT3BlblBhbmVsQ29uZmlndXJhdGlvbk1pbWVUeXBlc0tleQogX1dlYk9wZW5QYW5l bENvbmZpZ3VyYXRpb25NZWRpYUNhcHR1cmVUeXBlS2V5CiBfV2ViUXVpY2tMb29rRmlsZU5hbWVL ZXkKIF9XZWJRdWlja0xvb2tVVElLZXkKK19XZWJUaHJlYWRDYWxsRGVsZWdhdGVBc3luYworX1dl YlRocmVhZENhbGxEZWxlZ2F0ZQorX1dlYlRocmVhZElzQ3VycmVudAorX1dlYlRocmVhZElzRW5h YmxlZAorX1dlYlRocmVhZElzTG9ja2VkCitfV2ViVGhyZWFkTG9jaworX1dlYlRocmVhZExvY2tG cm9tQW55VGhyZWFkCitfV2ViVGhyZWFkTG9ja1BvcE1vZGFsCitfV2ViVGhyZWFkTG9ja1B1c2hN b2RhbAorX1dlYlRocmVhZE1ha2VOU0ludm9jYXRpb24KK19XZWJUaHJlYWROb3RDdXJyZW50Citf V2ViVGhyZWFkUnVuCitfV2ViVGhyZWFkUnVuT25NYWluVGhyZWFkCitfV2ViVGhyZWFkVW5sb2Nr CitfV2ViVGhyZWFkVW5sb2NrRnJvbUFueVRocmVhZAorX1dlYlRocmVhZFVubG9ja0d1YXJkRm9y TWFpbAogX1dlYlZpZXdwb3J0SGVpZ2h0S2V5CiBfV2ViVmlld3BvcnRJbml0aWFsU2NhbGVLZXkK IF9XZWJWaWV3cG9ydE1heGltdW1TY2FsZUtleQpAQCAtMjcsNiArNDksOCBAQCBfV2ViVmlld3Bv cnRNaW5pbXVtU2NhbGVLZXkKIF9XZWJWaWV3cG9ydFVzZXJTY2FsYWJsZUtleQogX1dlYlZpZXdw b3J0U2hyaW5rVG9GaXRLZXkKIF9XZWJWaWV3cG9ydFdpZHRoS2V5CitfV0tHZXRDdXJyZW50R3Jh cGhpY3NDb250ZXh0CitfV0tTZXRDdXJyZW50R3JhcGhpY3NDb250ZXh0CiAKICMgU28gdGhhdCB3 ZSBjYW4gdXNlIHRoZSBNZW1vcnlNZWFzdXJlIGNsYXNzIGluIE1vYmlsZVNhZmFyaQogX19aTjZX ZWJLaXQxM01lbW9yeU1lYXN1cmUxMHRhc2tNZW1vcnlFdgo=