168155 2017-02-10 16:47:29 -0800 Web Inspector: Request headers when copied & pasted should follow HTTP format, colon instead of tab 2017-02-15 22:16:07 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1275646 0 bburg 2017-02-10 16:47:29 -0800 From the depths of Radar: " When you copy an HTTP header from the resource inspector in Safari, the key and value are separated by a tab, but separating by a colon would be more useful. * STEPS TO REPRODUCE 1. Safari > Preferences > Advanced > Show Develop 2. Visit a website, then go to Develop > Show Page Resources > Resources > click Resource, select a resource 3. Scroll down to Request Headers, select a header, copy it then paste somewhere * RESULTS Actual: Accept-Encoding gzip, deflate Expected: Accept-Encoding: gzip, deflate The former is the usual form for copied table cells, but the latter is valid HTTP and can be pasted into a curl command line (e.g., curl … -H 'Accept-Encoding: gzip, deflate'). " 1275648 1 bburg 2017-02-10 16:47:38 -0800 <rdar://problem/17523913> 1277434 2 301677 hi 2017-02-15 17:27:08 -0800 Created attachment 301677 Patch 1277435 3 301678 hi 2017-02-15 17:28:48 -0800 Created attachment 301678 Patch 1277504 4 301678 mattbaker 2017-02-15 21:48:33 -0800 Comment on attachment 301678 Patch r=me 1277515 5 301678 commit-queue 2017-02-15 22:15:58 -0800 Comment on attachment 301678 Patch Clearing flags on attachment: 301678 Committed r212423: <http://trac.webkit.org/changeset/212423> 1277516 6 commit-queue 2017-02-15 22:16:07 -0800 All reviewed patches have been landed. Closing bug. 301677 2017-02-15 17:27:08 -0800 2017-02-15 17:28:44 -0800 Patch bug-168155-20170215172432.patch text/plain 3445 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQzZTNkZDExNzI4NDQ2MGMzZDM0YTIwM2IzNGI5 MDJmNGM3ZmIwZmIuLjRkZmQzZmVkNzgwYmFhNDE0MTc2MTg4MzBmNDUxYzNlMWRiYTM3N2YgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE3LTAyLTE1ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFJlcXVlc3QgaGVhZGVycyB3aGVuIGNvcGllZCAmIHBhc3RlZCBzaG91bGQgZm9sbG93 IEhUVFAgZm9ybWF0LCBjb2xvbiBpbnN0ZWFkIG9mIHRhYgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4MTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlk LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuc2V0IGNvcHlUZXh0RGVsaW1pdGVyKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX2NvcHlUZXh0Rm9yRGF0YUdyaWROb2Rl KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX2NvcHlUZXh0Rm9y RGF0YUdyaWRIZWFkZXJzKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNl RGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZURl dGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9jcmVhdGVOYW1lVmFsdWVEYXRhR3JpZCk6Cisg ICAgICAgIEFsbG93IGluc3RhbmNlcyBvZiBEYXRhR3JpZCB0byBjaGFuZ2UgdGhlIGRlbGltaXRl ciBiZXR3ZWVuIGl0ZW1zIHdoZW4gY29weWluZyByb3dzLgorCisyMDE3LTAyLTE1ICBEZXZpbiBS b3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFNwbGl0IGNvbnNvbGUgc2hvdWxkIGJlIGFsbG93ZWQgd2hlbiBkb2NrZWQgYm90dG9tIG9u IEVsZW1lbnRzL1Jlc291cmNlcy9EZWJ1Z2dlci9TdG9yYWdlIHRhYnMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODM4NQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCmluZGV4 IDRlODM1OWYwYzNjYzljODAxMzA3ZTg0NWQwYzIwY2YyMzk0MDUyNjEuLmQ0ODJlYTY1NWEzMDA3 NDAwYjRhNzY0YzVlMDAzNWRhOTdlMDc0ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC0xMzIsNiArMTMyLDgg QEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNw ZWN0b3IuVmlldwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fdXBkYXRlU2Nyb2xsYmFyUGFk ZGluZygpOworCisgICAgICAgIHRoaXMuX2NvcHlUZXh0RGVsaW1pdGVyID0gIlx0IjsKICAgICB9 CiAKICAgICBfdXBkYXRlU2Nyb2xsYmFyUGFkZGluZygpCkBAIC0xNzAzLDE2ICsxNzA1LDE4IEBA IFdlYkluc3BlY3Rvci5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV2ViSW5zcGVj dG9yLlZpZXcKICAgICAgICAgcmV0dXJuIChkYXRhIGluc3RhbmNlb2YgTm9kZSA/IGRhdGEudGV4 dENvbnRlbnQgOiBkYXRhKSB8fCAiIjsKICAgICB9CiAKKyAgICBzZXQgY29weVRleHREZWxpbWl0 ZXIodmFsdWUpIHsgdGhpcy5fY29weVRleHREZWxpbWl0ZXIgPSB2YWx1ZTsgfQorCiAgICAgX2Nv cHlUZXh0Rm9yRGF0YUdyaWROb2RlKG5vZGUpCiAgICAgewogICAgICAgICBsZXQgZmllbGRzID0g bm9kZS5kYXRhR3JpZC5vcmRlcmVkQ29sdW1ucy5tYXAoKGlkZW50aWZpZXIpID0+IHRoaXMudGV4 dEZvckRhdGFHcmlkTm9kZUNvbHVtbihub2RlLCBpZGVudGlmaWVyKSk7Ci0gICAgICAgIHJldHVy biBmaWVsZHMuam9pbigiXHQiKTsKKyAgICAgICAgcmV0dXJuIGZpZWxkcy5qb2luKHRoaXMuX2Nv cHlUZXh0RGVsaW1pdGVyKTsKICAgICB9CiAKICAgICBfY29weVRleHRGb3JEYXRhR3JpZEhlYWRl cnMoKQogICAgIHsKICAgICAgICAgbGV0IGZpZWxkcyA9IHRoaXMub3JkZXJlZENvbHVtbnMubWFw KChpZGVudGlmaWVyKSA9PiB0aGlzLmhlYWRlclRhYmxlSGVhZGVyKGlkZW50aWZpZXIpLnRleHRD b250ZW50KTsKLSAgICAgICAgcmV0dXJuIGZpZWxkcy5qb2luKCJcdCIpOworICAgICAgICByZXR1 cm4gZmllbGRzLmpvaW4odGhpcy5fY29weVRleHREZWxpbWl0ZXIpOwogICAgIH0KIAogICAgIGhh bmRsZUJlZm9yZUNvcHlFdmVudChldmVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWls c1NpZGViYXJQYW5lbC5qcwppbmRleCAyZDRlMWIwMmY2NTI4MzY2Njk4ZWQ0NDVlZTVjOWY2M2I1 MGEyMjhiLi41NWEwMzRkNGMxNDI5Zjc1YzU3YzE1NmI4N2RmODc2M2FmM2RiMmFmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZURl dGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0zNjgsNiArMzY4 LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIFJl c291cmNlRGV0YWlsc1NpZGViYXJQYW5lbCBleHQKICAgICAgICAgICAgIG5hbWU6IHt0aXRsZTog V2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJOYW1lIiksIHdpZHRoOiAiMzAlIiwgc29ydGFibGU6IHRy dWV9LAogICAgICAgICAgICAgdmFsdWU6IHt0aXRsZTogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJW YWx1ZSIpLCBzb3J0YWJsZTogdHJ1ZX0KICAgICAgICAgfSk7CisgICAgICAgIGRhdGFHcmlkLmNv cHlUZXh0RGVsaW1pdGVyID0gIiwgIjsKIAogICAgICAgICBmdW5jdGlvbiBhZGREYXRhR3JpZE5v ZGUobm9kZVZhbHVlKQogICAgICAgICB7Cg== 301678 2017-02-15 17:28:48 -0800 2017-02-15 22:15:58 -0800 Patch bug-168155-20170215172612.patch text/plain 3445 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQzZTNkZDExNzI4NDQ2MGMzZDM0YTIwM2IzNGI5 MDJmNGM3ZmIwZmIuLjRkZmQzZmVkNzgwYmFhNDE0MTc2MTg4MzBmNDUxYzNlMWRiYTM3N2YgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE3LTAyLTE1ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFJlcXVlc3QgaGVhZGVycyB3aGVuIGNvcGllZCAmIHBhc3RlZCBzaG91bGQgZm9sbG93 IEhUVFAgZm9ybWF0LCBjb2xvbiBpbnN0ZWFkIG9mIHRhYgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4MTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlk LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuc2V0IGNvcHlUZXh0RGVsaW1pdGVyKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX2NvcHlUZXh0Rm9yRGF0YUdyaWROb2Rl KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX2NvcHlUZXh0Rm9y RGF0YUdyaWRIZWFkZXJzKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNl RGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZURl dGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9jcmVhdGVOYW1lVmFsdWVEYXRhR3JpZCk6Cisg ICAgICAgIEFsbG93IGluc3RhbmNlcyBvZiBEYXRhR3JpZCB0byBjaGFuZ2UgdGhlIGRlbGltaXRl ciBiZXR3ZWVuIGl0ZW1zIHdoZW4gY29weWluZyByb3dzLgorCisyMDE3LTAyLTE1ICBEZXZpbiBS b3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFNwbGl0IGNvbnNvbGUgc2hvdWxkIGJlIGFsbG93ZWQgd2hlbiBkb2NrZWQgYm90dG9tIG9u IEVsZW1lbnRzL1Jlc291cmNlcy9EZWJ1Z2dlci9TdG9yYWdlIHRhYnMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODM4NQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCmluZGV4 IDRlODM1OWYwYzNjYzljODAxMzA3ZTg0NWQwYzIwY2YyMzk0MDUyNjEuLmQ0ODJlYTY1NWEzMDA3 NDAwYjRhNzY0YzVlMDAzNWRhOTdlMDc0ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC0xMzIsNiArMTMyLDgg QEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNw ZWN0b3IuVmlldwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fdXBkYXRlU2Nyb2xsYmFyUGFk ZGluZygpOworCisgICAgICAgIHRoaXMuX2NvcHlUZXh0RGVsaW1pdGVyID0gIlx0IjsKICAgICB9 CiAKICAgICBfdXBkYXRlU2Nyb2xsYmFyUGFkZGluZygpCkBAIC0xNzAzLDE2ICsxNzA1LDE4IEBA IFdlYkluc3BlY3Rvci5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV2ViSW5zcGVj dG9yLlZpZXcKICAgICAgICAgcmV0dXJuIChkYXRhIGluc3RhbmNlb2YgTm9kZSA/IGRhdGEudGV4 dENvbnRlbnQgOiBkYXRhKSB8fCAiIjsKICAgICB9CiAKKyAgICBzZXQgY29weVRleHREZWxpbWl0 ZXIodmFsdWUpIHsgdGhpcy5fY29weVRleHREZWxpbWl0ZXIgPSB2YWx1ZTsgfQorCiAgICAgX2Nv cHlUZXh0Rm9yRGF0YUdyaWROb2RlKG5vZGUpCiAgICAgewogICAgICAgICBsZXQgZmllbGRzID0g bm9kZS5kYXRhR3JpZC5vcmRlcmVkQ29sdW1ucy5tYXAoKGlkZW50aWZpZXIpID0+IHRoaXMudGV4 dEZvckRhdGFHcmlkTm9kZUNvbHVtbihub2RlLCBpZGVudGlmaWVyKSk7Ci0gICAgICAgIHJldHVy biBmaWVsZHMuam9pbigiXHQiKTsKKyAgICAgICAgcmV0dXJuIGZpZWxkcy5qb2luKHRoaXMuX2Nv cHlUZXh0RGVsaW1pdGVyKTsKICAgICB9CiAKICAgICBfY29weVRleHRGb3JEYXRhR3JpZEhlYWRl cnMoKQogICAgIHsKICAgICAgICAgbGV0IGZpZWxkcyA9IHRoaXMub3JkZXJlZENvbHVtbnMubWFw KChpZGVudGlmaWVyKSA9PiB0aGlzLmhlYWRlclRhYmxlSGVhZGVyKGlkZW50aWZpZXIpLnRleHRD b250ZW50KTsKLSAgICAgICAgcmV0dXJuIGZpZWxkcy5qb2luKCJcdCIpOworICAgICAgICByZXR1 cm4gZmllbGRzLmpvaW4odGhpcy5fY29weVRleHREZWxpbWl0ZXIpOwogICAgIH0KIAogICAgIGhh bmRsZUJlZm9yZUNvcHlFdmVudChldmVudCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWls c1NpZGViYXJQYW5lbC5qcwppbmRleCAyZDRlMWIwMmY2NTI4MzY2Njk4ZWQ0NDVlZTVjOWY2M2I1 MGEyMjhiLi5mZTE5M2Y2MDg3NTczOWMzZmNiY2FiMWRjMTA2MzNmOWYxYjQ4MDI5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZURl dGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0zNjgsNiArMzY4 LDcgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIFJl c291cmNlRGV0YWlsc1NpZGViYXJQYW5lbCBleHQKICAgICAgICAgICAgIG5hbWU6IHt0aXRsZTog V2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJOYW1lIiksIHdpZHRoOiAiMzAlIiwgc29ydGFibGU6IHRy dWV9LAogICAgICAgICAgICAgdmFsdWU6IHt0aXRsZTogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJW YWx1ZSIpLCBzb3J0YWJsZTogdHJ1ZX0KICAgICAgICAgfSk7CisgICAgICAgIGRhdGFHcmlkLmNv cHlUZXh0RGVsaW1pdGVyID0gIjogIjsKIAogICAgICAgICBmdW5jdGlvbiBhZGREYXRhR3JpZE5v ZGUobm9kZVZhbHVlKQogICAgICAgICB7Cg==