168141 2017-02-10 11:59:18 -0800 [Cocoa] Web Inspector: payload initializers for ObjC protocol types handles special-cased property names incorrectly 2017-02-10 15:48:42 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1275459 0 bburg 2017-02-10 11:59:18 -0800 We are trying to look up the ObjC-stylized property name in the payload, not the raw member name. So we improperly convert objects with fields 'id' and 'description'. 1275466 1 301192 bburg 2017-02-10 12:07:53 -0800 Created attachment 301192 Proposed Fix 1275467 2 commit-queue 2017-02-10 12:09:16 -0800 This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) 1275565 3 301192 joepeck 2017-02-10 15:23:32 -0800 Comment on attachment 301192 Proposed Fix r=me 1275585 4 301192 commit-queue 2017-02-10 15:48:37 -0800 Comment on attachment 301192 Proposed Fix Clearing flags on attachment: 301192 Committed r212157: <http://trac.webkit.org/changeset/212157> 1275586 5 commit-queue 2017-02-10 15:48:42 -0800 All reviewed patches have been landed. Closing bug. 301192 2017-02-10 12:07:53 -0800 2017-02-10 15:48:37 -0800 Proposed Fix bug-168141-20170210120526.patch text/plain 3691 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjExODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi N2U4ZGQ4M2ZjZWM1ZTkwZDg0YTU4NTcyZWE1MzY4NzBjM2EwMTQwLi44NmU3ZTNkODgwYTJiOGU5 MGU2ZDgzZjkyZGQzZWZlZWFiNjMyMjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0wMi0xMCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBbQ29jb2FdIFdlYiBJbnNwZWN0b3I6IHBheWxvYWQgaW5pdGlhbGl6ZXJzIGZvciBP YmpDIHByb3RvY29sIHR5cGVzIGhhbmRsZXMgc3BlY2lhbC1jYXNlZCBwcm9wZXJ0eSBuYW1lcyBp bmNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY4MTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIGdlbmVyYXRlZCBjb2RlIGVycm9uZW91c2x5IHVzZXMgdGhlIE9iakMgdmFyaWFibGUg bmFtZSBhcyB0aGUgcGF5bG9hZCBrZXksCisgICAgICAgIHJhdGhlciB0aGFuIHRoZSByYXcgdHlw ZSBtZW1iZXIgbmFtZS4gRm9yIGV4YW1wbGUsICdpZGVudGlmaWVyJyB3b3VsZCBiZSB1c2VkIGlu c3RlYWQgb2YgJ2lkJy4KKworICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2Vu ZXJhdGVfb2JqY19wcm90b2NvbF90eXBlc19pbXBsZW1lbnRhdGlvbi5weToKKyAgICAgICAgKE9i akNQcm90b2NvbFR5cGVzSW1wbGVtZW50YXRpb25HZW5lcmF0b3IuX2dlbmVyYXRlX2luaXRfbWV0 aG9kX2Zvcl9wYXlsb2FkKToKKworICAgICAgICAqIGluc3BlY3Rvci9zY3JpcHRzL3Rlc3RzL2dl bmVyaWMvZXhwZWN0ZWQvdHlwZS1yZXF1aXJpbmctcnVudGltZS1jYXN0cy5qc29uLXJlc3VsdDoK KyAgICAgICAgUmViYXNlbGluZSBhbiBhZmZlY3RlZCB0ZXN0LgorCiAyMDE3LTAyLTA4ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gV2ViIEluc3BlY3Rv cjogZ2VuZXJhdGUgYW4gTlNfRU5VTSBjb250YWluaW5nIHBsYXRmb3JtcyBzdXBwb3J0ZWQgYnkg dGhlIHByb3RvY29sIGNvZGUgZ2VuZXJhdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9nZW5lcmF0ZV9vYmpjX3Byb3RvY29sX3R5 cGVzX2ltcGxlbWVudGF0aW9uLnB5IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9z Y3JpcHRzL2NvZGVnZW4vZ2VuZXJhdGVfb2JqY19wcm90b2NvbF90eXBlc19pbXBsZW1lbnRhdGlv bi5weQppbmRleCBjZTlhZTM0OTlhMjY3MjY4MTM0ODA3NzVlNWZjZjUyNjg4NzgzMDdiLi40MjVi YWFlNjBmZTMxMDhkNTY4NDE1ZjQ1NzdlMDRhMWQ2ZTQ2ZGE1IDEwMDc1NQotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9nZW5lcmF0ZV9vYmpjX3By b3RvY29sX3R5cGVzX2ltcGxlbWVudGF0aW9uLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2VuL2dlbmVyYXRlX29iamNfcHJvdG9jb2xfdHlwZXNf aW1wbGVtZW50YXRpb24ucHkKQEAgLTEyOCwxMCArMTI4LDEzIEBAIGNsYXNzIE9iakNQcm90b2Nv bFR5cGVzSW1wbGVtZW50YXRpb25HZW5lcmF0b3IoT2JqQ0dlbmVyYXRvcik6CiAgICAgICAgIGxp bmVzLmFwcGVuZCgnJykKIAogICAgICAgICBmb3IgbWVtYmVyIGluIGRlY2xhcmF0aW9uLnR5cGVf bWVtYmVyczoKLSAgICAgICAgICAgIHZhcl9uYW1lID0gT2JqQ0dlbmVyYXRvci5pZGVudGlmaWVy X3RvX29iamNfaWRlbnRpZmllcihtZW1iZXIubWVtYmVyX25hbWUpCi0gICAgICAgICAgICBpZiBu b3QgbWVtYmVyLmlzX29wdGlvbmFsOgotICAgICAgICAgICAgICAgIGxpbmVzLmFwcGVuZCgnICAg IFRIUk9XX0VYQ0VQVElPTl9GT1JfUkVRVUlSRURfUFJPUEVSVFkocGF5bG9hZFtAIiVzIl0sIEAi JXMiKTsnICUgKHZhcl9uYW1lLCB2YXJfbmFtZSkpCisgICAgICAgICAgICBtZW1iZXJfbmFtZSA9 IG1lbWJlci5tZW1iZXJfbmFtZQogICAgICAgICAgICAgY29udmVyc2lvbl9leHByZXNzaW9uID0g c2VsZi5wYXlsb2FkX3RvX29iamNfZXhwcmVzc2lvbl9mb3JfbWVtYmVyKGRlY2xhcmF0aW9uLCBt ZW1iZXIpCisKKyAgICAgICAgICAgIGlmIG5vdCBtZW1iZXIuaXNfb3B0aW9uYWw6CisgICAgICAg ICAgICAgICAgbGluZXMuYXBwZW5kKCcgICAgVEhST1dfRVhDRVBUSU9OX0ZPUl9SRVFVSVJFRF9Q Uk9QRVJUWShwYXlsb2FkW0AiJXMiXSwgQCIlcyIpOycgJSAobWVtYmVyX25hbWUsIG1lbWJlcl9u YW1lKSkKKworICAgICAgICAgICAgdmFyX25hbWUgPSBPYmpDR2VuZXJhdG9yLmlkZW50aWZpZXJf dG9fb2JqY19pZGVudGlmaWVyKG1lbWJlcl9uYW1lKQogICAgICAgICAgICAgbGluZXMuYXBwZW5k KCcgICAgc2VsZi4lcyA9ICVzOycgJSAodmFyX25hbWUsIGNvbnZlcnNpb25fZXhwcmVzc2lvbikp CiAgICAgICAgICAgICBsaW5lcy5hcHBlbmQoJycpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90ZXN0cy9nZW5lcmljL2V4cGVjdGVkL3R5cGUt cmVxdWlyaW5nLXJ1bnRpbWUtY2FzdHMuanNvbi1yZXN1bHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3NjcmlwdHMvdGVzdHMvZ2VuZXJpYy9leHBlY3RlZC90eXBlLXJlcXVpcmlu Zy1ydW50aW1lLWNhc3RzLmpzb24tcmVzdWx0CmluZGV4IDdkYzg5YzM0YzNmOTAzNjBmYWU5MGRh NjZjODk2OWU5YWVhNmRiMWMuLjhkNDlkZTUwNGM3MjJmMWQ5Nzc3NGRiNTk1YzA3NGU5ZDEyODgz YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy90 ZXN0cy9nZW5lcmljL2V4cGVjdGVkL3R5cGUtcmVxdWlyaW5nLXJ1bnRpbWUtY2FzdHMuanNvbi1y ZXN1bHQKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL3Rlc3Rz L2dlbmVyaWMvZXhwZWN0ZWQvdHlwZS1yZXF1aXJpbmctcnVudGltZS1jYXN0cy5qc29uLXJlc3Vs dApAQCAtMTQ2Myw3ICsxNDYzLDcgQEAgdXNpbmcgbmFtZXNwYWNlIEluc3BlY3RvcjsKICAgICBU SFJPV19FWENFUFRJT05fRk9SX1JFUVVJUkVEX1BST1BFUlRZKHBheWxvYWRbQCJhbmltYWxzIl0s IEAiYW5pbWFscyIpOwogICAgIHNlbGYuYW5pbWFscyA9IGZyb21Qcm90b2NvbFN0cmluZzxUZXN0 UHJvdG9jb2xUZXN0Q2FzdGVkQW5pbWFscz4ocGF5bG9hZFtAImFuaW1hbHMiXSk7CiAKLSAgICBU SFJPV19FWENFUFRJT05fRk9SX1JFUVVJUkVEX1BST1BFUlRZKHBheWxvYWRbQCJpZGVudGlmaWVy Il0sIEAiaWRlbnRpZmllciIpOworICAgIFRIUk9XX0VYQ0VQVElPTl9GT1JfUkVRVUlSRURfUFJP UEVSVFkocGF5bG9hZFtAImlkIl0sIEAiaWQiKTsKICAgICBzZWxmLmlkZW50aWZpZXIgPSBbcGF5 bG9hZFtAImlkIl0gaW50ZWdlclZhbHVlXTsKIAogICAgIFRIUk9XX0VYQ0VQVElPTl9GT1JfUkVR VUlSRURfUFJPUEVSVFkocGF5bG9hZFtAInRyZWUiXSwgQCJ0cmVlIik7Cg==