168129 2017-02-10 10:30:52 -0800 LayoutTest workers/sab/postMessage-clones.html is a flaky failure 2017-02-28 13:56:35 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad ap ap commit-queue fpizlo oldest_to_newest 1275378 0 ryanhaddad 2017-02-10 10:30:52 -0800 LayoutTest workers/sab/postMessage-clones.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r212114%20(10957)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=workers%2Fsab%2FpostMessage-clones.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/workers/sab/postMessage-clones-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/workers/sab/postMessage-clones-actual.txt @@ -3,11 +3,11 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS successfullyParsed is true - -TEST COMPLETE PASS memory[0] is 42 PASS otherMemory[0] is 0 PASS memory[0] is 42 PASS otherMemory[0] is 43 +PASS successfullyParsed is true +TEST COMPLETE + 1275399 1 ryanhaddad 2017-02-10 10:45:42 -0800 This is a new test added with https://trac.webkit.org/changeset/212035 1275427 2 fpizlo 2017-02-10 11:11:50 -0800 Darn, that means I did a bad job writing the test. 1275490 3 fpizlo 2017-02-10 12:36:13 -0800 I think I fixed it in https://trac.webkit.org/changeset/212132. 1277491 4 ryanhaddad 2017-02-15 20:56:04 -0800 It appears that this test is still a flaky failure. https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/builds/13234 1281700 5 302918 ap 2017-02-27 20:18:20 -0800 Created attachment 302918 proposed fix This is actually straightforward. Two issues: 1. waitUntilDone cannot be used in js-tests. This is very clear if you look at js-test-post.js. This is why expected test results look wrong, you don't want TEST COMPLETE to be printed out before the test is complete 2. Even with setTimeout, the test races with HTML parser. To avoid the race, the test could use onload instead of a zero delay timer. But that's not necessary once #1 is fixed. While at it, also updated doctype to HTML5, and migrated to js-test.js, which are both inconsequential changes. 1281718 6 ap 2017-02-27 21:56:37 -0800 Filed bug 168961 about many more tests that mouse waiUntilDone. 1281936 7 302918 commit-queue 2017-02-28 13:56:31 -0800 Comment on attachment 302918 proposed fix Clearing flags on attachment: 302918 Committed r213174: <http://trac.webkit.org/changeset/213174> 1281937 8 commit-queue 2017-02-28 13:56:35 -0800 All reviewed patches have been landed. Closing bug. 302918 2017-02-27 20:18:20 -0800 2017-02-28 13:56:31 -0800 proposed fix sab.txt text/plain 2529 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxMzExNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAyLTI3ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFRlc3Qgd29ya2Vycy9zYWIvcG9z dE1lc3NhZ2UtY2xvbmVzLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgxMjkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdvcmtlcnMvc2FiL3Bvc3RNZXNzYWdl LWNsb25lcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogd29ya2Vycy9zYWIvcG9zdE1lc3NhZ2Ut Y2xvbmVzLmh0bWw6CisgICAgICAgIEZpeCByYWNpbmVzcywgYW5kIHVwZGF0ZSB0aGUgdGVzdCB0 byBtb2Rlcm4gc3R5bGUuCisKIDIwMTctMDItMjcgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFw cGxlLmNvbT4KIAogICAgICAgICBbTW9kZXJuIE1lZGlhIENvbnRyb2xzXSBVc2UgY29tcGFjdCBt b2RlIGJ5IGRlZmF1bHQgb24gbWFjT1MKSW5kZXg6IExheW91dFRlc3RzL3dvcmtlcnMvc2FiL3Bv c3RNZXNzYWdlLWNsb25lcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv d29ya2Vycy9zYWIvcG9zdE1lc3NhZ2UtY2xvbmVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjEz MDkxKQorKysgTGF5b3V0VGVzdHMvd29ya2Vycy9zYWIvcG9zdE1lc3NhZ2UtY2xvbmVzLWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMywxMSArMywxMSBAQCBDaGVja3MgdGhhdCB3aW5k b3cucG9zdE1lc3NhZ2UgY2xvbmVzIFNoCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAot UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQotCi1URVNUIENPTVBMRVRFCiBQQVNTIG1l bW9yeVswXSBpcyA0MgogUEFTUyBvdGhlck1lbW9yeVswXSBpcyAwCiBQQVNTIG1lbW9yeVswXSBp cyA0MgogUEFTUyBvdGhlck1lbW9yeVswXSBpcyA0MworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCiAKSW5kZXg6IExheW91dFRlc3RzL3dvcmtlcnMvc2Fi L3Bvc3RNZXNzYWdlLWNsb25lcy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3dvcmtl cnMvc2FiL3Bvc3RNZXNzYWdlLWNsb25lcy5odG1sCShyZXZpc2lvbiAyMTMwOTEpCisrKyBMYXlv dXRUZXN0cy93b3JrZXJzL3NhYi9wb3N0TWVzc2FnZS1jbG9uZXMuaHRtbAkod29ya2luZyBjb3B5 KQpAQCAtMSwxNCArMSwxMyBAQAotPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQg SFRNTC8vRU4iPgorPCFET0NUWVBFIGh0bWw+CiA8aHRtbD4KIDxoZWFkPgotPHNjcmlwdCBzcmM9 Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+CiA8 c2NyaXB0PgogZGVzY3JpcHRpb24oIkNoZWNrcyB0aGF0IHdpbmRvdy5wb3N0TWVzc2FnZSBjbG9u ZXMgU2hhcmVkQXJyYXlCdWZmZXJzIik7CiAKLWlmICh3aW5kb3cudGVzdFJ1bm5lcikKLSAgICB0 ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK2pzVGVzdElzQXN5bmMgPSB0cnVlOwogCiB2YXIg c2FiID0gbmV3IFNoYXJlZEFycmF5QnVmZmVyKDQpOwogdmFyIG1lbW9yeSA9IG5ldyBJbnQzMkFy cmF5KHNhYik7CkBAIC0yMiwxNiArMjEsMTAgQEAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoIm1l c3NhZ2UiLCBmdW5jdAogICAgIG90aGVyTWVtb3J5WzBdID0gNDM7CiAgICAgc2hvdWxkQmUoIm1l bW9yeVswXSIsICI0MiIpOwogICAgIHNob3VsZEJlKCJvdGhlck1lbW9yeVswXSIsICI0MyIpOwot ICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKLSAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25l KCk7CisgICAgZmluaXNoSlNUZXN0KCk7CiB9KTsKIAotd2luZG93LnNldFRpbWVvdXQoCi0gICAg ZnVuY3Rpb24oKSB7Ci0gICAgICAgIHdpbmRvdy5wb3N0TWVzc2FnZShtZW1vcnksICIqIik7Ci0g ICAgfSwKLSAgICAwKTsKK3dpbmRvdy5wb3N0TWVzc2FnZShtZW1vcnksICIqIik7CiA8L3Njcmlw dD4KLTxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Njcmlw dD4KIDwvYm9keT4KIDwvaHRtbD4K