168122 2017-02-10 09:53:11 -0800 [GStreamer][MSE][EME] Fix decryptor assignment 2017-02-11 20:16:03 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned bugs-noreply cgarcia commit-queue eocanha gustavo mcatanzaro zan oldest_to_newest 1275357 0 olivier.blin 2017-02-10 09:53:11 -0800 In AppendPipeline::parseDemuxerSrcPadCaps(), the new decryptor is a floating reference so we should not use the adopt GRefPtr constructor, but use the regular assignment operator that will sink the object. See previous pipeline fix in r210851 and WPE commit 06020b18831e1c0eead34e2c1a5a4b7d026c227d. 1275360 1 301167 olivier.blin 2017-02-10 09:59:56 -0800 Created attachment 301167 Patch 1275914 2 301167 commit-queue 2017-02-11 20:15:57 -0800 Comment on attachment 301167 Patch Clearing flags on attachment: 301167 Committed r212200: <http://trac.webkit.org/changeset/212200> 1275915 3 commit-queue 2017-02-11 20:16:03 -0800 All reviewed patches have been landed. Closing bug. 301167 2017-02-10 09:59:56 -0800 2017-02-11 20:15:57 -0800 Patch bug-168122-20170210185729.patch text/plain 2212 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjExODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRkOWNlMWJiZDIwYjFh MjZkMzkyY2M0ZWE4MWEwYWJhNjhkYmNkOC4uNmM5MGY4NWFmMDEzOWY1ODI2MGJhZDllZDlmYzQy NTYyMTk4MTc2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTAyLTEwICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0dTdHJl YW1lcl1bTVNFXVtFTUVdIEZpeCBkZWNyeXB0b3IgYXNzaWdubWVudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4MTIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG5ldyBkZWNyeXB0b3IgaXMgYSBm bG9hdGluZyByZWZlcmVuY2Ugc28gd2Ugc2hvdWxkIG5vdCB1c2UgdGhlCisgICAgICAgIGFkb3B0 IEdSZWZQdHIgY29uc3RydWN0b3IsIGJ1dCB1c2UgdGhlIHJlZ3VsYXIgYXNzaWdubWVudCBvcGVy YXRvcgorICAgICAgICB0aGF0IHdpbGwgc2luayB0aGUgb2JqZWN0IChjbGVhciB0aGUgZmxvYXRp bmcgZmxhZykuCisKKyAgICAgICAgVGhpcyBmaXhlcyBhc3NlcnRpb25zIGluIGRlYnVnIGJ1aWxk LgorCisgICAgICAgIFNlZSBwcmV2aW91cyBwaXBlbGluZSBmaXggaW4gcjIxMDg1MSBhbmQgV1BF IGNvbW1pdAorICAgICAgICAwNjAyMGIxODgzMWUxYzBlZWFkMzRlMmMxYTVhNGI3ZDAyNmMyMjdk LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBl bGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBlbmRQaXBlbGluZTo6cGFyc2VEZW11eGVy U3JjUGFkQ2Fwcyk6CisgICAgICAgIERvIG5vdCB1c2UgYWRvcHRHUmVmKCksIGl0IHByZXZlbnRl ZCB0aGUgb2JqZWN0IGZyb20gYmVpbmcgc3Vuay4KKwogMjAxNy0wMi0wNyAgQW50b2luZSBRdWlu dCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtNb2Rlcm4gTWVkaWEgQ29udHJvbHNd IEhhbmRsZSBtZWRpYSBkdXJhdGlvbnMgb2YgYW4gaG91ciBvciBtb3JlIGdyYWNlZnVsbHkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2Uv QXBwZW5kUGlwZWxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKaW5kZXggZmZhZjliMjY4NDc5ZjY5ODE2Y2I1 YzdiZWRhNDc0NGEwYzJhZWJiMy4uNDg4NWI0MGQwYzA3Yjk0NWNhMmRkZDcxODk5ZGYxOTA4NDhk NDhhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKQEAgLTU1MSw3ICs1NTEs NyBAQCB2b2lkIEFwcGVuZFBpcGVsaW5lOjpwYXJzZURlbXV4ZXJTcmNQYWRDYXBzKEdzdENhcHMq IGRlbXV4ZXJTcmNQYWRDYXBzKQogICAgICAgICAvLyBBbnkgcHJldmlvdXMgZGVjcnlwdG9yIHNo b3VsZCBoYXZlIGJlZW4gcmVtb3ZlZCBmcm9tIHRoZSBwaXBlbGluZSBieSBkaXNjb25uZWN0RnJv bUFwcFNpbmtGcm9tU3RyZWFtaW5nVGhyZWFkKCkKICAgICAgICAgQVNTRVJUKCFtX2RlY3J5cHRv cik7CiAKLSAgICAgICAgbV9kZWNyeXB0b3IgPSBhZG9wdEdSZWYoV2ViQ29yZTo6Y3JlYXRlR3N0 RGVjcnlwdG9yKGdzdF9zdHJ1Y3R1cmVfZ2V0X3N0cmluZyhzdHJ1Y3R1cmUsICJwcm90ZWN0aW9u LXN5c3RlbSIpKSk7CisgICAgICAgIG1fZGVjcnlwdG9yID0gV2ViQ29yZTo6Y3JlYXRlR3N0RGVj cnlwdG9yKGdzdF9zdHJ1Y3R1cmVfZ2V0X3N0cmluZyhzdHJ1Y3R1cmUsICJwcm90ZWN0aW9uLXN5 c3RlbSIpKTsKICAgICAgICAgaWYgKCFtX2RlY3J5cHRvcikgewogICAgICAgICAgICAgR1NUX0VS Uk9SKCJkZWNyeXB0b3Igbm90IGZvdW5kIGZvciBjYXBzOiAlIiBHU1RfUFRSX0ZPUk1BVCwgbV9k ZW11eGVyU3JjUGFkQ2Fwcy5nZXQoKSk7CiAgICAgICAgICAgICByZXR1cm47Cg==