<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>168096</bug_id>
          
          <creation_ts>2017-02-09 17:17:21 -0800</creation_ts>
          <short_desc>WebResourceLoadDelegatePrivate.h cannot be imported standalone</short_desc>
          <delta_ts>2017-02-10 11:28:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=145476</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=168058</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>andersca</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1275146</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-09 17:17:21 -0800</bug_when>
    <thetext>WebResourceLoadDelegatePrivate.h cannot be imported standalone (missing WebNSInteger type). Also TargetAvailability.h should be replaced by TargetConditionals.h as it is the header containing TARGET_OS_IPHONE definition.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1275150</commentid>
    <comment_count>1</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-09 17:19:59 -0800</bug_when>
    <thetext>Removing WebNSInteger was proposed in a patch in https://bugs.webkit.org/show_bug.cgi?id=145476, but missed in final commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1275155</commentid>
    <comment_count>2</comment_count>
      <attachid>301110</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-02-09 17:23:35 -0800</bug_when>
    <thetext>Created attachment 301110
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1275436</commentid>
    <comment_count>3</comment_count>
      <attachid>301110</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-10 11:28:11 -0800</bug_when>
    <thetext>Comment on attachment 301110
Proposed patch

Clearing flags on attachment: 301110

Committed r212128: &lt;http://trac.webkit.org/changeset/212128&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1275437</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-10 11:28:14 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>301110</attachid>
            <date>2017-02-09 17:23:35 -0800</date>
            <delta_ts>2017-02-10 11:28:11 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>patch_WebResourceLoadDelegatePrivate_v3</filename>
            <type>text/plain</type>
            <size>2364</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMjAxMSkKKysrIFNvdXJjZS9XZWJLaXQv
bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTA5
ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJSZXNv
dXJjZUxvYWREZWxlZ2F0ZVByaXZhdGUuaCBjYW5ub3QgYmUgaW1wb3J0ZWQgc3RhbmRhbG9uZQor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY4MDk2CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3
L1dlYlJlc291cmNlTG9hZERlbGVnYXRlUHJpdmF0ZS5oOiBDaGFuZ2UgV2ViTlNJbnRlZ2VyIHRv
IE5TSW50ZWdlci4gCisKIDIwMTctMDItMDkgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu
Y29tPgogCiAgICAgICAgIFJlbW92ZSBtb3N0IGNhc2VzIG9mICNpZiBFTkFCTEUoQ0FDSEVfUEFS
VElUSU9OSU5HKQpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJSZXNvdXJjZUxv
YWREZWxlZ2F0ZVByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJW
aWV3L1dlYlJlc291cmNlTG9hZERlbGVnYXRlUHJpdmF0ZS5oCShyZXZpc2lvbiAyMTE5NjcpCisr
KyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlJlc291cmNlTG9hZERlbGVnYXRlUHJpdmF0
ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw3ICsyNiw3IEBACiAgKiBUSElTIFNPRlRXQVJFLCBF
VkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAK
LSNpbXBvcnQgPFRhcmdldEF2YWlsYWJpbGl0eS5oPgorI2ltcG9ydCA8VGFyZ2V0Q29uZGl0aW9u
YWxzLmg+CiAKIEBjbGFzcyBXZWJWaWV3OwogQGNsYXNzIFdlYkRhdGFTb3VyY2U7CkBAIC01OCw3
ICs1OCw3IEBAIEBpbnRlcmZhY2UgTlNPYmplY3QgKFdlYlJlc291cmNlTG9hZERlbGUKICNpZiBU
QVJHRVRfT1NfSVBIT05FCiAtIChpZCl3ZWJUaHJlYWRXZWJWaWV3OihXZWJWaWV3ICopc2VuZGVy
IGlkZW50aWZpZXJGb3JJbml0aWFsUmVxdWVzdDooTlNVUkxSZXF1ZXN0ICopcmVxdWVzdCBmcm9t
RGF0YVNvdXJjZTooV2ViRGF0YVNvdXJjZSAqKWRhdGFTb3VyY2U7CiAtIChOU1VSTFJlcXVlc3Qg
Kil3ZWJUaHJlYWRXZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIHJlc291cmNlOihpZClpZGVudGlm
aWVyIHdpbGxTZW5kUmVxdWVzdDooTlNVUkxSZXF1ZXN0ICopcmVxdWVzdCByZWRpcmVjdFJlc3Bv
bnNlOihOU1VSTFJlc3BvbnNlICopcmVkaXJlY3RSZXNwb25zZSBmcm9tRGF0YVNvdXJjZTooV2Vi
RGF0YVNvdXJjZSAqKWRhdGFTb3VyY2U7Ci0tICh2b2lkKXdlYlRocmVhZFdlYlZpZXc6KFdlYlZp
ZXcgKilzZW5kZXIgcmVzb3VyY2U6KGlkKWlkZW50aWZpZXIgZGlkUmVjZWl2ZUNvbnRlbnRMZW5n
dGg6KFdlYk5TSW50ZWdlcilsZW5ndGggZnJvbURhdGFTb3VyY2U6KFdlYkRhdGFTb3VyY2UgKilk
YXRhU291cmNlOworLSAodm9pZCl3ZWJUaHJlYWRXZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIHJl
c291cmNlOihpZClpZGVudGlmaWVyIGRpZFJlY2VpdmVDb250ZW50TGVuZ3RoOihOU0ludGVnZXIp
bGVuZ3RoIGZyb21EYXRhU291cmNlOihXZWJEYXRhU291cmNlICopZGF0YVNvdXJjZTsKIC0gKHZv
aWQpd2ViVGhyZWFkV2ViVmlldzooV2ViVmlldyAqKXNlbmRlciByZXNvdXJjZTooaWQpaWRlbnRp
ZmllciBkaWRSZWNlaXZlUmVzcG9uc2U6KE5TVVJMUmVzcG9uc2UgKilyZXNwb25zZSBmcm9tRGF0
YVNvdXJjZTooV2ViRGF0YVNvdXJjZSAqKWRhdGFTb3VyY2U7CiAtICh2b2lkKXdlYlRocmVhZFdl
YlZpZXc6KFdlYlZpZXcgKil3ZWJWaWV3IGRpZExvYWRSZXNvdXJjZUZyb21NZW1vcnlDYWNoZToo
TlNVUkxSZXF1ZXN0ICopcmVxdWVzdCByZXNwb25zZTooTlNVUkxSZXNwb25zZSAqKXJlc3BvbnNl
IGxlbmd0aDooTlNJbnRlZ2VyKWxlbmd0aCBmcm9tRGF0YVNvdXJjZTooV2ViRGF0YVNvdXJjZSAq
KWRhdGFTb3VyY2U7CiAtICh2b2lkKXdlYlRocmVhZFdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIg
cmVzb3VyY2U6KGlkKWlkZW50aWZpZXIgZGlkRmluaXNoTG9hZGluZ0Zyb21EYXRhU291cmNlOihX
ZWJEYXRhU291cmNlICopZGF0YVNvdXJjZTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>