168095 2017-02-09 17:13:52 -0800 Web Automation: fail gracefully when a screenshot cannot be encoded as base64 2017-02-10 09:27:13 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1275145 0 bburg 2017-02-09 17:13:52 -0800 <rdar://problem/30297427> 1275234 1 301133 bburg 2017-02-09 22:27:07 -0800 Created attachment 301133 Proposed Fix 1275235 2 301133 joepeck 2017-02-09 22:32:01 -0800 Comment on attachment 301133 Proposed Fix r=me. When can we not base64? Could we write a test for this? 1275338 3 bburg 2017-02-10 09:01:30 -0800 (In reply to comment #2) > Comment on attachment 301133 [details] > Proposed Fix > > r=me. When can we not base64? Could we write a test for this? Unsure of how to reproduce this, but we have seen some crash reports to suggest it could happen. My guess is that the screenshot is too big to fit in memory for some reason–large web page or low memory or both. 1275343 4 301133 commit-queue 2017-02-10 09:27:10 -0800 Comment on attachment 301133 Proposed Fix Clearing flags on attachment: 301133 Committed r212115: <http://trac.webkit.org/changeset/212115> 1275344 5 commit-queue 2017-02-10 09:27:13 -0800 All reviewed patches have been landed. Closing bug. 301133 2017-02-09 22:27:07 -0800 2017-02-10 09:27:10 -0800 Proposed Fix bug-168095-20170209222441.patch text/plain 5071 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjExODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmIxNmRkMGRhOTJlYTJm MWY5YTI5MGYxODNhZTc1OWQxZjdmMjlkOS4uODM1Zjc5NjUxMzFiMDU5MDA3MGMxODY3OWVlZWRm NWZkMGI3ZGNmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAyLTA5ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBBdXRvbWF0aW9uOiBmYWls IGdyYWNlZnVsbHkgd2hlbiBhIHNjcmVlbnNob3QgY2Fubm90IGJlIGVuY29kZWQgYXMgYmFzZTY0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgwOTUK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMwMjk3NDI3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbnZlcnQgcGxhdGZvcm1HZXRCYXNlNjRFbmNv ZGVkUE5HRGF0YSB0byByZXR1cm4gYSBzdGQ6Om9wdGlvbmFsPFN0cmluZz4uCisgICAgICAgIFJl dHVybiBudWxsb3B0IGlmIHdlIGNhbid0IGNyZWF0ZSBhIHNjcmVlbnNob3Qgb3IgY29udmVydCBp dCB0byBiYXNlNjQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0 aW9uU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjpk aWRUYWtlU2NyZWVuc2hvdCk6CisgICAgICAgIChXZWJLaXQ6OldlYkF1dG9tYXRpb25TZXNzaW9u OjpwbGF0Zm9ybUdldEJhc2U2NEVuY29kZWRQTkdEYXRhKToKKyAgICAgICAgKiBVSVByb2Nlc3Mv QXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9B dXRvbWF0aW9uL2NvY29hL1dlYkF1dG9tYXRpb25TZXNzaW9uQ29jb2EubW06CisgICAgICAgIChX ZWJLaXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjpwbGF0Zm9ybUdldEJhc2U2NEVuY29kZWRQTkdE YXRhKToKKwogMjAxNy0wMi0wOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgR1VNIGlzIGNyYXNoaW5nIGluIERlYnVnIG1vZGUgd2hlbiBhY2Nlc3MgaXMgZ3Jh bnRlZC9kZW5pZWQgZm9yIGEgcGFnZSB0aGF0IGlzIGdvbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNw cAppbmRleCA1ZjAzMTQ2NTBkZjUzMzMyMjRjMWU2MDFhMWRhNjEyMGJiMmZhY2FhLi4yMjhlYTUz M2MyOTg0ZTI0YTMyYzc0OGRkYmYwYjU1YjZhNzJmNzdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24u Y3BwCkBAIC05MTYsMTMgKzkxNiwxMyBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uOjpkaWRU YWtlU2NyZWVuc2hvdCh1aW50NjRfdCBjYWxsYmFja0lELCBjb25zdCBTaGFyZWFibAogICAgICAg ICByZXR1cm47CiAgICAgfQogCi0gICAgU3RyaW5nIGJhc2U2NEVuY29kZWREYXRhID0gcGxhdGZv cm1HZXRCYXNlNjRFbmNvZGVkUE5HRGF0YShpbWFnZURhdGFIYW5kbGUpOwotICAgIGlmIChiYXNl NjRFbmNvZGVkRGF0YS5pc0VtcHR5KCkpIHsKKyAgICBzdGQ6Om9wdGlvbmFsPFN0cmluZz4gYmFz ZTY0RW5jb2RlZERhdGEgPSBwbGF0Zm9ybUdldEJhc2U2NEVuY29kZWRQTkdEYXRhKGltYWdlRGF0 YUhhbmRsZSk7CisgICAgaWYgKCFiYXNlNjRFbmNvZGVkRGF0YSkgewogICAgICAgICBjYWxsYmFj ay0+c2VuZEZhaWx1cmUoU1RSSU5HX0ZPUl9QUkVERUZJTkVEX0VSUk9SX05BTUUoSW50ZXJuYWxF cnJvcikpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgY2FsbGJhY2stPnNlbmRTdWNj ZXNzKGJhc2U2NEVuY29kZWREYXRhKTsKKyAgICBjYWxsYmFjay0+c2VuZFN1Y2Nlc3MoYmFzZTY0 RW5jb2RlZERhdGEudmFsdWUoKSk7CiB9CiAKIC8vIFBsYXRmb3JtLWRlcGVuZGVudCBJbXBsZW1l bnRhdGlvbiBTdHVicy4KQEAgLTk0Miw3ICs5NDIsNyBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNz aW9uOjpwbGF0Zm9ybVNpbXVsYXRlS2V5U2VxdWVuY2UoV2ViUGFnZVByb3h5JiwgY29uc3QgU3Ry aQogI2VuZGlmIC8vICFQTEFURk9STShNQUMpCiAKICNpZiAhUExBVEZPUk0oQ09DT0EpCi1TdHJp bmcgV2ViQXV0b21hdGlvblNlc3Npb246OnBsYXRmb3JtR2V0QmFzZTY0RW5jb2RlZFBOR0RhdGEo Y29uc3QgU2hhcmVhYmxlQml0bWFwOjpIYW5kbGUmKQorc3RkOjpvcHRpb25hbDxTdHJpbmc+IFdl YkF1dG9tYXRpb25TZXNzaW9uOjpwbGF0Zm9ybUdldEJhc2U2NEVuY29kZWRQTkdEYXRhKGNvbnN0 IFNoYXJlYWJsZUJpdG1hcDo6SGFuZGxlJikKIHsKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0 aW9uU2Vzc2lvbi5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0 b21hdGlvblNlc3Npb24uaAppbmRleCBiMzFjNTViZGFlOTZjNTQxOTVhNjIxNTFhYzc5YWRjMDQ2 Nzg1ZDY2Li5jZDJkMGI4YWYzZGFkMTQ3MmIzNzhlZTNhM2MzMjIzZjgwNGY5NjM3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vz c2lvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9t YXRpb25TZXNzaW9uLmgKQEAgLTE2Nyw3ICsxNjcsNyBAQCBwcml2YXRlOgogICAgIC8vIFNpbXVs YXRlcyBrZXkgcHJlc3NlcyB0byBwcm9kdWNlIHRoZSBjb2RlcG9pbnRzIGluIGEgc3RyaW5nLiBP bmUgb3IgbW9yZSBjb2RlIHBvaW50cyBhcmUgZGVsaXZlcmVkIGF0b21pY2FsbHkgYXQgZ3JhcGhl bWUgY2x1c3RlciBib3VuZGFyaWVzLgogICAgIHZvaWQgcGxhdGZvcm1TaW11bGF0ZUtleVNlcXVl bmNlKFdlYlBhZ2VQcm94eSYsIGNvbnN0IFN0cmluZyYpOwogICAgIC8vIEdldCBiYXNlNjQgZW5j b2RlZCBQTkcgZGF0YSBmcm9tIGEgYml0bWFwLgotICAgIFN0cmluZyBwbGF0Zm9ybUdldEJhc2U2 NEVuY29kZWRQTkdEYXRhKGNvbnN0IFNoYXJlYWJsZUJpdG1hcDo6SGFuZGxlJik7CisgICAgc3Rk OjpvcHRpb25hbDxTdHJpbmc+IHBsYXRmb3JtR2V0QmFzZTY0RW5jb2RlZFBOR0RhdGEoY29uc3Qg U2hhcmVhYmxlQml0bWFwOjpIYW5kbGUmKTsKIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICB2b2lk IHNlbmRTeW50aGVzaXplZEV2ZW50c1RvUGFnZShXZWJQYWdlUHJveHkmLCBOU0FycmF5ICpldmVu dHNUb1NlbmQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRp b24vY29jb2EvV2ViQXV0b21hdGlvblNlc3Npb25Db2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BdXRvbWF0aW9uL2NvY29hL1dlYkF1dG9tYXRpb25TZXNzaW9uQ29jb2EubW0KaW5k ZXggMzY4N2QyODI0MjAyNWQ5NzI4YmIwMDA5NGIwZjcwMDNhM2E2MjdjNC4uYmVhZGVjYjU3NDUy NmEwYmZhZmZlZmVkYmExNWY4ODRlMTJiNWY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0F1dG9tYXRpb24vY29jb2EvV2ViQXV0b21hdGlvblNlc3Npb25Db2NvYS5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9jb2NvYS9XZWJBdXRvbWF0 aW9uU2Vzc2lvbkNvY29hLm1tCkBAIC0zNywxOSArMzcsMjIgQEAgdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi1TdHJpbmcgV2ViQXV0b21hdGlvblNlc3Np b246OnBsYXRmb3JtR2V0QmFzZTY0RW5jb2RlZFBOR0RhdGEoY29uc3QgU2hhcmVhYmxlQml0bWFw OjpIYW5kbGUmIGltYWdlRGF0YUhhbmRsZSkKK3N0ZDo6b3B0aW9uYWw8U3RyaW5nPiBXZWJBdXRv bWF0aW9uU2Vzc2lvbjo6cGxhdGZvcm1HZXRCYXNlNjRFbmNvZGVkUE5HRGF0YShjb25zdCBTaGFy ZWFibGVCaXRtYXA6OkhhbmRsZSYgaW1hZ2VEYXRhSGFuZGxlKQogewogICAgIFJlZlB0cjxTaGFy ZWFibGVCaXRtYXA+IGJpdG1hcCA9IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlKGltYWdlRGF0YUhh bmRsZSwgU2hhcmVkTWVtb3J5OjpQcm90ZWN0aW9uOjpSZWFkT25seSk7CisgICAgaWYgKCFiaXRt YXApCisgICAgICAgIHJldHVybiBzdGQ6Om51bGxvcHQ7CisKICAgICBSZXRhaW5QdHI8Q0dJbWFn ZVJlZj4gY2dJbWFnZSA9IGJpdG1hcC0+bWFrZUNHSW1hZ2UoKTsKICAgICBSZXRhaW5QdHI8TlNN dXRhYmxlRGF0YT4gaW1hZ2VEYXRhID0gYWRvcHROUyhbW05TTXV0YWJsZURhdGEgYWxsb2NdIGlu aXRdKTsKICAgICBSZXRhaW5QdHI8Q0dJbWFnZURlc3RpbmF0aW9uUmVmPiBkZXN0aW5hdGlvbiA9 IGFkb3B0Q0YoQ0dJbWFnZURlc3RpbmF0aW9uQ3JlYXRlV2l0aERhdGEoKENGTXV0YWJsZURhdGFS ZWYpaW1hZ2VEYXRhLmdldCgpLCBrVVRUeXBlUE5HLCAxLCAwKSk7CiAgICAgaWYgKCFkZXN0aW5h dGlvbikKLSAgICAgICAgcmV0dXJuIFN0cmluZygpOworICAgICAgICByZXR1cm4gc3RkOjpudWxs b3B0OwogCiAgICAgQ0dJbWFnZURlc3RpbmF0aW9uQWRkSW1hZ2UoZGVzdGluYXRpb24uZ2V0KCks IGNnSW1hZ2UuZ2V0KCksIDApOwogICAgIENHSW1hZ2VEZXN0aW5hdGlvbkZpbmFsaXplKGRlc3Rp bmF0aW9uLmdldCgpKTsKIAotICAgIHJldHVybiBbaW1hZ2VEYXRhIGJhc2U2NEVuY29kZWRTdHJp bmdXaXRoT3B0aW9uczowXTsKKyAgICByZXR1cm4gU3RyaW5nKFtpbWFnZURhdGEgYmFzZTY0RW5j b2RlZFN0cmluZ1dpdGhPcHRpb25zOjBdKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==