16806 2008-01-09 14:06:39 -0800 SunSpider/tests/string-base64.js does not compute a valid base64 encoded string 2009-12-14 14:26:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 eric eric ap erikkay mjs seth.gaurav webkit.review.bot oldest_to_newest 66682 0 eric 2008-01-09 14:06:39 -0800 SunSpider/tests/string-base64.js does not compute a valid base64 encoded string This patch to the test shows the error: Index: string-base64.js =================================================================== --- string-base64.js (revision 29341) +++ string-base64.js (working copy) @@ -126,7 +126,10 @@ var base64; base64 = toBase64(str); - base64ToString(base64); + var roundtrip = base64ToString(base64); + if (str != roundtrip) { + throw "oops!"; + } // Double the string str += str; I'll attach a patch to fix the bug soon. I expect this is already a well known issue. 66683 1 18354 eric 2008-01-09 14:16:16 -0800 Created attachment 18354 fix correctness and add correctness check 66992 2 18354 darin 2008-01-11 18:36:45 -0800 Comment on attachment 18354 fix correctness and add correctness check Looks fine to me. I don't know what Maciej's plan is for changes to SunSpider, though. 66993 3 darin 2008-01-11 18:38:37 -0800 What I mean is that I know he wants to fix issues like this one, but I do not know how he wants to stage the changes to SunSpider itself. 67120 4 18354 eric 2008-01-13 11:08:39 -0800 Comment on attachment 18354 fix correctness and add correctness check Since Maciej is going to be the one making this change, I might as well make that clear in the review queue. 69576 5 timothy 2008-02-06 07:27:11 -0800 Maybe you should remove the string compare (str != roundtrip) before this lands. Do we want Sunspider to check correctness like this? Having the extra string compare in the test will make results differ more from the previous version. 69588 6 eric 2008-02-06 10:55:17 -0800 (In reply to comment #5) > Maybe you should remove the string compare (str != roundtrip) before this > lands. Do we want Sunspider to check correctness like this? Having the extra > string compare in the test will make results differ more from the previous > version. > Testing correctness is definitely my intention with this patch. My recommendation would be that all sunspider tests should test themselves for correctness. 81936 7 18354 eric 2008-05-30 08:35:12 -0700 Comment on attachment 18354 fix correctness and add correctness check Unless I hear a very loud NO from maciej, I'm going to find another reviewer and land this next week. Silly to have SunSpider *still* be broken. 81941 8 darin 2008-05-30 09:03:34 -0700 I'm not sure that's helpful. We currently have SunSpider 0.9. I think it could be a mistake to turn our tree into "SunSpider 0.9 with some changes". 81947 9 eric 2008-05-30 10:03:58 -0700 (In reply to comment #8) > I'm not sure that's helpful. We currently have SunSpider 0.9. I think it could > be a mistake to turn our tree into "SunSpider 0.9 with some changes". I agree. My previous comment wasn't very helpful. Poor choice of venting other frustration and seeing that this bug is still awaiting review nearly 5 months later. There are two reasons I can see for the delay. 1. mjs is swamped with other things. 2. mjs is intentionally avoiding landing changes to SunSpider. 1. Is solved by finding another reviewer (it's a simple patch after all). 2. Seems slightly broken by-design, since that's using trunk/ as a stable branch. If 2 is the intention (and mjs and I can hash this out over IRC), then it seems that we could/should copy current SunSpider trunk into a branch, thus allowing further development. An alternative would be to create a SunSpider-unstable branch, and develop there (but that's the opposite of how the rest of WebKit development works). Either way, the status-quo is "don't touch sunspider" (or at least that's the vibe I've gotten from brief IRC conversations and having this patch sit for 3 months. :( Again, mjs and I can (and will) hash this out on IRC. 82023 10 mjs 2008-05-30 23:35:34 -0700 My apologies for not dealing with this patch yet. There are a couple of separate issues here: 1) trunk is not the frozen SunSpider 0.9 version; the copy on the web site is the frozen version 2) trunk SunSpider can change, but: 2.a) we should think about a way to let people still easily run command-line against the old eversion (I don't think about that before) -- the web site copy does not have the command line version, so maybe there should be version subfolders in the SunSpider directory or something. 2.b) I'd like to keep the tests balanced in time with each other in the reference browsers. I can deal with 2.b (now firing up the PC laptop to test and adjust as needed) but I need to figure out something for 2.a. As for the correctness check, I would like all the tests to have correctness checks (I have some code lying around to that effect), but ideally I would like the check to be outside the test itself (as well as, ideally having an input outside the test itself; the combination of the two things means a smart compiler can't just fold the whole test to a constant which would miss the point of the benchmark). I'm sorry for having made myself the gatekeeper for SunSpider and not being responsive enough. 87589 11 eric 2008-08-01 12:07:57 -0700 (In reply to comment #10) Just checking in again... 2 months later. I know you all are busy. But this is one patch in the (very long) review queue which I can't review myself. 89842 12 mjs 2008-08-31 19:54:55 -0700 I have not had a chance to do what I said in comment #10 yet. If you'd like to add support for multiple versions of the test content for SunSpider (with 0.9 still the default for now) then I'd be glad to review this patch immediately for 0.9.1. Otherwise, I (or anyone else) can review it once that infrastructure is in place. Basically SunSpider has become important enough in the broader browser performance community that I don't think I can unilaterally judge what changes are good, so I think the next version of the benchmark should be staged for testing and put out for wider community review before it becomes official. I'd appreciate your help on that. 100852 13 18354 eric 2008-12-01 12:27:24 -0800 Comment on attachment 18354 fix correctness and add correctness check This bug doesn't need to sit in the review queue. Maciej knows of the issue. Sitting in the review queue for the next 11 months isn't going to solve the issue. :) Maciej has noted reviewing this patch is blocked on other issues with sunspider distribution. 104468 14 seth.gaurav 2009-01-05 12:28:34 -0800 This fix does not completely solve the problem of correctness of the base64 test (esp for IE). Reason being a non-standard compliance issue as detailed in the bug 22914. 171270 15 44770 mjs 2009-12-13 17:34:16 -0800 Created attachment 44770 Patch 171273 16 44770 barraclough 2009-12-13 17:39:24 -0800 Comment on attachment 44770 Patch Do you mean the sunspider-compare-results change to be there? 171274 17 webkit.review.bot 2009-12-13 17:39:29 -0800 style-queue ran check-webkit-style on attachment 44770 without any errors. 171281 18 mjs 2009-12-13 18:38:56 -0800 Committed r52078: <http://trac.webkit.org/changeset/52078> 171460 19 eric 2009-12-14 10:21:16 -0800 Is sunspider versioned now? It's nice that this is finally fixed! 171582 20 seth.gaurav 2009-12-14 14:26:54 -0800 How do we access the updated version of SunSpider tests that have this change? 18354 2008-01-09 14:16:16 -0800 2009-12-13 17:32:08 -0800 fix correctness and add correctness check fix.patch text/plain 2950 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI5MzQx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDEt MDkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0cmluZy1iYXNlNjQgdGVzdCBkb2VzIG5vdCBj b21wdXRlIGEgdmFsaWQgYmFzZTY0IHN0cmluZworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgwNgorCisgICAgICAgICogdGVzdHMvc3RyaW5nLWJhc2U2 NC5qczogY2hhbmdlIHN0cltpXSB0byBzdHIuY2hhckNvZGVBdChpKQorCiAyMDA3LTEyLTI5ICBB bHAgVG9rZXIgIDxhbHBAYXRva2VyLmNvbT4KIAogICAgICAgICBGaXggdHlwby4KSW5kZXg6IHRl c3RzL3N0cmluZy1iYXNlNjQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdGVzdHMvc3RyaW5nLWJhc2U2NC5q cwkocmV2aXNpb24gMjkzNDEpCisrKyB0ZXN0cy9zdHJpbmctYmFzZTY0LmpzCSh3b3JraW5nIGNv cHkpCkBAIC00OCwyMiArNDgsMjIgQEAgZnVuY3Rpb24gdG9CYXNlNjQoZGF0YSkgewogICAgIHZh ciBpOwogICAgIC8vIENvbnZlcnQgZXZlcnkgdGhyZWUgYnl0ZXMgdG8gNCBhc2NpaSBjaGFyYWN0 ZXJzLgogICAgIGZvciAoaSA9IDA7IGkgPCAobGVuZ3RoIC0gMik7IGkgKz0gMykgewotICAgICAg ICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVtkYXRhW2ldID4+IDJdOwotICAgICAgICByZXN1bHQg Kz0gdG9CYXNlNjRUYWJsZVsoKGRhdGFbaV0gJiAweDAzKSA8PCA0KSArIChkYXRhW2krMV0gPj4g NCldOwotICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVsoKGRhdGFbaSsxXSAmIDB4MGYp IDw8IDIpICsgKGRhdGFbaSsyXSA+PiA2KV07Ci0gICAgICAgIHJlc3VsdCArPSB0b0Jhc2U2NFRh YmxlW2RhdGFbaSsyXSAmIDB4M2ZdOworICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVtk YXRhLmNoYXJDb2RlQXQoaSkgPj4gMl07CisgICAgICAgIHJlc3VsdCArPSB0b0Jhc2U2NFRhYmxl WygoZGF0YS5jaGFyQ29kZUF0KGkpICYgMHgwMykgPDwgNCkgKyAoZGF0YS5jaGFyQ29kZUF0KGkr MSkgPj4gNCldOworICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVsoKGRhdGEuY2hhckNv ZGVBdChpKzEpICYgMHgwZikgPDwgMikgKyAoZGF0YS5jaGFyQ29kZUF0KGkrMikgPj4gNildOwor ICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVtkYXRhLmNoYXJDb2RlQXQoaSsyKSAmIDB4 M2ZdOwogICAgIH0KIAogICAgIC8vIENvbnZlcnQgdGhlIHJlbWFpbmluZyAxIG9yIDIgYnl0ZXMs IHBhZCBvdXQgdG8gNCBjaGFyYWN0ZXJzLgogICAgIGlmIChsZW5ndGglMykgewogICAgICAgICBp ID0gbGVuZ3RoIC0gKGxlbmd0aCUzKTsKLSAgICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFibGVb ZGF0YVtpXSA+PiAyXTsKKyAgICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFibGVbZGF0YS5jaGFy Q29kZUF0KGkpID4+IDJdOwogICAgICAgICBpZiAoKGxlbmd0aCUzKSA9PSAyKSB7Ci0gICAgICAg ICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVsoKGRhdGFbaV0gJiAweDAzKSA8PCA0KSArIChk YXRhW2krMV0gPj4gNCldOwotICAgICAgICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFibGVbKGRh dGFbaSsxXSAmIDB4MGYpIDw8IDJdOworICAgICAgICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFi bGVbKChkYXRhLmNoYXJDb2RlQXQoaSkgJiAweDAzKSA8PCA0KSArIChkYXRhLmNoYXJDb2RlQXQo aSsxKSA+PiA0KV07CisgICAgICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVsoZGF0YS5j aGFyQ29kZUF0KGkrMSkgJiAweDBmKSA8PCAyXTsKICAgICAgICAgICAgIHJlc3VsdCArPSBiYXNl NjRQYWQ7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRU YWJsZVsoZGF0YVtpXSAmIDB4MDMpIDw8IDRdOworICAgICAgICAgICAgcmVzdWx0ICs9IHRvQmFz ZTY0VGFibGVbKGRhdGEuY2hhckNvZGVBdChpKSAmIDB4MDMpIDw8IDRdOwogICAgICAgICAgICAg cmVzdWx0ICs9IGJhc2U2NFBhZCArIGJhc2U2NFBhZDsKICAgICAgICAgfQogICAgIH0KQEAgLTkx LDcgKzkxLDcgQEAgZnVuY3Rpb24gYmFzZTY0VG9TdHJpbmcoZGF0YSkgewogICAgIC8vIENvbnZl cnQgb25lIGJ5IG9uZS4KICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGRhdGEubGVuZ3RoOyBpKysp IHsKICAgICAgICAgdmFyIGMgPSB0b0JpbmFyeVRhYmxlW2RhdGEuY2hhckNvZGVBdChpKSAmIDB4 N2ZdOwotICAgICAgICB2YXIgcGFkZGluZyA9IChkYXRhW2ldID09IGJhc2U2NFBhZCk7CisgICAg ICAgIHZhciBwYWRkaW5nID0gKGRhdGEuY2hhckNvZGVBdChpKSA9PSBiYXNlNjRQYWQuY2hhckNv ZGVBdCgwKSk7CiAgICAgICAgIC8vIFNraXAgaWxsZWdhbCBjaGFyYWN0ZXJzIGFuZCB3aGl0ZXNw YWNlCiAgICAgICAgIGlmIChjID09IC0xKSBjb250aW51ZTsKICAgICAgICAgCkBAIC0xMjYsNyAr MTI2LDEwIEBAIGZvciAoIHZhciBpID0gODE5MjsgaSA8PSAxNjM4NDsgaSAqPSAyICkKICAgICB2 YXIgYmFzZTY0OwogCiAgICAgYmFzZTY0ID0gdG9CYXNlNjQoc3RyKTsKLSAgICBiYXNlNjRUb1N0 cmluZyhiYXNlNjQpOworICAgIHZhciByb3VuZHRyaXAgPSBiYXNlNjRUb1N0cmluZyhiYXNlNjQp OworICAgIGlmIChzdHIgIT0gcm91bmR0cmlwKSB7CisJdGhyb3cgIm9vcHMhIjsKKyAgICB9CiAK ICAgICAvLyBEb3VibGUgdGhlIHN0cmluZwogICAgIHN0ciArPSBzdHI7Cg== 44770 2009-12-13 17:34:16 -0800 2009-12-13 17:39:24 -0800 Patch bug-16806-20091213173415.patch text/plain 4081 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDUyMDY0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTIt MTMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0cmluZy1iYXNlNjQgdGVzdCBkb2VzIG5vdCBj b21wdXRlIGEgdmFsaWQgYmFzZTY0IHN0cmluZworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgwNgorCisgICAgICAgICogdGVzdHMvc3RyaW5nLWJhc2U2 NC5qczogY2hhbmdlIHN0cltpXSB0byBzdHIuY2hhckNvZGVBdChpKQorCiAyMDA5LTEyLTEwICBH dXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KSW5kZXg6IFN1blNwaWRlci9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU3VuU3BpZGVyL0NoYW5nZUxvZwkocmV2aXNpb24gNTIwNzUpCisr KyBTdW5TcGlkZXIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIw MDktMTItMTMgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdW5TcGlkZXIvdGVzdHMvc3Ry aW5nLWJhc2U2NC5qcyBkb2VzIG5vdCBjb21wdXRlIGEgdmFsaWQgYmFzZTY0IGVuY29kZWQgc3Ry aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgw NgorCisgICAgICAgIEJhc2VkIG9uIGEgcGF0Y2ggYnkgRXJpYyBTZWlkZWwuCisgICAgICAgIAor ICAgICAgICBGaXggdGhlIGJhc2U2NCBjb21wdXRhdGlvbiB0byBhY3R1YWxseSBjb21wdXRlIGNv cnJlY3QgcmVzdWx0cy4gVGhlIGltcGFjdCBvbiBydW50aW1lIG9mCisgICAgICAgIHRoZSB0ZXN0 IGlzIHByZXR0eSBzbWFsbCwgYnV0IG5vdGljZWFibGUgZm9yIHNvbWUgYnJvd3NlcnMuIEJ1dCBh dCBsZWFzdCBpdCdzIG5vdAorICAgICAgICBkb2luZyBhIHdyb25nIGFuZCBtZWFuaW5nbGVzcyBj b21wdXRhdGlvbiBhbnkgbW9yZS4KKyAgICAgICAgCisgICAgICAgICogdGVzdHMvc3Vuc3BpZGVy LTAuOS4xL3N0cmluZy1iYXNlNjQuanM6CisgICAgICAgICgpOgorICAgICAgICAoYmFzZTY0VG9T dHJpbmcpOgorCiAyMDA5LTEyLTEzICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+ CiAKSW5kZXg6IFN1blNwaWRlci90ZXN0cy9zdW5zcGlkZXItMC45LjEvc3RyaW5nLWJhc2U2NC5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTdW5TcGlkZXIvdGVzdHMvc3Vuc3BpZGVyLTAuOS4xL3N0cmluZy1i YXNlNjQuanMJKHJldmlzaW9uIDUyMDY4KQorKysgU3VuU3BpZGVyL3Rlc3RzL3N1bnNwaWRlci0w LjkuMS9zdHJpbmctYmFzZTY0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC00OCwyMiArNDgsMjIgQEAg ZnVuY3Rpb24gdG9CYXNlNjQoZGF0YSkgewogICAgIHZhciBpOwogICAgIC8vIENvbnZlcnQgZXZl cnkgdGhyZWUgYnl0ZXMgdG8gNCBhc2NpaSBjaGFyYWN0ZXJzLgogICAgIGZvciAoaSA9IDA7IGkg PCAobGVuZ3RoIC0gMik7IGkgKz0gMykgewotICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJs ZVtkYXRhW2ldID4+IDJdOwotICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVsoKGRhdGFb aV0gJiAweDAzKSA8PCA0KSArIChkYXRhW2krMV0gPj4gNCldOwotICAgICAgICByZXN1bHQgKz0g dG9CYXNlNjRUYWJsZVsoKGRhdGFbaSsxXSAmIDB4MGYpIDw8IDIpICsgKGRhdGFbaSsyXSA+PiA2 KV07Ci0gICAgICAgIHJlc3VsdCArPSB0b0Jhc2U2NFRhYmxlW2RhdGFbaSsyXSAmIDB4M2ZdOwor ICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVtkYXRhLmNoYXJDb2RlQXQoaSkgPj4gMl07 CisgICAgICAgIHJlc3VsdCArPSB0b0Jhc2U2NFRhYmxlWygoZGF0YS5jaGFyQ29kZUF0KGkpICYg MHgwMykgPDwgNCkgKyAoZGF0YS5jaGFyQ29kZUF0KGkrMSkgPj4gNCldOworICAgICAgICByZXN1 bHQgKz0gdG9CYXNlNjRUYWJsZVsoKGRhdGEuY2hhckNvZGVBdChpKzEpICYgMHgwZikgPDwgMikg KyAoZGF0YS5jaGFyQ29kZUF0KGkrMikgPj4gNildOworICAgICAgICByZXN1bHQgKz0gdG9CYXNl NjRUYWJsZVtkYXRhLmNoYXJDb2RlQXQoaSsyKSAmIDB4M2ZdOwogICAgIH0KIAogICAgIC8vIENv bnZlcnQgdGhlIHJlbWFpbmluZyAxIG9yIDIgYnl0ZXMsIHBhZCBvdXQgdG8gNCBjaGFyYWN0ZXJz LgogICAgIGlmIChsZW5ndGglMykgewogICAgICAgICBpID0gbGVuZ3RoIC0gKGxlbmd0aCUzKTsK LSAgICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFibGVbZGF0YVtpXSA+PiAyXTsKKyAgICAgICAg cmVzdWx0ICs9IHRvQmFzZTY0VGFibGVbZGF0YS5jaGFyQ29kZUF0KGkpID4+IDJdOwogICAgICAg ICBpZiAoKGxlbmd0aCUzKSA9PSAyKSB7Ci0gICAgICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRU YWJsZVsoKGRhdGFbaV0gJiAweDAzKSA8PCA0KSArIChkYXRhW2krMV0gPj4gNCldOwotICAgICAg ICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFibGVbKGRhdGFbaSsxXSAmIDB4MGYpIDw8IDJdOwor ICAgICAgICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFibGVbKChkYXRhLmNoYXJDb2RlQXQoaSkg JiAweDAzKSA8PCA0KSArIChkYXRhLmNoYXJDb2RlQXQoaSsxKSA+PiA0KV07CisgICAgICAgICAg ICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVsoZGF0YS5jaGFyQ29kZUF0KGkrMSkgJiAweDBmKSA8 PCAyXTsKICAgICAgICAgICAgIHJlc3VsdCArPSBiYXNlNjRQYWQ7CiAgICAgICAgIH0gZWxzZSB7 Ci0gICAgICAgICAgICByZXN1bHQgKz0gdG9CYXNlNjRUYWJsZVsoZGF0YVtpXSAmIDB4MDMpIDw8 IDRdOworICAgICAgICAgICAgcmVzdWx0ICs9IHRvQmFzZTY0VGFibGVbKGRhdGEuY2hhckNvZGVB dChpKSAmIDB4MDMpIDw8IDRdOwogICAgICAgICAgICAgcmVzdWx0ICs9IGJhc2U2NFBhZCArIGJh c2U2NFBhZDsKICAgICAgICAgfQogICAgIH0KQEAgLTkxLDcgKzkxLDcgQEAgZnVuY3Rpb24gYmFz ZTY0VG9TdHJpbmcoZGF0YSkgewogICAgIC8vIENvbnZlcnQgb25lIGJ5IG9uZS4KICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IGRhdGEubGVuZ3RoOyBpKyspIHsKICAgICAgICAgdmFyIGMgPSB0b0Jp bmFyeVRhYmxlW2RhdGEuY2hhckNvZGVBdChpKSAmIDB4N2ZdOwotICAgICAgICB2YXIgcGFkZGlu ZyA9IChkYXRhW2ldID09IGJhc2U2NFBhZCk7CisgICAgICAgIHZhciBwYWRkaW5nID0gKGRhdGEu Y2hhckNvZGVBdChpKSA9PSBiYXNlNjRQYWQuY2hhckNvZGVBdCgwKSk7CiAgICAgICAgIC8vIFNr aXAgaWxsZWdhbCBjaGFyYWN0ZXJzIGFuZCB3aGl0ZXNwYWNlCiAgICAgICAgIGlmIChjID09IC0x KSBjb250aW51ZTsKICAgICAgICAgCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3N1bnNwaWRl ci1jb21wYXJlLXJlc3VsdHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9zdW5z cGlkZXItY29tcGFyZS1yZXN1bHRzCShyZXZpc2lvbiA1MjA2NCkKKysrIFdlYktpdFRvb2xzL1Nj cmlwdHMvc3Vuc3BpZGVyLWNvbXBhcmUtcmVzdWx0cwkod29ya2luZyBjb3B5KQpAQCAtNDIsNiAr NDIsNyBAQCBteSAkc2hvd0hlbHAgPSAwOwogbXkgJHN1aXRlID0gIiI7CiBteSAkdWJlbmNoID0g MDsKIG15ICR2OCA9IDA7CitteSAkcGFyc2Vvbmx5ID0gMDsKIAogbXkgJHByb2dyYW1OYW1lID0g YmFzZW5hbWUoJDApOwogbXkgJHVzYWdlID0gPDxFT0Y7Cg==