168054 2017-02-09 10:21:37 -0800 REGRESSION (r211845): [ios-simulator] LayoutTest compositing/masks/solid-color-masked.html is a flaky failure 2017-04-13 10:30:17 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad simon.fraser jbedard rniwa simon.fraser webkit-bug-importer oldest_to_newest 1274909 0 ryanhaddad 2017-02-09 10:21:37 -0800 [ios-simulator] LayoutTest compositing/masks/solid-color-masked.html is a flaky failure https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r211961%20(3594)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Fmasks%2Fsolid-color-masked.html Direct link to images and diff: https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r211961%20(3594)/compositing/masks/solid-color-masked-diffs.html 1274958 1 ryanhaddad 2017-02-09 12:05:20 -0800 Flakiness dashboard suggests that this started with https://trac.webkit.org/changeset/211845 1274967 2 simon.fraser 2017-02-09 12:19:22 -0800 I have a hunch about what the problem is here. 1275362 3 ryanhaddad 2017-02-10 10:03:43 -0800 Marked test as failing in http://trac.webkit.org/projects/webkit/changeset/212123 1275563 4 simon.fraser 2017-02-10 15:17:28 -0800 I get: 463$ $ wktests --debug --ios-simulator LayoutTests/compositing/masks/ --iterations=10 Using port 'ios-simulator' Test configuration: <, x86_64, debug> Placing test results in /Volumes/Data/Development/OSX/webkit/OpenSource/WebKitBuild/Debug-iphonesimulator/layout-test-results Baseline search path: platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/wk2 -> generic Using Debug build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /Volumes/Data/Development/OSX/webkit/OpenSource/WebKitBuild/Debug-iphonesimulator/WebKitTestRunnerApp.app - Found 20 tests; running 18 (10 times each: --repeat-each=1 --iterations=10), skipping 2. Running 18 tests This machine could support 12 simulators, but is only configured for 2. Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>. Running 1 WebKitTestRunnerApp.app. [16/180] compositing/masks/solid-color-masked.html passed unexpectedly [34/180] compositing/masks/solid-color-masked.html passed unexpectedly [52/180] compositing/masks/solid-color-masked.html passed unexpectedly [70/180] compositing/masks/solid-color-masked.html passed unexpectedly [88/180] compositing/masks/solid-color-masked.html passed unexpectedly [106/180] compositing/masks/solid-color-masked.html passed unexpectedly [124/180] compositing/masks/solid-color-masked.html passed unexpectedly [142/180] compositing/masks/solid-color-masked.html passed unexpectedly [160/180] compositing/masks/solid-color-masked.html passed unexpectedly [178/180] compositing/masks/solid-color-masked.html passed unexpectedly stopping WebKitTestRunnerApp.app(pid 15605) timed out, killing it 170 tests ran as expected, 10 didn't: Expected to fail, but passed: (1) compositing/masks/solid-color-masked.html 1275632 5 simon.fraser 2017-02-10 16:32:39 -0800 Ah, i can reproduce this on first MobileSafari launch. 1275645 6 simon.fraser 2017-02-10 16:47:21 -0800 Ah, we never run the code at the top of GraphicsLayerCA::recursiveCommitChanges() for mask layers. 1275651 7 simon.fraser 2017-02-10 17:05:22 -0800 Actually GraphicsLayerCA::setVisibleAndCoverageRects() copies the m_intersectsCoverageRect flag to the mask layer. The bug happens when GraphicsLayerCA::setVisibleAndCoverageRects() is called for the masked layer before it has a mask. After than, assigning the mask doesn't ever update the mask's m_intersectsCoverageRect. 1275676 8 webkit-bug-importer 2017-02-10 17:45:29 -0800 <rdar://problem/30476807> 1275681 9 301228 simon.fraser 2017-02-10 17:49:49 -0800 Created attachment 301228 Patch 1275696 10 simon.fraser 2017-02-10 18:32:24 -0800 https://trac.webkit.org/r212172 1297024 11 jbedard 2017-04-13 10:30:17 -0700 Someone forgot to remove this test expectation. Removed in https://trac.webkit.org/r215324. 301228 2017-02-10 17:49:49 -0800 2017-02-10 17:54:27 -0800 Patch bug-168054-20170210174722.patch text/plain 5552 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyMTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTZhNzJhMTMyNmMxNzBm NjllOTJlMmZhODNmYTRlMmZmZjk1MDdjNS4uNTU2MDhkYWFlYTJlZTM4NjA5NGU4Yzk1MTdlYmQ1 MTU4YzAxMmVhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTAyLTEwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyMTE4NDUpOiBbaW9zLXNpbXVsYXRvcl0gTGF5b3V0VGVzdCBjb21wb3NpdGluZy9tYXNrcy9z b2xpZC1jb2xvci1tYXNrZWQuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODA1NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYWRkaW5nIG1hc2sgbGF5ZXJz LCB0aGVyZSB3YXMgYW4gb3JkZXJpbmcgZGVwZW5kZW5jeS4gVGhlcmUgd2FzIGEgaGFjayBpbiBH cmFwaGljc0xheWVyQ0E6OnNldFZpc2libGVBbmRDb3ZlcmFnZVJlY3RzKCkKKyAgICAgICAgdG8g cHJvcGFnYXRlIG1faW50ZXJzZWN0c0NvdmVyYWdlUmVjdCB0byBtYXNrcy4gSG93ZXZlciwgaWYg R3JhcGhpY3NMYXllckNBOjpzZXRWaXNpYmxlQW5kQ292ZXJhZ2VSZWN0cygpCisgICAgICAgIHJh biBvbiB0aGUgbWFza2VkIGxheWVyIGJlZm9yZSB0aGUgbWFzayB3YXMgYWRkZWQsIG5vdGhpbmcg dXBkYXRlZCB0aGUgIm1faW50ZXJzZWN0c0NvdmVyYWdlUmVjdCIgc3RhdGUgb2YgdGhlIG1hc2sg bGF5ZXIuCisKKyAgICAgICAgRml4IGJ5IGV4cGxpY2l0bHkgY2FsbGluZyBzZXRWaXNpYmxlQW5k Q292ZXJhZ2VSZWN0cygpIG9uIHRoZSBtYXNrIGxheWVyLCBwYXNzaW5nIHRoZSBzYW1lIHJlY3Rz IGFuZAorICAgICAgICB2aWV3cG9ydC1jb25zdHJhaW5lZCBzdGF0ZSBhcyBmb3IgaXRzIGhvc3Qg bGF5ZXIgKHdlIGFscmVhZHkgYXNzdW1lIHRoYXQgdGhlaXIgZ2VvbWV0cnkgbWF0Y2hlcykuCisK KyAgICAgICAgVGVzdGVkIGJ5IGNvbXBvc2l0aW5nL21hc2tzL3NvbGlkLWNvbG9yLW1hc2tlZC5o dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNBOjpzZXRWaXNpYmxlQW5kQ292ZXJh Z2VSZWN0cyk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ0E6OnJlY3Vyc2l2ZUNv bW1pdENoYW5nZXMpOgorCiAyMDE3LTAyLTA5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFRpbGVkIGxheWVycyBhcmUgc29tZXRpbWVzIGxlZnQgd2l0 aCBzb21lIHRpbGVzIHdoZW4gb3V0c2lkZSB0aGUgdmlld3BvcnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCmluZGV4 IDk1NzJhNWU0MmRlOGM3NWVkOWFkNmMxOTYzZTdmZmI4ZmVhNjBkOGIuLjJjNTQ4NWMzODNkMWZh M2UwYjU5NTAwMTcwZDg4ZTUyZTU1ODg4N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcApAQCAtMTMzMiwzMiAr MTMzMiwxNiBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDQTo6c2V0VmlzaWJsZUFuZENvdmVyYWdlUmVj dHMoY29uc3QgVmlzaWJsZUFuZENvdmVyYWdlUmVjdHMmCiAgICAgaWYgKGludGVyc2VjdHNDb3Zl cmFnZVJlY3QgIT0gbV9pbnRlcnNlY3RzQ292ZXJhZ2VSZWN0KSB7CiAgICAgICAgIG1fdW5jb21t aXR0ZWRDaGFuZ2VzIHw9IENvdmVyYWdlUmVjdENoYW5nZWQ7CiAgICAgICAgIG1faW50ZXJzZWN0 c0NvdmVyYWdlUmVjdCA9IGludGVyc2VjdHNDb3ZlcmFnZVJlY3Q7Ci0KLSAgICAgICAgaWYgKEdy YXBoaWNzTGF5ZXJDQSogbWFza0xheWVyID0gZG93bmNhc3Q8R3JhcGhpY3NMYXllckNBPihtX21h c2tMYXllcikpIHsKLSAgICAgICAgICAgIG1hc2tMYXllci0+bV91bmNvbW1pdHRlZENoYW5nZXMg fD0gQ292ZXJhZ2VSZWN0Q2hhbmdlZDsKLSAgICAgICAgICAgIG1hc2tMYXllci0+bV9pbnRlcnNl Y3RzQ292ZXJhZ2VSZWN0ID0gaW50ZXJzZWN0c0NvdmVyYWdlUmVjdDsKLSAgICAgICAgfQogICAg IH0KIAogICAgIGlmICh2aXNpYmxlUmVjdENoYW5nZWQpIHsKICAgICAgICAgbV91bmNvbW1pdHRl ZENoYW5nZXMgfD0gQ292ZXJhZ2VSZWN0Q2hhbmdlZDsKICAgICAgICAgbV92aXNpYmxlUmVjdCA9 IHJlY3RzLnZpc2libGVSZWN0OwotCi0gICAgICAgIGlmIChHcmFwaGljc0xheWVyQ0EqIG1hc2tM YXllciA9IGRvd25jYXN0PEdyYXBoaWNzTGF5ZXJDQT4obV9tYXNrTGF5ZXIpKSB7Ci0gICAgICAg ICAgICAvLyBGSVhNRTogdGhpcyBhc3N1bWVzIHRoYXQgdGhlIG1hc2sgbGF5ZXIgaGFzIHRoZSBz YW1lIGdlb21ldHJ5IGFzIHRoaXMgbGF5ZXIgKHdoaWNoIGlzIGN1cnJlbnRseSBhbHdheXMgdHJ1 ZSkuCi0gICAgICAgICAgICBtYXNrTGF5ZXItPm1fdW5jb21taXR0ZWRDaGFuZ2VzIHw9IENvdmVy YWdlUmVjdENoYW5nZWQ7Ci0gICAgICAgICAgICBtYXNrTGF5ZXItPm1fdmlzaWJsZVJlY3QgPSBy ZWN0cy52aXNpYmxlUmVjdDsKLSAgICAgICAgfQogICAgIH0KIAogICAgIGlmIChjb3ZlcmFnZVJl Y3RDaGFuZ2VkKSB7CiAgICAgICAgIG1fdW5jb21taXR0ZWRDaGFuZ2VzIHw9IENvdmVyYWdlUmVj dENoYW5nZWQ7CiAgICAgICAgIG1fY292ZXJhZ2VSZWN0ID0gcmVjdHMuY292ZXJhZ2VSZWN0Owot Ci0gICAgICAgIGlmIChHcmFwaGljc0xheWVyQ0EqIG1hc2tMYXllciA9IGRvd25jYXN0PEdyYXBo aWNzTGF5ZXJDQT4obV9tYXNrTGF5ZXIpKSB7Ci0gICAgICAgICAgICBtYXNrTGF5ZXItPm1fdW5j b21taXR0ZWRDaGFuZ2VzIHw9IENvdmVyYWdlUmVjdENoYW5nZWQ7Ci0gICAgICAgICAgICBtYXNr TGF5ZXItPm1fY292ZXJhZ2VSZWN0ID0gcmVjdHMuY292ZXJhZ2VSZWN0OwotICAgICAgICB9CiAg ICAgfQogfQogCkBAIC0xNDIzLDggKzE0MDcsMTAgQEAgdm9pZCBHcmFwaGljc0xheWVyQ0E6OnJl Y3Vyc2l2ZUNvbW1pdENoYW5nZXMoY29uc3QgQ29tbWl0U3RhdGUmIGNvbW1pdFN0YXRlLCBjb24K ICAgICAKICAgICBjaGlsZENvbW1pdFN0YXRlLmFuY2VzdG9ySXNWaWV3cG9ydENvbnN0cmFpbmVk IHw9IG1faXNWaWV3cG9ydENvbnN0cmFpbmVkOwogCi0gICAgaWYgKEdyYXBoaWNzTGF5ZXJDQSog bWFza0xheWVyID0gZG93bmNhc3Q8R3JhcGhpY3NMYXllckNBPihtX21hc2tMYXllcikpCisgICAg aWYgKEdyYXBoaWNzTGF5ZXJDQSogbWFza0xheWVyID0gZG93bmNhc3Q8R3JhcGhpY3NMYXllckNB PihtX21hc2tMYXllcikpIHsKKyAgICAgICAgbWFza0xheWVyLT5zZXRWaXNpYmxlQW5kQ292ZXJh Z2VSZWN0cyhyZWN0cywgbV9pc1ZpZXdwb3J0Q29uc3RyYWluZWQgfHwgY29tbWl0U3RhdGUuYW5j ZXN0b3JJc1ZpZXdwb3J0Q29uc3RyYWluZWQpOwogICAgICAgICBtYXNrTGF5ZXItPmNvbW1pdExh eWVyQ2hhbmdlc0JlZm9yZVN1YmxheWVycyhjaGlsZENvbW1pdFN0YXRlLCBwYWdlU2NhbGVGYWN0 b3IsIGJhc2VSZWxhdGl2ZVBvc2l0aW9uKTsKKyAgICB9CiAKICAgICBjb25zdCBWZWN0b3I8R3Jh cGhpY3NMYXllcio+JiBjaGlsZExheWVycyA9IGNoaWxkcmVuKCk7CiAgICAgc2l6ZV90IG51bUNo aWxkcmVuID0gY2hpbGRMYXllcnMuc2l6ZSgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJmNjMxZDBkYzExNDgyMzljZDc5 MWNjMDcxZjY2YTRkYjQ0YWU2MzcuLmM0MzFhZmE2MTlmNjU3NGY5ZmFmNzZhNzE2ZTQ3ZDYwMDIy NmYxMDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0wMi0xMCAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjExODQ1KTog W2lvcy1zaW11bGF0b3JdIExheW91dFRlc3QgY29tcG9zaXRpbmcvbWFza3Mvc29saWQtY29sb3It bWFza2VkLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgwNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSB0aW1lb3V0IDEwbXMgc28gdGhlIHRlc3Qg Y29uc2lzdGVudGx5IGZhaWxzIHdpdGggdGhlIG9sZCBjb2RlLgorCisgICAgICAgICogY29tcG9z aXRpbmcvbWFza3Mvc29saWQtY29sb3ItbWFza2VkLmh0bWw6CisKIDIwMTctMDItMDkgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgVGlsZWQgbGF5ZXJz IGFyZSBzb21ldGltZXMgbGVmdCB3aXRoIHNvbWUgdGlsZXMgd2hlbiBvdXRzaWRlIHRoZSB2aWV3 cG9ydApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvbWFza3Mvc29saWQtY29s b3ItbWFza2VkLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9tYXNrcy9zb2xpZC1jb2xv ci1tYXNrZWQuaHRtbAppbmRleCA4NjgzNGFhNjIzZGJhYmIzYzBjZjY1Mjc5YTdiMTFhYTQzYjMw NDlhLi5iZWMxNDA5NzFhZTk0YmEyOWQ3Y2E4Nzk0ZTEzNjVkZTRkZjJhNDlkIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9tYXNrcy9zb2xpZC1jb2xvci1tYXNrZWQuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9tYXNrcy9zb2xpZC1jb2xvci1tYXNrZWQuaHRt bApAQCAtMTAsNyArMTAsNyBAQAogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICAuY29tcG9z aXRlZCB7Ci0gICAgICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZVooMCk7CisgICAg ICAgICAgdHJhbnNmb3JtOiB0cmFuc2xhdGVaKDApOwogICAgICAgICB9CiAKICAgICAgICAgLm1h c2tlZCB7CkBAIC0yNiw3ICsyNiw3IEBACiAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ2JveCcpLmNsYXNzTGlzdC5hZGQoJ21hc2tlZCcpOwogICAgICAgICAgICAgICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKICAgICAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5u b3RpZnlEb25lKCk7Ci0gICAgICAgICAgICB9LCAwKTsKKyAgICAgICAgICAgIH0sIDEwKTsKICAg ICAgICAgfQogICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRvVGVzdCwg ZmFsc2UpOwogICAgIDwvc2NyaXB0Pgo=