168052 2017-02-09 09:07:35 -0800 Use all cacheable speculatively loaded responses 2017-02-10 04:47:43 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned beidson cdumez cgarcia commit-queue webkit-bug-importer oldest_to_newest 1274882 0 koivisto 2017-02-09 09:07:35 -0800 There is no reason not to use any cacheable response that is cacheable. This is helpful with 204s and 404s. 1274885 1 301046 koivisto 2017-02-09 09:15:00 -0800 Created attachment 301046 patch 1274887 2 301046 kling 2017-02-09 09:19:53 -0800 Comment on attachment 301046 patch r=me 1274895 3 koivisto 2017-02-09 09:38:32 -0800 Committed r211963: <http://trac.webkit.org/changeset/211963> 1275297 4 webkit-bug-importer 2017-02-10 04:47:43 -0800 <rdar://problem/30463400> 301046 2017-02-09 09:15:00 -0800 2017-02-09 09:19:53 -0800 patch speculative-204.patch text/plain 7415 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTk0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAyLTA5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgYWxsIGNhY2hlYWJsZSBz cGVjdWxhdGl2ZWx5IGxvYWRlZCByZXNwb25zZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODA1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9DYWNoZVZhbGlkYXRpb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNTdGF0dXNDb2RlQ2FjaGVhYmxlQnlEZWZhdWx0KToK KyAgICAgICAgKFdlYkNvcmU6OmlzU3RhdHVzQ29kZVBvdGVudGlhbGx5Q2FjaGVhYmxlKToKKwor ICAgICAgICBNb3ZlZCBoZXJlIGZyb20gV2ViS2l0Mi4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvQ2FjaGVWYWxpZGF0aW9uLmg6CisKIDIwMTctMDItMDkgIEFudHRpIEtvaXZpc3RvICA8 YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBtb3N0IGNhc2VzIG9mICNpZiBFTkFC TEUoQ0FDSEVfUEFSVElUSU9OSU5HKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9DYWNoZVZhbGlkYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvQ2FjaGVWYWxpZGF0aW9uLmNwcAkocmV2aXNpb24gMjExOTQ1KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9DYWNoZVZhbGlkYXRpb24uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zODAsNCArMzgwLDQzIEBAIGJvb2wgdmVyaWZ5VmFyeWluZ1JlcXVlc3RI ZWFkZXJzKGNvbnN0IFYKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorLy8gaHR0cDovL3Rvb2xzLmll dGYub3JnL2h0bWwvcmZjNzIzMSNwYWdlLTQ4Citib29sIGlzU3RhdHVzQ29kZUNhY2hlYWJsZUJ5 RGVmYXVsdChpbnQgc3RhdHVzQ29kZSkKK3sKKyAgICBzd2l0Y2ggKHN0YXR1c0NvZGUpIHsKKyAg ICBjYXNlIDIwMDogLy8gT0sKKyAgICBjYXNlIDIwMzogLy8gTm9uLUF1dGhvcml0YXRpdmUgSW5m b3JtYXRpb24KKyAgICBjYXNlIDIwNDogLy8gTm8gQ29udGVudAorICAgIGNhc2UgMjA2OiAvLyBQ YXJ0aWFsIENvbnRlbnQKKyAgICBjYXNlIDMwMDogLy8gTXVsdGlwbGUgQ2hvaWNlcworICAgIGNh c2UgMzAxOiAvLyBNb3ZlZCBQZXJtYW5lbnRseQorICAgIGNhc2UgNDA0OiAvLyBOb3QgRm91bmQK KyAgICBjYXNlIDQwNTogLy8gTWV0aG9kIE5vdCBBbGxvd2VkCisgICAgY2FzZSA0MTA6IC8vIEdv bmUKKyAgICBjYXNlIDQxNDogLy8gVVJJIFRvbyBMb25nCisgICAgY2FzZSA1MDE6IC8vIE5vdCBJ bXBsZW1lbnRlZAorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBkZWZhdWx0OgorICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgfQorfQorCitib29sIGlzU3RhdHVzQ29kZVBvdGVudGlhbGx5Q2Fj aGVhYmxlKGludCBzdGF0dXNDb2RlKQoreworICAgIHN3aXRjaCAoc3RhdHVzQ29kZSkgeworICAg IGNhc2UgMjAxOiAvLyBDcmVhdGVkCisgICAgY2FzZSAyMDI6IC8vIEFjY2VwdGVkCisgICAgY2Fz ZSAyMDU6IC8vIFJlc2V0IENvbnRlbnQKKyAgICBjYXNlIDMwMjogLy8gRm91bmQKKyAgICBjYXNl IDMwMzogLy8gU2VlIE90aGVyCisgICAgY2FzZSAzMDc6IC8vIFRlbXBvcmFyeSByZWRpcmVjdAor ICAgIGNhc2UgNDAzOiAvLyBGb3JiaWRkZW4KKyAgICBjYXNlIDQwNjogLy8gTm90IEFjY2VwdGFi bGUKKyAgICBjYXNlIDQxNTogLy8gVW5zdXBwb3J0ZWQgTWVkaWEgVHlwZQorICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICBkZWZhdWx0OgorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorfQor CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0NhY2hlVmFsaWRhdGlv bi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvQ2FjaGVW YWxpZGF0aW9uLmgJKHJldmlzaW9uIDIxMTk0NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvQ2FjaGVWYWxpZGF0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTczLDYgKzczLDkg QEAgV0VCQ09SRV9FWFBPUlQgQ2FjaGVDb250cm9sRGlyZWN0aXZlcyBwYQogV0VCQ09SRV9FWFBP UlQgVmVjdG9yPHN0ZDo6cGFpcjxTdHJpbmcsIFN0cmluZz4+IGNvbGxlY3RWYXJ5aW5nUmVxdWVz dEhlYWRlcnMoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYs IFNlc3Npb25JRCA9IFNlc3Npb25JRDo6ZGVmYXVsdFNlc3Npb25JRCgpKTsKIFdFQkNPUkVfRVhQ T1JUIGJvb2wgdmVyaWZ5VmFyeWluZ1JlcXVlc3RIZWFkZXJzKGNvbnN0IFZlY3RvcjxzdGQ6OnBh aXI8U3RyaW5nLCBTdHJpbmc+PiYgdmFyeWluZ1JlcXVlc3RIZWFkZXJzLCBjb25zdCBSZXNvdXJj ZVJlcXVlc3QmLCBTZXNzaW9uSUQgPSBTZXNzaW9uSUQ6OmRlZmF1bHRTZXNzaW9uSUQoKSk7CiAK K1dFQkNPUkVfRVhQT1JUIGJvb2wgaXNTdGF0dXNDb2RlQ2FjaGVhYmxlQnlEZWZhdWx0KGludCBz dGF0dXNDb2RlKTsKK1dFQkNPUkVfRVhQT1JUIGJvb2wgaXNTdGF0dXNDb2RlUG90ZW50aWFsbHlD YWNoZWFibGUoaW50IHN0YXR1c0NvZGUpOworCiB9CiAKICNlbmRpZgpJbmRleDogU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwko cmV2aXNpb24gMjExOTYwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTctMDItMDkgIEFudHRpIEtvaXZpc3RvICA8YW50dGlA YXBwbGUuY29tPgorCisgICAgICAgIFVzZSBhbGwgY2FjaGVhYmxlIHNwZWN1bGF0aXZlbHkgbG9h ZGVkIHJlc3BvbnNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY4MDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2UgY3VycmVudGx5IG9ubHkgYWxsb3cgMjAwIHJlc3BvbnNlcy4gVGhlcmUgaXMgbm8g cmVhc29uIG5vdCB0byB1c2Ugc3BlY3VsYXRpdmUgcmVzcG9uc2VzCisgICAgICAgIHRoYXQgaGF2 ZSBvdGhlciBjYWNoZWFibGUgc3RhdHVzIGNvZGVzLiBUaGlzIGlzIGhlbHBmdWwgZm9yIDIwNHMg YW5kIDQwNHMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUu Y3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6Om1ha2VTdG9yZURlY2lzaW9uKToK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya0NhY2hlOjppc1N0YXR1c0NvZGVDYWNoZWFibGVCeURl ZmF1bHQpOiBEZWxldGVkLgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OmlzU3RhdHVz Q29kZVBvdGVudGlhbGx5Q2FjaGVhYmxlKTogRGVsZXRlZC4KKworICAgICAgICAgICAgTW92ZSB0 byBDYWNoZVZhbGlkYXRpb24uaAorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0 d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0Nh Y2hlOjpTcGVjdWxhdGl2ZUxvYWQ6OmRpZEZpbmlzaExvYWRpbmcpOgorCisgICAgICAgICAgICBB bGxvdyBhbGwgY2FjaGVhYmxlLWJ5LWRlZmF1bHQgcmVzcG9uc2VzLgorCiAyMDE3LTAyLTA5ICBU b21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g Rml4IGd0ay1kb2Mgd2FybmluZwpJbmRleDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mv Y2FjaGUvTmV0d29ya0NhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCShyZXZpc2lvbiAyMTE5NDYpCisrKyBT b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMDgsNDUgKzIwOCw2IEBAIHN0YXRpYyBSZXRyaWV2ZURlY2lzaW9uIG1h a2VSZXRyaWV2ZURlY2kKICAgICByZXR1cm4gUmV0cmlldmVEZWNpc2lvbjo6WWVzOwogfQogCi0v LyBodHRwOi8vdG9vbHMuaWV0Zi5vcmcvaHRtbC9yZmM3MjMxI3BhZ2UtNDgKLXN0YXRpYyBib29s IGlzU3RhdHVzQ29kZUNhY2hlYWJsZUJ5RGVmYXVsdChpbnQgc3RhdHVzQ29kZSkKLXsKLSAgICBz d2l0Y2ggKHN0YXR1c0NvZGUpIHsKLSAgICBjYXNlIDIwMDogLy8gT0sKLSAgICBjYXNlIDIwMzog Ly8gTm9uLUF1dGhvcml0YXRpdmUgSW5mb3JtYXRpb24KLSAgICBjYXNlIDIwNDogLy8gTm8gQ29u dGVudAotICAgIGNhc2UgMjA2OiAvLyBQYXJ0aWFsIENvbnRlbnQKLSAgICBjYXNlIDMwMDogLy8g TXVsdGlwbGUgQ2hvaWNlcwotICAgIGNhc2UgMzAxOiAvLyBNb3ZlZCBQZXJtYW5lbnRseQotICAg IGNhc2UgNDA0OiAvLyBOb3QgRm91bmQKLSAgICBjYXNlIDQwNTogLy8gTWV0aG9kIE5vdCBBbGxv d2VkCi0gICAgY2FzZSA0MTA6IC8vIEdvbmUKLSAgICBjYXNlIDQxNDogLy8gVVJJIFRvbyBMb25n Ci0gICAgY2FzZSA1MDE6IC8vIE5vdCBJbXBsZW1lbnRlZAotICAgICAgICByZXR1cm4gdHJ1ZTsK LSAgICBkZWZhdWx0OgotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotfQotCi1zdGF0aWMg Ym9vbCBpc1N0YXR1c0NvZGVQb3RlbnRpYWxseUNhY2hlYWJsZShpbnQgc3RhdHVzQ29kZSkKLXsK LSAgICBzd2l0Y2ggKHN0YXR1c0NvZGUpIHsKLSAgICBjYXNlIDIwMTogLy8gQ3JlYXRlZAotICAg IGNhc2UgMjAyOiAvLyBBY2NlcHRlZAotICAgIGNhc2UgMjA1OiAvLyBSZXNldCBDb250ZW50Ci0g ICAgY2FzZSAzMDI6IC8vIEZvdW5kCi0gICAgY2FzZSAzMDM6IC8vIFNlZSBPdGhlcgotICAgIGNh c2UgMzA3OiAvLyBUZW1wb3JhcnkgcmVkaXJlY3QKLSAgICBjYXNlIDQwMzogLy8gRm9yYmlkZGVu Ci0gICAgY2FzZSA0MDY6IC8vIE5vdCBBY2NlcHRhYmxlCi0gICAgY2FzZSA0MTU6IC8vIFVuc3Vw cG9ydGVkIE1lZGlhIFR5cGUKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgZGVmYXVsdDoKLSAg ICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLX0KLQogc3RhdGljIGJvb2wgaXNNZWRpYU1JTUVU eXBlKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCiB7CiAgICAgaWYgKG1pbWVUeXBlLnN0YXJ0c1dp dGgoInZpZGVvLyIsIC8qY2FzZVNlbnNpdGl2ZSovIGZhbHNlKSkKQEAgLTI3MSwxMCArMjMyLDEw IEBAIHN0YXRpYyBTdG9yZURlY2lzaW9uIG1ha2VTdG9yZURlY2lzaW9uKGMKICAgICBpZiAocmVz cG9uc2UuY2FjaGVDb250cm9sQ29udGFpbnNOb1N0b3JlKCkpCiAgICAgICAgIHJldHVybiBTdG9y ZURlY2lzaW9uOjpOb0R1ZVRvTm9TdG9yZVJlc3BvbnNlOwogCi0gICAgaWYgKCFpc1N0YXR1c0Nv ZGVDYWNoZWFibGVCeURlZmF1bHQocmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSkpIHsKKyAgICBp ZiAoIVdlYkNvcmU6OmlzU3RhdHVzQ29kZUNhY2hlYWJsZUJ5RGVmYXVsdChyZXNwb25zZS5odHRw U3RhdHVzQ29kZSgpKSkgewogICAgICAgICAvLyBodHRwOi8vdG9vbHMuaWV0Zi5vcmcvaHRtbC9y ZmM3MjM0I3NlY3Rpb24tNC4zLjIKICAgICAgICAgYm9vbCBoYXNFeHBpcmF0aW9uSGVhZGVycyA9 IHJlc3BvbnNlLmV4cGlyZXMoKSB8fCByZXNwb25zZS5jYWNoZUNvbnRyb2xNYXhBZ2UoKTsKLSAg ICAgICAgYm9vbCBleHBpcmF0aW9uSGVhZGVyc0FsbG93Q2FjaGluZyA9IGlzU3RhdHVzQ29kZVBv dGVudGlhbGx5Q2FjaGVhYmxlKHJlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkpICYmIGhhc0V4cGly YXRpb25IZWFkZXJzOworICAgICAgICBib29sIGV4cGlyYXRpb25IZWFkZXJzQWxsb3dDYWNoaW5n ID0gV2ViQ29yZTo6aXNTdGF0dXNDb2RlUG90ZW50aWFsbHlDYWNoZWFibGUocmVzcG9uc2UuaHR0 cFN0YXR1c0NvZGUoKSkgJiYgaGFzRXhwaXJhdGlvbkhlYWRlcnM7CiAgICAgICAgIGlmICghZXhw aXJhdGlvbkhlYWRlcnNBbGxvd0NhY2hpbmcpCiAgICAgICAgICAgICByZXR1cm4gU3RvcmVEZWNp c2lvbjo6Tm9EdWVUb0hUVFBTdGF0dXNDb2RlOwogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3BlY3VsYXRpdmVMb2FkLmNwcAkocmV2aXNpb24gMjExOTQ1KQorKysgU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTIzLDcgKzEyMyw3IEBAIHZvaWQgU3BlY3VsYXRpdmVMb2FkOjpk aWRGaW5pc2hMb2FkaW5nKGQKICAgICBpZiAoIW1fY2FjaGVFbnRyeSAmJiBtX2J1ZmZlcmVkRGF0 YUZvckNhY2hlKSB7CiAgICAgICAgIG1fY2FjaGVFbnRyeSA9IE5ldHdvcmtDYWNoZTo6c2luZ2xl dG9uKCkuc3RvcmUobV9vcmlnaW5hbFJlcXVlc3QsIG1fcmVzcG9uc2UsIG1fYnVmZmVyZWREYXRh Rm9yQ2FjaGUuY29weVJlZigpLCBbXShhdXRvJiBtYXBwZWRCb2R5KSB7IH0pOwogICAgICAgICAv LyBDcmVhdGUgYSBzeW50aGV0aWMgY2FjaGUgZW50cnkgaWYgd2UgY2FuJ3Qgc3RvcmUuCi0gICAg ICAgIGlmICghbV9jYWNoZUVudHJ5ICYmIG1fcmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSA9PSAy MDApCisgICAgICAgIGlmICghbV9jYWNoZUVudHJ5ICYmIGlzU3RhdHVzQ29kZUNhY2hlYWJsZUJ5 RGVmYXVsdChtX3Jlc3BvbnNlLmh0dHBTdGF0dXNDb2RlKCkpKQogICAgICAgICAgICAgbV9jYWNo ZUVudHJ5ID0gTmV0d29ya0NhY2hlOjpzaW5nbGV0b24oKS5tYWtlRW50cnkobV9vcmlnaW5hbFJl cXVlc3QsIG1fcmVzcG9uc2UsIFdURk1vdmUobV9idWZmZXJlZERhdGFGb3JDYWNoZSkpOwogICAg IH0KIAo=