168012 2017-02-08 11:55:12 -0800 Promote WKWebView.allowsRemoteInspection from SPI to API 2020-06-23 13:28:25 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 bburg bburg andersca bburg ggaren joepeck mjs webkit-bug-importer webkitbugzilla oldest_to_newest 1274486 0 bburg 2017-02-08 11:55:12 -0800 <rdar://problem/29764488> 1278013 1 301854 bburg 2017-02-16 16:42:35 -0800 Created attachment 301854 Patch 1278060 2 ggaren 2017-02-16 18:29:28 -0800 Did we submit this to API review? 1278063 3 bburg 2017-02-16 18:32:59 -0800 (In reply to comment #2) > Did we submit this to API review? No. Should we? I was under the impression to check it in first. 1278068 4 ggaren 2017-02-16 18:39:27 -0800 Yeah, I think we should submit for review and then check in. 1278079 5 301854 joepeck 2017-02-16 19:39:55 -0800 Comment on attachment 301854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301854&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:240 > +@property This doesn't match the format of other comments. The @property can be dropped and the @abstract on the same line as the /*! 1278424 6 301983 bburg 2017-02-17 13:53:18 -0800 Created attachment 301983 Patch v2 1657686 7 301983 mjs 2020-05-30 18:06:13 -0700 Comment on attachment 301983 Patch v2 This seems like a good idea, and I'm surprised this is still SPI, but r- because the patch no longer applies. 301854 2017-02-16 16:42:35 -0800 2017-02-17 13:53:15 -0800 Patch bug-168012-20170216163957.patch text/plain 3115 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjk5NWY1YTJmNWQ0NWI0 YTE0MzM2NzZiNDc0ODU4NWQ1ZjBlZTQ5My4uOTNiZjU3MWE1NWYyYmVlMmVkM2RlNmRkNDlmZjI4 NzAzZWVjMzU3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAyLTE2ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFByb21vdGUgV0tXZWJWaWV3LmFs bG93c1JlbW90ZUluc3BlY3Rpb24gZnJvbSBTUEkgdG8gQVBJCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgwMTIKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzI5NzY0NDg4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBhIHByb3BlcnR5IHdpdGhvdXQgYSBwcmVmaXguIEtlZXAgdGhlIHByaXZhdGUg cHJvcGVydHkgZm9yIGNvbXBhdGliaWxpdHkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgYWxsb3dzUmVtb3RlSW5zcGVjdGlvbl0pOgorICAg ICAgICAoLVtXS1dlYlZpZXcgc2V0QWxsb3dzUmVtb3RlSW5zcGVjdGlvbjpdKToKKyAgICAgICAg KC1bV0tXZWJWaWV3IF9hbGxvd3NSZW1vdGVJbnNwZWN0aW9uXSk6CisgICAgICAgICgtW1dLV2Vi VmlldyBfc2V0QWxsb3dzUmVtb3RlSW5zcGVjdGlvbjpdKToKKwogMjAxNy0wMi0xNiAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViUlRDXVtNYWNdW1dl YktpdDJdIEluaXRpYWwgV2ViUHJvY2VzcyBkb2VzIG5vdCBzdXBwb3J0IFdlYlJUQwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcuaCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3LmgKaW5kZXggYjcxZjEx OThkOGE5ODM4Nzk0YWJhMDBkYzFlYzMwYWJhNTNjYTEwNS4uMjBjNzE5MTQ3Y2I4NzA2MDhkZjQ3 ODVhYTBjYzRhOTgxN2E0MGZmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5oCkBAIC0yMzYsNiArMjM2LDE0IEBAIFdLX0NMQVNTX0FWQUlMQUJM RShtYWNvc3goMTAuMTApLCBpb3MoOC4wKSkKICAqLwogQHByb3BlcnR5IChub25hdG9taWMpIEJP T0wgYWxsb3dzTGlua1ByZXZpZXcgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTEpLCBpb3Mo OS4wKSk7CiAKKy8qIQorQHByb3BlcnR5CitAYWJzdHJhY3QgV2hldGhlciByZW1vdGUgaW5zcGVj dGlvbiBvZiB0aGlzIFdLV2ViVmlldyBpcyBhbGxvd2VkLiBEZWZhdWx0IHZhbHVlIGlzIFlFUy4K K0BkaXNjdXNzaW9uIEFuIGFwcGxpY2F0aW9uIG11c3QgYWxzbyBoYXZlIHRoZSA8aT5jb20uYXBw bGUud2ViaW5zcGVjdG9yLmFsbG93PC9pPiBlbnRpdGxlbWVudAorIGluIG9yZGVyIGZvciBpdHMg V0tXZWJWaWV3IGluc3RhbmNlcyB0byBiZSByZW1vdGVseSBpbnNwZWN0YWJsZS4KKyovCitAcHJv cGVydHkgKG5vbmF0b21pYykgQk9PTCBhbGxvd3NSZW1vdGVJbnNwZWN0aW9uIFdLX0FQSV9BVkFJ TEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOworCiAjaWYgVEFSR0VU X09TX0lQSE9ORQogLyohIEBhYnN0cmFjdCBUaGUgc2Nyb2xsIHZpZXcgYXNzb2NpYXRlZCB3aXRo IHRoZSB3ZWIgdmlldy4KICAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbQppbmRleCBjZmI0MzYxZmQ3OGJiMmY2ZGZmYTA2ZDIxYTBmMWEwY2Fl YjI3NmJjLi4wYjRlNzdhZDQzNWEzZmYyMWFjYzgyMGU5Njk1ZGMxMDkxODI5ZTAwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtMzcw NCw3ICszNzA0LDcgQEAgLSAodm9pZClfdXBkYXRlV2Vic2l0ZVBvbGljaWVzOihfV0tXZWJzaXRl UG9saWNpZXMgKil3ZWJzaXRlUG9saWNpZXMKICAgICBfcGFnZS0+dXBkYXRlV2Vic2l0ZVBvbGlj aWVzKHdlYnNpdGVQb2xpY2llcy0+X3dlYnNpdGVQb2xpY2llcy0+d2Vic2l0ZVBvbGljaWVzKCkp OwogfQogCi0tIChCT09MKV9hbGxvd3NSZW1vdGVJbnNwZWN0aW9uCistIChCT09MKWFsbG93c1Jl bW90ZUluc3BlY3Rpb24KIHsKICNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKICAgICByZXR1 cm4gX3BhZ2UtPmFsbG93c1JlbW90ZUluc3BlY3Rpb24oKTsKQEAgLTM3MTMsMTMgKzM3MTMsMjMg QEAgLSAoQk9PTClfYWxsb3dzUmVtb3RlSW5zcGVjdGlvbgogI2VuZGlmCiB9CiAKLS0gKHZvaWQp X3NldEFsbG93c1JlbW90ZUluc3BlY3Rpb246KEJPT0wpYWxsb3cKKy0gKHZvaWQpc2V0QWxsb3dz UmVtb3RlSW5zcGVjdGlvbjooQk9PTClhbGxvdwogewogI2lmIEVOQUJMRShSRU1PVEVfSU5TUEVD VE9SKQogICAgIF9wYWdlLT5zZXRBbGxvd3NSZW1vdGVJbnNwZWN0aW9uKGFsbG93KTsKICNlbmRp ZgogfQogCistIChCT09MKV9hbGxvd3NSZW1vdGVJbnNwZWN0aW9uCit7CisgICAgcmV0dXJuIHNl bGYuYWxsb3dzUmVtb3RlSW5zcGVjdGlvbjsKK30KKworLSAodm9pZClfc2V0QWxsb3dzUmVtb3Rl SW5zcGVjdGlvbjooQk9PTClhbGxvdworeworICAgIHNlbGYuYWxsb3dzUmVtb3RlSW5zcGVjdGlv biA9IGFsbG93OworfQorCiAtIChOU1N0cmluZyAqKV9yZW1vdGVJbnNwZWN0aW9uTmFtZU92ZXJy aWRlCiB7CiAjaWYgRU5BQkxFKFJFTU9URV9JTlNQRUNUT1IpCg== 301983 2017-02-17 13:53:18 -0800 2020-05-30 18:06:13 -0700 Patch v2 bug-168012-20170217135039.patch text/plain 3104 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjEyNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjk5NWY1YTJmNWQ0NWI0 YTE0MzM2NzZiNDc0ODU4NWQ1ZjBlZTQ5My4uOTNiZjU3MWE1NWYyYmVlMmVkM2RlNmRkNDlmZjI4 NzAzZWVjMzU3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAyLTE2ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFByb21vdGUgV0tXZWJWaWV3LmFs bG93c1JlbW90ZUluc3BlY3Rpb24gZnJvbSBTUEkgdG8gQVBJCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjgwMTIKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzI5NzY0NDg4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBhIHByb3BlcnR5IHdpdGhvdXQgYSBwcmVmaXguIEtlZXAgdGhlIHByaXZhdGUg cHJvcGVydHkgZm9yIGNvbXBhdGliaWxpdHkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3 Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgYWxsb3dzUmVtb3RlSW5zcGVjdGlvbl0pOgorICAg ICAgICAoLVtXS1dlYlZpZXcgc2V0QWxsb3dzUmVtb3RlSW5zcGVjdGlvbjpdKToKKyAgICAgICAg KC1bV0tXZWJWaWV3IF9hbGxvd3NSZW1vdGVJbnNwZWN0aW9uXSk6CisgICAgICAgICgtW1dLV2Vi VmlldyBfc2V0QWxsb3dzUmVtb3RlSW5zcGVjdGlvbjpdKToKKwogMjAxNy0wMi0xNiAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViUlRDXVtNYWNdW1dl YktpdDJdIEluaXRpYWwgV2ViUHJvY2VzcyBkb2VzIG5vdCBzdXBwb3J0IFdlYlJUQwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcuaCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3LmgKaW5kZXggYjcxZjEx OThkOGE5ODM4Nzk0YWJhMDBkYzFlYzMwYWJhNTNjYTEwNS4uZThjNGVjNDYyZGRhYjUwYzczYmU5 YmFmYTEzM2I5OGJiMmNlOTY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5oCkBAIC0yMzYsNiArMjM2LDEyIEBAIFdLX0NMQVNTX0FWQUlMQUJM RShtYWNvc3goMTAuMTApLCBpb3MoOC4wKSkKICAqLwogQHByb3BlcnR5IChub25hdG9taWMpIEJP T0wgYWxsb3dzTGlua1ByZXZpZXcgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTEpLCBpb3Mo OS4wKSk7CiAKKy8qISBAYWJzdHJhY3QgV2hldGhlciByZW1vdGUgaW5zcGVjdGlvbiBvZiB0aGlz IFdLV2ViVmlldyBpcyBhbGxvd2VkLiBEZWZhdWx0IHZhbHVlIGlzIFlFUy4KKyBAZGlzY3Vzc2lv biBBbiBhcHBsaWNhdGlvbiBtdXN0IGFsc28gaGF2ZSB0aGUgPGk+Y29tLmFwcGxlLndlYmluc3Bl Y3Rvci5hbGxvdzwvaT4gZW50aXRsZW1lbnQKKyBpbiBvcmRlciBmb3IgaXRzIFdLV2ViVmlldyBp bnN0YW5jZXMgdG8gYmUgcmVtb3RlbHkgaW5zcGVjdGFibGUuCisqLworQHByb3BlcnR5IChub25h dG9taWMpIEJPT0wgYWxsb3dzUmVtb3RlSW5zcGVjdGlvbiBXS19BUElfQVZBSUxBQkxFKG1hY29z eChXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKKwogI2lmIFRBUkdFVF9PU19JUEhPTkUK IC8qISBAYWJzdHJhY3QgVGhlIHNjcm9sbCB2aWV3IGFzc29jaWF0ZWQgd2l0aCB0aGUgd2ViIHZp ZXcuCiAgKi8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXcubW0KaW5kZXggY2ZiNDM2MWZkNzhiYjJmNmRmZmEwNmQyMWEwZjFhMGNhZWIyNzZiYy4uMGI0 ZTc3YWQ0MzVhM2ZmMjFhY2M4MjBlOTY5NWRjMTA5MTgyOWUwMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTM3MDQsNyArMzcwNCw3 IEBAIC0gKHZvaWQpX3VwZGF0ZVdlYnNpdGVQb2xpY2llczooX1dLV2Vic2l0ZVBvbGljaWVzICop d2Vic2l0ZVBvbGljaWVzCiAgICAgX3BhZ2UtPnVwZGF0ZVdlYnNpdGVQb2xpY2llcyh3ZWJzaXRl UG9saWNpZXMtPl93ZWJzaXRlUG9saWNpZXMtPndlYnNpdGVQb2xpY2llcygpKTsKIH0KIAotLSAo Qk9PTClfYWxsb3dzUmVtb3RlSW5zcGVjdGlvbgorLSAoQk9PTClhbGxvd3NSZW1vdGVJbnNwZWN0 aW9uCiB7CiAjaWYgRU5BQkxFKFJFTU9URV9JTlNQRUNUT1IpCiAgICAgcmV0dXJuIF9wYWdlLT5h bGxvd3NSZW1vdGVJbnNwZWN0aW9uKCk7CkBAIC0zNzEzLDEzICszNzEzLDIzIEBAIC0gKEJPT0wp X2FsbG93c1JlbW90ZUluc3BlY3Rpb24KICNlbmRpZgogfQogCi0tICh2b2lkKV9zZXRBbGxvd3NS ZW1vdGVJbnNwZWN0aW9uOihCT09MKWFsbG93CistICh2b2lkKXNldEFsbG93c1JlbW90ZUluc3Bl Y3Rpb246KEJPT0wpYWxsb3cKIHsKICNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKICAgICBf cGFnZS0+c2V0QWxsb3dzUmVtb3RlSW5zcGVjdGlvbihhbGxvdyk7CiAjZW5kaWYKIH0KIAorLSAo Qk9PTClfYWxsb3dzUmVtb3RlSW5zcGVjdGlvbgoreworICAgIHJldHVybiBzZWxmLmFsbG93c1Jl bW90ZUluc3BlY3Rpb247Cit9CisKKy0gKHZvaWQpX3NldEFsbG93c1JlbW90ZUluc3BlY3Rpb246 KEJPT0wpYWxsb3cKK3sKKyAgICBzZWxmLmFsbG93c1JlbW90ZUluc3BlY3Rpb24gPSBhbGxvdzsK K30KKwogLSAoTlNTdHJpbmcgKilfcmVtb3RlSW5zcGVjdGlvbk5hbWVPdmVycmlkZQogewogI2lm IEVOQUJMRShSRU1PVEVfSU5TUEVDVE9SKQo=