<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>168008</bug_id>
          
          <creation_ts>2017-02-08 11:36:47 -0800</creation_ts>
          <short_desc>Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1</short_desc>
          <delta_ts>2024-07-30 11:12:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=277299</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>ap</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>joepeck</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1274465</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2017-02-08 11:36:47 -0800</bug_when>
    <thetext>Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1

Seems like these would need to handle iOS WebKit&apos;s WebThread.

    bindings/js/SerializedScriptValue.cpp
    2912:    RunLoop::main().dispatch([this, conditionPtr = &amp;condition, valuePtr = &amp;value] {

    inspector/WebHeapAgent.cpp
    57:    , m_timer(RunLoop::main(), this, &amp;SendGarbageCollectionEventsTask::timerFired)

    Modules/applepay/ApplePaySession.cpp
    496:        RunLoop::main().dispatch([promise, canMakePayments]() mutable {

    Modules/websockets/WebSocket.cpp
    295:            RunLoop::main().dispatch([this, protectedThis = makeRef(*this)]() {

    platform/graphics/MediaPlaybackTargetPicker.cpp
    40:    , m_pendingActionTimer(RunLoop::main(), this, &amp;MediaPlaybackTargetPicker::pendingActionTimerFired)

    workers/WorkerMessagingProxy.cpp
    165:    RunLoop::main().dispatch([this, message = message.isolatedCopy()] {

This is code in WebCore that stays in WebCore, so probably needs a WebThreadLock for legacy WebKit.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>