168000 2017-02-08 09:47:58 -0800 Simple line layout: Fix printReason for unsupported overflow values. 2017-02-08 10:35:23 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan bfulgham commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield simon.fraser zalan oldest_to_newest 1274400 0 zalan 2017-02-08 09:47:58 -0800 It says we don't support overflow visible, but we do. 1274401 1 300914 zalan 2017-02-08 09:49:52 -0800 Created attachment 300914 Patch 1274402 2 300914 simon.fraser 2017-02-08 09:51:41 -0800 Comment on attachment 300914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300914&action=review > Source/WebCore/rendering/SimpleLineLayout.cpp:79 > + FlowHasNoOverflowVisible = 1LLU << 13, Maybe call this FlowHasOverflowNotVisible ? 1274406 3 300915 zalan 2017-02-08 09:57:45 -0800 Created attachment 300915 Patch 1274429 4 300915 commit-queue 2017-02-08 10:35:19 -0800 Comment on attachment 300915 Patch Clearing flags on attachment: 300915 Committed r211884: <http://trac.webkit.org/changeset/211884> 1274430 5 commit-queue 2017-02-08 10:35:23 -0800 All reviewed patches have been landed. Closing bug. 300914 2017-02-08 09:49:52 -0800 2017-02-08 09:57:42 -0800 Patch bug-168000-20170208094726.patch text/plain 2817 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjExODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTBiN2M0MzRkMGM4NjY5 YzJjMGE0MWM4YjIxYWZhNmMxY2QyMDNhMS4uN2UwYWFjMmVmMGY1YmI1MzYzOTNhYmQyNDViY2E3 N2ExNjc5YjVkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAyLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxlIGxpbmUgbGF5b3V0 OiBGaXggcHJpbnRSZWFzb24gZm9yIHVuc3VwcG9ydGVkIG92ZXJmbG93IHZhbHVlcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODAwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdCB0ZXN0YWJsZS4K KworICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OmNhblVzZUZvclN0eWxlKToKKyAgICAgICAgKFdlYkNv cmU6OlNpbXBsZUxpbmVMYXlvdXQ6OnByaW50UmVhc29uKToKKwogMjAxNy0wMi0wNyAgWW91ZW5u IEZhYmxldCAgPHlvdWVubmZAZ21haWwuY29tPgogCiAgICAgICAgIFtXZWJSVENdIExpYldlYlJU Q0VuZHBvaW50IHNob3VsZCBub3Qgb3duIG9iamVjdHMgdGhhdCBzaG91bGQgYmUgZGVzdHJveWVk IG9uIHRoZSBtYWluIHRocmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1NpbXBsZUxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxp bmVMYXlvdXQuY3BwCmluZGV4IDcyMWQ3NWMzZDg5MjQyZGUwNGQyNWEzOTdmZTUyNTFmNDY1MTlj YzcuLjhhYzQxZGQ2OGYyMDJhOWRjZTE4MzNiYTZjMmY1Mzk4NjA0YzljMTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKQEAgLTc2LDcgKzc2LDcg QEAgZW51bSBBdm9pZGFuY2VSZWFzb25fIDogdWludDY0X3QgewogICAgIEZsb3dIYXNVbnN1cHBv cnRlZEZsb2F0ICAgICAgICAgICAgICAgPSAxTExVICA8PCAxMCwKICAgICBGbG93SGFzVW5zdXBw b3J0ZWRVbmRlcmxpbmVEZWNvcmF0aW9uID0gMUxMVSAgPDwgMTEsCiAgICAgRmxvd0hhc0p1c3Rp ZmllZE5vbkxhdGluVGV4dCAgICAgICAgICA9IDFMTFUgIDw8IDEyLAotICAgIEZsb3dIYXNPdmVy Zmxvd1Zpc2libGUgICAgICAgICAgICAgICAgPSAxTExVICA8PCAxMywKKyAgICBGbG93SGFzTm9P dmVyZmxvd1Zpc2libGUgICAgICAgICAgICAgID0gMUxMVSAgPDwgMTMsCiAgICAgRmxvd0hhc1dl YktpdE5CU1BNb2RlICAgICAgICAgICAgICAgICA9IDFMTFUgIDw8IDE0LAogICAgIEZsb3dJc05v dExUUiAgICAgICAgICAgICAgICAgICAgICAgICAgPSAxTExVICA8PCAxNSwKICAgICBGbG93SGFz TGluZUJveENvbnRhaW5Qcm9wZXJ0eSAgICAgICAgID0gMUxMVSAgPDwgMTYsCkBAIC0yNTYsNyAr MjU2LDcgQEAgc3RhdGljIEF2b2lkYW5jZVJlYXNvbkZsYWdzIGNhblVzZUZvclN0eWxlKGNvbnN0 IFJlbmRlclN0eWxlJiBzdHlsZSwgSW5jbHVkZVJlYXMKICAgICAgICAgU0VUX1JFQVNPTl9BTkRf UkVUVVJOX0lGX05FRURFRChGbG93SGFzVW5zdXBwb3J0ZWRVbmRlcmxpbmVEZWNvcmF0aW9uLCBy ZWFzb25zLCBpbmNsdWRlUmVhc29ucyk7CiAgICAgLy8gTm9uLXZpc2libGUgb3ZlcmZsb3cgc2hv dWxkIGJlIHByZXR0eSBlYXN5IHRvIHN1cHBvcnQuCiAgICAgaWYgKHN0eWxlLm92ZXJmbG93WCgp ICE9IE9WSVNJQkxFIHx8IHN0eWxlLm92ZXJmbG93WSgpICE9IE9WSVNJQkxFKQotICAgICAgICBT RVRfUkVBU09OX0FORF9SRVRVUk5fSUZfTkVFREVEKEZsb3dIYXNPdmVyZmxvd1Zpc2libGUsIHJl YXNvbnMsIGluY2x1ZGVSZWFzb25zKTsKKyAgICAgICAgU0VUX1JFQVNPTl9BTkRfUkVUVVJOX0lG X05FRURFRChGbG93SGFzTm9PdmVyZmxvd1Zpc2libGUsIHJlYXNvbnMsIGluY2x1ZGVSZWFzb25z KTsKICAgICBpZiAoIXN0eWxlLmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSkKICAgICAgICAgU0VU X1JFQVNPTl9BTkRfUkVUVVJOX0lGX05FRURFRChGbG93SXNOb3RMVFIsIHJlYXNvbnMsIGluY2x1 ZGVSZWFzb25zKTsKICAgICBpZiAoIShzdHlsZS5saW5lQm94Q29udGFpbigpICYgTGluZUJveENv bnRhaW5CbG9jaykpCkBAIC05OTUsOCArOTk1LDggQEAgc3RhdGljIHZvaWQgcHJpbnRSZWFzb24o QXZvaWRhbmNlUmVhc29uIHJlYXNvbiwgVGV4dFN0cmVhbSYgc3RyZWFtKQogICAgIGNhc2UgRmxv d0hhc0p1c3RpZmllZE5vbkxhdGluVGV4dDoKICAgICAgICAgc3RyZWFtIDw8ICJ0ZXh0LWFsaWdu OiBqdXN0aWZ5IHdpdGggbm9uLWxhdGluIHRleHQiOwogICAgICAgICBicmVhazsKLSAgICBjYXNl IEZsb3dIYXNPdmVyZmxvd1Zpc2libGU6Ci0gICAgICAgIHN0cmVhbSA8PCAib3ZlcmZsb3c6IHZp c2libGUiOworICAgIGNhc2UgRmxvd0hhc05vT3ZlcmZsb3dWaXNpYmxlOgorICAgICAgICBzdHJl YW0gPDwgIm92ZXJmbG93OiBoaWRkZW4gfCBzY3JvbGwgfCBhdXRvIjsKICAgICAgICAgYnJlYWs7 CiAgICAgY2FzZSBGbG93SGFzV2ViS2l0TkJTUE1vZGU6CiAgICAgICAgIHN0cmVhbSA8PCAiLXdl YmtpdC1uYnNwLW1vZGU6IHNwYWNlIjsK 300915 2017-02-08 09:57:45 -0800 2017-02-08 10:35:19 -0800 Patch bug-168000-20170208095526.patch text/plain 2785 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjExODgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzM0NmEyMTM3YWQ2NzEx YTkwZGYyNWIyOGQ1ZDM5M2JmNDJmOTNiYi4uZDgzYzk1YzQwZmU3NjVlYjNlZjU4Y2M4MjViOGU2 MWQ2Y2Y3MGYwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAyLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxlIGxpbmUgbGF5b3V0 OiBGaXggcHJpbnRSZWFzb24gZm9yIHVuc3VwcG9ydGVkIG92ZXJmbG93IHZhbHVlcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2ODAwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICBOb3QgdGVzdGFibGUuCisK KyAgICAgICAgKiByZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpTaW1wbGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3JTdHlsZSk6CisgICAgICAgIChXZWJDb3Jl OjpTaW1wbGVMaW5lTGF5b3V0OjpwcmludFJlYXNvbik6CisKIDIwMTctMDItMDggIEFha2FzaCBK YWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBXZWJDb3JlT2Jq Q0RlYWxsb2NXaXRoV2ViVGhyZWFkTG9jayBmcm9tIGhlYWRlciBmaWxlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKaW5kZXggNzIxZDc1YzNkODkyNDJk ZTA0ZDI1YTM5N2ZlNTI1MWY0NjUxOWNjNy4uOWE5ZmNkZmUwZmVkMDA3MWM3MjAzMzczOTFkYTYx MmYxZDQ5YmQ0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxp bmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5 b3V0LmNwcApAQCAtNzYsNyArNzYsNyBAQCBlbnVtIEF2b2lkYW5jZVJlYXNvbl8gOiB1aW50NjRf dCB7CiAgICAgRmxvd0hhc1Vuc3VwcG9ydGVkRmxvYXQgICAgICAgICAgICAgICA9IDFMTFUgIDw8 IDEwLAogICAgIEZsb3dIYXNVbnN1cHBvcnRlZFVuZGVybGluZURlY29yYXRpb24gPSAxTExVICA8 PCAxMSwKICAgICBGbG93SGFzSnVzdGlmaWVkTm9uTGF0aW5UZXh0ICAgICAgICAgID0gMUxMVSAg PDwgMTIsCi0gICAgRmxvd0hhc092ZXJmbG93VmlzaWJsZSAgICAgICAgICAgICAgICA9IDFMTFUg IDw8IDEzLAorICAgIEZsb3dIYXNPdmVyZmxvd05vdFZpc2libGUgICAgICAgICAgICAgPSAxTExV ICA8PCAxMywKICAgICBGbG93SGFzV2ViS2l0TkJTUE1vZGUgICAgICAgICAgICAgICAgID0gMUxM VSAgPDwgMTQsCiAgICAgRmxvd0lzTm90TFRSICAgICAgICAgICAgICAgICAgICAgICAgICA9IDFM TFUgIDw8IDE1LAogICAgIEZsb3dIYXNMaW5lQm94Q29udGFpblByb3BlcnR5ICAgICAgICAgPSAx TExVICA8PCAxNiwKQEAgLTI1Niw3ICsyNTYsNyBAQCBzdGF0aWMgQXZvaWRhbmNlUmVhc29uRmxh Z3MgY2FuVXNlRm9yU3R5bGUoY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlLCBJbmNsdWRlUmVhcwog ICAgICAgICBTRVRfUkVBU09OX0FORF9SRVRVUk5fSUZfTkVFREVEKEZsb3dIYXNVbnN1cHBvcnRl ZFVuZGVybGluZURlY29yYXRpb24sIHJlYXNvbnMsIGluY2x1ZGVSZWFzb25zKTsKICAgICAvLyBO b24tdmlzaWJsZSBvdmVyZmxvdyBzaG91bGQgYmUgcHJldHR5IGVhc3kgdG8gc3VwcG9ydC4KICAg ICBpZiAoc3R5bGUub3ZlcmZsb3dYKCkgIT0gT1ZJU0lCTEUgfHwgc3R5bGUub3ZlcmZsb3dZKCkg IT0gT1ZJU0lCTEUpCi0gICAgICAgIFNFVF9SRUFTT05fQU5EX1JFVFVSTl9JRl9ORUVERUQoRmxv d0hhc092ZXJmbG93VmlzaWJsZSwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOworICAgICAgICBT RVRfUkVBU09OX0FORF9SRVRVUk5fSUZfTkVFREVEKEZsb3dIYXNPdmVyZmxvd05vdFZpc2libGUs IHJlYXNvbnMsIGluY2x1ZGVSZWFzb25zKTsKICAgICBpZiAoIXN0eWxlLmlzTGVmdFRvUmlnaHRE aXJlY3Rpb24oKSkKICAgICAgICAgU0VUX1JFQVNPTl9BTkRfUkVUVVJOX0lGX05FRURFRChGbG93 SXNOb3RMVFIsIHJlYXNvbnMsIGluY2x1ZGVSZWFzb25zKTsKICAgICBpZiAoIShzdHlsZS5saW5l Qm94Q29udGFpbigpICYgTGluZUJveENvbnRhaW5CbG9jaykpCkBAIC05OTUsOCArOTk1LDggQEAg c3RhdGljIHZvaWQgcHJpbnRSZWFzb24oQXZvaWRhbmNlUmVhc29uIHJlYXNvbiwgVGV4dFN0cmVh bSYgc3RyZWFtKQogICAgIGNhc2UgRmxvd0hhc0p1c3RpZmllZE5vbkxhdGluVGV4dDoKICAgICAg ICAgc3RyZWFtIDw8ICJ0ZXh0LWFsaWduOiBqdXN0aWZ5IHdpdGggbm9uLWxhdGluIHRleHQiOwog ICAgICAgICBicmVhazsKLSAgICBjYXNlIEZsb3dIYXNPdmVyZmxvd1Zpc2libGU6Ci0gICAgICAg IHN0cmVhbSA8PCAib3ZlcmZsb3c6IHZpc2libGUiOworICAgIGNhc2UgRmxvd0hhc092ZXJmbG93 Tm90VmlzaWJsZToKKyAgICAgICAgc3RyZWFtIDw8ICJvdmVyZmxvdzogaGlkZGVuIHwgc2Nyb2xs IHwgYXV0byI7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgRmxvd0hhc1dlYktpdE5CU1BNb2Rl OgogICAgICAgICBzdHJlYW0gPDwgIi13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZSI7Cg==