167989 2017-02-08 08:02:21 -0800 Move WKMouseInRect to WAKView.mm 2017-02-08 09:27:59 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain aestes ap commit-queue ddkilzer juergen oldest_to_newest 1274335 0 aakash_jain 2017-02-08 08:02:21 -0800 WKMouseInRect() is only used in WAKView.mm. Having it in a private header (WAKAppKitStubs.h) exposes it more than it should be. We should move it to WAKView.mm 1274337 1 300898 aakash_jain 2017-02-08 08:15:15 -0800 Created attachment 300898 Proposed patch 1274373 2 300898 ap 2017-02-08 09:09:54 -0800 Comment on attachment 300898 Proposed patch I'm not sure abut the original purpose of "WAKAppKitStubs.m", but from what I can tell, this change is correct. 1274386 3 300898 commit-queue 2017-02-08 09:27:55 -0800 Comment on attachment 300898 Proposed patch Clearing flags on attachment: 300898 Committed r211878: <http://trac.webkit.org/changeset/211878> 1274387 4 commit-queue 2017-02-08 09:27:59 -0800 All reviewed patches have been landed. Closing bug. 300898 2017-02-08 08:15:15 -0800 2017-02-08 09:27:55 -0800 Proposed patch patch_WKMouseInRect text/plain 2630 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTg3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAyLTA4ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIFdLTW91c2VJblJl Y3QgdG8gV0FLVmlldy5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY3OTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2FrL1dBS0FwcEtpdFN0dWJzLmg6IFJlbW92ZWQgV0tN b3VzZUluUmVjdC4KKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2FrL1dBS0FwcEtpdFN0dWJzLm06 CisgICAgICAgIChXS01vdXNlSW5SZWN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9p b3Mvd2FrL1dBS1ZpZXcubW06IAorICAgICAgICAoLVtXQUtWaWV3IG1vdXNlOmluUmVjdDpdKTog QWRkZWQgdGhlIGxvZ2ljIG9mIFdLTW91c2VJblJlY3QgaGVyZSBpbnN0ZWFkIG9mIHNlcGFyYXRl IGZ1bmN0aW9uIGNhbGwuCisKIDIwMTctMDItMDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgZW5oYW5jZWQgcHJpdmFjeSBkaWFnbm9z dGljIGxvZ2dpbmcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLQXBw S2l0U3R1YnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2Fr L1dBS0FwcEtpdFN0dWJzLmgJKHJldmlzaW9uIDIxMTQ0MikKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy93YWsvV0FLQXBwS2l0U3R1YnMuaAkod29ya2luZyBjb3B5KQpAQCAtMjA5LDE2 ICsyMDksNiBAQCBXRUJDT1JFX0VYUE9SVCBAaW50ZXJmYWNlIE5TQ3Vyc29yIDogTlNPCiArICh2 b2lkKXNldEhpZGRlblVudGlsTW91c2VNb3ZlczooQk9PTClmbGFnOwogQGVuZAogCi0jaWZkZWYg X19jcGx1c3BsdXMKLWV4dGVybiAiQyIgewotI2VuZGlmCi0KLUJPT0wgV0tNb3VzZUluUmVjdChD R1BvaW50IGFQb2ludCwgQ0dSZWN0IGFSZWN0KTsKLQotI2lmZGVmIF9fY3BsdXNwbHVzCi19Ci0j ZW5kaWYKLQogI2VuZGlmIC8vIFRBUkdFVF9PU19JUEhPTkUKIAogI2VuZGlmIC8vIFdBS0FwcEtp dFN0dWJzX2gKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLQXBwS2l0 U3R1YnMubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dB S0FwcEtpdFN0dWJzLm0JKHJldmlzaW9uIDIxMTQ0MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy93YWsvV0FLQXBwS2l0U3R1YnMubQkod29ya2luZyBjb3B5KQpAQCAtMzAsMTMgKzMw LDYgQEAKIAogaWQgTlNBcHAgPSBuaWw7CiAKLUJPT0wgV0tNb3VzZUluUmVjdChDR1BvaW50IGFQ b2ludCwgQ0dSZWN0IGFSZWN0KSAKLXsKLSAgICByZXR1cm4gYVBvaW50LnggPj0gYVJlY3Qub3Jp Z2luLnggJiYKLSAgICAgICAgYVBvaW50LnggPCAoYVJlY3Qub3JpZ2luLnggKyBhUmVjdC5zaXpl LndpZHRoKSAmJgotICAgICAgICBhUG9pbnQueSA+PSBhUmVjdC5vcmlnaW4ueSAmJiBhUG9pbnQu eSA8IChhUmVjdC5vcmlnaW4ueSArIGFSZWN0LnNpemUuaGVpZ2h0KTsKLX0KLQogQGltcGxlbWVu dGF0aW9uIE5TQ3Vyc29yCiArICh2b2lkKXNldEhpZGRlblVudGlsTW91c2VNb3ZlczooQk9PTClm bGFnCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtWaWV3Lm1t CShyZXZpc2lvbiAyMTE0NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dB S1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTY3Myw3ICs2NzMsOSBAQCAtIChCT09MKWlzSGlk ZGVuT3JIYXNIaWRkZW5BbmNlc3RvcgogCiAtIChCT09MKW1vdXNlOihOU1BvaW50KWFQb2ludCBp blJlY3Q6KE5TUmVjdClhUmVjdCAKIHsgCi0gICAgcmV0dXJuIFdLTW91c2VJblJlY3QgKGFQb2lu dCwgYVJlY3QpOworICAgIHJldHVybiBhUG9pbnQueCA+PSBhUmVjdC5vcmlnaW4ueAorICAgICAg ICAmJiBhUG9pbnQueCA8IChhUmVjdC5vcmlnaW4ueCArIGFSZWN0LnNpemUud2lkdGgpCisgICAg ICAgICYmIGFQb2ludC55ID49IGFSZWN0Lm9yaWdpbi55ICYmIGFQb2ludC55IDwgKGFSZWN0Lm9y aWdpbi55ICsgYVJlY3Quc2l6ZS5oZWlnaHQpOwogfQogCiAtIChCT09MKW5lZWRzUGFuZWxUb0Jl Y29tZUtleQo=