167987 2017-02-08 07:34:39 -0800 Remove WebCoreObjCDeallocWithWebThreadLock from header file 2017-02-08 09:32:52 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue juergen oldest_to_newest 1274328 0 aakash_jain 2017-02-08 07:34:39 -0800 WebCoreObjCDeallocWithWebThreadLock() is used only in WebCore/platform/ios/wak/WebCoreThread.mm. Keeping it in a private header (WebCoreThreadMessage.h) exposes it more than it should be. We should remove it from the private header. 1274332 1 300897 aakash_jain 2017-02-08 07:46:54 -0800 Created attachment 300897 Proposed patch 1274393 2 300897 commit-queue 2017-02-08 09:32:48 -0800 Comment on attachment 300897 Proposed patch Clearing flags on attachment: 300897 Committed r211880: <http://trac.webkit.org/changeset/211880> 1274394 3 commit-queue 2017-02-08 09:32:52 -0800 All reviewed patches have been landed. Closing bug. 300897 2017-02-08 07:46:54 -0800 2017-02-08 09:32:48 -0800 Proposed patch patch_WebCoreThread text/plain 1954 aakash_jain SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTg2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTA4ICBBYWthc2gg SmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgV2ViQ29yZU9i akNEZWFsbG9jV2l0aFdlYlRocmVhZExvY2sgZnJvbSBoZWFkZXIgZmlsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3OTg3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2FrL1dl YkNvcmVUaHJlYWQubW06IEFkZGVkIFdlYkNvcmVPYmpDRGVhbGxvY1dpdGhXZWJUaHJlYWRMb2Nr LgorICAgICAgICAqIHBsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZE1lc3NhZ2UuaDogUmVt b3ZlZCBXZWJDb3JlT2JqQ0RlYWxsb2NXaXRoV2ViVGhyZWFkTG9jay4KKwogMjAxNy0wMi0wOCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dT dHJlYW1lcl0gQ3JpdGljYWwgd2FybmluZ3Mgd2hlbiBtZWRpYSBwbGF5ZXIgaXMgZGVzdHJveWVk CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNvcmVUaHJlYWQubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XZWJDb3JlVGhy ZWFkLm1tCShyZXZpc2lvbiAyMTE0NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mv d2FrL1dlYkNvcmVUaHJlYWQubW0JKHdvcmtpbmcgY29weSkKQEAgLTEzOSw2ICsxMzksNyBAQCBX RUJDT1JFX0VYUE9SVCB2b2xhdGlsZSBib29sIHdlYlRocmVhZFNoCiAKIHN0YXRpYyBwdGhyZWFk X211dGV4X3QgV2ViQ29yZVJlbGVhc2VMb2NrOwogc3RhdGljIHZvaWQgV2ViQ29yZU9iakNEZWFs bG9jT25XZWJUaHJlYWRJbXBsKGlkIHNlbGYsIFNFTCBfY21kKTsKK3N0YXRpYyB2b2lkIFdlYkNv cmVPYmpDRGVhbGxvY1dpdGhXZWJUaHJlYWRMb2NrKENsYXNzIGNscyk7CiBzdGF0aWMgdm9pZCBX ZWJDb3JlT2JqQ0RlYWxsb2NXaXRoV2ViVGhyZWFkTG9ja0ltcGwoaWQgc2VsZiwgU0VMIF9jbWQp OwogCiBzdGF0aWMgTlNNdXRhYmxlQXJyYXkgKnNBc3luY0RlbGVnYXRlcyA9IG5pbDsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZE1lc3NhZ2UuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNvcmVUaHJl YWRNZXNzYWdlLmgJKHJldmlzaW9uIDIxMTQ0MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy93YWsvV2ViQ29yZVRocmVhZE1lc3NhZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNyAr NDcsNiBAQCBleHRlcm4gIkMiIHsKIAogLy8gUmVnaXN0ZXIgYSBjbGFzcyBmb3IgZGVhbGxvY2F0 aW9uIG9uIHRoZSBXZWJUaHJlYWQKIFdFQkNPUkVfRVhQT1JUIHZvaWQgV2ViQ29yZU9iakNEZWFs bG9jT25XZWJUaHJlYWQoQ2xhc3MgY2xzKTsKLXZvaWQgV2ViQ29yZU9iakNEZWFsbG9jV2l0aFdl YlRocmVhZExvY2soQ2xhc3MgY2xzKTsKIAogLy8gQXN5bmNocm9ub3VzIGZyb20gbWFpbiB0aHJl YWQgdG8gd2ViIHRocmVhZC4KIFdFQkNPUkVfRVhQT1JUIHZvaWQgV2ViVGhyZWFkQWRvcHRBbmRS ZWxlYXNlKGlkIG9iaik7Cg==