167985 2017-02-08 06:43:04 -0800 [GTK] Test fast/forms/select-empty-option-height.html fails 2017-02-08 08:27:24 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply tonikitoo oldest_to_newest 1274319 0 cgarcia 2017-02-08 06:43:04 -0800 This seems to be a problem with the differences in scroll step or the size of the items in the list. The thing is that 10 attempts with an scroll amount of 10 is not enoug in the GTk+ port to scroll the list to the desired point. Either increasing the scroll amount or the maximum attempts would fix the test. Increasing the scroll amount would break the test in other ports so better use a higher number of maximum attempts. 1274320 1 300893 cgarcia 2017-02-08 06:45:44 -0800 Created attachment 300893 Patch 1274333 2 300893 mcatanzaro 2017-02-08 07:50:21 -0800 Comment on attachment 300893 Patch We expect our list items to use theme size and not match other ports, I presume? 1274347 3 cgarcia 2017-02-08 08:27:24 -0800 Committed r211872: <http://trac.webkit.org/changeset/211872> 300893 2017-02-08 06:45:44 -0800 2017-02-08 07:50:21 -0800 Patch wk-padding-tests-gtk.diff text/plain 1694 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NGY0OGQ2N2I1Ni4uMjFmZDk1NWE1NzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAog MjAxNy0wMi0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK KyAgICAgICAgW0dUS10gVGVzdCBmYXN0L2Zvcm1zL3NlbGVjdC1lbXB0eS1vcHRpb24taGVpZ2h0 Lmh0bWwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2Nzk4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgc2VlbXMgdG8gYmUgYSBwcm9ibGVtIHdpdGggdGhlIGRpZmZlcmVuY2VzIGluIHNj cm9sbCBzdGVwIG9yIHRoZSBzaXplIG9mIHRoZSBpdGVtcyBpbiB0aGUgbGlzdC4gVGhlIHRoaW5n CisgICAgICAgIGlzIHRoYXQgMTAgYXR0ZW1wdHMgd2l0aCBhbiBzY3JvbGwgYW1vdW50IG9mIDEw IGlzIG5vdCBlbm91Z2ggaW4gdGhlIEdUaysgcG9ydCB0byBzY3JvbGwgdGhlIGxpc3QgdG8gdGhl IGRlc2lyZWQKKyAgICAgICAgcG9pbnQuIEVpdGhlciBpbmNyZWFzaW5nIHRoZSBzY3JvbGwgYW1v dW50IG9yIHRoZSBtYXhpbXVtIGF0dGVtcHRzIHdvdWxkIGZpeCB0aGUgdGVzdC4gSW5jcmVhc2lu ZyB0aGUgc2Nyb2xsCisgICAgICAgIGFtb3VudCB3b3VsZCBicmVhayB0aGUgdGVzdCBpbiBvdGhl ciBwb3J0cyBzbyBiZXR0ZXIgdXNlIGEgaGlnaGVyIG51bWJlciBvZiBtYXhpbXVtIGF0dGVtcHRz LgorCisgICAgICAgICogZmFzdC9mb3Jtcy9saXN0Ym94LXJlc3BlY3RzLXBhZGRpbmctYm90dG9t Lmh0bWw6CisKKzIwMTctMDItMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLKyBnYXJkZW5pbmcuIFNraXAgYW5pbWF0 aW9ucy9mb250LXZhcmlhdGlvbnMvIHRlc3RzLgogCiAgICAgICAgIFRoZXkgYXJlIG1hcmtlZCBh cyBJbWFnZU9ubHlGYWlsdXJlLCBidXQgYXJlIGFjdHVhbGx5IGZhaWxpbmcgbm93LiBJIHRoaW5r IGl0J3MgYmV0dGVyIHRvIHNpbXBseSBza2lwIGFsbCBmb250CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL2xpc3Rib3gtcmVzcGVjdHMtcGFkZGluZy1ib3R0b20uaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvbGlzdGJveC1yZXNwZWN0cy1wYWRkaW5nLWJvdHRvbS5odG1s CmluZGV4IDQ1MDcyYmU1NzhkLi5kYjU0OWJmODNhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9saXN0Ym94LXJlc3BlY3RzLXBhZGRpbmctYm90dG9tLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9saXN0Ym94LXJlc3BlY3RzLXBhZGRpbmctYm90dG9tLmh0bWwK QEAgLTYsNyArNiw3IEBACiAgICAgICAgIHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIAog ICAgICAgICB2YXIgaSA9IDA7Ci0gICAgICAgIHZhciBtYXhBdHRlbXB0cyA9IDEwOworICAgICAg ICB2YXIgbWF4QXR0ZW1wdHMgPSAyMDsKICAgICAgICAgZnVuY3Rpb24gcnVuVGVzdCgpCiAgICAg ICAgIHsKICAgICAgICAgICAgIHZhciBzY3JvbGxBbW91bnQgPSAwOwo=